Commit graph

534 commits

Author SHA1 Message Date
Noemi Erli
7c565dc045 Backed out 6 changesets (bug 1304001) for mochitest failures in test_bug430351.html CLOSED TREE
Backed out changeset 5fafa838de11 (bug 1304001)
Backed out changeset d75340a9a264 (bug 1304001)
Backed out changeset ed7ae6b877df (bug 1304001)
Backed out changeset 93bd4d634b14 (bug 1304001)
Backed out changeset e41015881591 (bug 1304001)
Backed out changeset 6346331d934d (bug 1304001)
2019-02-21 04:04:47 +02:00
Matthew Noorenberghe
e911b23229 Bug 1304001 - Update comments related to gEnabled/rememberSignons. r=sfoster
Fixes some stales comments and identation.

Differential Revision: https://phabricator.services.mozilla.com/D20392

--HG--
extra : moz-landing-system : lando
2019-02-20 15:26:29 +00:00
Jonas Allmann
fbe8b0661c Bug 1523813, Remove new Function from utilityOverlay.js, r=Gijs
Replaced new Function() by CustomEvent carrying original click event as sourceEvent.
Adapted all oncommand listeners to use event.sourceEvent instead of event.

Differential Revision: https://phabricator.services.mozilla.com/D18847

--HG--
extra : moz-landing-system : lando
2019-02-19 16:20:02 +00:00
Daisuke Akatsuka
a48415d8aa Bug 1522400: Set proper context menu items on about:devtools-toolbox page. r=jdescottes,mconley
Depends on D17458

Differential Revision: https://phabricator.services.mozilla.com/D17459

--HG--
extra : moz-landing-system : lando
2019-02-13 01:50:20 +00:00
Jonathan Kingston
3421b8fcff Bug 1520868 - Replacing AsyncOpen2 with AsyncOpen always r=valentin
Replacing js and text occurences of asyncOpen2
Replacing open2 with open

Differential Revision: https://phabricator.services.mozilla.com/D16885

--HG--
rename : layout/style/test/test_asyncopen2.html => layout/style/test/test_asyncopen.html
extra : moz-landing-system : lando
2019-02-12 16:08:25 +00:00
Mike Conley
52278792ca Bug 1520329 - Add messaging infrastructure for opening videos in a Picture in Picture window. r=Felipe
Differential Revision: https://phabricator.services.mozilla.com/D16903

--HG--
extra : moz-landing-system : lando
2019-02-12 02:34:38 +00:00
Myk Melez
25349d2601 Bug 1518283 - prohibit blank lines at the beginning and end of blocks (eslint padded-blocks) r=mossop,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D17526

--HG--
extra : moz-landing-system : lando
2019-01-30 17:26:25 +00:00
Kris Maglione
e930b89c34 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750

--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
2019-01-17 10:18:31 -08:00
Daisuke Akatsuka
336d4a7b39 Bug 1495944: Show/Hide 'Inspect Element' item in content context menu. r=jdescottes
This patch removes "Inspect Element" menu item from content context menu in
case that about:devtools-toolbox are opening.
However, we may be able to remove after fixing 1515265.

Depends on D16684

Differential Revision: https://phabricator.services.mozilla.com/D16685

--HG--
extra : moz-landing-system : lando
2019-01-18 16:21:43 +00:00
Dorel Luca
5e7e061044 Backed out 5 changesets (bug 1495944) for DevTools failures in devtools/client/aboutdebugging-new/test/browser/browser_aboutdebugging_devtoolstoolbox_menubar.js
Backed out changeset 52e5f0d01900 (bug 1495944)
Backed out changeset 025ffd6f441f (bug 1495944)
Backed out changeset df656c9d03b1 (bug 1495944)
Backed out changeset be64b571b600 (bug 1495944)
Backed out changeset 9418ac4c2fa1 (bug 1495944)
2019-01-18 16:14:34 +02:00
Daisuke Akatsuka
d5682bba8c Bug 1495944: Show/Hide 'Inspect Element' item in content context menu. r=jdescottes
This patch removes "Inspect Element" menu item from content context menu in
case that about:devtools-toolbox are opening.
However, we may be able to remove after fixing 1515265.

Depends on D16684

Differential Revision: https://phabricator.services.mozilla.com/D16685

--HG--
extra : moz-landing-system : lando
2019-01-18 11:53:50 +00:00
Bogdan Tara
1aa3019b05 Backed out 5 changesets (bug 1495944) for browser_989751_subviewbutton_class.js failures CLOSED TREE
Backed out changeset f365b9fa9697 (bug 1495944)
Backed out changeset cd627a79a250 (bug 1495944)
Backed out changeset 7862a0a1c3ec (bug 1495944)
Backed out changeset f78876cf49e6 (bug 1495944)
Backed out changeset 85f355a22192 (bug 1495944)
2019-01-18 04:58:40 +02:00
Daisuke Akatsuka
d6c3c7678a Bug 1495944: Show/Hide 'Inspect Element' item in content context menu. r=jdescottes
This patch removes "Inspect Element" menu item from content context menu in
case that about:devtools-toolbox are opening.
However, we may be able to remove after fixing 1515265.

Depends on D16684

Differential Revision: https://phabricator.services.mozilla.com/D16685

--HG--
extra : moz-landing-system : lando
2019-01-17 06:59:17 +00:00
Luca Greco
49a13352a4 Bug 1468460 - Fix and test extension menus and menus.overrideContext on options_ui pages. r=mixedpuppy,robwu
Depends on D9920

Differential Revision: https://phabricator.services.mozilla.com/D15225

--HG--
extra : moz-landing-system : lando
2019-01-08 22:23:00 +00:00
Luca Greco
b003d66246 Bug 1468460 - Support context menu in WebExtensions options pages embedded inside an about:addons tab. r=mixedpuppy,robwu
Differential Revision: https://phabricator.services.mozilla.com/D9920

--HG--
extra : moz-landing-system : lando
2019-01-07 20:53:13 +00:00
Siddhant085
6ab6938f8c Bug 1493483 - Use nsIBrowserSearchService::defaultEngine instead of currentEngine (in production code) r=Standard8
nsIBrowserSearchService::currentEngine and nsIBrowserSearchService::defaultEngine are the same thing.
The use of defaultEngine makes more sense and thus we are phasing out the use of currentEngine and replace it with defaultEngine.

Differential Revision: https://phabricator.services.mozilla.com/D7972

--HG--
extra : moz-landing-system : lando
2018-10-27 16:52:02 +00:00
Csoregi Natalia
523d3ae4fe Backed out changeset c35bab726b03 (bug 1493483) for multiple browser-chrome failures e.g browser_extension_controlled.js. CLOSED TREE 2018-10-09 23:26:24 +03:00
Siddhant085
5e4fc9f261 Bug 1493483 - Use nsIBrowserSearchService::defaultEngine instead of currentEngine (in production code) r=Standard8
nsIBrowserSearchService::currentEngine and nsIBrowserSearchService::defaultEngine are the same thing.
The use of defaultEngine makes more sense and thus we are phasing out the use of currentEngine and replace it with defaultEngine.

Differential Revision: https://phabricator.services.mozilla.com/D7972

--HG--
extra : moz-landing-system : lando
2018-10-09 18:40:08 +00:00
Rob Wu
4cb234ed7e Bug 1416839 - Add viewType/viewTypes to menus API r=mixedpuppy
- Support viewTypes property in menus.create / menus.update.
- Add info.viewType to menus.onShown / menus.onClicked event.
- This "viewType" reuses the existing extension.ViewType enum,
  which is a "tab", "popup" (pageAction/browserAction) or "sidebar".

Differential Revision: https://phabricator.services.mozilla.com/D6205

--HG--
extra : moz-landing-system : lando
2018-10-01 16:56:53 +00:00
Rob Wu
ee0928a251 Bug 1367160 - Allow extensions to hide default menu items r=mixedpuppy
The new method allows extensions to modify menu items in their own
moz-extension:-pages, with the following features:

- All matching extension items are shown in the root menu (instead of
  being moved into a submenu), above other menu items, if any.
- The icons for these menu items are customizable.
- Optionally, the default menu items (including those from other
  extensions) can be hidden.

Depends on D6621

Differential Revision: https://phabricator.services.mozilla.com/D6622

--HG--
extra : moz-landing-system : lando
2018-09-25 16:41:47 +00:00
Christoph Kerschbaumer
60e3239dee Bug 1490874: Log Principal based Security Errors to the Security pane in the console. r=smaug 2018-09-25 07:25:05 +02:00
shindli
0b6d93ef4d Backed out changeset 510e95767aeb (bug 1490874) for security failures in browser/components/payments/test/mochitest/test_basic_card_form.html CLOSED TREE 2018-09-24 11:43:30 +03:00
Christoph Kerschbaumer
0df81cd9f4 Bug 1490874: Log Principal based Security Errors to the Security pane in the console. r=smaug 2018-09-24 09:34:04 +02:00
Mark Banner
691543ee89 Bug 1486739 - Add missing dangling commas in browser/, services/, taskcluster/ and toolkit/. r=mossop
Automatic changes by ESLint, except for manual corrections for .xml files.

Differential Revision: https://phabricator.services.mozilla.com/D4439

--HG--
extra : moz-landing-system : lando
2018-08-31 05:59:17 +00:00
Paolo Amadini
36aefe42c5 Bug 1482648 - Part 4 - Clean up remaining references to broadcasters in front-end code. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D3151

--HG--
extra : rebase_source : d5aaf97c89deca198abefcebf61da3436e833ebb
2018-08-11 17:25:58 +01:00
Paolo Amadini
bb3d2cf63d Bug 1482648 - Part 3 - Remove remaining broadcasters from front-end code. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D3150

--HG--
extra : rebase_source : ae1bca38891bf3876af59e1cff047199b19abacd
2018-08-21 14:55:04 +01:00
Jonathan Kingston
3d93e94550 Bug 1364392 - Provide correct triggeringPrincipal to openLinkIn r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D3873

--HG--
extra : moz-landing-system : lando
2018-08-21 14:15:40 +00:00
Andreea Pavel
870fc40e66 Merge mozilla-central to autoland. a=merge on a CLOSED TREE 2018-08-14 19:17:13 +03:00
Paolo Amadini
88c6b35cb5 Bug 1481813 - Part 1 - Remove unneeded broadcaster observers for bookmarks. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D3007

--HG--
extra : source : a2067cf24c1befd37d200fe7055dbdb06ad9c152
2018-08-09 13:13:27 +01:00
Jonathan Kingston
736db71698 Bug 1482681 - Fix load iframe in tab context menu. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D3200

--HG--
extra : moz-landing-system : lando
2018-08-14 12:58:24 +00:00
Jonathan Kingston
a91f8e8108 Bug 1466801 - Flipping disallowInheritPrincipal to be allow. r=ckerschb r=gijs
--HG--
rename : browser/base/content/test/general/browser_utilityOverlay.js => browser/base/content/test/contextMenu/browser_utilityOverlay.js
extra : source : 5eab8f37c4bd6048057069cb0ac2ab0b4729d950
2018-07-16 10:17:51 +01:00
Rob Wu
23cf8852bb Bug 1325814 - Add extension API to find menu target r=mixedpuppy
- Add info.targetElementId to menus.onShown event.

- Add info.targetElementId to menus.onClicked event.

- Add menus.getTargetElement API that is available to all contexts,
  including content scripts, which allows extensions to get the DOM
  element for a given targetElementId.

- Add new schema instead of re-using schemas/menus.json to avoid sending
  too much schema data (of the existing menus API) to content processes.

MozReview-Commit-ID: 6Onf7jZlIho

--HG--
extra : rebase_source : eb095d04ce381606be90d325712bfc57233d8291
2018-08-04 18:09:49 +02:00
Jonathan Kingston
9b7fb2f20c Bug 1362034 - Have addTab() provide the correct triggering principal. r=ckerschb r=Gijs
Reviewers: ckerschb!, Gijs!

Tags: #secure-revision

Bug #: 1362034

Differential Revision: https://phabricator.services.mozilla.com/D2046

--HG--
extra : source : 44b25dea67d2ed079e17057ab619d827e9983400
extra : amend_source : 5742820277e0269b6f5d42b1abd98fd9b228ac4a
extra : histedit_source : 790bd2490333e4d8fea7774d036eafbc2fc329b9
2018-07-06 15:14:54 +01:00
dvarga
12f19b94e9 Backed out 2 changesets (bug 1362034) for failure at browser/tools/mozscreenshots/primaryUI/browser_primaryUI.js on a CLOSED TREE
Backed out changeset 1c3329958b8a (bug 1362034)
Backed out changeset f68b1b76af36 (bug 1362034)

--HG--
extra : histedit_source : 6169c5ffe856266d3bc8b2ca32f4b67054c71bbe
2018-08-08 22:11:56 +03:00
Jonathan Kingston
f389570122 Bug 1362034 - Have addTab() provide the correct triggering principal. r=ckerschb,Gijs
Reviewers: ckerschb, Gijs

Reviewed By: ckerschb, Gijs

Subscribers: mixedpuppy, reviewbot

Bug #: 1362034

Differential Revision: https://phabricator.services.mozilla.com/D2046

--HG--
extra : rebase_source : ea688b35744f970e74de3039da3973f1177d8577
extra : amend_source : 89efdb8ccec2c334a83155eec6b30f08fa0f7074
2018-08-08 20:03:55 +03:00
Andreea Pavel
f5c1119983 Backed out 2 changesets (bug 1362034) for failing damp | inspector/cold-open.js on a CLOSED TREE
Backed out changeset 8c8925b75aa2 (bug 1362034)
Backed out changeset ff6b05c96094 (bug 1362034)
2018-08-06 20:42:44 +03:00
Jonathan Kingston
9be2ebdb53 Bug 1362034 - Have addTab() provide the correct triggering principal. r=ckerschb,Gijs
Reviewers: ckerschb, Gijs

Reviewed By: ckerschb, Gijs

Subscribers: reviewbot

Bug #: 1362034

Differential Revision: https://phabricator.services.mozilla.com/D2046

--HG--
extra : rebase_source : 57c6bda461781ec20f0ceba8d1dd9c48778bf568
extra : amend_source : 2eebbf1e7df91697ce984d2845dbae41f9dcbcbd
2018-08-06 19:54:47 +03:00
Boris Zbarsky
30718f15fe Bug 1480310. Use docshell's editingSession getter instead of getInterface to get editing sessions. r=kmag
All the C++ consumers already call the getter, so we can remove
nsIEditingSession from the docshell GetInterface method completely.

Differential Revision: https://phabricator.services.mozilla.com/D2668

--HG--
extra : moz-landing-system : lando
2018-08-02 19:15:27 +00:00
Boris Zbarsky
4abc5c5a25 Bug 1446940 part 2. Stop getting docshells from windows via getInterface in browser. r=gijs 2018-08-01 13:07:10 -04:00
Boris Zbarsky
270fa12c79 Bug 1476145 part 3. Stop using getInterface(nsIDOMWindowUtils) in browser/. r=gijs 2018-07-24 19:47:41 -04:00
Narcis Beleuzu
6fdff882de Backed out changeset 4cba8b6eb37a (bug 1466801) for wpt failures. CLOSED TREE
--HG--
rename : browser/base/content/test/contextMenu/browser_utilityOverlay.js => browser/base/content/test/general/browser_utilityOverlay.js
2018-07-25 00:37:59 +03:00
Jonathan Kingston
dd884fb6d5 Bug 1466801 - Flipping disallowInheritPrincipal to be allow. r=ckerschb,Gijs
Reviewers: Gijs, ckerschb

Reviewed By: Gijs, ckerschb

Subscribers: aryx, smaug, dao, RyanVM, dveditz, Gijs, ckerschb, bzbarsky, jkt

Bug #: 1466801

Differential Revision: https://phabricator.services.mozilla.com/D2096

--HG--
rename : browser/base/content/test/general/browser_utilityOverlay.js => browser/base/content/test/contextMenu/browser_utilityOverlay.js
extra : rebase_source : 6d912ffff2ecd717748b3a71f0efa17b36775e5a
extra : amend_source : 3414e5885544709640c9250759e61737b46cae4d
2018-07-24 20:35:55 +03:00
Marco Bonardo
d932936d53 Bug 1475276 - Remove some no more necessary usage of promiseItemGuid. r=lina
Some code is unnecessarily using promiseItemGuid

Differential Revision: https://phabricator.services.mozilla.com/D2100

--HG--
extra : moz-landing-system : lando
2018-07-12 21:38:21 +00:00
Gurzau Raul
112c3bb6dd Merge mozilla-central to autoland. a=merge CLOSED TREE 2018-07-04 13:01:13 +03:00
Gijs Kruitbosch
09a107bc24 Bug 1469916, r=ckerschb,jkt
--HG--
extra : rebase_source : 180442deeef92f0e9202d76c5e4e46b630072d99
extra : source : be11a32900298eb6fd4d18ad21b9a699995254c3
2018-06-22 15:41:39 +01:00
Gijs Kruitbosch
9396488809 Backed out changeset be11a3290029 (bug 1469916) for test orange involving Not enough arguments [nsIWebBrowserPersist.saveURI] 2018-07-03 15:45:13 +01:00
Gijs Kruitbosch
0d0616cad1 Bug 1469916, r=ckerschb,jkt
--HG--
extra : rebase_source : 5c2f49af85664fdb5375f6dc4cc57d6913f1eff9
2018-06-22 15:41:39 +01:00
Dão Gottwald
03203945f5 Bug 1472275 - Remove PlacesCommandHook.bookmarkPage's aShowEditUI argument. r=standard8
MozReview-Commit-ID: CGYSF1OvoVg

--HG--
extra : rebase_source : 3470cd6522ae3c3e2802dfa2e032643c7fbdcb55
2018-06-29 19:45:35 +02:00
Dão Gottwald
96a00916f7 Bug 1473073 - Remove PlacesCommandHook.bookmarkPage's browser argument. r=mak
MozReview-Commit-ID: BH5r7Tn8KV1

--HG--
extra : rebase_source : 845e8ec126d91f682ed09939aa89c07bd2c1078e
2018-07-03 22:46:46 +02:00
J. Ryan Stinnett
84c4eba82e Bug 1365626 - Remove View MathML Source feature. r=mconley
The in-tree version of View MathML Source appears to have low usage, so it seems
reasonable to remove.  A similar feature is available as an add-on.

In recent months, the in-tree version has actually been broken, which wasn't
noticed for quite a while.  This adds further evidence for removal given the
lack of maintenance and interest in this feature.

Differential Revision: https://phabricator.services.mozilla.com/D1830

--HG--
extra : moz-landing-system : lando
2018-06-28 20:45:31 +00:00