Commit graph

173 commits

Author SHA1 Message Date
Carsten "Tomcat" Book
f2a98554ec Backed out changeset 27f3968ae8b2 (bug 1245184) 2016-02-19 15:55:23 +01:00
Andrea Marchesini
0a72c5e9e3 Bug 1245184 - CookieManager should remove cookies only if they match the userContextId, r=sicking 2016-02-19 14:49:50 +01:00
Marco Bonardo
77808a4218 Bug 1244650 - Failure to clear Forms and Search Data on exit. r=yoric
The problem is due to sanitization happening too late in the shutdown cycle.
The Sanitizer depends on Places shutdown, that recently moved to async shutdown.
That change caused shutdown to happen completely at profile-before-change, unfortunately
during that phase it's impossible to predict which services are already shutdown.
The patch restores the previous Places shutdown procedure, thus clients are notified
earlier, during profile-change-teardown.

Additional meaningful changes:
* Fixes FX_SANITIZE_TOTAL telemetry to properly count total time taken by sanitize.
* Makes each cleanup operation isolated from other errors to try cleaning up as most as possible.
* In case of multiple sanitization sub steps, each step is isolated by a try/catch, the last seen exception is reported upstream.
* Makes FX_SANITIZE_HISTORY actually measure history, not other random stuff.
* Removes TOPIC_SIMULATE_PLACES_MUST_CLOSE_1 since we can now just use profile-change-teardown for shutdown phase 1.

MozReview-Commit-ID: HroLvbi25IC

--HG--
extra : rebase_source : 5cd01a803fbc1f72dc5174dd0c5a5b5aea473fc2
2016-02-04 13:51:34 +01:00
Marco Bonardo
0bffcc3559 Bug 1243549 - Add missing bits. r=post-facto
MozReview-Commit-ID: BTRUMtNsSeQ
2016-02-11 16:09:17 +01:00
David Rajchenbach-Teller
5ad17c3a22 Bug 1243549 - Make sure that startup sanitization doesn't throw because it can't find a tabbrowser. r=mak 2016-02-04 09:40:40 -05:00
Matthew Noorenberghe
66c73b5940 Bug 1244908 - Remove privacy.clearOnShutdown.passwords migration code. r=dolske
--HG--
extra : commitid : 2HnKfq3jUZK
extra : rebase_source : 4cca79b260a18b95758bed5fbd2518b3d84d430a
2016-02-03 15:26:14 -08:00
Matthew Noorenberghe
6f76f345ba Bug 1242176 - Don't migrate privacy.clearOnShutdown.passwords if privacy.sanitize.sanitizeOnShutdown is false. r=dolske 2016-01-28 10:49:00 -08:00
Mélanie Chauvel (ariasuni)
24691fcfc3 bug 1211849 - Remove canClear support from the Sanitizer. r=mak
Modifications by Patrick <nwokop@uni.coventry.ac.uk>

--HG--
extra : commitid : 4sPxOcyS2qv
2015-10-07 19:46:35 +02:00
Kit Cambridge
2aac6b9fea Bug 1189998, Part 2 - Migrate Push service callers. r=mt
--HG--
extra : commitid : Irrl5pvEqC
extra : rebase_source : 11c261c95820225bcc50976956000f34a79f9578
2015-12-08 15:41:48 -05:00
Felipe Gomes
2df6ae44b6 Bug 1229603 - Make most of browser/base lintable by removing non-standard syntax. r=Mossop
--HG--
extra : commitid : 5Dg6Q0MzXTN
2015-12-02 17:51:26 -02:00
Bill McCloskey
4f99faeaed Bug 967873 - Proxy nsDocumentViewer::PermitUnload to the child process (r=Gijs) 2015-11-11 18:04:21 -08:00
Tooru Fujisawa
8ed7719ea4 Bug 1216775 - Remove for-each from browser/. r=Gijs
--HG--
extra : commitid : 5KlVHJwTU1Q
extra : rebase_source : 6526234004427109c826cb63f42c9def8ca31281
2015-10-19 01:27:39 +09:00
J. Ryan Stinnett
6335fd7480 Bug 1203159 - Clean up various incorrect paths. r=ochameau 2015-10-21 12:48:55 -05:00
J. Ryan Stinnett
986f2a5cde Bug 1203159 - Rewrite DevTools resource URLs. r=ochameau 2015-10-21 12:48:53 -05:00
David Rajchenbach-Teller
7924ef22c9 Bug 1213672 - Turning onWindowOpened into a variable; r=mak
--HG--
extra : amend_source : 4749a0f13895765ec3431c51405483543742fafc
2015-10-12 09:30:23 +02:00
Bill McCloskey
c5d5457154 Back out bug 967873 - Proxy nsDocumentViewer::PermitUnload to the child process 2015-10-07 11:15:11 -07:00
Bill McCloskey
207404ad2d Bug 967873 - Proxy nsDocumentViewer::PermitUnload to the child process (r=Gijs) 2015-10-01 21:18:48 -07:00
Wes Kocher
296abd21ee Merge m-c to inbound a=merge
--HG--
extra : rebase_source : 38a51b2c491658bc19cfac0d227b04ef6e5f6718
2015-09-30 14:10:21 -07:00
Tooru Fujisawa
d88225d76e Bug 1207490 - Part 1: Remove use of expression closure from browser/base/. r=dao
--HG--
extra : commitid : GTnFNtx973B
extra : rebase_source : 5bf8bb3d7ddb0234bd533cf6ddc843dd2db9d8f5
2015-09-21 00:29:37 +09:00
David Rajchenbach-Teller
34c2816fc1 Bug 1089695 - Async sanitize.js;r=mak
--HG--
extra : transplant_source : n%84iA%8D%87%D1t%81C%22%E9%02Z%BB%04%D1Q%93%3C
2015-07-27 19:18:19 +02:00
David Rajchenbach-Teller
1bea015a1a Bug 1089695 - Fixing wrong dependency in Places shutdown. r=mak
--HG--
extra : transplant_source : %E43%A0G%04%97%1E%2B8%26i%B8X%8A%D9%B5%D53%E0%F9
2015-08-10 11:07:54 +02:00
Nikhil Marathe
079c3d0a1b Bug 1188937 - Only add Push API interfaces to build if the feature is enabled. r=kitcambridge
--HG--
extra : commitid : BRZ0gZEecxz
extra : amend_source : fb91b88616e837bf5e09a6a19c31acb1b94e4e64
extra : transplant_source : %84W%27%B8%40A%7F%26%04%0E%C6%A9%13o%25%D4SOD6
2015-07-29 09:12:51 -07:00
Edouard Oger
a818212fb8 Bug 1102184 - Deprecate the clear saved passwords on shutdown feature. r=dolske 2015-07-17 13:18:00 -04:00
Brad Lassey
857ea25644 bug 1158561 - [e10s] Browser hang in PluginModuleParent::NPP_ClearSiteData() r=jimm,mak 2015-06-30 18:08:19 -04:00
Wes Kocher
9e61cb09b7 Backed out changeset 9e0475a23d21 (bug 1158561) for assertions in test_clear_site_data.html CLOSED TREE 2015-07-01 16:25:26 -07:00
Brad Lassey
8caec1b14a bug 1158561 - [e10s] Browser hang in PluginModuleParent::NPP_ClearSiteData() r=jimm,mak 2015-06-30 18:08:19 -04:00
Ryan VanderMeulen
9483a612e8 Backed out changesets 57bbe09f18f2 and 8353c823b8b5 (bug 1158561) for win32 build bustage.
CLOSED TREE
2015-07-01 12:11:41 -04:00
Brad Lassey
9ddc8315be bug 1158561 - [e10s] Browser hang in PluginModuleParent::NPP_ClearSiteData() r=jimm,mak 2015-06-30 18:08:19 -04:00
Chris Manchester
d71f544ddf Bug 1171210 - Add a telemetry probe for how long it takes to clear plugin cookies during sanitize. r=vladan 2015-06-10 17:31:34 -07:00
Xidorn Quan
d7dd0eac3b Bug 1161802 part 2 - Split nsGlobalWindow::SetFullScreenInternal into two parts, one part before the window resizing, the other after. r=smaug,dao,margaret
This patch moves the "fullscreen" event from the original place to the
second part, which indicates two other changes:

1. When the event is triggered, the value of fullScreen would have been
toggled to the new value, which is different from before. The changes in
browser/../browser-fullScreen.js and mobile/../browser.js are for this.

2. This event is no longer preventDefault-able, since it is triggered
after the fullscreen change. This leads to the removal of the test and
the only place which calls preventDefault on that event. That place is
a workaround for bug 1079222. To address that problem, this patch fixes
the intrinsic issue via stoping handling the fullscreen change once it
finds we failed to change the state of the widget.

--HG--
extra : source : 78f78a62ce31b33413f0b52532eb22e5712cb646
2015-06-10 23:13:12 +12:00
Doug Turner
91f963df66 Bug 1149274 - Clear site-permissions should clear all registered push notifications. r=nsm 2015-04-21 20:10:51 +02:00
Jan-Ivar Bruaroey
c6676519f2 Bug 1046245 - enumerateDevices w/non-blocking e10s, nsICryptoHMAC, clear cookies, lambdas. r=keeler, florian, billm, jesup 2015-03-03 09:51:05 -05:00
Randell Jesup
2b3486247c Backed out 6 changesets (bug 1046245) on a CLOSED TREE 2015-03-29 01:42:32 -04:00
Jan-Ivar Bruaroey
cdd0b089a5 Bug 1046245 - enumerateDevices w/non-blocking e10s, nsICryptoHMAC, clear cookies, lambdas. r=keeler, r=florian, r=billm, r=jesup 2015-03-03 09:51:05 -05:00
Phil Ringnalda
24b4f38005 Back out 6 changesets (bug 1046245) for thinking that MSVC would have anything to do with a __PRETTY_FUNCTION__
CLOSED TREE

Backed out changeset 9e3ecca831d8 (bug 1046245)
Backed out changeset 87dc145f4da8 (bug 1046245)
Backed out changeset 01606cf19a77 (bug 1046245)
Backed out changeset 2ed2b15fe940 (bug 1046245)
Backed out changeset 2b99b193828a (bug 1046245)
Backed out changeset d1ac67faccbb (bug 1046245)
2015-03-28 19:57:17 -07:00
Jan-Ivar Bruaroey
222e93c87c Bug 1046245 - enumerateDevices w/non-blocking e10s, nsICryptoHMAC, clear cookies, lambdas. r=keeler, r=florian, r=billm, r=jesup 2015-03-03 09:51:05 -05:00
Ryan VanderMeulen
003e8f5278 Backed out 6 changesets (bug 1046245) for bustage on a CLOSED TREE.
Backed out changeset 222c2f9e3bc9 (bug 1046245)
Backed out changeset 4251eef464a2 (bug 1046245)
Backed out changeset 592f4cc23197 (bug 1046245)
Backed out changeset 5bfb9a1c0550 (bug 1046245)
Backed out changeset e966a5df87b6 (bug 1046245)
Backed out changeset 609f3ca64004 (bug 1046245)
2015-03-28 16:24:25 -04:00
Jan-Ivar Bruaroey
59e13faed0 Bug 1046245 - enumerateDevices w/non-blocking e10s, nsICryptoHMAC, clear cookies, lambdas. r=keeler, r=florian, r=billm, r=jesup 2015-03-03 09:51:05 -05:00
Neil Deakin
352abe4eb4 Bug 1091140, add telemetry for sanitize, r=vdjeric 2015-01-26 20:58:22 -05:00
JW Wang
4dd9718845 Bug 1111788 - Part 1 - include timestamps for "browser:purge-session-history" notification. r=gavin. 2015-01-08 18:50:00 +01:00
Gijs Kruitbosch
858e4683f0 Bug 1094429 - fix strict warning in sanitize.js, r=gavin
--HG--
extra : rebase_source : 4e970dad314c815f535fa388c0d8ab77356ea6ff
2014-11-06 11:53:34 +00:00
Gijs Kruitbosch
5da38c25ef Bug 1079222 - deny fullscreen from the forget button, r=dolske
--HG--
extra : rebase_source : 4d3f61bb3ae6798449f7be0bce1a680faf949aa6
2014-10-21 04:19:40 +01:00
Justin Dolske
a7594172f2 Bug 1088137 - Forget button can fail to clear cookies by running sanitizer too early. r=MattN 2014-10-26 20:46:03 -07:00
Mark Hammond
f391fcd547 Bug 1058442 - sanitize.js now passes the date range being cleared to the permission manager and content pref service. r=MattN 2014-10-14 16:03:31 +11:00
Gijs Kruitbosch
4a94538aa8 Bug 1069300 - add a privacy/forget/panic button, r=jaws
--HG--
extra : rebase_source : cc94c6449aab3fc64f7b034cb553cc6cf0879395
2014-09-24 17:22:05 +01:00
David Keeler
d219ed0d80 bug 775370 - (part 2/2) use DataStorage as back-end to nsSiteSecurityService r=briansmith 2014-09-04 10:42:31 -07:00
Jim Blandy
7e20285e70 Bug 914753: Make Emacs file variable header lines correct, or at least consistent. DONTBUILD r=ehsan
The -*- file variable lines -*- establish per-file settings that Emacs will
pick up. This patch makes the following changes to those lines (and touches
nothing else):

 - Never set the buffer's mode.

   Years ago, Emacs did not have a good JavaScript mode, so it made sense
   to use Java or C++ mode in .js files. However, Emacs has had js-mode for
   years now; it's perfectly serviceable, and is available and enabled by
   default in all major Emacs packagings.

   Selecting a mode in the -*- file variable line -*- is almost always the
   wrong thing to do anyway. It overrides Emacs's default choice, which is
   (now) reasonable; and even worse, it overrides settings the user might
   have made in their '.emacs' file for that file extension. It's only
   useful when there's something specific about that particular file that
   makes a particular mode appropriate.

 - Correctly propagate settings that establish the correct indentation
   level for this file: c-basic-offset and js2-basic-offset should be
   js-indent-level. Whatever value they're given should be preserved;
   different parts of our tree use different indentation styles.

 - We don't use tabs in Mozilla JS code. Always set indent-tabs-mode: nil.
   Remove tab-width: settings, at least in files that don't contain tab
   characters.

 - Remove js2-mode settings that belong in the user's .emacs file, like
   js2-skip-preprocessor-directives.
2014-06-24 22:12:07 -07:00
Jeremy Poulin
21428535f7 Bug 1016622: Renaming mozilla::network::Seer to mozilla::network Predictor. r=hurley
--HG--
rename : netwerk/base/public/nsINetworkSeer.idl => netwerk/base/public/nsINetworkPredictor.idl
rename : netwerk/base/public/nsINetworkSeerVerifier.idl => netwerk/base/public/nsINetworkPredictorVerifier.idl
rename : netwerk/base/src/Seer.cpp => netwerk/base/src/Predictor.cpp
rename : netwerk/base/src/Seer.h => netwerk/base/src/Predictor.h
rename : netwerk/test/unit/test_seer.js => netwerk/test/unit/test_predictor.js
2014-06-03 13:37:46 -07:00
Paolo Amadini
cb51f08bcd Bug 984872 - Remove deprecated promise.js usage in Firefox for Desktop. r=mak 2014-03-20 22:21:05 +01:00
Malintha Fernando
c8698209af Bug 953124 - [Australis] Remove the "Open Location" dialog (openLocation.xul). r=dao 2014-01-25 17:12:20 +01:00
Paolo Amadini
147dff90bb Bug 899110 - Remove the code to switch between different back-ends from the Downloads Panel. r=enn 2013-11-04 19:21:13 +01:00
Nicholas Hurley
9000e8ce5d Bug 881804 (part 6) - Plumb browser UI into predictive network actions to allow clearing data. r=ttaubert r=mossop f=gavin 2013-10-25 14:57:00 -07:00
Honza Bambas
894ba59236 Bug 913807 - HTTP cache v2: API+top service+integration+tests, off by default, r=michal+ehsan+mark.finkle+fabrice+mhammond+gavin 2013-09-20 11:11:25 +02:00
Paolo Amadini
a78cae2649 Bug 913118 - Add a combined list of public and private downloads. r=enn 2013-09-12 21:20:30 +02:00
Neil Deakin
ebe4488a9b Bug 847863 - Part 6 of 8 - Convert tests for clearing recent history. r=paolo 2013-08-21 09:36:07 +02:00
Ed Morley
8b3523f429 Backed out changeset 7e8ff4c464f9 (bug 847863) on suspicion of causing failures in browser_sanitize-timespans.js 2013-08-20 11:52:34 +01:00
Neil Deakin
224deda30d Bug 847863 - Part 6 of 8 - Convert tests for clearing recent history. r=paolo 2013-08-19 23:39:14 +02:00
Neil Deakin
c1b7543f1b Bug 899125 - Part 1 of 2 - Allow using the JavaScript API instead of nsIDownloadManager when clearing recent history. r=paolo 2013-08-17 15:19:55 +02:00
Adam Dane [:hobophobe]
7bb721921b Bug 537013 - Make the find bar exist on a per-tab basis. r=dao 2013-07-06 02:56:36 +02:00
Doug Turner
56ec59c248 Bug 882485 - Add API keys support for Google Location Service API. r=gps, jdm, gavin. sr=brendan 2013-06-12 19:20:07 -07:00
Mark Hammond
d8cdc4443e Bug 566746 - various fixes to sanitize(). r=mak 2013-05-09 09:08:07 +10:00
Gavin Sharp
4d947b6985 Re-land patches from bug 566746 and bug 697377 now that bug 851641 is addressed 2013-04-19 15:21:30 -07:00
Ryan VanderMeulen
048824e68e Backed out changeset 555f2b757639 (bug 566746, bug 697377) for intermittent Win7 mochitest b-c orange. 2013-05-02 21:20:08 -04:00
Gavin Sharp
1372a3cf1c Re-land patches from bug 566746 and bug 697377 now that bug 851641 is addressed 2013-04-19 15:21:30 -07:00
Ryan VanderMeulen
0021e7aaee Backed out 17 changesets (bug 566746, bug 697377) for frequent OSX debug mochitest-5 crashes. 2013-04-11 11:53:13 -04:00
Neil Deakin
f700a57efa Bug 566746, use improved callback api for asyncronous form history methods, r=mak 2013-04-11 04:01:49 -04:00
Felix Fung
38683fb3ae Bug 566746 - Use Asynchronous FormHistory.jsm for sanitize.js, p=enndeakin,felix, r=mak 2011-12-17 01:31:50 -08:00
Felipe Gomes
975f9fb142 Bug 850210 - Part 2. Update removeGroupedPrefs usage to nsIContentPrefService2.removeAllDomains. r=adw 2013-03-29 23:08:49 -03:00
Marco Bonardo
43203f208f Bug 838874 - Stop implementing nsIGlobalHistory2.
r=Mano sr=gavin
2013-03-20 18:09:41 +01:00
Josh Matthews
efeaece5f9 Bug 722859 - Support concurrent private/public downloads in the download manager. r=paolo/mak sr=bz ui-r=shorlander 2012-05-25 12:24:35 +01:00
Ed Morley
4290399916 Backout f077ad362ca3 (bug 722859) for bustage 2012-11-16 10:44:20 +00:00
Josh Matthews
6371de55a7 Bug 722859 - Support concurrent private/public downloads in the download manager. r=paolo/mak sr=bz ui-r=shorlander 2012-05-25 12:24:35 +01:00
Ed Morley
c292bc7a94 Backout 00cc23d1f72b (bug 722859) for compilation failures 2012-11-16 10:01:14 +00:00
Josh Matthews
4da5ab7437 Bug 722859 - Support concurrent private/public downloads in the download manager. r=mak/paolo 2012-05-25 12:24:35 +01:00
Josh Matthews
fda5be2065 Bug 723002 - Determine privacy status from provided nsILoadContext in ContentPrefService. r=ehsan 2012-06-30 07:50:07 -07:00
Graeme McCutcheon
051422810f Bug 409624 - Sanitizer should clear findBar data. r=adw 2012-10-22 12:42:53 +01:00
Josh Matthews
c5574afd30 Bug 789546 - Convert all JS users of imgICache service to use privacy-aware imgITools API instead. r=ehsan 2012-09-17 12:18:40 -04:00
Gervase Markham
82ff7027aa Bug 716478 - update licence to MPL 2. 2012-05-21 12:12:37 +01:00
Geoff Lankow
8c5fdd1d03 Bug 718255 - Merge nsIPrefBranch2 with nsIPrefBranch - Part D, remove uses of nsIPrefBranch2 in browser/ and mobile/ ; r=bsmedberg 2012-01-17 14:34:51 +13:00
Michal Novotny
9776ec5e71 Bug 538588 - Split offline storage into http and offline cache in advanced network preferences dialog 2011-12-16 23:36:09 +01:00
arno renevier
24449bb83a Bug 680883 - unneeded nsIPluginHost QueryInterface in sanitize.js and nsPrivateBrowsingService.js; r=ehsan 2011-08-22 14:29:20 -04:00
Benjamin Smedberg
1b9d968e1c Bug 617539 - Remove nsIPluginHost_MOZILLA_2_0_BRANCH, nsIPluginInstanceOwner_MOZILLA_2_0_BRANCH, and nsIPluginInstance_MOZILLA_2_0_BRANCH; r=jst 2011-04-11 16:00:30 -04:00
Dan Witte
9bbbe66da7 Bug 625496 - Clear Adobe Flash Cookies (LSOs) when Cookies is selected in Clear Recent History. r=ehsan, a=final+ 2011-02-08 14:16:09 -08:00
Bobby Holley
57fe00ab9a Bug 576621 - clearing cache does NOT clear cached images.r=joe,gavin 2010-07-11 21:01:53 -04:00
Dão Gottwald
ae30b0fbe8 Bug 5265285 - getAllLogins, getAllDisabledHosts and getAllEncryptedLogins count out params should be optional. r=dolske 2009-11-08 10:22:11 +01:00
Dão Gottwald
43d1a1d645 Bug 507881 - remove useless "|| null" fallback in browserGlue.sanitize(window) calls. r=gavin 2009-08-04 20:10:23 +02:00
Ehsan Akhgari
95421f45f0 Bug 488706: Migrate clear private data settings. r=mconnor 2009-05-21 10:51:56 +01:00
adw@mozilla.com
5da2e47dea Bug 491883 - Clear Recent History removes pages (URIs) from history instead of visits (r=johnath) 2009-05-20 16:05:25 -07:00
Drew Willcoxon
73f247cb0f Bug 480169 - Clear recent history refresh (sprint)
Item list hidden behind expander/progressive disclosure button, added a warning when clearing all history, added a tree view for selecting a fine-grained timespan.  We decided to remove the tree view at the last minute; code is still there but #ifdef'ed out.
r=mconnor
2009-04-15 10:59:07 -07:00
Doug Turner
441451be3c Bug 487467. Support for a Network Geolocation Provider.
Browser bits for sanitizing.  r=gavin
Mochitest. r=ctalbert
Dom bits. r/sr=jst
Provider component. r=gavin, sr=jst
2009-04-14 09:10:20 -07:00
Michal Novotny
618a8fbb85 Bug 474434 - Active ftp sessions are not closed when clearing recent history; r=bzbarsky sr=cbiesinger 2009-02-23 19:28:17 +01:00
Johnathan Nightingale
04d126b4b4 Bug 474792 - Clear "Never remember passwords for this site" with other site-specific settings in CRH dialog. r=dolske 2009-02-04 14:08:06 -05:00
Ehsan Akhgari
4f15fed377 Bug 475564 - Clear Recent History dialog should not be minimized; r=gavin 2009-01-30 11:43:16 +03:30
Johnathan Nightingale
6783415329 Expose site-specific settings in CRH dialog. b=380852, r=gavin 2009-01-20 10:59:49 -05:00
Ehsan Akhgari
4f803cdd28 Bug 469158 - Remove the 'privacy.sanitize.promptOnSanitize' preference; r=gavin ui-r=beltzner 2009-01-02 03:30:49 +03:30
Ehsan Akhgari
6e6796cce2 Bug 463474 - Make sanitizer's searchbar clearing code a bit cleaner; r=gavin a191=beltzner 2008-11-28 12:51:16 -08:00
Justin Dolske
0310bdcb87 Bug 464947 - Clear Recent History dialog should clear form data by timespan. r=mconnor 2008-11-17 16:46:31 -08:00
Johnathan Nightingale
0ba9c0d0ed Extend "Clear Private Data" with time period option. b=453440, r=mconnor ui-r=beltzner a=blocking-firefox3.1 2008-11-05 19:57:00 -08:00
Gavin Sharp
bfe8fbcd61 Bug 446274: make sure to properly enable the 'clear history' menu option if there is search bar state to clear, r=dao 2008-09-15 09:21:28 -04:00
dcamp@mozilla.com
a6e912d3e4 Bug 398478: Clear globalStorage for offline apps separately from cookies, and the offline cache separately from the main cache. r=enndeakin, r=mconnor, sr=biesi 2008-01-22 20:06:36 -08:00