Commit graph

1626 commits

Author SHA1 Message Date
Gijs Kruitbosch
46b1167088 Bug 1420583 - fix new tab adjacency logic when using "restore defaults", r=jaws
When using "restore defaults", Customize mode unwraps all elements. The previous implementation
of _updateNewTabVisibility assumed that elements were wrapped in <toolbarpaletteitem>s when in
customize mode, but this isn't true during a reset. The new implementation just looks for the
<toolbarpaletteitem>s and their children as necessary.

MozReview-Commit-ID: FjNJ1n8foGi

--HG--
extra : rebase_source : c9de8a2a4d4dcf191281fead320acc2ddc1321d6
2017-11-27 15:23:42 +00:00
Tawny Hoover
a33fa6a1f2 Bug 1398992 = Make 'Recently Bookmarked' in Photon panels support browser.bookmarks.openInTabClosesMenu pref. r=jaws
MozReview-Commit-ID: 3Rio9EjwilT

--HG--
extra : rebase_source : dde522b0eb65b22ee74d8dfb6d5f1d1a5489237f
2017-11-24 21:54:54 -05:00
Mark Striemer
8a1f9ea7ae Bug 1390158 - Notify user of extension controlling New Tab on first access r=aswan,jaws
MozReview-Commit-ID: 1g9d4UTuOgr

--HG--
extra : rebase_source : 29e07cff103e7751bf4ca414a88f89136d3ac237
2017-11-22 19:00:58 -06:00
Gijs Kruitbosch
53181787f7 Bug 1418757 - new tab button isn't adjacent to the last tab when customizing in customize mode, r=jaws
MozReview-Commit-ID: bQoNfDD2sX

--HG--
extra : rebase_source : e8afb0662e82e3b879bd3b6e28aef27d477bf92c
2017-11-22 13:49:07 +00:00
Paolo Amadini
166ddcece1 Bug 1414244 - Part 7 - Remove unused code paths from PanelMultiview.jsm. r=Gijs
MozReview-Commit-ID: 9cwaAZXqDGO

--HG--
extra : rebase_source : 90cf1a99c2ca1a64709abfa7383462480282ba0f
2017-11-23 15:18:14 +00:00
Paolo Amadini
fc23659e93 Bug 1414244 - Part 6 - Fold the "photonpanelmultiview" binding into "panelmultiview". r=Gijs
MozReview-Commit-ID: IjvSZZUHUMt

--HG--
extra : rebase_source : a94e212e8af35b77806d1d62e020a511ab62e224
2017-11-21 14:21:32 +00:00
Paolo Amadini
5bf848634e Bug 1414244 - Part 5 - Remove the "panel-mainview" container. r=Gijs
MozReview-Commit-ID: 3NDGiy3Mwtq

--HG--
extra : rebase_source : 9c46b5dd69df05ff7688eae2e6b4aabaca4e2d8d
2017-11-11 22:56:15 +00:00
Paolo Amadini
90a19d3ca4 Bug 1414244 - Part 4 - Remove the "panel-clickcapturer" element. r=Gijs
MozReview-Commit-ID: 3aPVbnmr7QB

--HG--
extra : rebase_source : f59452147d08b3f75521c544f78f1c29b2c39814
2017-11-11 22:48:32 +00:00
Paolo Amadini
82f9f4f35d Bug 1414244 - Part 3 - Remove the "panel-subviews" container. r=Gijs
MozReview-Commit-ID: 2GGJ1myKuF5

--HG--
extra : rebase_source : e4089ae1ec828048f052932f13a687aca109b7c5
2017-11-11 22:09:30 +00:00
Paolo Amadini
b4f8aa9d1e Bug 1414244 - Part 2 - Remove the "viewtype" attribute. r=Gijs
MozReview-Commit-ID: 8fq0KLfYWnc

--HG--
extra : rebase_source : a75197f66d0b8699e1cad5640eb0bc20ee53ee0c
2017-11-21 13:22:47 +00:00
Paolo Amadini
46c88521a3 Bug 1414244 - Part 1 - Remove the "panelid" attribute. r=Gijs
MozReview-Commit-ID: 4o27h6PhCRg

--HG--
extra : rebase_source : 7be0dd97832033fa0d5304afd0def1cd3dcd3ddf
2017-11-11 13:05:51 +00:00
Alphan Chen
54f4537537 Bug 980904 - Disable the Character Encoding menu when document is decoded as UTF-8 without errors. r=hsivonen,emk,Gijs 2017-11-23 15:03:41 +08:00
Xidorn Quan
843aaedf4d Bug 1417600 - Wait for another frame before setting animation out to ensure start of the animation. r=jaws
MozReview-Commit-ID: 96nGBDgdr05

--HG--
extra : rebase_source : a5bdf5ff0576a3d24d02e0e35effaa13c6eace43
2017-11-16 10:33:04 -08:00
Sam Foster
c5c9a1666e Bug 1412364 - defer applying maxHeight in PanelMultiView until popup is positioned. r=Paolo
* Let popup code initially measure and place the panel without maxHeight, this ensures alignmentPosition is a reasonable value
* Assign maxHeight from a popuppositioned handler and update the comment explaining the role of the autoPosition property
* Refactor to move the maxHeight calculation into a method on PMV
* panel autoPosition now gets reset to false in popuppositioned (was popupshowing) as the ShowWithPositionedEvent on popupFrame sets it back to true every time
* Update reflow tests with new signatures, and elimination of 1 reflow
* In appMenu reflow test, we must now wait for popupshown before opening subviews

MozReview-Commit-ID: KfHxngnajM3

--HG--
extra : rebase_source : 2918a30f6ecdfded57fb7b93aba3f0479fd4635c
2017-11-16 17:12:06 -08:00
Tooru Fujisawa
50f5bf47cd Bug 1418739 - Part 2: Remove unused delayedStartup parameter from BrowserTestUtils.waitForNewWindow. r=smaug 2017-11-21 03:41:56 +09:00
Andreea Pavel
eaff9152a3 Backed out 1 changesets (bug 1417600) for failing browser/components/customizableui/test/browser_972267_customizationchange_events.js r=backout on a CLOSED TREE
Backed out changeset 04dac3301ecd (bug 1417600)
2017-11-17 12:51:12 +02:00
Xidorn Quan
948e8f416e Bug 1417600 - Wait for a style flush before setting animation out to ensure start of the animation. r=jaws
MozReview-Commit-ID: IhnmZ0L9yx

--HG--
extra : rebase_source : 013417c60cc85dbb90b8ab33afe60b55252d0b17
2017-11-16 10:33:04 -08:00
Johann Hofmann
3508660808 Bug 1362065 - Add the touchdownstartsdrag attribute to selected tabs on Windows. r=dao
This allows dragging them via touch gestures.

I'm not adding this attribute to all tabs (so that you need
to select a tab before dragging it), because the tab
strip can also be scrolled with touch gestures and
the two touch move actions would easily conflict
otherwise. It would also make it easier to accidentally
mess up your tabs when touching your window somehow.

MozReview-Commit-ID: IVWQtVGFE9j

--HG--
extra : rebase_source : b4d616f45de4362d2fd505dacbf7176d12a04e37
2017-11-10 12:06:50 +01:00
Mark Banner
ab78a2a54d Bug 1371293 - Fix instances of space-before-function-paren failures after ESLint 4 upgrade. r=mossop
MozReview-Commit-ID: 5XfdCSDjLEG

--HG--
extra : rebase_source : 96335eec91a40f893ff28a1c002653b758d8f24d
2017-11-06 13:46:21 +00:00
Gijs Kruitbosch
7cc3de1624 Bug 1388029 - remove dead CSS relating to the old panel, r=jaws
MozReview-Commit-ID: FoXjvWPc9in

--HG--
extra : rebase_source : b098e2efc8f154aaae5f4ddfd30558fb0f3299c1
2017-11-07 12:52:56 +00:00
Gijs Kruitbosch
8c1b02e3d4 Bug 1388029 - remove the remaining uses of AREA_PANEL, r=jaws
MozReview-Commit-ID: L017kRfHfOv

--HG--
extra : rebase_source : c9dcbb76d787281ac2dcf18c59786205aeaacaf9
2017-11-07 12:15:18 +00:00
Gijs Kruitbosch
d01a2b63d7 Bug 1388029 - remove notion of 'wide' widget and panel columns from the tree, r=jaws
MozReview-Commit-ID: IrCB3zn1BIT

--HG--
extra : rebase_source : efb192e8c82a4272078bd7754ef453113166b81c
2017-11-07 12:00:18 +00:00
Gijs Kruitbosch
f98c738db9 Bug 1388029 - remove useless param from PanelUI.showSubView, r=jaws
MozReview-Commit-ID: 9hkYtLxAOtQ

--HG--
extra : rebase_source : 76f0f2acb9c785e9497fccb493e5c158d9d35eb4
2017-11-07 11:54:47 +00:00
Paolo Amadini
f735328150 Bug 1409301 - Update the site security subview to the Photon style. r=johannh
The site security subview is now implemented using the "photonpanelmultiview" element, replacing the last instance of the "panelmultiview" element. The subview features a standard Photon header, hence the connection state icon was moved to the element below it. This makes the styles more similar between the main view and the subview. The connection state styles are now applied using a class name, and the tests have been updated accordingly.

This change required some fixes in the "photonpanelmultiview" implementation to make sure the height of the subview is correct and to allow keyboard navigation back to the main view.

Since the expander button and the permission controls in the main view are not visible anymore after the subview is shown, some code related to focus and hover could be removed as well.

MozReview-Commit-ID: 4nIAPWJPV8k

--HG--
extra : rebase_source : 74d6d769421c0f8521bdfae249b4d111e630a3bd
2017-11-11 19:13:43 +00:00
Jared Wein
aa66390484 Bug 1415054 - Handle RTL in empty customize mode better. r=gijs
MozReview-Commit-ID: HjqvOM1n14G

--HG--
extra : rebase_source : fb133bb320f37585f63f872ead38ba7e7f87e544
2017-11-08 15:32:21 -05:00
Gijs Kruitbosch
c2d962cea7 Bug 1408613 - stop trying to use a smaller image in the overflow panel which is wide enough, r=mikedeboer
MozReview-Commit-ID: Kh83oju1Dud

--HG--
extra : rebase_source : 30219c8ef0a3bc592191df4c01fd32de4004ef5f
2017-11-08 17:52:20 +01:00
Johann Hofmann
93aef727a2 Bug 1299286 - Add the touchdownstartsdrag attribute to customize mode elements. r=jaws
MozReview-Commit-ID: LziDBjACA0

--HG--
extra : rebase_source : b0c08cb1ecafa6fce4b9e55ce3dae65412c5070e
2017-11-03 13:12:10 +01:00
Gijs Kruitbosch
974b0a4c68 Bug 1408166 - prevent search bar popup from ever showing when browser_940307_panel_click_closure_handling is running to avoid it interfering with context menu clicks, r=florian
MozReview-Commit-ID: jyRcdAKpxR

--HG--
extra : rebase_source : 66d4452809e8b66383bf8cfb02cfc695b9ade37a
2017-11-07 10:54:10 +00:00
Thom Chiovoloni
837350c20d Bug 1411794 - Fix bug where sync tabs panel would become permanently empty. r=eoger
MozReview-Commit-ID: 2mRAPhABCXA

--HG--
extra : rebase_source : cd004aef3b604a8d2426c0896d83a57003f2ea8d
2017-11-01 21:58:55 -04:00
Gijs Kruitbosch
b8a8802972 Bug 1411011 - stop offering context menu (re)move options on skipintoolbarset items, r=jaws
Giving all these nodes ids doesn't seem like the right fix. `buildArea` already ignores skipintoolbarset
items before doing anything else with nodes, so bailing out early seemed like the right solution here.

MozReview-Commit-ID: H3EyqoospNR

--HG--
extra : rebase_source : 6dc06d18c82e2af5024be0aba271c270f7403839
2017-11-06 14:49:37 +00:00
Jared Wein
b8ffd9d167 Bug 1410666 - Remove unused PanelUI-popup code. r=mconley
Original patch authored by Tim Nguyen (:ntim).

MozReview-Commit-ID: 6qQnRMQXPTH

--HG--
extra : rebase_source : 319d160f3057173359f02adba44bdcc12a68e209
2017-10-31 14:38:15 -04:00
Coroiu Cristina
03154bfceb Backed out changeset b558ad2372bf (bug 1410666) for failing the browser-chrome on browser_all_files_referenced.js and browser_switch_to_customize_mode.js r=backout on a CLOSED TREE
Backed out changeset b558ad2372bf (bug 1410666)
2017-11-02 01:02:12 +02:00
Jared Wein
2fdc4b7cdf Bug 1410666 - Remove unused PanelUI-popup code. r=mconley
Original patch authored by Tim Nguyen (:ntim).

MozReview-Commit-ID: 6qQnRMQXPTH

--HG--
extra : rebase_source : f85e763cc130a71ba0f4bda228a874ebf65b84be
2017-10-31 14:38:15 -04:00
Andrea Casaccia
71abace57c Bug 1402849 - Close library panel on mid mouse click r=mikedeboer
MozReview-Commit-ID: 8AM0efs7krS

--HG--
extra : rebase_source : 12795d3f89f0d158b2ba357aa72d014fc51b64e3
2017-10-31 09:16:50 +02:00
Jared Wein
77a52a2953 Bug 1413030 - Polish up a few conditions when the customization palette is mostly empty. r=mconley
MozReview-Commit-ID: Gr4sXTZo7pG

--HG--
extra : rebase_source : 2960fd2f09655c44692dd708767593374762eefb
extra : amend_source : 0dc4fdcda68a05851dbe61f50768d91b0683c246
2017-10-24 17:23:22 -04:00
Mark Banner
01008c7d57 Bug 1412778 - Enable ESLint rule no-cpows-in-tests across the whole tree. r=florian
MozReview-Commit-ID: 8pidN7x6MYh

--HG--
extra : rebase_source : 6a0d6800091231fc1535223bd7fc6df0ba40d47b
2017-10-30 09:55:39 +00:00
Edouard Oger
76547f53cc Bug 1395460 p1 - Remove usages of about:accounts. r=tcsc
MozReview-Commit-ID: APdGc9avJDw

--HG--
extra : rebase_source : aaa788be5251607ebedcb5b690da0e2a1a64e2cb
2017-10-24 14:05:52 -04:00
Sebastian Hengst
93903f0306 Backed out 2 changesets (bug 1395460) for eslint failure at browser/components/uitour/UITour.jsm:556 (no return value from arrow function). r=backout on a CLOSED TREE
Backed out changeset 0bc6d186d609 (bug 1395460)
Backed out changeset 6c028123001d (bug 1395460)
2017-10-26 23:33:04 +02:00
Edouard Oger
58876ecbe9 Bug 1395460 p1 - Remove usages of about:accounts. r=tcsc
MozReview-Commit-ID: APdGc9avJDw

--HG--
extra : rebase_source : 9da1cea9fb6494c057bc6587a7bcbdb4ac127448
2017-10-24 14:05:52 -04:00
Drew Willcoxon
7633396485 Bug 1409377 - Prevent the app menu's scrollbar from overlapping its content. r=mikedeboer
MozReview-Commit-ID: EHx5yi0pW6B

--HG--
extra : rebase_source : f6bce2b635c04026f9dc8a09bcff86b626c0b1c7
2017-10-25 12:42:28 -04:00
Johann Hofmann
2807fe98d1 Bug 1410352 - Make the overflow menu adhere to touchmode sizing. r=nhnt11
MozReview-Commit-ID: JhMIp65wuaq

--HG--
extra : rebase_source : b786a695a954ef72eb08bf7ea5710fee7f3ead42
2017-10-25 13:07:46 +02:00
Sebastian Hengst
fabade716b Backed out changeset cc55d4e3d13d (bug 1410352) for eslint failure at browser/components/customizableui/CustomizableUI.jsm:4339: 'aEvent' is already declared in the upper scope. r=backout
--HG--
extra : rebase_source : 29fad97f166d57cc9b192874f0ec82ea8b6c044c
2017-10-25 16:53:27 +02:00
Johann Hofmann
ad3fb07012 Bug 1410352 - Make the overflow menu adhere to touchmode sizing. r=nhnt11
MozReview-Commit-ID: JhMIp65wuaq

--HG--
extra : rebase_source : f18647cf4631e489ef2787884d69b08ceabfee4d
2017-10-25 13:07:46 +02:00
Mike de Boer
5f6fdc1ef0 Bug 1387808 - Switch to using XUL spacer elements for the zoom and edit controls' leading space in the app menu to fix auto-sizing issues. r=jaws
When the locale has a slightly longer label for 'Zoom', the popup auto-sizing
code starts having trouble with the inline start padding of that label and doesn't
size the popup correctly anymore.
When I change this to using a spacer element, this issue no longer occurs and the
label may become as large as localizers may need, as long as it doesn't exceed
the max-width of a panelview - 30em, currently.

MozReview-Commit-ID: CHRheMqazrj

--HG--
extra : rebase_source : 6e0441908617a954e782d8fcbbc16035e8c0e942
2017-10-23 13:40:18 +02:00
Sebastian Hengst
f9b5b9b40c merge mozilla-inbound to mozilla-central. r=merge a=merge
MozReview-Commit-ID: 790IXj5MZ4f
2017-10-18 11:48:34 +02:00
Jared Wein
49cd682e0d Bug 1409463 - Handle customization mode when only the Spacer is left. r=mconley
mconley helped with the initial setup here and they were reviewed by myself (jaws). His changes have been folded in to this patch since they didn't work as a standalone changeset.

MozReview-Commit-ID: E7U1ZciJl4D

--HG--
extra : rebase_source : 63400055b28fe15764190127996a0420c5f1f722
2017-10-15 14:11:57 -04:00
Ryan VanderMeulen
e8cd5f653b Backed out 5 changesets (bug 1407351) for causing bug 1409395 and breaking nightlies.
Backed out changeset e6ee25ad6a9f (bug 1407351)
Backed out changeset 8e04412824b5 (bug 1407351)
Backed out changeset effeee94316e (bug 1407351)
Backed out changeset a53f34a45f9b (bug 1407351)
Backed out changeset 86a360e12b8a (bug 1407351)
2017-10-17 10:07:55 -04:00
Phil Ringnalda
dcda41b943 Backed out changeset 5b9d2ebcf44e (bug 1033395) for failures in browser_overflow_anchor.js
MozReview-Commit-ID: LfhmJLydnaF
2017-10-16 22:01:54 -07:00
Erica Wright
d29984c27b Bug 1033395 - Panels Should Be Anchored from the Same Height on the Toolbar. r=johannh
MozReview-Commit-ID: 6bhlfeD1esE

--HG--
extra : rebase_source : 6e2d645505f154ae556827032af2e51f32657484
2017-09-13 15:49:32 -04:00
Erica Wright
6146d651bb Bug 1407754 - exiting customize mode quickly after adding a toolbar item to toolbar properly adds it to the toolbar. r=jaws
MozReview-Commit-ID: C7uvVVWoIeB

--HG--
extra : rebase_source : 423b5a7449410a5064405fdb18a87017eb668c6c
2017-10-13 09:27:48 -04:00