Commit graph

89 commits

Author SHA1 Message Date
Jared Wein
eaeac4ff97 Bug 1383207 - Using the keyboard shortcut to select-all in the Cookies dialog should select all the visible cookies. r=evanxd
MozReview-Commit-ID: KmIapWrr0Zm

--HG--
extra : rebase_source : b5417adbcd1ad3bfaff96693f0076edc86193d63
2017-10-24 14:59:34 -04:00
Mark Banner
42cb2dc6a3 Bug 1230373 - Enable mozilla/use-services for browser/components/ r=mossop
MozReview-Commit-ID: 9m9iss3jUJJ

--HG--
extra : rebase_source : e6a6f9dec168ab1d0e0343236db65f3dd1b44aeb
2017-10-11 15:43:51 +01:00
Dan Banner
7caa92d5d8 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
Rajesh Kathiriya
48e6bc2124 Bug 1374620 - Enabled the ESLint dot-notation rule across mozilla-central r=standard8
MozReview-Commit-ID: FadrI2li43G

--HG--
extra : rebase_source : b455e846ab79c8141150517e67e542e3e06d630e
2017-07-25 23:45:41 +05:30
Sebastian Hengst
804a36e668 Backed out changeset f5922a7ed25a (bug 1374620) for failing eslint at telemetry/tests/unit/test_TelemetrySend.js:358: ["os"] is better written in dot notation. r=backout 2017-07-31 14:44:34 +02:00
Rajesh Kathiriya
22dfa54ef4 Bug 1374620 - Enabled the ESLint dot-notation rule across mozilla-central r=standard8
MozReview-Commit-ID: FadrI2li43G

--HG--
extra : rebase_source : 5992bdde34bcc2421350433bc8c1e498a6bba848
2017-07-25 23:45:41 +05:30
Prathiksha
d912178c6f Bug 1365957 - Pressing backspace on the cookies dialog to delete a cookie no longer removes the dialog. r=johannh
MozReview-Commit-ID: LDwIljC7Ji7

--HG--
extra : rebase_source : 0f3ae4e2aa901eb92d62935cdbced0db0bc9531a
2017-07-17 17:01:36 +05:30
Jorg K
ce5c327601 Bug 1383463 - Use mozIntl for cookies and page info. r=zibi
--HG--
extra : rebase_source : fd5e59df9904a406fe381d6e4f5ad5e52700faf4
2017-07-22 23:18:00 -04:00
Florian Queze
37ff4fc7cc Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst
a07223d699 Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
Florian Queze
95d4d20c17 Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Jared Wein
a54eda04ca Bug 1348068 - Enable the key-spacing rule for eslint and fix the related issues. r=standard8
Running eslint with --fix didn't fix many of the issues. The majority here had to be fixed by hand but a significant majority of the issues were related to a few files that I was able to use find-and-replace with. I regret not making this in to separate commits of the hand-fixes and the fixes from --fix but I don't recall --fix fixing any of the issues.

MozReview-Commit-ID: ANyg2qfo3Qx

--HG--
extra : rebase_source : 61d2aa91bf9474af3d72a5dea41b25dca442c1b7
2017-03-21 14:29:43 -04:00
Zibi Braniecki
3d91da8726 Bug 1347314 - Migrate calls to ChromeRegistry::GetSelectedLocale to use LocaleService::GetAppLocale. r=jfkthame,Pike
In cases, where the caller is looking for the locale to be used for JS Intl API,
we can now replace it with `undefined` which causes JS Intl API to use the default
locale which since bug 1346674 is resolved to the app locale.

This allows us to remove a lot of calls for the app locale.

The remaining ones are split between `AsBCP47` and `AsLangTag`.
Here, the `AsLangTag` is used, as described in the API docs, for cases where
the language string is used for localization purposes, such as language negotaition
matching to our language resources etc.
`AsBCP47` is used when the returned value is handed over to ICU API.

MozReview-Commit-ID: DzmFEUvMq3N

--HG--
extra : rebase_source : 513ed31d995864939aa893e73c81ffdf591a6617
2017-03-14 16:09:54 -07:00
Sebastian Hengst
0a04f3b9e2 Backed out changeset cc308a73ad05 (bug 1347314) for eslint failure in test_device.html. r=backout 2017-03-22 18:20:26 +01:00
Zibi Braniecki
c2cd68a689 Bug 1347314 - Migrate calls to ChromeRegistry::GetSelectedLocale to use LocaleService::GetAppLocale. r=jfkthame,Pike
In cases, where the caller is looking for the locale to be used for JS Intl API,
we can now replace it with `undefined` which causes JS Intl API to use the default
locale which since bug 1346674 is resolved to the app locale.

This allows us to remove a lot of calls for the app locale.

The remaining ones are split between `AsBCP47` and `AsLangTag`.
Here, the `AsLangTag` is used, as described in the API docs, for cases where
the language string is used for localization purposes, such as language negotaition
matching to our language resources etc.
`AsBCP47` is used when the returned value is handed over to ICU API.

MozReview-Commit-ID: DzmFEUvMq3N

--HG--
extra : rebase_source : 13fa4c397ba4c79303a2cd76684b5b8c4bd17331
2017-03-14 16:09:54 -07:00
Fischer.json
613e459869 Bug 1338757 - "Remove All Shown" and button in about:preferences should use its own accesskey, r=jaws
MozReview-Commit-ID: 2ucF0GqOCJV

--HG--
extra : rebase_source : 5c1899f808ff287365e6621199b865516224a2d8
2017-02-13 11:43:37 +08:00
Fischer.json
6fba9fc139 Bug 1338036 - Switch button label from "Remove All" to "Remove All Shown" when filtering by keyword in about:preferences, r=jaws
MozReview-Commit-ID: 8iK6bg8i0uT

--HG--
extra : rebase_source : 9f44d7ba2df0cb4017d4164dd5bdd5233de9400e
2017-02-09 12:00:12 +08:00
Fischer.json
32d84fe236 Bug 1312377 - Remove selected site data in Settings of Site Data, r=jaws
MozReview-Commit-ID: 2MlnZfajM4t

--HG--
extra : rebase_source : 95468bcdfb884eec93f93274a4597173cd105a78
2016-12-19 16:57:34 +08:00
Jared Wein
43bac26d30 Bug 1331661 - Enable the 'quotes' rule for eslint and fix most of the errors with --fix. r=Gijs
MozReview-Commit-ID: 6tv0Z06CO4a

--HG--
extra : rebase_source : 014c0b04d8538dc5f15bc6dd4ed6bd220c55c5d4
2017-01-17 09:48:17 -06:00
Jared Wein
9141469edf Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN
MozReview-Commit-ID: FuVu8skcqOe

--HG--
extra : rebase_source : 8ab34c4e46a7c3075b459bf44786ec184d10d203
2016-12-30 21:47:25 -05:00
Jared Wein
ecab54a7c9 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje

--HG--
extra : rebase_source : 0572a35415a766a3f31d266760ecd07f0dcc3f72
2016-12-29 18:34:54 -05:00
Wes Kocher
0dfb7c2b5c Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
7255df4e9a Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR

--HG--
extra : rebase_source : da7172285d43b820421557ed3b05887e091ff939
2016-12-29 15:20:47 -05:00
Dave Townsend
8de07a19a0 Bug 1316882: Turn on space-before-function-paren eslint rule (browser). r=jaws
MozReview-Commit-ID: 2ZvTiZDHchz

--HG--
extra : rebase_source : db6482481b7338df491afd6f6fd376eccec84d7e
2016-11-11 08:10:51 -08:00
Mark Banner
a41b5adcb0 Bug 1314918 - Fix most of the remaining no-unused-vars issues for local scope in browser/. r=mossop
MozReview-Commit-ID: LdoXLniNeT7

--HG--
extra : rebase_source : d2418b8cfab0a399d0dfb5a96ea50c62fac63e70
2016-11-03 11:51:48 +00:00
Jared Wein
5040f17e00 Bug 1312486 - Enable no-extra-boolean-cast, no-new-object, no-shadow-restricted-names, and spaced-comment rules for eslint. r=standard8
MozReview-Commit-ID: 7Gx90a5y8t6

--HG--
extra : rebase_source : 9c8a6b15c19982d720b0163fbbf19d465da786fe
2016-10-24 13:14:19 -04:00
Mark Banner
fbd5ec1798 Bug 1313634 - Fix undefined variables issues in cookies.js that lead to the cookies window not updating properly when open. r=jaws
MozReview-Commit-ID: RBhuCbjrYT
2016-10-29 14:49:17 +01:00
Jonathan Kew
57a08b0a08 Bug 1301655 - pt 5 - Replace use of nsIScriptableDateFormat for cookie date formatting. r=gandalf 2016-10-28 12:04:07 +01:00
William CS
5e63b538ec Bug 1295000 - Clean up for-loops in cookies.js. r=Standard8
MozReview-Commit-ID: KO3KTaPXLpS
2016-10-19 15:47:58 +01:00
Gijs Kruitbosch
677cdb5fb6 Bug 1307132 - import AppConstants.jsm, r=jaws
MozReview-Commit-ID: DQZtraWCZnK

--HG--
extra : rebase_source : d1a2e47b77978875f760b385865c4c247a46dbba
2016-10-03 17:10:07 +01:00
Jared Wein
8d45b8762e Bug 1294989 - Enable eslint for browser/components/preferences. r=Gijs
MozReview-Commit-ID: 62ymdZhluHx

--HG--
extra : rebase_source : 330d512f91d840a47e48f39c21d70d13b2953d2d
2016-08-13 21:58:42 -04:00
Jonathan Hao
6be2c98b6c Bug 1285587 - Cookies set by thumbnails shouldn't appear. r=jdm 2016-07-26 20:09:00 +02:00
Tim Huang
fd497dc733 Bug 1285889 - Moving the ContextualIdentityService.jsm from from browser/components/contextualidentity into tookit/components/contextualidentity. r=baku
--HG--
rename : browser/components/contextualidentity/ContextualIdentityService.jsm => toolkit/components/contextualidentity/ContextualIdentityService.jsm
2016-07-11 20:03:00 +02:00
Andrea Marchesini
e42cf01dd7 Bug 1267923 - Move the CSS rules to ContextualIdentityService, r=mconley
--HG--
rename : browser/modules/UserContextUI.jsm => browser/components/contextualidentity/ContextualIdentityService.jsm
rename : browser/themes/shared/usercontext/usercontext.inc.css => browser/components/contextualidentity/content/usercontext.css
2016-05-17 15:03:43 +02:00
Andrea Marchesini
83a08cd72e Bug 1259169 - nsICookieManager::remove() should be back-compatible, r=jdm 2016-04-10 05:46:07 +01:00
Ryan VanderMeulen
1c7872d0af Backed out changeset 7d5f1e9ce04c (bug 1259169) for various cookie-related crashes and test failures. 2016-04-09 15:36:07 -04:00
Andrea Marchesini
d09d8959fe Bug 1259169 - nsICookieManager::remove() should be back-compatible, r=jdm 2016-04-09 19:09:49 +01:00
Carsten "Tomcat" Book
78d9f80444 Backed out changeset 74330da56b82 (bug 1259169) for assertion failures in nsCookieService.cpp:2390 2016-04-08 14:47:39 +02:00
Andrea Marchesini
87827f2189 Bug 1259169 - nsICookieManager::remove() should be back-compatible, r=jdm 2016-04-08 12:38:15 +01:00
Andrea Marchesini
ed31fee8d4 Bug 1245184 - nsICookieManager.remove should use the OriginAttributes, r=sicking 2016-02-25 16:41:13 +01:00
Carsten "Tomcat" Book
f2a98554ec Backed out changeset 27f3968ae8b2 (bug 1245184) 2016-02-19 15:55:23 +01:00
Andrea Marchesini
0a72c5e9e3 Bug 1245184 - CookieManager should remove cookies only if they match the userContextId, r=sicking 2016-02-19 14:49:50 +01:00
Andrea Marchesini
a34fe426f2 Bug 1244795 - adding a string for the default container under cookie manager, part 2, r=me 2016-02-09 06:49:58 +00:00
Andrea Marchesini
187c1a6d8f Bug 1244795 - adding a string for the default container under cookie manager, r=paolo 2016-02-08 16:55:33 +00:00
Sebastian Hengst
93d9f645d3 Backed out changeset 9494bdf52cc6 (bug 1244795) for browser chrome failures. r=backout 2016-02-08 17:45:08 +01:00
Sebastian Hengst
0b8a877450 Backed out changeset cc1cda7b777c (bug 1244795) for browser chrome failures. r=backout 2016-02-08 17:44:05 +01:00
Andrea Marchesini
ea03bd29d5 Bug 1244795 - adding a string for the default container under cookie manager - part 2, r=paolo 2016-02-08 14:25:43 +00:00
Andrea Marchesini
e4998cbcdc Bug 1244795 - adding a string for the default container under cookie manager, r=paolo 2016-02-08 14:24:19 +00:00
Andrea Marchesini
0ac8e42215 Bug 1239606 - Implement UserContextUI.jsm, r=paolo 2016-01-14 14:23:54 +00:00
Andrea Marchesini
8d1fe3d9e0 Bug 1199466 - part 2 - Cookie manager in FF preferences should show the userContextId, r=paolo 2016-01-14 08:05:08 +00:00