Commit graph

199 commits

Author SHA1 Message Date
Ethan Lin
7096d91795 Bug 1416620 - Fix webrender commands in nsDisplayButtonBorder. r=kats
MozReview-Commit-ID: 418FZgwFR2i
2017-11-17 17:09:33 +08:00
Sebastian Hengst
53f71049ff Backed out 2 changesets (bug 1416620) for failing own reftest. r=backout a=backout on a CLOSED TREE
Backed out changeset 3b45218edc2e (bug 1416620)
Backed out changeset c48580e1f535 (bug 1416620)
2017-11-14 13:04:52 +02:00
Ethan Lin
81075981f6 Bug 1416620 - Part1. Fix webrender commands in nsDisplayButtonBorder. r=kats
MozReview-Commit-ID: 418FZgwFR2i

--HG--
extra : rebase_source : a1f1da061f55fb6cac22e74eae80503fd9168717
2017-11-13 13:54:11 +08:00
Ethan Lin
beaea27dc3 Bug 1415989 - Do not use 'ShouldUseAdvancedLayer' for button type display items. r=jrmuizel
MozReview-Commit-ID: 83qOTfTRUY0

--HG--
extra : rebase_source : 560f285f3092cd75d14d27cae4adcb8e9dca0e3a
2017-11-10 11:41:15 +08:00
Ethan Lin
fa15fe7736 Bug 1414036 - Make sure we paint nsDisplayButtonBorder's box shadow before early return of the empty border. r=kats
MozReview-Commit-ID: AWevj7ls5SL

--HG--
extra : rebase_source : 251e4b40c96974a01608f57568fb7806306a9ca8
2017-11-03 14:15:29 +08:00
Ethan Lin
f18aa8ed14 Bug 1413397 - Avoid empty border's fallback. r=kats
MozReview-Commit-ID: 1KXYjcObJdi

--HG--
extra : rebase_source : ea36d0f77dff76175dbc6d2a27cb0017e703e0bf
2017-11-01 17:30:04 +08:00
Kartikaya Gupta
bb085f1a25 Bug 1407749 - Follow-up for 1393383 to remove useless code. r=jrmuizel
MozReview-Commit-ID: Dq7J8OurIcl

--HG--
extra : rebase_source : 9df07d0597c3503168c2c2f493392d7b71548886
2017-10-31 15:52:36 -04:00
Kartikaya Gupta
f392c7eba8 Bug 1407752 - Avoid taking the webrender fallback path for empty borders. r=jrmuizel
MozReview-Commit-ID: BTSljrUuKcH

--HG--
extra : rebase_source : f5370968de71c9b46dee32b743908f971c1ed3df
2017-10-31 13:18:14 -04:00
Daniel Holbert
680815cd6e Bug 1412346 part 5: (automated patch) Switch a bunch of C++ files in layout to use our standard mode lines. r=jfkthame
This patch was generated automatically by the "modeline.py" script, available
here: https://github.com/amccreight/moz-source-tools/blob/master/modeline.py

For every file that is modified in this patch, the changes are as follows:
 (1) The patch changes the file to use the exact C++ mode lines from the
     Mozilla coding style guide, available here:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#Mode_Line

 (2) The patch deletes any blank lines between the mode line & the MPL
     boilerplate comment.

 (3) If the file previously had the mode lines and MPL boilerplate in a
     single contiguous C++ comment, then the patch splits them into
     separate C++ comments, to match the boilerplate in the coding style.

MozReview-Commit-ID: EuRsDue63tK

--HG--
extra : rebase_source : 3356d4b80ff6213935192e87cdbc9103fec6084c
2017-10-27 10:33:53 -07:00
Kartikaya Gupta
eae58bd759 Bug 1409446 - Modify the extra-clip flag to instead track more useful information. r=ethlin,mstange
Instead of just keeping a count of how many "extra clips" (aka
out-of-band clips) we have pushed, track more complex information for
each clip. In particular, track the display item's normal clip chain, as
well as the clip id of the extra clip that was pushed. This will be
needed to override clip cache information in the next patch.

MozReview-Commit-ID: AWKDTkelhyL

--HG--
extra : rebase_source : 379e38550cf45d54862850f6c4aad0ac488f6ca9
2017-10-24 15:45:59 -04:00
Chih-Yi Leu
bee92ecf09 Bug 1393383 - Update webrender binding code to support non-uniform border radius r=kats
MozReview-Commit-ID: 9YIPRJ9Mzfi

--HG--
extra : rebase_source : c4404c2dbd5e6ab6206b170c506ef07306c8e601
2017-10-24 14:44:29 +08:00
Kartikaya Gupta
d8ac050c91 Bug 1409856 - Update all the WebRender code to use LayoutDevice units instead of Layer units. r=jrmuizel
MozReview-Commit-ID: DP3hwlFWyZC
2017-10-18 22:25:11 -04:00
Kartikaya Gupta
2f1948343f Bug 1403915 - Remove the WebRender*Layer classes and functions that refer to them. r=jrmuizel
MozReview-Commit-ID: 2syFwMc7j3r

--HG--
extra : rebase_source : 9a3852506820eb09328d91007581d74786eba9b0
2017-10-03 16:31:08 -04:00
Kartikaya Gupta
dbe077b3f1 Bug 1403915 - Remove the IsLayersFreeTransaction() machinery and assume it's always true. r=jrmuizel
MozReview-Commit-ID: 7FYVirQ5pal

--HG--
extra : rebase_source : 4b33fba54776003b4f0d45b89be07916db1f2340
2017-10-03 16:31:07 -04:00
Morris Tseng
ce9b629335 Bug 1392200 - Add backface-visibility support for layers-free mode. r=kats
For layers-full mode, we set the backface-visibility to visible because
visibility would be handled by FLB and layers.

MozReview-Commit-ID: CUbeUabfC7K
2017-09-21 14:41:38 +08:00
Nicolas Silva
61546da339 Bug 1393031 - Remove unused nsTArray<WebRenderParentCommand>& parameter all over the place. r=jrmuizel 2017-09-20 13:36:53 +02:00
Sebastian Hengst
d27b05e04e Backed out changeset f34a52244cf9 (bug 1393031) 2017-09-14 23:17:35 +02:00
Nicolas Silva
2d3eb6cef7 Bug 1393031 - Remove unused nsTArray<WebRenderParentCommand>& parameter all over the place. r=jrmuizel 2017-09-14 20:21:54 +02:00
Nicolas Silva
59e80c8f7e Bug 1393031 - Use shared memory to pass resource update data. r=jrmuizel 2017-09-14 18:48:55 +02:00
Miko Mynttinen
351756e478 Bug 1359584 - Part 3: Improve nsDisplayItem const correctness and fix surrounding whitespace r=mstange
MozReview-Commit-ID: 3GkWiu6C4Zo

--HG--
extra : rebase_source : 1423442cd723b8a052d183394dc5f5ef272a5272
2017-08-24 17:09:44 +02:00
Ethan Lin
87d42ae44a Bug 1393077 - Part1. Round the transformed rectangles and transformed points in StackingContextHelper. r=kats
MozReview-Commit-ID: Gk5z6BwsuTM

--HG--
extra : rebase_source : 36db102162518622f1da659ff83fb71fe4d9eccf
2017-08-31 17:59:41 +08:00
Kevin Chen
49e4dfee9c Bug 1392470 - Add wr support for nsDisplayButtonBoxShadowOuter; r=mattwoodrow
MozReview-Commit-ID: Az1w8HusRlX

--HG--
extra : rebase_source : 5c0e6c8eaf601e6996b31f28a2ab7ffbd1bc318a
2017-08-28 11:29:35 +08:00
Nicolas Silva
a9bf06994d Bug 1377595 - Mark display items that should be painted on the content side. r=jnicol 2017-07-20 11:34:15 +02:00
Sylvestre Ledru
4e9cf83ee8 Bug 1378712 - Remove all trailing whitespaces r=Ehsan
MozReview-Commit-ID: Kdz2xtTF9EG

--HG--
extra : rebase_source : 7235b3802f25bab29a8c6ba40a181a722f3df0ce
2017-07-06 14:00:35 +02:00
Ethan Lin
17960f3f3e Bug 1372118 - Part2. Use new interface of CreateWebRenderCommands for non-image display items. r=jrmuizel, r=kats
MozReview-Commit-ID: BcmRjQhDEyf
2017-06-30 17:23:20 -07:00
Alexis Beingessner
adb013669b Bug 1088760 - Remove nsRenderingContext, replacing all of its uses with gfxContext. r=jwatt,jrmuizel
MozReview-Commit-ID: K1WUIOnvazF
2017-06-13 11:00:10 -04:00
Sebastian Hengst
f3bf820bfd Backed out changeset 3d1ce85e6348 (bug 1088760) for bustage, at least on Android at layout/generic/nsPluginFrame.cpp:1612. r=backout 2017-06-13 00:30:03 +02:00
Alexis Beingessner
c75211cb95 Bug 1088760 - Remove nsRenderingContext, replacing all of its uses with gfxContext. r=jwatt,jrmuizel
MozReview-Commit-ID: K1WUIOnvazF
2017-06-12 17:32:48 -04:00
Mats Palmgren
297b9d70e1 Bug 1365614 part 3 - Backout bug 1333482 part 1-9. Removes support for [-webkit-]appearance for now b/c web compat issues. r=bz
MozReview-Commit-ID: IbwWM0FL6HF

--HG--
extra : source : bbb688fe1ba3f5201a190c6e25b693ef7272ea2d
2017-05-21 17:15:00 +08:00
Carsten "Tomcat" Book
00d4ea331d Backed out changeset bbb688fe1ba3 (bug 1365614) 2017-05-22 15:45:31 +02:00
Mats Palmgren
e706869580 Bug 1365614 part 3 - Backout bug 1333482 part 1-9. Removes support for [-webkit-]appearance for now b/c web compat issues. r=bz 2017-05-21 17:15:00 +08:00
Kartikaya Gupta
0ec3e2d4dd Bug 1360246 - Propagate the StackingContextHelper to the rest of the displaylist-building code. r=nical
This propagates the StackingContextHelper to the rest of the code that
builds WR display items, because we will need it in future patches to
stop using RelativeToParent.

MozReview-Commit-ID: 3PlQrJRhH36
2017-05-03 08:48:08 -04:00
Kartikaya Gupta
9c0fee2d43 Bug 1360246 - Propagate the StackingContextHelper through CreateWebRenderCommands. r=nical
This is needed for the next patch, because the bullet frame WR rendering
code will need a StackingContextHelper to pass to the PushGlyphs call.
It also helps with some of the later patches in this series, when we get
rid of the RelativeToParent calls.

MozReview-Commit-ID: Is0aciHhy2N
2017-05-03 08:48:07 -04:00
Ethan Lin
e7c48eaf73 Bug 1357003 - Keep original layer state for basic layer manager when enabling advanced layer. r=mattwoodrow
--HG--
extra : rebase_source : 75540e18973d788e4e076aa3bdfa8a26036b2269
2017-04-21 23:11:38 +08:00
Ethan Lin
44273be6f1 Bug 1355417 - Enable "layers.advanced.button-foreground-layers" by default. r=mchang 2017-04-12 16:47:21 +08:00
Mason Chang
3b2070933d Bug 1350182 - Enable button border display items by default. r=ethlin 2017-03-27 13:09:55 -07:00
Mats Palmgren
79cff05243 Bug 1333482 part 2 - [css-ui] Change all consumers of StyleDisplay::mAppearance to use the accessor UsedAppearance() instead, and make mAppearance/mMozAppearance private. r=dholbert
MozReview-Commit-ID: 8JwLsY1CLDJ
2017-03-23 22:11:18 -07:00
Mason Chang
516a3654f4 Bug 1346451 - Delete WebRenderBorderLayer. r=ethlin 2017-03-11 10:04:26 -08:00
Ethan Lin
8b0fa844a8 Bug 1346110 - Use BorderRenderer to generate wr commands for nsDisplayButtonBorder. r=mchang
---
 layout/forms/nsButtonFrameRenderer.cpp | 37 +---------------------------------
 1 file changed, 1 insertion(+), 36 deletions(-)
2017-03-10 12:45:20 -08:00
Ethan Lin
1928c02454 Bug 1344622 - Part2. Add webrender support for nsDisplayButtonForeground. r=mattwoodrow 2017-03-09 16:58:39 +08:00
Mason Chang
2289ed06ba Bug 1343979 - Add webrender support for ButtonBorderBackground. r=ethlin 2017-03-08 08:31:46 -08:00
Thomas Wisniewski
4c82121568 Bug 140562 - Part 2: Remove the 2px extra padding on buttons for a prospective -moz-focus-inner ring, and just size that ring the same as the content frame (inflated by its CSS padding). r=dbaron 2016-12-02 01:11:48 -05:00
Thomas Wisniewski
d48094301d Bug 140562 - Part 1: Remove unused moz-focus-outer code for buttons. r=dbaron 2016-10-21 12:19:03 -04:00
Daniel Holbert
4c16d721f5 Bug 1272983 part 2: Use more forgiving margin/padding getters in nsButtonFrameRenderer, for better behavior when percent or auto values are encountered. r=dbaron
MozReview-Commit-ID: 4vIehNg2vND
2016-05-20 15:05:33 -07:00
Bobby Holley
60bd9ae61b Bug 1269901 - Remove mCachedMargin. r=dbaron 2016-05-04 16:56:17 -07:00
Bobby Holley
f2c9cdf0d8 Bug 1269901 - Remove mCachedPadding. r=dbaron 2016-05-04 16:56:17 -07:00
Markus Stange
cd46c2a7e9 Bug 1227327 - Use regular background image display items for painting button backgrounds. r=mattwoodrow
This has multiple benefits:
 - It makes DLBI detection of background-position changes work for buttons.
 - It makes background-attachment: fixed work for button backgrounds.
 - It allows the willPaintBorder optimization to be used for button background
   drawing, which reduces the background clip to not overlap with opaque borders.

The willPaintBorder optimization requires a change to the reftest 611574-2.html.
This reftest compares backgrounds to inset box shadows. Box shadows those don't
have a willPaintBorder optimization, so we'd get different results due to the
borders - inset box shadows will bleed through the rounded corner anti-aliasing
of the border, backgrounds won't any more. So we just turn off button borders
and cover the outer edges of the borders with an outline in that reftest.

MozReview-Commit-ID: Lvx2p5szjw7
***
Cover the antialiasing in 611574-2.html with a black outline.

MozReview-Commit-ID: IHC3B7Eq72j

--HG--
extra : rebase_source : 71ae376f482d14e55820879f28b37056e1b857bf
2016-05-04 14:12:23 -04:00
Phil Ringnalda
f74761a568 Back out 6 changesets (bug 1227327) for Android reftest failures in 942672-1.html, background-position-2b.html and background-position-2c.html
CLOSED TREE

Backed out changeset c9b0ba301426 (bug 1227327)
Backed out changeset c857ad1fa01c (bug 1227327)
Backed out changeset 4ba58cd94310 (bug 1227327)
Backed out changeset 30e394faeb23 (bug 1227327)
Backed out changeset ce7fd04cc749 (bug 1227327)
Backed out changeset e0fe45294034 (bug 1227327)
2016-05-03 21:49:07 -07:00
Markus Stange
bb440eec66 Bug 1227327 - Use regular background image display items for painting button backgrounds. r=mattwoodrow
This has multiple benefits:
 - It makes DLBI detection of background-position changes work for buttons.
 - It makes background-attachment: fixed work for button backgrounds.
 - It allows the willPaintBorder optimization to be used for button background
   drawing, which reduces the background clip to not overlap with opaque borders.

The willPaintBorder optimization requires a change to the reftest 611574-2.html.
This reftest compares backgrounds to inset box shadows. Box shadows those don't
have a willPaintBorder optimization, so we'd get different results due to the
borders - inset box shadows will bleed through the rounded corner anti-aliasing
of the border, backgrounds won't any more. So we just turn off button borders
and cover the outer edges of the borders with an outline in that reftest.

MozReview-Commit-ID: Lvx2p5szjw7
***
Cover the antialiasing in 611574-2.html with a black outline.

MozReview-Commit-ID: IHC3B7Eq72j

--HG--
extra : rebase_source : fbd7d3152b819232adfc97dd9df1481a582925c5
2016-04-29 13:16:23 -04:00
Phil Ringnalda
5387bf0160 Back out 6 changesets (bug 1227327) for failures in est_fixed_bg_scrolling_repaints.html
Backed out changeset 529ff32ced48 (bug 1227327)
Backed out changeset b726c30c4290 (bug 1227327)
Backed out changeset 5453b1ce4e85 (bug 1227327)
Backed out changeset 462dc0904d05 (bug 1227327)
Backed out changeset 1515512d3731 (bug 1227327)
Backed out changeset 2276fc059bf7 (bug 1227327)
2016-05-02 22:23:10 -07:00