Commit graph

1 commit

Author SHA1 Message Date
Steve Melia
8873d2d5e0 servo: Merge #12703 - Fix Issue 12343: Add pref-gated methods and test for activatable element (from sjmelia:12343_test_activation); r=Manishearth
<!-- Please describe your changes on the following line: -->
Add methods to activatable elements; gated by a preference, for use in servo-specific WPT tests.

I cargo-culted over the "redundant check" from #12322, I don't really understand the possible exploit.

Obvious flaw is the copypasta for each element. I understand that the webidl codegen will produce a trait for ActivatableElement, but I can't see how I can provide a default implementation for this? I guess otherwise could be an improvement to have each element just delegate to an Enter.../Exit... method on the Activatable trait?

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #12343 (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

…states

Source-Repo: https://github.com/servo/servo
Source-Revision: 2fb4dd9ec3bb4be7d5ea8404964536c89fc8732b
2016-09-16 20:34:25 -05:00