nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity
584407 commits 1 branch 98 tags 6.4 GiB
Commit graph

58 commits

Author SHA1 Message Date
Paolo Amadini
c7bdffd735 Bug 1437512 - Part 2 - Remove the "panelmultiview" binding. r=Gijs 
MozReview-Commit-ID: H9R7ahkCr2U

--HG--
extra : rebase_source : d6403d026b4539acc71325c600ee9ff3be667591
 2018-02-25 18:43:55 +00:00
Paolo Amadini
d59df3cdd5 Bug 1434883 - Part 2 - Use an asynchronous API to open PanelMultiView panels. r=Gijs 
MozReview-Commit-ID: 3VzoxJ3Ociy

--HG--
extra : source : 22c83b1d417d7c7bd21a71109f4800f5d37bbb77
extra : intermediate-source : 6de7133c267288a468804f67f91df68b10b9793e
 2018-02-06 09:02:27 +00:00
Cosmin Sabou
793dad7903 Backed out 3 changesets (bug 1434883) for frequent leaks in AbstractThread, AnimationTimeline, Annotators, Array, AsyncFreeSnowWhite, ... on a CLOSED TREE 
Backed out changeset c8115e90ffa8 (bug 1434883)
Backed out changeset 22c83b1d417d (bug 1434883)
Backed out changeset 085796417462 (bug 1434883)
 2018-02-06 16:30:56 +02:00
Paolo Amadini
5ac445ad8f Bug 1434883 - Part 2 - Use an asynchronous API to open PanelMultiView panels. r=Gijs 
MozReview-Commit-ID: 3VzoxJ3Ociy

--HG--
extra : rebase_source : 7302ce6eed5364c80b7dfe9409e5c9d28e030e38
 2018-02-06 09:02:27 +00:00
Paolo Amadini
26c7b11e09 Bug 1432015 - Part 3 - Ensure that views passed to showSubView are added to the list of known views without having to reset the internal _panelViews variable. r=Gijs 
MozReview-Commit-ID: Hld45ghdduv

--HG--
extra : rebase_source : e01d8facd56a4be21818879b21de75802d723db3
 2018-01-17 15:04:18 +00:00
Paolo Amadini
11d708f26b Bug 1432015 - Part 2 - Remove the setMainView methods. r=Gijs 
The setMainView method of PanelMultiView controls the "mainview" attribute, which is already set or removed later in the showSubView method. When called at construction time, it changes the mainViewId if there is at least one child in the "panelmultiview" element and the original mainViewId does not already reference the first child. This would be incorrect, but in practice it never happens for either ephemeral or static panels, and can be avoided for the throw-away activated page action panel.

The setMainView method of PanelUI is never called, and this makes the corresponding PanelMultiView method removable.

MozReview-Commit-ID: 5bNidHfKFTA

--HG--
extra : rebase_source : b527827d30d682d183981347c2caf3a8a5d81355
 2018-01-21 15:59:41 +00:00
Paolo Amadini
1aee9c11f9 Bug 1432015 - Part 1 - Fix anchor handling for the action feedback panel. r=Gijs 
Commands started from an activated action panel should not be anchored to the main button, and regression tests should simulate the case where both the main action panel and the individual action button are visible and the action is invoked from the main action panel.

MozReview-Commit-ID: Eg1wP2rRe2d

--HG--
extra : rebase_source : 6caac7368c85195c91066c6a61d3043a9fbc770f
 2018-01-21 17:01:59 +00:00
Paolo Amadini
b12ae1861e Bug 1417042 - Remove the "panelview" binding. r=Gijs 
MozReview-Commit-ID: 26uQb3pteQd

--HG--
extra : rebase_source : 93263ff4f1e0d38292dbfef3f7385ddd881b25ef
extra : source : bce38a7817ee39ccd38f57f73f5acf81a41e1f69
 2017-12-06 10:37:25 +00:00
Edouard Oger
80589e1731 Bug 1417597 - Show a different feedback message in send tab when we're offline. r=jaws 
MozReview-Commit-ID: Emsx0LwFAE1

--HG--
extra : rebase_source : a10a5795f0c4c140a5d9eea5c72821be4931bd9b
 2017-11-16 16:11:46 -05:00
Paolo Amadini
fc23659e93 Bug 1414244 - Part 6 - Fold the "photonpanelmultiview" binding into "panelmultiview". r=Gijs 
MozReview-Commit-ID: IjvSZZUHUMt

--HG--
extra : rebase_source : a94e212e8af35b77806d1d62e020a511ab62e224
 2017-11-21 14:21:32 +00:00
Drew Willcoxon
5f90902bda Bug 1417272 - The "Send Tab to Device" page action can be disabled in the page action menu but enabled in the urlbar. r=Gijs 
MozReview-Commit-ID: BZ4CAqG0kkH

--HG--
extra : rebase_source : 3aaa7601b9f3f11e84d65788378c0fdb1dac9292
 2017-11-15 11:25:45 -08:00
Drew Willcoxon
65176851c3 Bug 1417036 - "Save to Pocket" drop down menu glitches. r=Gijs 
MozReview-Commit-ID: 1JPOmQNLn26

--HG--
extra : rebase_source : ec596c222caa916b02897cbbd36f4a9ae614e518
 2017-11-15 10:44:47 -08:00
Edouard Oger
0648f86b7f Bug 1304898 - Include why in sync ping. r=tcsc 
MozReview-Commit-ID: G9WnHhuWD7Z

--HG--
extra : rebase_source : 27cb3c2bdf7432e0db1e6a8431d348be50c2afd8
 2017-11-15 17:10:45 -05:00
Drew Willcoxon
46c5139ac2 Bug 1413574 - Hide disabled page actions and offer a "Manage Extension" command for actions in extensions. r=Gijs 
MozReview-Commit-ID: HJpu9Jfi2bB

--HG--
extra : rebase_source : ee219138b8df1744c223d81281d9525c3d7b7227
 2017-11-10 11:06:02 -05:00
Drew Willcoxon
13280ee095 Bug 1412170 - Integrate WebExtension page action context menus with the Photon page action context menu: Photon page action changes. r=jaws 
MozReview-Commit-ID: BOEhQEJbUNO

--HG--
extra : rebase_source : ff88d19669530269486d3441fe9cbebe6c73090b
 2017-10-30 17:47:54 -04:00
Phil Ringnalda
c21a471320 Backed out 2 changesets (bug 1412170) for eslint bustage 
Backed out changeset a9a646fe54ec (bug 1412170)
Backed out changeset 8b46ed411edf (bug 1412170)

MozReview-Commit-ID: Et3MnX3ieBe
 2017-10-30 14:21:45 -07:00
Drew Willcoxon
cdfcd527d8 Bug 1412170 - Integrate WebExtension page action context menus with the Photon page action context menu: Photon page action changes. r=jaws 
MozReview-Commit-ID: BOEhQEJbUNO

--HG--
extra : rebase_source : 4cfa98799c5b1a673efe52c37e595c88cbd71902
 2017-10-30 16:53:21 -04:00
Drew Willcoxon
6d7492ef9b Bug 1395387 - Reconcile WebExtension page actions and Photon page actions: Photon page actions changes. r=Gijs 
MozReview-Commit-ID: 5NOc9N2idRE

--HG--
extra : rebase_source : 17e91f9b85bfb49d6fdf29c25bfba7a7c4f86452
 2017-10-27 17:39:38 -04:00
Mark Banner
4de6bf22b1 Bug 1411368 - Automatically fix no-multi-spaces issues raised when using ESLint 4. r=mossop 
MozReview-Commit-ID: H5YVp3rnzGo

--HG--
extra : rebase_source : 5b45b6c0df834131812d094e975047eaad374e06
 2017-10-26 11:47:01 +01:00
Jared Wein
2ad00e3d21 Bug 1408135 - Copy URL confirmation message should appear where user selects it. r=mikedeboer 
MozReview-Commit-ID: 99hEGe7Dtgf

--HG--
extra : rebase_source : c84918920ca2791940d4daeec12cf86c2c04c1c2
 2017-10-19 11:58:53 -04:00
Henrik Adolfsson
9fec5a40e2 Bug 1392536 - Add last sync date as tooltip to send to device tab 
MozReview-Commit-ID: BsCoBJXm10B
 2017-10-10 13:50:28 -04:00
Drew Willcoxon
9100f68edc Bug 1387141 - Pocket button does not stay red after URL pocketed and animation has finished. r=Gijs 
MozReview-Commit-ID: KQVOUJUOfrx

--HG--
extra : rebase_source : 07e77c7835286c78789fc6c6ff553ae475f26e5e
 2017-10-05 13:03:44 -07:00
Drew Willcoxon
91dcf7e9cf Bug 1385882 - Intermittent browser/base/content/test/urlbar/browser_page_action_menu.js | Test timed out. r=Gijs 
MozReview-Commit-ID: H6BtvGNtMmQ

--HG--
extra : rebase_source : ac0bc23ebe47d9b5669036a56e0b6e39e7994ff7
 2017-10-05 12:45:15 -07:00
Gijs Kruitbosch
8dea08a240 Bug 1389721 - fix page action menu to deal with not being passed an event, so the 'save link to pocket' context menu works, r=jaws 
This also removes the now-obsolete onBeforeCommand method from the pocket code.

MozReview-Commit-ID: EjrMoAIv3xw

--HG--
extra : rebase_source : 0921854ff6d1110a35bb225d946cea3caa2ae3c1
 2017-10-02 20:34:01 +01:00
Gijs Kruitbosch
c6ffe22372 Bug 1393843 - add telemetry for page action items and the context menu that enables/disables them, data-review=rweiss, r=adw,rweiss+418169 
MozReview-Commit-ID: E52TGDLgjCC

--HG--
extra : rebase_source : 9a370490ec927bde37468295c1fb4415aa6e0212
 2017-09-20 17:32:11 +01:00
Drew Willcoxon
2fa9f06a0b Bug 1402721 - Add/edit bookmark panel should open anchored on the page action (ellipsis) button instead of on the identity block (left side of the address bar) when the bookmarks star action is not pinned/visible. r=Gijs 
MozReview-Commit-ID: JMviXx5ov7F

--HG--
extra : rebase_source : b205b0ae9d0e4eb7ed34b912f62e28fb2e2f9467
 2017-09-25 13:30:08 -07:00
Gijs Kruitbosch
49a325326c Bug 1397790 - add 'open' active state to urlbar buttons, use a more distinct background colour for it, r=abenson+572682,adw 
MozReview-Commit-ID: 7QrhAB79yNw

--HG--
extra : rebase_source : 90c3715259271bf9cb34b635ca8348acd020c51c
 2017-09-19 15:13:25 +01:00
Zibi Braniecki
70e0d2b8e8 Bug 1398390 - Only react to mousedown if it is a left-click. r=Gijs 
MozReview-Commit-ID: Ie2Xgasg2eN

--HG--
extra : rebase_source : 5e58c418f91a1802328c4128dffd2c1ab9aa067f
 2017-09-09 22:17:19 -07:00
Sebastian Hengst
a4b102b6d9 Backed out changeset 1a8147d55b02 (bug 1398390) for failing browser-chrome's browser_overflow_anchor.js at least on macOS and Windows. r=backout 2017-09-10 09:37:30 +02:00
Zibi Braniecki
923420c64a Bug 1398390 - Only react to mousedown if it is a left-click. r=Gijs 
MozReview-Commit-ID: Ie2Xgasg2eN

--HG--
extra : rebase_source : 9aeed150b6106210bbe06e8a98ae602e5471851b
 2017-09-09 22:17:19 -07:00
Drew Willcoxon
67fd8c9838 Bug 1397501 - Page actions added to the urlbar should always come before the bookmark star. r=Gijs 
MozReview-Commit-ID: 6pVlr9d0crn

--HG--
extra : rebase_source : 0f83a8ea8ada71bc6ce88859d09fc93460abafa3
 2017-09-07 16:44:34 -07:00
Drew Willcoxon
7fb6175d88 Bug 1396053 - Page action urlbar button ordering can get messed up for new windows. r=Gijs 
MozReview-Commit-ID: 1KwrS6tsnhO

--HG--
extra : rebase_source : 05f4a7e485757ca72fb56a1116e271ad3d6241bf
 2017-09-04 23:58:27 -07:00
Drew Willcoxon
e8a1dadbb5 Bug 1395410 - Page action notifications should be anchored on relevant urlbar button, not main button, if present. r=jaws 
MozReview-Commit-ID: iFM0cR7zFi

--HG--
extra : rebase_source : b8d30a126227a190723ff77021ae8eea3c2c22e3
 2017-08-31 15:48:19 -07:00
Drew Willcoxon
d19cdf7b3d Bug 1395154 - If Send Page to Device pageAction is Pinned, it should dismiss when a user sends a tab. r=jaws 
MozReview-Commit-ID: HkuzOOp8PDP

--HG--
extra : rebase_source : 48f4d06016129b21c0731b9cd751c57f38030161
 2017-08-31 15:27:22 -07:00
Drew Willcoxon
ea66c1176b Bug 1395398 - Send to Device notification shouldn't appear after clicking "Sign in" and other non-device menu items. r=jaws 
MozReview-Commit-ID: Gm35IfZCJPQ

--HG--
extra : rebase_source : c321d66c4cd903ff094f6bde3ad48535d33bf144
 2017-08-31 09:38:37 -07:00
Drew Willcoxon
1f60dd6d1c Bug 1395178 - The new buttons that can be added to the toolbar don't announce themselves to screen readers as buttons. r=jaws 
MozReview-Commit-ID: AvQD9Z9ySfu

--HG--
extra : rebase_source : 27b79ef79f6c2ecad8a8258245123b9dad94e7c5
 2017-08-30 13:29:54 -07:00
Jared Wein
7764962be9 Bug 1395194 - Copy URL confirmation should fade out at timeout. r=adw 
MozReview-Commit-ID: DTrzSOaft3N

--HG--
extra : rebase_source : 17ccd2d6a2f6861b6554be77b381aab60eabcfa0
 2017-08-30 16:23:05 -04:00
Jared Wein
b67ac2b7fd Bug 1387042 - Add a toast notification that will be shown when the Copy Link or Send to Device page actions are used. r=adw,sfoster 
MozReview-Commit-ID: CZZnLz84T4h

--HG--
extra : rebase_source : bee7806ee6886dbbeefc7bc7ed39cc075fca1590
 2017-08-24 16:44:11 -04:00
Drew Willcoxon
73ad0ddaf3 Bug 1388835 - Hide page action urlbar buttons on about pages (about:preferences, etc.). r=Gijs 
MozReview-Commit-ID: 9lid8VpPkJE

--HG--
extra : rebase_source : b57a37788f20345750d8daa5f73011bf6fac1ef8
 2017-08-26 12:47:33 -07:00
Gijs Kruitbosch
0a10556def Bug 1391705 - don't show context menu except on toolbarbuttons on the main view, r=adw 
MozReview-Commit-ID: GkGXAIrP15u

--HG--
extra : rebase_source : f089a365490238992f22db869cb19f3ccca2587c
 2017-08-23 13:29:47 +01:00
Drew Willcoxon
ccec56a9ab Bug 1391759 - [Photon] Page action temp panel (e.g., the Pocket panel) should have rounded corners (not square ones) on OS X. r=Gijs 
MozReview-Commit-ID: 6EdRRjsQLga

--HG--
extra : rebase_source : a6e4d080b0776e8b4c33d692ba9c3d99e3fc1c79
 2017-08-18 12:48:01 -07:00
Drew Willcoxon
e3ddbef6f2 Bug 1391082 - Page action panel ordering can get messed up. r=Gijs 
MozReview-Commit-ID: 3hQLTLF3RU8

--HG--
extra : rebase_source : 7ed94560c20882ac85114df80d50221eb0e2b172
 2017-08-17 16:40:35 -07:00
Gijs Kruitbosch
f66567c39c Bug 1366327 - deal with about:reader, IDNA and non-exposable URIs better for copy/email link, r=adw 
MozReview-Commit-ID: AnZa3mq2zMY

--HG--
extra : rebase_source : b35026f864c6d45856fb02b90e91b3a06b1a0ec0
 2017-08-17 13:11:06 +01:00
Drew Willcoxon
3c27aee62b Bug 1385418 - Remove disabled pocket code for the toolbar button now that it's been replaced by the item in the page action panel. r=Gijs 
MozReview-Commit-ID: 1wANxaD3QaV

--HG--
extra : rebase_source : f87650ab8c09f7a313cda9b7ec73ee1e20d6fe34
 2017-08-16 10:13:15 -07:00
Dão Gottwald
e2259fbc44 Bug 1389740 - Rename urlbar-icons to page-action-buttons. r=gijs 
MozReview-Commit-ID: 980Rvv8mxtU
 2017-08-14 16:45:17 +02:00
Sebastian Hengst
57f655f77a Backed out changeset c73631b194bb (bug 1389740) for failing Firefox-UI's test_windows.py and test_about_private_browsing.py. r=backout 2017-08-12 18:42:57 +02:00
Dão Gottwald
ad2ba7b0b1 Bug 1389740 - Consolidate URL bar history dropmarker styling. r=Gijs 
The dropmarker gets the urlbar-icon class for consistency with the other URL bar icons. On this occasion, I increased the urlbar-icon padding and removed the margin to match the photon spec. Also added a rudimentary hover effect.

#urlbar-icons is renamed to #page-action-buttons to better reflect its meaning, and because .urlbar-icon is now used outside of this container.

#urlbar-wrapper wrapper isn't needed anymore -- we can just set the switchingtabs attribute directly on #urlbar.

MozReview-Commit-ID: EiuUW71IKgU

--HG--
extra : rebase_source : dcc7753e92073e06278d714a0b5b976d073e75c8
 2017-08-12 17:49:35 +02:00
Jared Wein
baaaed0eec Bug 1387077 - Reimplement Pocket animation in the Page Action area. r=adw 
MozReview-Commit-ID: 5pJ96un8W5t

--HG--
extra : rebase_source : e862c01c1d71165ccd5d0932299c7f1fbdebe659
 2017-08-08 11:56:49 -04:00
Wes Kocher
3c7cc8f012 Backed out changeset d4cc2f1e5c48 (bug 1387077) for windows debug crashtest failures a=backout 
MozReview-Commit-ID: kEMoucDCJY
 2017-08-10 15:46:38 -07:00
Jared Wein
8880224f6b Bug 1387077 - Reimplement Pocket animation in the Page Action area. r=adw 
MozReview-Commit-ID: 5pJ96un8W5t

--HG--
extra : rebase_source : bef396788013f8ed60d72b01bf59e34e01d36209
 2017-08-08 11:56:49 -04:00