When a theme doesn't specify popup colors, it makes sense to follow the
system-preferred color scheme. Refactor theming attributes so that we
can distinguish this. Instead of a single [lwt-popup-brighttext], we get
lwt-popup="dark"/"light", and handle it appropriately.
Same for the other relevant attributes.
Refactor sidebar theming (which already did this tri-state thing via
lwt-sidebar and lwt-sidebar-brighttext) to do the same using a single
lwt-sidebar attribute, and update the docs.
Differential Revision: https://phabricator.services.mozilla.com/D190919
We have less constraints on the minimum supported clang-cl version, and
it would unlock C++17 inline variables (which had a bug on Windows
targets in clang up-to 8.x).
Differential Revision: https://phabricator.services.mozilla.com/D179037
This patch removes the vast majority of OS.File and support code. A few things remain:
- The nsIOSFileConstantsService still exists, but the path related constants
(OS.Constants.Path.*) are no longer added to the OS object. The plan is to
replace this with a proper service e.g. Services.osConstants or similar) in
bug 1786885.
- There is still support for OS.File errors in ErrorSanitizer, which will be
removed in bug 1775167.
- The OS.File to IOUtils migration guide will be rewritten as general IOUtils
documentation in bug 1830097.
- dom/base/Document.cpp has a workaround for not loading osfile.jsm at startup,
which may want to be reconsidered in bug 1830100.
So long, and thanks for all the I/O.
Differential Revision: https://phabricator.services.mozilla.com/D176543
This patch removes the vast majority of OS.File and support code. A few things remain:
- The nsIOSFileConstantsService still exists, but the path related constants
(OS.Constants.Path.*) are no longer added to the OS object. The plan is to
replace this with a proper service e.g. Services.osConstants or similar) in
bug 1786885.
- There is still support for OS.File errors in ErrorSanitizer, which will be
removed in bug 1775167.
- The OS.File to IOUtils migration guide will be rewritten as general IOUtils
documentation in bug 1830097.
- dom/base/Document.cpp has a workaround for not loading osfile.jsm at startup,
which may want to be reconsidered in bug 1830100.
So long, and thanks for all the I/O.
Differential Revision: https://phabricator.services.mozilla.com/D176543
This patch removes the vast majority of OS.File and support code. A few things remain:
- The nsIOSFileConstantsService still exists, but the path related constants
(OS.Constants.Path.*) are no longer added to the OS object. The plan is to
replace this with a proper service e.g. Services.osConstants or similar) in
bug 1786885.
- There is still support for OS.File errors in ErrorSanitizer, which will be
removed in bug 1775167.
- The OS.File to IOUtils migration guide will be rewritten as general IOUtils
documentation in bug 1830097.
- dom/base/Document.cpp has a workaround for not loading osfile.jsm at startup,
which may want to be reconsidered in bug 1830100.
So long, and thanks for all the I/O.
Differential Revision: https://phabricator.services.mozilla.com/D176543
This patch removes the vast majority of OS.File and support code. A few things remain:
- The nsIOSFileConstantsService still exists, but the path related constants
(OS.Constants.Path.*) are no longer added to the OS object. The plan is to
replace this with a proper service e.g. Services.osConstants or similar) in
bug 1786885.
- There is still support for OS.File errors in ErrorSanitizer, which will be
removed in bug 1775167.
- The OS.File to IOUtils migration guide will be rewritten as general IOUtils
documentation in bug 1830097.
- dom/base/Document.cpp has a workaround for not loading osfile.jsm at startup,
which may want to be reconsidered in bug 1830100.
So long, and thanks for all the I/O.
Differential Revision: https://phabricator.services.mozilla.com/D176543
This is enabling the PLE and PLC rules across a much larger swatch of the code
base. The PLR and PLW are additionally enabled at the warning level (introduces
~2500 new warnings).
To avoid extraneous changes in people's patches, rules at the warning level are
excluded from --fix.
Differential Revision: https://phabricator.services.mozilla.com/D172358
Ruff is a very fast linter implemented in Rust and it can act as a drop-in
replacement for flake8. When running the same set of rules across all files
in mozilla-central (without mozlint), flake8 takes 900 seconds whereas ruff
takes 0.9 seconds.
Ruff also implements rules from other popular Python linters such as pylint,
isort and pyupgrade. There are even plans to implement feature parity with
black in the future. Ultimately, it can become our one stop shop for all Python
linting and formatting.
This stack will swap out all our Python lint tools for ruff (excluding black
for now).
Differential Revision: https://phabricator.services.mozilla.com/D172313
