Commit graph

482 commits

Author SHA1 Message Date
Johann Hofmann
a84fe102d8 Bug 1377802 - Check if bookmarking UI is visible before anchoring bookmarking popup. r=mak
This also avoids flushing when bounds checking the identity popup for visibility.

MozReview-Commit-ID: EBUR7RIB0w6

--HG--
extra : rebase_source : 496811988d26be3065888845c699663f0cc20d52
2017-07-11 23:17:07 +02:00
Marco Bonardo
bfc44708bc Bug 1371677 - Delay the database connection in the history service as far as possible. r=adw
Makes initing Places services cheaper, by delaying the connection creation to the first time
it's actually needed.
Same way, delays reading the bookmark roots at the first time they are requested.
Deprecates the concept of lazy observers, since they are no more needed, we can just use addObserver.
Simplifies the startup path: always sends "places-init-complete" (both as a category and a topic) when
the connection starts and adds a "locked" database state when we can't get a working connection.
Makes PlacesCategoriesStarter register for the new category, since it's cheaper than being a bookmarks
observer.
Fixes a couple race conditions in keywords and expiration due to new startup timings.
Removes a test in test_keywords.js that is no more easily feasible, since it'd requires a pre-build
places.sqlite that should be kept up-to-date at every version.

MozReview-Commit-ID: 6ccPUZ651m0

--HG--
extra : rebase_source : 07376076eb42c84caaedeffd75f133d83a6c3d70
2017-06-09 18:51:09 +02:00
Mike de Boer
702aa1332c Bug 1354159 - Part 3 - Add a Bookmarks button to the Library panel that shows a subview with a list of most recent bookmarks. r=Gijs,mak
This patch changes the Recent Bookmarks flow in browser-places.js to use the new
PlacesPanelview to provide a rich view that support drag and drop and context
actions.
A new button 'Search Bookmarks' was added, which prefills the urlbar with '* ',
which is a shortcut for searching bookmarks using the Awesomebar.

MozReview-Commit-ID: 1XlO8HMKEJs

--HG--
extra : rebase_source : 59cdf8a24341eb5df55511c5be83ebee8787aad5
2017-06-29 17:57:25 -07:00
Mike de Boer
0da1ebf2ab Bug 1354159 - Part 1 - Remove the unneeded third 'view' argument from PlacesUIUtils.openNodeWithEvent(). r=mak
MozReview-Commit-ID: Jema2qMYEdX

--HG--
extra : rebase_source : 9cd5850e7c306ff62f9751ce419a278e8978b04e
2017-06-29 17:57:22 -07:00
Gijs Kruitbosch
dd070a9e91 Bug 1352120 - move the bookmarks star into the url bar, r=mak
MozReview-Commit-ID: Ka5Wn2hrb1P

--HG--
extra : rebase_source : e22d25295066386c4becc1a430b78aaa9c40ae4f
2017-06-23 17:35:59 +01:00
Rajesh Kathiriya
fafb858b26 Bug 1370225 - Enabled the ESLint comma-style rule across mozilla-central. r=standard8
MozReview-Commit-ID: 9OhLgBpYS4L

--HG--
extra : rebase_source : 5155e715934e7acd2ffadb4856eb91f481cbf56c
2017-06-15 18:24:17 +01:00
Marco Bonardo
96fbeb3306 Bug 625778 - Contextual commands on the main menubar bookmarks menu don't work after a customization. r=adw
MozReview-Commit-ID: 8Atiql9Zplv

--HG--
extra : rebase_source : 104f490a478742971fb333e2229bf470cc42b1ef
2017-06-09 16:15:28 +02:00
Drew Willcoxon
83efe33bc6 Bug 1363183 - Add a "bookmark" item to the page action menu. r=mikedeboer
MozReview-Commit-ID: 9RR4U3X3gIT

--HG--
extra : rebase_source : b2307c2c64a2913fd2c0fc3d2225164fcd6d0cba
2017-05-25 16:19:02 -07:00
milindl
39f69b4ab0 Bug 1350377 - Remove getPlacesInfo and change associated files and tests, r=mak
Files which make use of `getPlacesInfo` have been replaced with `History.fetch`.
The code for `GetPlacesInfo` has been deleted from the cpp and idl files.
The test for `getPlacesInfo` has been suitably rewritten and moved alongside the
other History.jsm tests.

There were 2 places where the fact that `getPlacesInfo` takes an array as opposed
to a single uri mattered, in `test_getPlacesInfo.js` and `test_refresh_firefox.py`.

MozReview-Commit-ID: KQSMHCvvlrQ

--HG--
extra : rebase_source : 78a4381587e040bec8ba5e51d1c5b5a67e70897e
2017-05-17 16:02:21 +05:30
Marco Bonardo
bac23ee9cb Bug 1364488 - Allow fetch to use a concurrent connection. r=standard8
MozReview-Commit-ID: 4L4PFtXsjsy

--HG--
extra : rebase_source : f12cbc4f9f6bb5cf9fc791c1c44978c98e3ca325
2017-05-17 15:51:02 +02:00
Marco Bonardo
c8f2a10f2c Bug 1364488 - Recover from a Talos regression due to recent changes to the Star button. r=standard8
The main reason for these changes is to avoid initializing the bookmarks service too early,
plus a lot of micro-optimizations to reduce the code-bloat compared to the previous bogus
(but slick) async getter.

MozReview-Commit-ID: Fy4fshsDaIw

--HG--
extra : rebase_source : 3ad245e932e718ee5ca1fa8da4df8a0f8efd3f0b
2017-05-15 19:32:47 +02:00
Florian Quèze
1d0e28a791 Bug 1353542 - script-generated patch to remove .bind(this) calls we no longer need now that generator functions have been replaced with async functions, r=Mossop. 2017-05-12 14:47:41 +02:00
Florian Quèze
5e3539e504 Bug 1353542 - massive script-generated patch converting Task.async and Task.spawn calls, and generators clearly identifiable as tasks, rs=Mossop. 2017-05-12 14:42:39 +02:00
Pauline
7a2cca54c5 Bug 1157709 - Removed all uses of PlacesUtils.asyncGetBookmarkIds. r=mak77
MozReview-Commit-ID: FPhhbbIxOwz
2017-05-11 14:23:03 +01:00
Nihanth Subramanya
a1b61bc267 Bug 1347543 - Use SVGs instead of PNGs for toolbar button icons. r=dao
MozReview-Commit-ID: EWgOI8x4Qdj

--HG--
extra : rebase_source : 1776100991adb88d6c42e6af74a1936211faf8a4
2017-04-28 21:47:07 +05:30
Carsten "Tomcat" Book
dab561c88c Backed out changeset 4d6cbe2ebbd1 (bug 1347543) for causing bc6 issues 2017-05-03 15:50:55 +02:00
Nihanth Subramanya
14e60e7e57 Bug 1347543 - Use SVGs instead of PNGs for toolbar button icons. r=dao
MozReview-Commit-ID: 27zDcyScFnj

--HG--
extra : rebase_source : 66c95a6c573eb224d993c9e64979ac6e59dbbab0
2017-04-28 21:47:07 +05:30
Wes Kocher
2e85784df7 Backed out changeset 0e3f9e184e6b (bug 1347543) for landing on the wrong tree a=backout
MozReview-Commit-ID: 33rhqi8g77s

--HG--
extra : rebase_source : a83a2ee1cdf5778fee3eeae289161600374b4c9a
2017-04-28 12:32:38 -07:00
Nihanth Subramanya
b884e0d04c Bug 1347543 - Use SVGs instead of PNGs for toolbar button icons. r=dao
MozReview-Commit-ID: AdW6POOBeeh

--HG--
extra : rebase_source : 627395018a62b88f1a91d772984e43d257cdd35c
2017-04-28 21:47:07 +05:30
Florian Queze
4b1556a5f2 Bug 1355056 - replace (function(args) { /* do stuff using this */ }).bind(this) with arrow functions, r=jaws. 2017-04-27 00:25:45 +02:00
Florian Queze
37ff4fc7cc Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst
a07223d699 Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
Florian Queze
95d4d20c17 Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Kirk Steuber
6d0283fc61 Bug 1349823 - Populate bookmark panel before showing it r=enndeakin+6102,mak
When panel behavior became asynchronous, |StarUI._doShowEditBookmarkPanel| needed to be changed to wait for the panel to finish opening before initializing it. Although the content of the panel can be changed successfully before the panel opens, the element focus at the end of initialization fails. This prevents the capturing of certain events, such as an Esc keypress (which should close the panel).

However, this introduced the problem where there is a short delay between when the bookmark panel opens and when the correct content is displayed in it. To fix this, the initialization function |gEditItemOverlay.initPanel| will now be called before the panel opens, but the element focus code will wait for the panel's popupshown event.

MozReview-Commit-ID: 6SrcCz963qW

--HG--
extra : rebase_source : c45f16913597b336dcae2717c0f902dbbe8025f2
2017-04-05 15:38:37 -07:00
Florian Quèze
9d62681259 Bug 1345253 - Use element.firstChild.remove() instead of element.removeChild(element.firstChild), r=jaws. 2017-03-08 10:17:52 +01:00
Jared Wein
3dd99bad30 Bug 1294799 - Disable the autoclosing of the bookmark popup if there is any interaction with it such as mousedown or keypress. r=mak
MozReview-Commit-ID: JRo5ZVu0uFD

--HG--
extra : rebase_source : ffb0d7a8323595fe61e85fee200a2aca5bc63310
2017-02-10 11:11:57 -05:00
Jared Wein
fdfcbce1e7 Bug 1335043 - Prevent the bookmark panel from closing automatically if the mouse is hovering over it. r=mak
MozReview-Commit-ID: 2jor6H2cQck

--HG--
extra : rebase_source : 970215308ca95d07c13179dcc5106e4e5eae14db
2017-01-30 10:34:53 -05:00
Thom Chiovoloni
c197835bcf Bug 1295237 - Add 'Mobile Bookmarks' root to the bookmark menus if we have it. r=markh
MozReview-Commit-ID: 3ybnskOID1O

--HG--
extra : rebase_source : 3faec9e53939626dc89c039706aaa2f003571d18
2017-01-17 13:15:49 -05:00
Ehsan Akhgari
b3e5ce4a2d Bug 1319908 - Load the menu icons for the bookmarks menu with the correct content type and principal on OSX; r=baku
This patch makes nsMenuItemIconX also participate in the setup
introduced in bug 1277803.
2017-01-20 10:55:23 -05:00
Masayuki Nakano
4515205f36 Bug 1331798 Bookmark panel for new bookmark shouldn't be closed automatically during composition and after text input without keyboard events nor composition events r=jaws
Bookmark panel for a new bookmark shouldn't be closed automatically during composition even if mouse cursor is moved outside the panel because user may click in IME's UI.

Additionally, editor might be modified without keyboard events nor composition events.  In such case, the bookmark panel shouldn't be closed automatically too.

MozReview-Commit-ID: 1FAUmkXjid

--HG--
extra : rebase_source : b4bc6eeeebfeeafe12d9cb16df7b3d31e60c5ae5
2017-01-19 15:04:56 +09:00
Jared Wein
feee0e79ef Bug 1327938 - Clear the existing timeout before creating a new one, as we should only have one autoclose timer running at a time. r=mak
MozReview-Commit-ID: 9HdSMGWRvb1

--HG--
extra : rebase_source : ab1aa61dd0eb9899baf3659841d8dc09be6f66b3
2017-01-18 11:17:10 -05:00
Jared Wein
43bac26d30 Bug 1331661 - Enable the 'quotes' rule for eslint and fix most of the errors with --fix. r=Gijs
MozReview-Commit-ID: 6tv0Z06CO4a

--HG--
extra : rebase_source : 014c0b04d8538dc5f15bc6dd4ed6bd220c55c5d4
2017-01-17 09:48:17 -06:00
Florian Quèze
85611a7b6d Bug 1331081 - script generated patch to omit addEventListener/removeEventListener's third parameter when it's false, r=jaws.
--HG--
extra : rebase_source : a22344ee1569f58f1f0a01017bfe0d46a6a14602
2017-01-17 11:50:25 +01:00
Florian Quèze
a03918c148 Bug 1330147 - automatic removal of the third boolean parameter in removeObserver calls, r=jaws. 2017-01-11 22:27:42 +01:00
Jared Wein
33317c9d1b Bug 1326712 - Allow hitting Enter on the Remove Bookmark button to remove the bookmark instead of performing the default action on the popup. r=mossop
MozReview-Commit-ID: AQ0Q4zb2g2Q

--HG--
extra : rebase_source : b44f6ab87fc0d264fb04f0de22cfba5023530e0d
2017-01-03 17:02:09 -05:00
Phil Ringnalda
cfa6520d74 Backed out changeset 83d895c1c1ea (bug 1326712) for failures in browser_bookmark_popup.js 2017-01-03 19:36:42 -08:00
Jared Wein
5670df04ee Bug 1326712 - Allow hitting Enter on the Remove Bookmark button to remove the bookmark instead of performing the default action on the popup. r=mossop
MozReview-Commit-ID: AQ0Q4zb2g2Q

--HG--
extra : rebase_source : 642233413f4656683799e31398c9dd88dc2896d9
2017-01-03 17:02:09 -05:00
Jared Wein
9141469edf Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN
MozReview-Commit-ID: FuVu8skcqOe

--HG--
extra : rebase_source : 8ab34c4e46a7c3075b459bf44786ec184d10d203
2016-12-30 21:47:25 -05:00
Jared Wein
ecab54a7c9 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje

--HG--
extra : rebase_source : 0572a35415a766a3f31d266760ecd07f0dcc3f72
2016-12-29 18:34:54 -05:00
Wes Kocher
0dfb7c2b5c Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
7255df4e9a Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR

--HG--
extra : rebase_source : da7172285d43b820421557ed3b05887e091ff939
2016-12-29 15:20:47 -05:00
Marco Bonardo
975f9b571e Bug 1321556 - Remove unused bindings from urlbarbindings.xml. r=dao
MozReview-Commit-ID: FfIsoh76ajn

--HG--
extra : rebase_source : cfc30eb7a1d9961d108dbad9ca0fb32d5c208043
2016-12-09 14:17:12 -10:00
Dave Townsend
8de07a19a0 Bug 1316882: Turn on space-before-function-paren eslint rule (browser). r=jaws
MozReview-Commit-ID: 2ZvTiZDHchz

--HG--
extra : rebase_source : db6482481b7338df491afd6f6fd376eccec84d7e
2016-11-11 08:10:51 -08:00
Dave Townsend
0a2c8f9b78 Bug 1316882: Turn on space-infix-ops eslint rule. r=jaws
MozReview-Commit-ID: HBpjT2uHJaZ

--HG--
extra : rebase_source : 78fe71a1d673a1c698520a9c82c6f35959614f8f
2016-11-10 14:48:04 -08:00
Jared Wein
87b2d4c295 Bug 1315013 - part 1, remove unnecessary double-slash comments that don't add value and look out of place with the spaced-comment eslint rule. r=mossop
MozReview-Commit-ID: HIUTSdkXxbY

--HG--
extra : rebase_source : 2f05e2f275ac7f293f9c650bdec8943189e3ce01
2016-11-03 14:42:06 -04:00
Mark Banner
09ab00a94f Bug 1313998 - Turn on no-unused-vars for local variable scopes in browser/base/content. r=mossop
MozReview-Commit-ID: IyFGBotfd11

--HG--
extra : rebase_source : aa43e5aea9e7fd7223fc59e941ecdc067abdb48f
2016-10-31 10:33:38 +00:00
Jared Wein
5040f17e00 Bug 1312486 - Enable no-extra-boolean-cast, no-new-object, no-shadow-restricted-names, and spaced-comment rules for eslint. r=standard8
MozReview-Commit-ID: 7Gx90a5y8t6

--HG--
extra : rebase_source : 9c8a6b15c19982d720b0163fbbf19d465da786fe
2016-10-24 13:14:19 -04:00
Mark Banner
709dd68567 Bug 1313626 - Clean up more issues found by eslint no-undef rule. r=mossop
MozReview-Commit-ID: HGiOmpyN5zV

--HG--
extra : rebase_source : f09a308b4c34b3cd3c28e170440bd1012176ef08
2016-10-28 11:40:32 +01:00
Dão Gottwald
dfd29d920e Bug 1304617 - Avoid using the ordinal attribute for positioning the Hide / Show Recently Bookmarked menu items. r=mak 2016-10-13 18:47:52 +02:00
Kirk Steuber
ad4b55af1f Bug 1206133 - Add popuppositioning state and popuppositioned event to improve arrow panel position handling. r=enndeakin
MozReview-Commit-ID: Dh1npORCQ6J

--HG--
extra : rebase_source : 5df6076561a746791c44d249afa31009d0e1b30a
2016-08-16 15:33:05 -07:00
Katie Broida[:ktbee]
07f2d654fe Bug 1171746 - Ensure tab-specific panels close when you switch the tab. r=jaws
--HG--
extra : amend_source : 8c8bd60be44132befa37a50422086d9ffdae3cbe
2016-08-19 07:27:00 -04:00
Wes Kocher
7636e9aaaf Backed out changeset 33fcf83eefe4 (bug 1171746) for browser_visibleFindSelection.js failures a=backout 2016-08-12 19:11:21 -07:00
Katie Broida[:ktbee]
b9d80840e4 Bug 1171746 - ensure tab specific panels close when you switch the tab r=jaws
Adds a tabspecific attribute to the edit bookmarks panel and the Pocket subview panel to signal that these popups should close when the user navigates away from the tab. It also specifies that the localized keyboard short cut for closing a  window should close the edit bookmarks panel and the tab by adding a general function to check whether a certain <key> has been pressed. Adds tests for both closing specific tabs and checking keys.

MozReview-Commit-ID: AxW5uQgDQQB

--HG--
extra : rebase_source : 76f649492e719317a9ef71895e9cb1d600ea67b1
2016-08-11 16:51:45 -04:00
Dão Gottwald
347cc05845 Bug 1289659 - Account for placesContext not existing in non-browser windows on Mac. r=mdeboer 2016-08-10 13:49:20 +02:00
Jared Wein
fd84c776c7 Bug 1292042 - Enable the keyword-spacing rule for eslint. Most of this patch was autogenerated by 'eslint --fix'. Files with .xml extension needed to be changed by hand due to limitations of custom plugin. r=markh
MozReview-Commit-ID: EMjJ3yWt9Wt

--HG--
extra : rebase_source : 2b8327e5a7cf0bfd190d696ad5fe475f13faa3cc
2016-08-04 03:28:58 -04:00
Pushpankar
c6670d980f Bug 1286854 - Replace ownerDocument.defaultView with ownerGlobal in browser/. r=dao
--HG--
extra : rebase_source : 72d50e73baf595840a2aade57ae782e4c40d4c27
2016-07-16 10:20:04 +02:00
Jared Wein
78099b5a1b Bug 1251071 - "New bookmark" popup disappears if I reopen it after creating bookmark. r=mak
MozReview-Commit-ID: DNqcu5vxrBG
* * *


MozReview-Commit-ID: 3KoNVklCK8d
2016-07-06 07:27:00 +02:00
Scott Wu
14183e306e Bug 754623 - Get page title from tab label; r=mak
MozReview-Commit-ID: BOXUKUcA0fZ

--HG--
extra : transplant_source : C%15%EB%C50%A3%E4eK%C7%60%965l%F5u%A3%F3%B9%0F
2016-05-19 12:45:21 +08:00
Dão Gottwald
f0ad31722f Bug 1257087 - Middle mouse click on history item should open it. r=mak 2016-05-25 18:15:15 +02:00
Dão Gottwald
b2ab89a79b Bug 1219788 - Show bookmarks toolbar when adding a bookmark to the bookmarks toolbar folder. r=mak 2016-05-24 14:31:33 +02:00
Sebastian Hengst
5a53f34fe3 Backed out changeset 54ebf85e8731 (bug 1219788) for leaks in many mochitests on Linux. r=backout 2016-05-21 09:35:06 +02:00
Dão Gottwald
377084b710 Bug 1219788 - Show bookmarks toolbar when adding a bookmark to the bookmarks toolbar folder. r=mak
--HG--
extra : rebase_source : d7fc47340b6655ac5050d5e742dc39565e147e82
2016-05-20 14:41:49 +02:00
Mike de Boer
08e2673c63 Bug 1248267 - allow Recently Bookmarked items to be special root nodes to allow primitive contextual actions. r=mak,dao 2016-05-19 12:37:33 +02:00
Dão Gottwald
ab3bd282d9 Bug 1250203 - Re-populate recent bookmarks when a bookmark gets deleted while the menu is open. r=mak 2016-05-04 16:52:40 +02:00
Carsten "Tomcat" Book
548d98c27e merge mozilla-inbound to mozilla-central a=merge 2016-05-02 11:25:32 +02:00
Matt Brubeck
a17fb5bfed Bug 943888 - Always keep the bookmark star button enabled [r=mak]
MozReview-Commit-ID: 27ee1dbLSM1

--HG--
extra : rebase_source : 2d9a4aa005d585fa6ceafe174bbbd5f8c6b8f5ec
2016-04-25 13:59:00 -07:00
Scott Wu
ca33d182f4 Bug 446171 - Part 1: Get page titles from tab and not depend on history; r=mak
MozReview-Commit-ID: EUQv2p9LxtY

--HG--
extra : rebase_source : 0967a5d7b3fcb6cfd74c00f6252a6cca1a85b77b
extra : histedit_source : 6ee3667d3a79284058e2f9628e0b5d1c365ff7a9
2016-03-21 14:57:18 +08:00
Dão Gottwald
ac879e2e39 Bug 1248268 - Add option for disabling the "Recently Bookmarked" UI. r=mak 2016-04-29 13:43:59 +02:00
Wes Kocher
5b1e4f68c2 Backed out changeset fec92924befb (bug 1250203) for bc leaks
MozReview-Commit-ID: BMq0vBarOQZ
2016-04-15 12:19:44 -07:00
Dão Gottwald
10bc69ffda Bug 1250203 - Re-populate recent bookmarks when a bookmark has been deleted. r=mak 2016-04-15 16:50:20 +02:00
Sebastian Hengst
c515d4ce79 Backed out changeset 81df156cb345 (bug 1250203) for test failures in mochitest-5 test_ext_bookmarks.html, browser-chrome browser_views_liveupdate.js, OS X xpcshell test_browserGlue_migrate.js and maybe more. r=backout on a CLOSED TREE 2016-04-08 18:42:07 +02:00
Dão Gottwald
02c6656bf9 Bug 1250203 - Re-populate recent bookmarks when a bookmark has been deleted. r=mak 2016-04-08 16:33:21 +02:00
malayaleecoder
b3deb181bb Bug 1254496 - Remove gURLBar null-checks. r=dao 2016-03-10 23:15:49 +05:30
Marco Bonardo
6cc886e9f3 Bug 1253930 - Recently bookmarked items have the default favicon instead of the correct one. r=dao
MozReview-Commit-ID: LMTVQetQL9Q

--HG--
extra : rebase_source : 76bc5e0eb24bfd0e6c26e7d577100a566dda94de
2016-03-07 12:06:40 +01:00
Dão Gottwald
d97fcaaba2 Bug 1250806 - Add menuitems for recent bookmarks synchronously so that they show up in the native menubar on OS X. r=mak 2016-03-02 17:16:59 +01:00
Jared Wein
2d2a2f8e9d Bug 1219794 - Show the bookmark popup for new bookmarks and autoclose if no interaction. r=mak
MozReview-Commit-ID: FSx0bB4KqpQ
2016-02-18 15:36:22 -05:00
Dão Gottwald
9249c82407 Bug 1249473 - Right-clicking a recent bookmark shouldn't load it. r=mak 2016-02-19 15:10:17 +01:00
Justin Dolske
d342593533 Backout 44f79bbe2b51 (bug 1219788), not working as intended. 2016-02-18 12:16:52 -08:00
Dão Gottwald
040a3bb826 Bug 1248266 - Make recently added bookmarks keyboard-accessible by not using a vbox container. r=mak
--HG--
extra : rebase_source : 169ad437807eba57a863d582a54ea81e50323e19
2016-02-16 12:05:47 +01:00
Dão Gottwald
060c2c03e3 Bug 1248259 - onMainMenuPopupShowing shouldn't handle the popupshowing event from sub menus. r=mak 2016-02-15 13:16:58 +01:00
Dão Gottwald
486c442ad2 Bug 1248258 - Fix sorting in the query used for 5 most recently added bookmarks. r=mak 2016-02-15 13:15:30 +01:00
Dão Gottwald
52d9a689b0 Bug 1219804 - Show last 5 recent bookmarks in the bookmarks menu. r=mak 2016-02-12 12:21:17 +01:00
Dave Townsend
a9fc7f9380 Bug 1245649: Turn on no-irregular-whitespace and no-mixed-spaces-and-tabs. r=jaws
--HG--
extra : commitid : AHmjTpVmCOP
extra : rebase_source : 0034d884816464bff4677afbe96c52fa9dca9072
2016-02-03 18:09:49 -08:00
Dave Townsend
0a6414b898 Bug 1245649: Turn on no-trailing-spaces. r=Gijs
--HG--
extra : commitid : F2OWKTvXUO4
extra : rebase_source : ec68631342e0edc59d77b6bab1cdc975ad175327
2016-02-03 14:22:33 -08:00
Dão Gottwald
13fb21d300 Bug 1219788 - Show bookmarks toolbar when adding a bookmark to the bookmarks toolbar folder. r=mak 2016-01-06 14:29:36 +01:00
Sebastian Hengst
6738c45761 Bug 1236481 - 'Synced Tabs' History menuitem not shown. r=markh 2016-01-05 17:29:39 +01:00
Ryan VanderMeulen
8dbcac5e68 Backed out changeset 4e9389db3a5a (bug 1219788) for causing M(JP) LSAN permaleaks. a=backout 2016-01-01 20:21:59 -05:00
Dão Gottwald
3b0c155b31 Bug 1219788 - Show bookmarks toolbar when adding a bookmark to the bookmarks toolbar folder. r=mak 2015-12-31 11:01:09 +01:00
Shane Caraveo
eabb5f6400 Bug 1215694 move pocket to a system addon, r=Gijs, r=glandium
part 1: reorganize file locations, r=Gijs
  part 2: remove built-in pocket code, r=Gijs
  part 3: l10n support, r=glandium
  part 4: move code/functionality from part 2 into the addon, r=Gijs
  part 5: remove dead code, r=Gijs
  part 6: create a simple api for addons to add to reader mode, r=Gijs
  part 7: various test fixes related to cui behaviour and pocket, r=me

--HG--
rename : browser/components/pocket/Pocket.jsm => browser/extensions/pocket/content/Pocket.jsm
rename : browser/components/pocket/main.js => browser/extensions/pocket/content/main.js
rename : browser/components/pocket/panels/css/firasans.css => browser/extensions/pocket/content/panels/css/firasans.css
rename : browser/components/pocket/panels/css/normalize.css => browser/extensions/pocket/content/panels/css/normalize.css
rename : browser/components/pocket/panels/css/saved.css => browser/extensions/pocket/content/panels/css/saved.css
rename : browser/components/pocket/panels/css/signup.css => browser/extensions/pocket/content/panels/css/signup.css
rename : browser/components/pocket/panels/fonts/FiraSans-Regular.woff => browser/extensions/pocket/content/panels/fonts/FiraSans-Regular.woff
rename : toolkit/themes/shared/reader/pocket.svg => browser/extensions/pocket/content/panels/img/pocket.svg
rename : browser/components/pocket/panels/img/pocketerror@1x.png => browser/extensions/pocket/content/panels/img/pocketerror@1x.png
rename : browser/components/pocket/panels/img/pocketerror@2x.png => browser/extensions/pocket/content/panels/img/pocketerror@2x.png
rename : browser/components/pocket/panels/img/pocketlogo@1x.png => browser/extensions/pocket/content/panels/img/pocketlogo@1x.png
rename : browser/components/pocket/panels/img/pocketlogo@2x.png => browser/extensions/pocket/content/panels/img/pocketlogo@2x.png
rename : browser/components/pocket/panels/img/pocketlogosolo@1x.png => browser/extensions/pocket/content/panels/img/pocketlogosolo@1x.png
rename : browser/components/pocket/panels/img/pocketlogosolo@2x.png => browser/extensions/pocket/content/panels/img/pocketlogosolo@2x.png
rename : browser/components/pocket/panels/img/pocketmenuitem16.png => browser/extensions/pocket/content/panels/img/pocketmenuitem16.png
rename : browser/components/pocket/panels/img/pocketmenuitem16@2x.png => browser/extensions/pocket/content/panels/img/pocketmenuitem16@2x.png
rename : browser/components/pocket/panels/img/pocketsignup_button@1x.png => browser/extensions/pocket/content/panels/img/pocketsignup_button@1x.png
rename : browser/components/pocket/panels/img/pocketsignup_button@2x.png => browser/extensions/pocket/content/panels/img/pocketsignup_button@2x.png
rename : browser/components/pocket/panels/img/pocketsignup_devices@1x.png => browser/extensions/pocket/content/panels/img/pocketsignup_devices@1x.png
rename : browser/components/pocket/panels/img/pocketsignup_devices@2x.png => browser/extensions/pocket/content/panels/img/pocketsignup_devices@2x.png
rename : browser/components/pocket/panels/img/pocketsignup_hero@1x.png => browser/extensions/pocket/content/panels/img/pocketsignup_hero@1x.png
rename : browser/components/pocket/panels/img/pocketsignup_hero@2x.png => browser/extensions/pocket/content/panels/img/pocketsignup_hero@2x.png
rename : browser/components/pocket/panels/img/signup_firefoxlogo@1x.png => browser/extensions/pocket/content/panels/img/signup_firefoxlogo@1x.png
rename : browser/components/pocket/panels/img/signup_firefoxlogo@2x.png => browser/extensions/pocket/content/panels/img/signup_firefoxlogo@2x.png
rename : browser/components/pocket/panels/img/signup_help@1x.png => browser/extensions/pocket/content/panels/img/signup_help@1x.png
rename : browser/components/pocket/panels/img/signup_help@2x.png => browser/extensions/pocket/content/panels/img/signup_help@2x.png
rename : browser/components/pocket/panels/img/signup_or@1x.png => browser/extensions/pocket/content/panels/img/signup_or@1x.png
rename : browser/components/pocket/panels/img/signup_or@2x.png => browser/extensions/pocket/content/panels/img/signup_or@2x.png
rename : browser/components/pocket/panels/img/tag_close@1x.png => browser/extensions/pocket/content/panels/img/tag_close@1x.png
rename : browser/components/pocket/panels/img/tag_close@2x.png => browser/extensions/pocket/content/panels/img/tag_close@2x.png
rename : browser/components/pocket/panels/img/tag_closeactive@1x.png => browser/extensions/pocket/content/panels/img/tag_closeactive@1x.png
rename : browser/components/pocket/panels/img/tag_closeactive@2x.png => browser/extensions/pocket/content/panels/img/tag_closeactive@2x.png
rename : browser/components/pocket/panels/js/messages.js => browser/extensions/pocket/content/panels/js/messages.js
rename : browser/components/pocket/panels/js/saved.js => browser/extensions/pocket/content/panels/js/saved.js
rename : browser/components/pocket/panels/js/signup.js => browser/extensions/pocket/content/panels/js/signup.js
rename : browser/components/pocket/panels/js/tmpl.js => browser/extensions/pocket/content/panels/js/tmpl.js
rename : browser/components/pocket/panels/js/vendor/handlebars.runtime.js => browser/extensions/pocket/content/panels/js/vendor/handlebars.runtime.js
rename : browser/components/pocket/panels/js/vendor/jquery-2.1.1.min.js => browser/extensions/pocket/content/panels/js/vendor/jquery-2.1.1.min.js
rename : browser/components/pocket/panels/js/vendor/jquery.tokeninput.min.js => browser/extensions/pocket/content/panels/js/vendor/jquery.tokeninput.min.js
rename : browser/components/pocket/panels/license.txt => browser/extensions/pocket/content/panels/license.txt
rename : browser/components/pocket/panels/saved.html => browser/extensions/pocket/content/panels/saved.html
rename : browser/components/pocket/panels/signup.html => browser/extensions/pocket/content/panels/signup.html
rename : browser/components/pocket/panels/tmpl/saved_premiumextras.handlebars => browser/extensions/pocket/content/panels/tmpl/saved_premiumextras.handlebars
rename : browser/components/pocket/panels/tmpl/saved_premiumshell.handlebars => browser/extensions/pocket/content/panels/tmpl/saved_premiumshell.handlebars
rename : browser/components/pocket/panels/tmpl/saved_shell.handlebars => browser/extensions/pocket/content/panels/tmpl/saved_shell.handlebars
rename : browser/components/pocket/panels/tmpl/signup_shell.handlebars => browser/extensions/pocket/content/panels/tmpl/signup_shell.handlebars
rename : browser/components/pocket/panels/tmpl/signupstoryboard_shell.handlebars => browser/extensions/pocket/content/panels/tmpl/signupstoryboard_shell.handlebars
rename : browser/components/pocket/pktApi.js => browser/extensions/pocket/content/pktApi.jsm
rename : browser/locales/en-US/chrome/browser/browser-pocket.properties => browser/extensions/pocket/locales/en-US/pocket.properties
2015-12-29 15:40:52 -08:00
Felipe Gomes
bddd338cd7 Bug 1231728 - Fixes some code to follow eslint rules. r=mak
--HG--
extra : commitid : 2pB0pOqsHVW
2015-12-10 14:38:30 -05:00
Felipe Gomes
0e0c0d5f18 Bug 1228655 - Remove ifdefs in browser-places.js. r=Gijs 2015-12-01 20:06:11 -02:00
Felipe Gomes
909d49249d Bug 1228627 - Remove #includes from browser.js. r=Gijs 2015-11-30 12:13:57 -02:00
Sebastian Hengst
66ebfb501e Bug 1227361 - Remove checks for MOZ_SERVICES_SYNC from browser/. r=markh 2015-11-24 19:31:16 +01:00
Paolo Amadini
383af26e19 Bug 1206244 - Replace globe with the "i" icon, keep separate lock for secure pages. r=past
--HG--
extra : commitid : FK2Mm4rfvXP
extra : rebase_source : 27b3567bb0db0f8b5dc042f3958a4374b012429e
2015-11-11 15:52:56 +00:00
Hassen ben tanfous
45492f28fb Bug 1074804 - Replace arrays .indexOf with .includes in Places. r=mak 2015-10-11 20:24:32 +02:00
Marco Bonardo
ed553c88ae Bug 1208063 - The name input field on the new bookmark dialog doesn't get focus. r=adw 2015-10-07 15:40:13 +02:00
Tooru Fujisawa
d88225d76e Bug 1207490 - Part 1: Remove use of expression closure from browser/base/. r=dao
--HG--
extra : commitid : GTnFNtx973B
extra : rebase_source : 5bf8bb3d7ddb0234bd533cf6ddc843dd2db9d8f5
2015-09-21 00:29:37 +09:00
Neil Deakin
895856cf29 Bug 1199239, remove cpow usage from bookmark this page, r=mak 2015-09-25 21:14:43 -04:00
Shu-yu Guo
64db2267cf Bug 1202902 - Mass replace toplevel 'let' with 'var' in preparation for global lexical scope. (rs=jorendorff) 2015-09-15 11:19:45 -07:00
Dão Gottwald
e0bb5614ac Bug 1182102 - Stop setting the bookmark-item class on the home button or the bookmarks button when moving them to the bookmarks toolbar. r=gijs 2015-08-17 15:51:22 +02:00