nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity
845935 commits 1 branch 98 tags 6.4 GiB
Commit graph

89 commits

Author SHA1 Message Date
Mike Conley
061f8f7d3a Bug 1837367 - Allow file migrators to show an error message if migration failed for some reason. r=kpatenio,desktop-theme-reviewers 
The spec calls for a special-case in the event that file migration
ever fails - the wizard should be sent back to the selection page,
have the associated file migrator still set in the dropdown, and
show an error message.

A later patch in this series will add such an error message for
the bookmarks file migrator.

Depends on D180458

Differential Revision: https://phabricator.services.mozilla.com/D180490
 2023-06-13 14:53:00 +00:00
Mike Conley
062b58f00f Bug 1837619 - Make sure to clear the file progress status message when going back to in-progress. r=kpatenio 
Differential Revision: https://phabricator.services.mozilla.com/D180458
 2023-06-12 19:45:51 +00:00
Mike Conley
50f933ea0d Bug 1823537 - Add tests for the ported telemetry probes. r=kpatenio 
Differential Revision: https://phabricator.services.mozilla.com/D180232
 2023-06-09 17:39:51 +00:00
Mike Conley
03806b5352 Bug 1823537 - Port some older telemetry probes from the old migration wizard to the new one. r=Gijs 
Those probes are:
* migration.uninstaller_profile_refresh (scalar)
* migration.discovered_migrators (keyed scalar)
* FX_MIGRATION_SOURCE_BROWSER (histogram)
* FX_MIGRATION_USAGE (histogram)
* FX_MIGRATION_ERRORS (histogram)

Not being ported are the following histograms:
* FX_STARTUP_MIGRATION_BROWSER_COUNT
* FX_STARTUP_MIGRATION_EXISTING_DEFAULT_BROWSER
* FX_STARTUP_MIGRATION_DATA_RECENCY
* FX_STARTUP_MIGRATION_USED_RECENT_BROWSER

as these are all expired.

Differential Revision: https://phabricator.services.mozilla.com/D180231
 2023-06-09 17:39:51 +00:00
Mike Conley
cffc131623 Bug 1823537 - Use new migration wizard for startup and profile reset migrations. r=kpatenio,Gijs,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D180230
 2023-06-09 17:39:51 +00:00
Mike Conley
91f5fd48f8 Bug 1833427 - Add bookmark import from HTML file in new migration wizard. r=fluent-reviewers,kpatenio,flod 
Original patch by Tim Giles <tgiles@mozilla.com>, completed by Mike Conley <mconley@mozilla.com>.

Differential Revision: https://phabricator.services.mozilla.com/D179273
 2023-05-30 13:37:54 +00:00
Mike Conley
a3c41c4d0c Bug 1825874 - Offer to import passwords from a CSV file for Safari. r=kpatenio 
Safari doesn't let us import all passwords from Keychain at once. Instead,
the user needs to authorize each read from Keychain one by one. This is
not tenable for password import.

Instead, we show the user instructions on how they can export their passwords
from Safari into a CSV file that can then be imported. This patch adds support
for showing those instructions (which had landed earlier in bug 1818789) and
then importing from that CSV file upon selection.

The data-review for the safari_password_file Telemetry event being used here
was done earlier in bug 1824786.

Differential Revision: https://phabricator.services.mozilla.com/D175669
 2023-05-29 16:12:41 +00:00
Butkovits Atila
4fe057c425 Backed out changeset 863fae78db03 (bug 1825874) for causing failures at browser_disabled_migrator.js. CLOSED TREE 2023-05-29 18:34:53 +03:00
Mike Conley
0128cbcc0b Bug 1825874 - Offer to import passwords from a CSV file for Safari. r=kpatenio 
Safari doesn't let us import all passwords from Keychain at once. Instead,
the user needs to authorize each read from Keychain one by one. This is
not tenable for password import.

Instead, we show the user instructions on how they can export their passwords
from Safari into a CSV file that can then be imported. This patch adds support
for showing those instructions (which had landed earlier in bug 1818789) and
then importing from that CSV file upon selection.

The data-review for the safari_password_file Telemetry event being used here
was done earlier in bug 1824786.

Differential Revision: https://phabricator.services.mozilla.com/D175669
 2023-05-29 14:39:59 +00:00
Mike Conley
002250eb40 Bug 1826149 - Add payment method migration experience in new migration wizard. r=niklas,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D178364
 2023-05-25 20:16:04 +00:00
Mike Conley
5fe310d168 Bug 1830891 - Clear new migration wizard progress strings when going back to in-progress. r=kpatenio 
Differential Revision: https://phabricator.services.mozilla.com/D178856
 2023-05-23 23:13:26 +00:00
Mike Conley
152872924f Bug 1832227 - Use a button label that matches the instructions for migrating from Safari. r=flod,niklas 
Differential Revision: https://phabricator.services.mozilla.com/D177806
 2023-05-15 14:50:59 +00:00
negin
8eba2c1f19 Bug 1829039 - Updates embedded migration wizard styles to match figma r=aminomancer,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D176352
 2023-05-10 13:08:59 +00:00
Narcis Beleuzu
f9cc14ad1a Backed out changeset 86f74f61adc0 (bug 1829039) for newtab failure on aboutwelcome.scss 2023-05-10 00:43:26 +03:00
negin
2a55ec8b7c Bug 1829039 - Updates embedded migration wizard styles to match figma r=aminomancer 
This patch fixes the font size inconsistencies, extra whitespace above title, and introduces simplified animations for [Embedded Migration Wizard](https://www.figma.com/file/c83OEio9DhCQKuabx2tIEl/NUO-Experiments-2023?node-id=976-31535) screen. Other feedback from the initial bug has been broken down into other bugs:

* [Position relative feedback bug](https://bugzilla.mozilla.org/show_bug.cgi?id=1829272)
* [Checkbox spacing](https://bugzilla.mozilla.org/show_bug.cgi?id=1829733)
* Logo feedback - syncing up with Gabrielle and will file a follow-up bug depending on what we want to do (figma does not include the logo)

Differential Revision: https://phabricator.services.mozilla.com/D176352
 2023-05-09 20:22:09 +00:00
Cosmin Sabou
05c75a0051 Backed out changeset f1e19e0fa144 (bug 1829039) as requested by aminomancer. CLOSED TREE 2023-05-09 20:05:34 +03:00
negin
6475b32209 Bug 1829039 - Updates embedded migration wizard styles to match figma r=aminomancer 
This patch fixes the font size inconsistencies, extra whitespace above title, and introduces simplified animations for [Embedded Migration Wizard](https://www.figma.com/file/c83OEio9DhCQKuabx2tIEl/NUO-Experiments-2023?node-id=976-31535) screen. Other feedback from the initial bug has been broken down into other bugs:

* [Position relative feedback bug](https://bugzilla.mozilla.org/show_bug.cgi?id=1829272)
* [Checkbox spacing](https://bugzilla.mozilla.org/show_bug.cgi?id=1829733)
* Logo feedback - syncing up with Gabrielle and will file a follow-up bug depending on what we want to do (figma does not include the logo)

Differential Revision: https://phabricator.services.mozilla.com/D176352
 2023-05-09 16:41:53 +00:00
Norisz Fay
9cbee35db5 Backed out changeset 67d785ab3cb3 (bug 1829039) for causing node-newtab failure on aboutwelcome.scss CLOSED TREE 2023-05-09 17:35:44 +03:00
negin
d19ea37cd4 Bug 1829039 - Updates embedded migration wizard styles to match figma r=aminomancer 
This patch fixes the font size inconsistencies, extra whitespace above title, and introduces simplified animations for [Embedded Migration Wizard](https://www.figma.com/file/c83OEio9DhCQKuabx2tIEl/NUO-Experiments-2023?node-id=976-31535) screen. Other feedback from the initial bug has been broken down into other bugs:

* [Position relative feedback bug](https://bugzilla.mozilla.org/show_bug.cgi?id=1829272)
* [Checkbox spacing](https://bugzilla.mozilla.org/show_bug.cgi?id=1829733)
* Logo feedback - syncing up with Gabrielle and will file a follow-up bug depending on what we want to do (figma does not include the logo)

Differential Revision: https://phabricator.services.mozilla.com/D176352
 2023-05-09 13:46:13 +00:00
Cristian Tuns
9d916fde7e Backed out changeset 743c4f059b79 (bug 1829039) for causing bc failures in browser_aboutwelcome_multistage_mr.js CLOSED TREE 2023-05-05 19:50:02 -04:00
negin
79fb9c2840 Bug 1829039 - Updates embedded migration wizard styles to match figma r=aminomancer,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D176352
 2023-05-05 19:30:31 +00:00
Stanca Serban
2c11f18f89 Backed out changeset 72f882230f63 (bug 1829039) for causing mochitests failures in browser_aboutwelcome_multistage_mr.js. CLOSED TREE 2023-05-05 04:28:52 +03:00
negin
938be7d607 Bug 1829039 - Updates embedded migration wizard styles to match figma r=aminomancer,mconley 
This patch fixes the font size inconsistencies, extra whitespace above title, and lack of transition animations for [Embedded Migration Wizard](https://www.figma.com/file/c83OEio9DhCQKuabx2tIEl/NUO-Experiments-2023?node-id=976-31535) screen. Other feedback from the initial bug has been broken down into other bugs:

* [Position relative feedback bug](https://bugzilla.mozilla.org/show_bug.cgi?id=1829272)
* [Checkbox spacing](https://bugzilla.mozilla.org/show_bug.cgi?id=1829733)
* Logo feedback - syncing up with Gabrielle and will file a follow-up bug depending on what we want to do (figma does not include the logo)

Differential Revision: https://phabricator.services.mozilla.com/D176352
 2023-05-04 23:32:12 +00:00
Cosmin Sabou
c8052f726d Backed out changeset cdaa6a0312f0 (bug 1829039) for causing increase in failures on browser_aboutwelcome_multistage_mr.js. CLOSED TREE 2023-05-03 19:40:03 +03:00
negin
41613af3eb Bug 1829039 - Updates embedded migration wizard styles to match figma r=aminomancer,mconley 
This patch fixes the font size inconsistencies, extra whitespace above title, and introduces simplified animations for [Embedded Migration Wizard](https://www.figma.com/file/c83OEio9DhCQKuabx2tIEl/NUO-Experiments-2023?node-id=976-31535) screen. Other feedback from the initial bug has been broken down into other bugs:

* [Position relative feedback bug](https://bugzilla.mozilla.org/show_bug.cgi?id=1829272)
* [Checkbox spacing](https://bugzilla.mozilla.org/show_bug.cgi?id=1829733)
* Logo feedback - syncing up with Gabrielle and will file a follow-up bug depending on what we want to do (figma does not include the logo)

Differential Revision: https://phabricator.services.mozilla.com/D176352
 2023-05-03 13:46:47 +00:00
Mike Conley
9257c9bf55 Bug 1830726 - Only show the scrollbar in the migration wizard browser profile selector when there is something to scroll to. r=niklas 
Differential Revision: https://phabricator.services.mozilla.com/D176810
 2023-05-01 18:22:22 +00:00
Mike Conley
c1248109ff Bug 1829733 - Remove extraneous block margin around migration wizard checkboxes. r=niklas 
This also updates the iterator that was - unchecking and hiding all of
the resource checkboxes during the start of the routine that runs
when the browser / profile selector changes. This original iterator
was accidentally including the "Select All" checkbox from Variant 2,
and setting the "hidden" attribute on it. That attribute has no effect,
but it _does_ cause the label:not([hidden]) selector in the migration
wizard to not select it, which cause the label to not have the right
vertical alignment.

This patch updates the iterator to just select and hide the checkboxes
that have resources associated with them.

Differential Revision: https://phabricator.services.mozilla.com/D176342
 2023-04-26 20:27:13 +00:00
elephanteatsapple
d8ea8860d2 Bug 1827903 - Browser list is cut off inside Import Browser data when having multiple browsers or profiles or reduced height.r=mconley 
Differential Revision: https://phabricator.services.mozilla.com/D175447
 2023-04-21 13:18:42 +00:00
Mike Conley
11e8037546 Bug 1829196 - Use the term 'Continue' rather than 'Done' in the success state of the new migration wizard when embedding. r=niklas,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D176072
 2023-04-21 03:18:13 +00:00
Mike Conley
af83292a15 Bug 1820640 - Enforce left-alignment and expose the button containers for the new Migration Wizard. r=kpatenio 
This is so that the contents of the Migration Wizard don't get automatically
centered if its embedding context is centering things.

This change also makes it so that embedders can customize some of the rules of how
buttons are laid out.

Differential Revision: https://phabricator.services.mozilla.com/D171771
 2023-04-21 03:18:12 +00:00
Mike Conley
6b6a82db38 Bug 1828758 - Make Password file migrator only available if importing logins from CSV is enabled. r=kpatenio 
Differential Revision: https://phabricator.services.mozilla.com/D175804
 2023-04-18 22:36:26 +00:00
Mike Conley
08686a9936 Bug 1828463 - Make file migrator icon the same size as browser icons in the browser-profile-selector dropdown. r=niklas,Itiel 
Differential Revision: https://phabricator.services.mozilla.com/D175677
 2023-04-18 19:22:25 +00:00
Mike Conley
6969581510 Bug 1827204 - Set the right aria roles and attributes for the browser profile selector in the new migration wizard. r=Jamie 
Differential Revision: https://phabricator.services.mozilla.com/D175052
 2023-04-18 14:31:50 +00:00
Mike Conley
790969beb5 Bug 1827274 - Allow users to use file importers after showing NO_BROWSERS_FOUND page in the new migration wizard. r=kpatenio,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D175069
 2023-04-14 17:37:57 +00:00
Mike Conley
d9c3fa4536 Bug 1828003 - Remove aria-live attribute from new Migration Wizard deck to reduce chattiness. r=nlapre 
Differential Revision: https://phabricator.services.mozilla.com/D175410
 2023-04-13 21:31:39 +00:00
Mike Conley
d9c70f322c Bug 1821187 - Add infrastructure for file migrators in the new Migration Wizard. r=fluent-reviewers,kpatenio,flod 
This also includes our first file migrator, which imports passwords from CSV/TSV files.

Depends on D174537

Differential Revision: https://phabricator.services.mozilla.com/D173033
 2023-04-13 20:15:03 +00:00
Butkovits Atila
54c533e94a Backed out 2 changesets (bug 1821187) for causing failures at browser_file_migration.js. CLOSED TREE 
Backed out changeset 8402100dfc12 (bug 1821187)
Backed out changeset 2a7196e34b3d (bug 1821187)
 2023-04-13 05:28:27 +03:00
Mike Conley
b3d86515cb Bug 1821187 - Add infrastructure for file migrators in the new Migration Wizard. r=fluent-reviewers,kpatenio,flod 
This also includes our first file migrator, which imports passwords from CSV/TSV files.

Differential Revision: https://phabricator.services.mozilla.com/D173033
 2023-04-13 01:28:38 +00:00
Mike Conley
473827093c Bug 1827206 - Focus the Done button after migration completes in the new wizard. r=kpatenio 
Differential Revision: https://phabricator.services.mozilla.com/D175050
 2023-04-11 20:53:23 +00:00
Mike Conley
f975bc9a50 Bug 1827205 - Make sure browser / profile selector is focused when showing the selection page in the new migration wizard. r=kpatenio 
Differential Revision: https://phabricator.services.mozilla.com/D175049
 2023-04-11 20:53:22 +00:00
elephanteatsapple
6761cfa290 Bug 1825070 - Make the Migration Wizard panel / panel-list closer to the width of the selector button. r=mconley 
Differential Revision: https://phabricator.services.mozilla.com/D174801
 2023-04-05 21:42:35 +00:00
Mike Conley
b6752be6de Bug 1824786 - Add event telemetry for the migration wizards. data-review=jhirsch, r=niklas 
Differential Revision: https://phabricator.services.mozilla.com/D174184
 2023-04-03 20:47:13 +00:00
Mike Conley
a46819cdb9 Bug 1821779 - Move migrationWizard.ftl out from locales-preview into the locales folder. r=flod,fluent-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D174482
 2023-04-03 17:25:18 +00:00
steven wang
901ad85687 Bug 1819334 - Display an error message when no importable resources can be found for a browser / profile pair. r=mconley,fluent-reviewers. 
Differential Revision: https://phabricator.services.mozilla.com/D173544
 2023-03-31 15:17:19 +00:00
Mike Conley
180bc050d1 Bug 1801981 - Use the word "favorites" instead of "bookmarks" when importing from IE / Edge. r=niklas,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D173567
 2023-03-29 17:58:22 +00:00
elephanteatsapple
c9dad3388d Bug 1822312 - Send brand images from each browser migrator class down to the Migration Wizard, and set the images in the panel-list / selector button. r=mconley 
Differential Revision: https://phabricator.services.mozilla.com/D173537
 2023-03-29 03:43:37 +00:00
Mike Conley
1d20672b0e Bug 1825024 - Make sure that the Select All checkbox is checked if all visible resources are checked, and unchecked otherwise. r=kpatenio 
Differential Revision: https://phabricator.services.mozilla.com/D173851
 2023-03-28 19:26:26 +00:00
Mike Conley
9e0af92a95 Bug 1825009 - Make sure that Select All only checks resources that are visible. r=kpatenio 
This also adds some belt-and-suspenders checks here so that even if the Migration Wizard
somehow gets confused and sends resource types that the migrator can't import from, they'll
just get ignored rather than having a forever-progress-spinner for that resource type.

Differential Revision: https://phabricator.services.mozilla.com/D173848
 2023-03-28 19:26:26 +00:00
Mike Conley
3a9a221da4 Bug 1822676 - Have the new Migration Wizard request permissions if necessary for Safari import. r=NeilDeakin 
Differential Revision: https://phabricator.services.mozilla.com/D172840
 2023-03-27 20:08:54 +00:00
Cosmin Sabou
257756f09e Backed out changeset fe5dd9d4dcbb (bug 1822676) for causing macOS shippable bc failures on browser_safari_permissions.js. 2023-03-27 21:21:39 +03:00