Commit graph

22 commits

Author SHA1 Message Date
Julian Descottes
3f0e2f4c4f Bug 1592517 - Migrate devtools DOMHelpers.jsm from JSM to plain JS module r=ochameau
Depends on D51054

Summary of the changes here:
- move DOMHelpers.jsm to dom-helpers.js
- remove all unused methods
- converted to a static helper to avoid instanciating DOMHelpers objects for no reason
- updated call sites accordingly

Differential Revision: https://phabricator.services.mozilla.com/D51065

--HG--
rename : devtools/shared/DOMHelpers.jsm => devtools/shared/dom-helpers.js
extra : moz-landing-system : lando
2019-10-30 11:25:01 +00:00
Michael Ratcliffe
079415e5ec Bug 1556201 - Inactive CSS: Clicking on the info icon should not close the tooltip r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D45678

--HG--
extra : moz-landing-system : lando
2019-09-18 11:05:48 +00:00
Julian Descottes
fdea67edb5 Bug 1273656 - Add wait before trying to click in browser_html_tooltip-02.js r=daisuke
Differential Revision: https://phabricator.services.mozilla.com/D44356

--HG--
extra : moz-landing-system : lando
2019-09-04 07:52:21 +00:00
Julian Descottes
33776481fd Bug 1539979 - Fix HTML Tooltip test for content frames r=gl
Depends on D40989

I though I fixed this a few months ago, but there are still timing issues with the current test when using a frame with type=content.

Differential Revision: https://phabricator.services.mozilla.com/D40990

--HG--
extra : moz-landing-system : lando
2019-08-20 06:21:22 +00:00
Victor Porof
f6db0ee557 Bug 1561435 - Format devtools/client/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D35884

--HG--
extra : source : 60e4496cf9699dc59f2f4738cb60f87cbdb01e67
2019-07-05 11:24:38 +02:00
Emilio Cobos Álvarez
337c7bf696 Bug 1440537 - Don't unnecessarily use cross-origin iframes on a devtools test. r=pbro
See the rest of the patches in this bug for more context :)

Differential Revision: https://phabricator.services.mozilla.com/D28912
2019-04-27 12:40:36 +02:00
Julian Descottes
b1b3b48975 Bug 1544749 - Fix HTML Tooltip tests when running in content frame r=bgrins
Depends on D27680

Not strictly related to win.top/parent, but those tests would fail if the toolbox is in a content frame.
tooltip-01.js is creating a blank tab for no reason which prevents interacting with the actual test frame.
tooltip-02.js is not properly targeting an iframe to simulate a click

Differential Revision: https://phabricator.services.mozilla.com/D27674

--HG--
extra : moz-landing-system : lando
2019-04-23 15:00:23 +00:00
Mantaroh Yoshinaga
495837c33c Bug 1472942 - Part 2. Add setContentSize() instead of setContent() in HTMLTooltip. r=birtles
This patch will remove setContest(), and change the following things instead of this:

 * Use HTMLTooltip.panel.appendChild() instead of HTMLTooltip.setContent().
 * Add HTMLTooltip.setContetnSize() to specify the panel size if need this.

Differential Revision: https://phabricator.services.mozilla.com/D7044

--HG--
extra : moz-landing-system : lando
2018-09-27 07:14:55 +00:00
Julian Descottes
640fe52298 Bug 1454696 - Run eslint --fix for prefer-const;r=yulia
MozReview-Commit-ID: F6xUXCgdRE4

--HG--
extra : rebase_source : 65de1b0aba412d9044b5196115f74276caa058f2
2018-06-01 12:36:09 +02:00
Alexandre Poirot
bcf6facc3c Bug 1440321 - Convert Task.jsm to async/await in devtools/client. r=jryans
MozReview-Commit-ID: HaGOC5cn3JD
2018-03-12 19:46:35 -05:00
Yoshi Huang
7363e22f81 Bug 1377523 - Part 4: fix devtools/client/shared/test. r=pbro
Move data: URIs in devtools/client/shared/test to seperate files.


--HG--
rename : devtools/client/shared/test/browser_layoutHelpers-getBoxQuads.html => devtools/client/shared/test/doc_layoutHelpers-getBoxQuads.html
rename : devtools/client/shared/test/browser_layoutHelpers.html => devtools/client/shared/test/doc_layoutHelpers.html
rename : devtools/client/shared/test/html-mdn-css-basic-testing.html => devtools/client/shared/test/doc_mdn-css-basic-testing.html
rename : devtools/client/shared/test/html-mdn-css-no-summary-or-syntax.html => devtools/client/shared/test/doc_mdn-css-no-summary-or-syntax.html
rename : devtools/client/shared/test/html-mdn-css-no-summary.html => devtools/client/shared/test/doc_mdn-css-no-summary.html
rename : devtools/client/shared/test/html-mdn-css-no-syntax.html => devtools/client/shared/test/doc_mdn-css-no-syntax.html
rename : devtools/client/shared/test/html-mdn-css-syntax-old-style.html => devtools/client/shared/test/doc_mdn-css-syntax-old-style.html
rename : devtools/client/shared/test/browser_templater_basic.html => devtools/client/shared/test/doc_templater_basic.html
rename : devtools/client/shared/test/browser_toolbar_basic.html => devtools/client/shared/test/doc_toolbar_basic.html
2017-07-13 12:27:52 +08:00
Gabriel Luong
445a55675b Bug 1307481 - Part 3: HTMLTooltip should receive the document that it should be attached to instead of the toolbox r=jdescottes 2016-10-08 09:49:07 -04:00
Gabriel Luong
badbea5392 Bug 1307481 - Part 1: Move Tooltip.js and HTMLTooltip.js into widgets/tooltip/ r=jdescottes
--HG--
rename : devtools/client/shared/widgets/HTMLTooltip.js => devtools/client/shared/widgets/tooltip/HTMLTooltip.js
rename : devtools/client/shared/widgets/Tooltip.js => devtools/client/shared/widgets/tooltip/Tooltip.js
2016-10-04 22:48:49 -04:00
Julian Descottes
50dbb87670 Bug 1286553 - HTMLTooltip: consume only left click events;r=bgrins
MozReview-Commit-ID: Hr0Lwv8Zx5C

--HG--
extra : rebase_source : 5464c3881db5ad0413cb3ca3a8103c88d970d851
2016-07-14 16:13:11 +02:00
Julian Descottes
3aa417586a Bug 1267403 - HTMLTooltip: add useXulWrapper option when displayed in a XUL document;r=ochameau
The HTMLTooltip supports an additional configuration parameter "useXulWrapper".
When set to true, if the tooltip is displayed in a XUL document, a XUL panel
will be used as an additional container for the tooltip.

This allows the tooltip to be displayed anywhere on the screen and can be
useful when displayed in small toolboxes.

MozReview-Commit-ID: 63kv4vAeW5R

--HG--
extra : source : fc4d902ff01ee92a5b6742d44286e5feaaba1500
extra : intermediate-source : 126f43ff3be5505920946a77ad82401c6bbaebef
extra : histedit_source : 863888c014723f7e95742079395497ba1a30aa36%2C13ba9aaf80acb96c587739c767c20a8f0f6a9a5a
2016-07-06 14:50:44 +02:00
Julian Descottes
718a901bda Bug 1266456 - part2: HTMLTooltip setContent() use object as 2nd arg;r=jsnajdr
setContent expects 3 arguments: content, width, height. Height is already optional
but for the autocomplete migration, the width will also become optional.

Using an object argument for width and height makes this easier.

MozReview-Commit-ID: 9CiMG0BdLOR

--HG--
extra : rebase_source : 4ec54714ccc2476fa4b341aaad3773ba095cca5a
2016-06-23 17:27:32 +02:00
Julian Descottes
4ce7004bfb Bug 1266456 - part1: HTMLTooltip cleanup test & jsdoc for synchronous setContent;r=jsnajdr
MozReview-Commit-ID: Ia3aRmwFawP

--HG--
extra : rebase_source : 6a569ffd14264ff8c680e5fc8f8cf6eae4ff5877
2016-06-22 15:18:21 +02:00
Julian Descottes
7bd66d252a Bug 1279441 - fix HTMLTooltip closing after click on inner iframe;r=bgrins
MozReview-Commit-ID: EggheTpU2y3

--HG--
extra : rebase_source : 5c6a678776292446aeb36a0555f89a5e943d252e
2016-06-10 11:24:04 +02:00
Julian Descottes
14ed6c99b4 Bug 1266450 - part3: fix helper to check if click occurred in tooltip;r=bgrins
The existing helper checking if a click occurred inside or outside a
HTMLTooltip container was failing if the click occurred in an iframe.

MozReview-Commit-ID: 9AIACOukYUF

--HG--
extra : rebase_source : e10ce05610e9a630ed1d9ba8a3f70b3344dffe9e
extra : source : 978c01749bdc4012f010db5fe09b0f8a402a9c0e
2016-06-03 12:50:39 +02:00
Julian Descottes
973205986c Bug 1266450 - part1: move devtools tooltip styles to dedicated file;r=bgrins
Tooltip styles are scattered between common.css and panel-specific CSS
files (e.g. inspector.css). For the HTML tooltip, the panel specific CSS
files will not be applied since the tooltip container is appended to the
devtools top window.

This changeset creates a new tooltips.css file which is loaded by default
with devtools themes.

MozReview-Commit-ID: BnoRi9gLfD5

--HG--
extra : rebase_source : 3fee4731f65563c4b61371e3a3c51fb797d1a12b
extra : source : bd8878532e1f370fb49e0c50de0b2da267f7de8a
2016-06-03 14:36:56 +02:00
Julian Descottes
3aec312112 Bug 1267401 - part2: include common.css in html tooltip tests;r=bgrins
MozReview-Commit-ID: KyYfOhAv6uo

--HG--
extra : rebase_source : a4c0546f2b55db1306e0cac5526feb64102cdbf7
extra : intermediate-source : c625fa7ed49a83bf0d52a20468527d85d4e2c654
extra : source : d5e3ee2d6861def9002cd60813a9403ff4ad84a8
2016-05-12 12:13:38 +02:00
Julian Descottes
b873e263bd Bug 1259834 - Create basic HTML tooltip API;r=bgrins
First implementation of HTML based tooltip to be used in devtools
instead of XUL panels. API is similar to the current API of
Tooltip.js

MozReview-Commit-ID: 8njiKBubLSj

--HG--
extra : rebase_source : 930bf7aef48e6c16d7a560d261e2bfd06fe02a63
extra : source : 09874a1e6f2c942a1f9de827fedd14da7e67a6e5
2016-05-04 14:44:57 +02:00