Commit graph

5614 commits

Author SHA1 Message Date
Meg Viar
8940eb0670 Bug 1793453 - Prevent automatic suppression of popups on 'blank' pages when URL bar is focused r=dao,adw
Differential Revision: https://phabricator.services.mozilla.com/D158850
2022-11-09 18:55:11 +00:00
James Teow
9ae4091c21 Bug 1798793 - Add search tip message for showSearchTerms feature - r=adw,fluent-reviewers,flod
The showSearchTerms feature has a search tip that should appear
on the users default search engine results page.

The design and copy for the feature are in this Figma file:
https://www.figma.com/file/Ock0cYjzi7I1GmcctqOr9K/Search-settings-updates?node-id=352%3A9183

Differential Revision: https://phabricator.services.mozilla.com/D161186
2022-11-09 18:36:08 +00:00
Mike Conley
42a671591b Bug 1797836 - Part 2: Update CUI to have a general TYPE_PANEL instead of TYPE_MENU_PANEL. r=desktop-theme-reviewers,dao,sclements
Long ago, the menu panel in was a customizable area that users could drag things into.

That changed back around 2017 in bug 1354117 when the Photon redesign was built. The
menu panel become a static menu, but we also made it possible to permanently move things
to the overflow panel of the nav-bar.

It looks like we never updated the area type constant from referring to the old menu panel
though, so it's "TYPE_MENU_PANEL", and registering a node for it happens with
registerMenuPanel. This patch changes to constant to TYPE_PANEL and updates the registration
method to registerPanelNode.

I a check around the codebase as well as GitHub looking to see if there were any
system add-ons or experimental WebExtensions that rely on TYPE_MENU_PANEL / registerMenuPanel,
but I couldn't find any.

Differential Revision: https://phabricator.services.mozilla.com/D161078
2022-11-08 14:51:40 +00:00
Mike Conley
25518bf24b Bug 1797836 - Part 1: browser.js should only call registerToolbarNode on CUI areas of TYPE_TOOLBAR. r=cmkm
It looks like we had some kind of hard-coded assumption here that every area
in CustomizableUI was of TYPE_TOOLBAR except for AREA_FIXED_OVERFLOW_PANEL, which
was manually spliced out of the area array when initting the toolbars after
DOMContentLoaded.

A later patch in this series is adding a new area of TYPE_MENU_PANEL, and
instead of also splicing that out of the area array in DOMContentLoaded,
we now make sure to only call registerToolbarNode on areas that are
actually toolbars.

Differential Revision: https://phabricator.services.mozilla.com/D161077
2022-11-08 14:51:39 +00:00
Mark Banner
18753bfe42 Bug 1798212 - Convert consumers of downloads code to ES modules. r=mak,geckoview-reviewers,extension-reviewers,settings-reviewers,credential-management-reviewers,sgalich,mconley,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D161013
2022-11-07 17:56:10 +00:00
Bernard Igiri
0213ab535b Bug 1785272 - Fix Fx View Button VO Announcement r=Gijs
Changed the aria role from tab to button to fix the VO announcement so that it correctly reports when the Fx View tab is actually selected.

Differential Revision: https://phabricator.services.mozilla.com/D159887
2022-11-07 07:07:20 +00:00
Neil Deakin
7997a24179 Bug 1676492, show the bookmarks toolbar when a new window is opened when the preference is set to show a blank page, r=Mardak,settings-reviewers
w

Differential Revision: https://phabricator.services.mozilla.com/D155003
2022-11-01 20:43:02 +00:00
Neil Deakin
e96d17d38c Bug 1676492, create a special blank tab page that will show the bookmarks toolbar when 'Only Show on New Tab' is used' even when the new tab page is disabled, r=Gijs,Mardak
Differential Revision: https://phabricator.services.mozilla.com/D154319
2022-11-01 20:43:01 +00:00
Kelly Cochrane
5a82125b6c Bug 1793088 - Make first available tab focusable when Fx View is open r=dao
Differential Revision: https://phabricator.services.mozilla.com/D159766
2022-11-01 15:45:45 +00:00
steven100695
a3f2b1c51f Bug 1788919 - Convert browser/components/migration JSM modules to ESMs. r=mconley,credential-management-reviewers,sgalich
Differential Revision: https://phabricator.services.mozilla.com/D158655
2022-10-27 23:52:49 +00:00
Noemi Erli
01a2d27871 Backed out 2 changesets (bug 1788919) for causing failures in browser_noLoginsView.js CLOSED TREE
Backed out changeset 2f03490ec72e (bug 1788919)
Backed out changeset 449aea6fc974 (bug 1788919)
2022-10-27 23:45:56 +03:00
steven100695
14e60b6839 Bug 1788919 - Convert browser/components/migration JSM modules to ESMs. r=mconley,credential-management-reviewers,sgalich
Differential Revision: https://phabricator.services.mozilla.com/D158655
2022-10-27 18:15:55 +00:00
Emilio Cobos Álvarez
b4e1c48671 Bug 1796972 - Fix popup container for webextension popups. r=Gijs
Depends on D160224

Differential Revision: https://phabricator.services.mozilla.com/D160225
2022-10-25 22:28:44 +00:00
Simon Friedberger
3c5991df13 Bug 1549057 - Rename (Gg)etCSP to (Gg)etCsp - r=freddyb
Differential Revision: https://phabricator.services.mozilla.com/D159268
2022-10-24 20:38:11 +00:00
Marian-Vasile Laza
51c683be62 Backed out changeset caddc49839d3 (bug 1793088) for causing bc failures on browser_firefoxview_tab.js. CLOSED TREE 2022-10-24 17:49:47 +03:00
Kelly Cochrane
22fba29900 Bug 1793088 - Make first available tab focusable when Fx View is open r=dao
Differential Revision: https://phabricator.services.mozilla.com/D159766
2022-10-24 12:32:44 +00:00
Henrik Skupin
1c61d460dc Bug 1533058 - [browser] Extend BrowserOpenTab to open a custom URL. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D159424
2022-10-24 07:46:15 +00:00
Tomislav Jovanovic
e82afd3462 Bug 1793629 - Implement attention indicator for the unified extensions button, r=willdurand
Differential Revision: https://phabricator.services.mozilla.com/D158938
2022-10-22 17:21:58 +00:00
Noemi Erli
9c4f5fd7bc Backed out changeset 0a1431ca8979 (bug 1793088) for causing failures browser_firefoxview_tab.js CLOSED TREE 2022-10-20 18:53:41 +03:00
Kelly Cochrane
80e600b519 Bug 1793088 - Make first available tab focusable when Fx View is open r=dao
Differential Revision: https://phabricator.services.mozilla.com/D159766
2022-10-20 14:43:31 +00:00
Cosmin Sabou
acc26cd06f Backed out changeset 27a859f55fdd (bug 1793629) for causing bc failures on browser_preferences_usage.js. 2022-10-19 02:34:23 +03:00
Tomislav Jovanovic
0975a1bceb Bug 1793629 - Implement attention indicator for the unified extensions button, r=willdurand
Differential Revision: https://phabricator.services.mozilla.com/D158938
2022-10-18 21:44:48 +00:00
Dana Keeler
04b2180978 Bug 1793841 - don't serialize securityInfo in browser_aboutCertError_exception.js r=pbz
This test only needs the bytes of the server certificate, not the entire
nsITransportSecurityInfo of the connection.

Differential Revision: https://phabricator.services.mozilla.com/D157994
2022-10-18 21:25:03 +00:00
Bernard Igiri
07dc284c09 Bug 1710092 - Back out workaround from bug 1708809 r=mconley
Backed out workaround from bug 1708809.

Differential Revision: https://phabricator.services.mozilla.com/D159331
2022-10-18 18:39:32 +00:00
Mark Banner
1b63e93005 Bug 1795370 - Add nsICrashReporter as an interface on nsAppRunner. r=gsvelto
This fixes ESLint issues raised by mozilla/valid-services-properties.
This also changes follow-on issues to use Services.appinfo rather than getService.

Differential Revision: https://phabricator.services.mozilla.com/D159461
2022-10-18 18:22:24 +00:00
James Teow
3c03da845b Bug 1788953 - Part 2: Use cached originalURI in setURI - r=adw
Depends on D157485

Differential Revision: https://phabricator.services.mozilla.com/D157486
2022-10-18 13:38:49 +00:00
Mark Banner
2ffde1e92f Bug 1792341 - Migrate more toolkit/modules consumers to use direct ES module import. r=Gijs,webdriver-reviewers,perftest-reviewers,necko-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,sgalich,owlish,bytesized,AlexandruIonescu,whimboo,mconley,mixedpuppy
Mainly automated changes. Some manual ESLint fixes and whitespace cleanup.

Differential Revision: https://phabricator.services.mozilla.com/D158452
2022-10-18 11:21:26 +00:00
Noemi Erli
5a21645f73 Backed out 2 changesets (bug 1793841) for causing Gtest failures CLOSED TREE
Backed out changeset 4d39c423b92e (bug 1793841)
Backed out changeset 5cfb5f595add (bug 1793841)
2022-10-18 04:29:44 +03:00
Dana Keeler
f37644a281 Bug 1793841 - don't serialize securityInfo in browser_aboutCertError_exception.js r=pbz
This test only needs the bytes of the server certificate, not the entire
nsITransportSecurityInfo of the connection.

Differential Revision: https://phabricator.services.mozilla.com/D157994
2022-10-18 00:18:08 +00:00
Cristian Tuns
b4150d1c6f Backed out changeset f8554e4080f2 (bug 1793629) for causing mochitest failures on browser_preferences_usage.js CLOSED TREE 2022-10-15 16:14:29 -04:00
Tomislav Jovanovic
670a479833 Bug 1793629 - Implement attention indicator for the unified extensions button, r=willdurand
Differential Revision: https://phabricator.services.mozilla.com/D158938
2022-10-15 19:05:26 +00:00
Norisz Fay
dd7b52f2f0 Backed out changeset c5a9bca461ce (bug 1793629) for causing multiple mochitest failures CLOSED TREE 2022-10-15 01:56:26 +03:00
Tomislav Jovanovic
f136f0b270 Bug 1793629 - Implement attention indicator for the unified extensions button, r=willdurand
Differential Revision: https://phabricator.services.mozilla.com/D158938
2022-10-14 21:03:23 +00:00
Narcis Beleuzu
d0f14ae8ef Backed out changeset 8140f297aa36 (bug 1710092) as req by Bernard. CLOSED TREE 2022-10-14 17:45:53 +03:00
Bernard Igiri
531fd9fb0c Bug 1710092 - Back out workaround from bug 1708809 r=mconley
Backed out workaround from bug 1708809.

Differential Revision: https://phabricator.services.mozilla.com/D159331
2022-10-14 14:13:47 +00:00
Bernard Igiri
8e4a1cef71 Bug 1784323 - Prevent hidden Firefox View tab from triggering the closing multiple tabs warning r=dao,Gijs
Updated the tab closing prompt logic to use the number of visible tabs open to determine if the prompt should show.

Differential Revision: https://phabricator.services.mozilla.com/D157965
2022-10-13 16:39:41 +00:00
Emilio Cobos Álvarez
e641646909 Bug 1794630 - Use resize*=sibling for searchbar container. r=dao
This simplifies the widget tracker code to avoid having to remove random
width attributes in all children.

Resize only the searchbar, since that's the only thing that's
effectively restored already on nightly.

Differential Revision: https://phabricator.services.mozilla.com/D159071
2022-10-13 15:01:20 +00:00
Sarah Clements
2b04f2ef7c Bug 1785853 - Close device connected tab after user returns to Firefox View r=sfoster
* Add _closeDeviceConnectedTab to FirefoxViewHandler that's called by the TabSelect event handler
* Add test coverage

Differential Revision: https://phabricator.services.mozilla.com/D158031
2022-10-12 16:39:39 +00:00
Norisz Fay
6e29272e17 Backed out changeset 9b1e2e6ceb70 (bug 1785853) for causing mochitest failures on browser_setup_state.js CLOSED TREE 2022-10-12 17:50:02 +03:00
Sarah Clements
ca8d94bc2d Bug 1785853 - Close device connected tab after user returns to Firefox View r=sfoster
* Add _closeDeviceConnectedTab to FirefoxViewHandler that's called by the TabSelect event handler
* Add test coverage

Differential Revision: https://phabricator.services.mozilla.com/D158031
2022-10-12 13:26:41 +00:00
Daisuke Akatsuka
1ae5e445bd Bug 1792971: Suppress popup notification while async tab switching. r=adw,zombie
Differential Revision: https://phabricator.services.mozilla.com/D158480
2022-10-11 00:10:26 +00:00
Masayuki Nakano
4ba9b4dd1c Bug 1792759 - part 1: Add nsIEditor.clearUndoRedo() to get rid of nsIEditor.transactionManager r=m_kato,NeilDeakin,Standard8
`nsIEditor.transactionManager` is used only for some simple purposes, however,
`nsIEditor` exposes the rich API.  That makes it harder to maintain internal
code around transactions.  Instead, `nsIEditor` exposes only simple and
necessary APIs.

This patch creates a new API to clear undo/redo history and make the users in
mozilla-central use it instead of using `nsITransactionManager.clear()`.

Differential Revision: https://phabricator.services.mozilla.com/D158336
2022-10-09 01:13:49 +00:00
Mark Banner
bbee5e7f3a Bug 1793414 - Move paste and search handling for the search bar into the search bar code itself. r=jteow
Differential Revision: https://phabricator.services.mozilla.com/D158499
2022-10-07 07:12:18 +00:00
Sandor Molnar
d416a7b827 Backed out 2 changesets (bug 1793414) for causing browser-chrome failures in browser/components/search/test/browser/browser_searchbar_context.js CLOSED TREE
Backed out changeset f27b2a93224e (bug 1793414)
Backed out changeset 1f011637d116 (bug 1793414)
2022-10-06 12:03:15 +03:00
Mark Banner
496c1718fa Bug 1793414 - Move paste and search handling for the search bar into the search bar code itself. r=jteow
Differential Revision: https://phabricator.services.mozilla.com/D158499
2022-10-06 07:44:51 +00:00
Alexandre Poirot
99b6c8357e Bug 1793573 - [devtools] Convert DevToolsSocketStatus.jsm to DevToolsSocketStatus.sys.mjs. r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D158572
2022-10-05 16:07:25 +00:00
Angel_V129
c74a074e42 Bug 1788756 - [Themes] Convert browser/theme JSM modules to ESMs. r=kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D157037
2022-10-04 19:02:24 +00:00
Niklas Baumgardner
14b904f207 Bug 1790855 - Enable screenshots button on about pages when screenshots component is enabled. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D157355
2022-10-04 13:23:19 +00:00
William Durand
7d12af981e Bug 1788994 - Fix test cases when the unifiedExtensions pref is enabled by default. r=rpl,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D157185
2022-10-04 08:45:57 +00:00
Sandor Molnar
fcb74829f6 Backed out changeset 45ea391514c0 (bug 1790855) for causing bc failures in browser_contextmenu CLOSED TREE 2022-10-04 06:41:48 +03:00