Commit graph

132 commits

Author SHA1 Message Date
Emily McMinn
86cbf9ecdd Bug 1886856 - Allow about:messagepreview to decode non-latin text r=omc-reviewers,dmose
Differential Revision: https://phabricator.services.mozilla.com/D205344
2024-03-28 16:26:14 +00:00
Punam Dahiya
87c4dca929 Bug 1859302 - NimbusRolloutMessageProvider should be listed as a generated file r=omc-reviewers,aminomancer
Patch invokes `import-rollouts` script that import Nimbus Rollout messages into NimbusRolloutMessageProvider.sys.mjs when running test using ` ./mach npm run test --prefix browser/components/asrouter`

Differential Revision: https://phabricator.services.mozilla.com/D205777
2024-03-27 22:12:31 +00:00
Cristina Horotan
e5d4d5bd18 Backed out changeset 4577a311fab7 (bug 1886856) for causing newtab failures at asrouter CLOSED TREE 2024-03-27 23:21:01 +02:00
Emily McMinn
4c8464fdd0 Bug 1886856 - Allow about:messagepreview to decode non-latin text r=omc-reviewers,dmose
Differential Revision: https://phabricator.services.mozilla.com/D205344
2024-03-27 20:00:04 +00:00
Norisz Fay
e3c2c6af1f Backed out changeset 66d93ead16c4 (bug 1886856) for causing node newtab failure in bundles CLOSED TREE 2024-03-27 21:08:57 +02:00
Emily McMinn
8f213d850b Bug 1886856 - Allow about:messagepreview to decode non-latin text r=omc-reviewers,dmose
Differential Revision: https://phabricator.services.mozilla.com/D205344
2024-03-27 17:19:10 +00:00
Jason Prickett
75050b93a2 Bug 1876173 - Add attribute to allow RDM to be disabled for aboutwelcome spotlight r=omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D201902
2024-03-25 23:05:05 +00:00
Emily McMinn
cd13a6c923 Bug 1887066 - Reformat schema files in ASRouter r=barret,omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D205470
2024-03-25 15:07:52 +00:00
Emily McMinn
079ff41016 Bug 1724300 - Remove What's New Panel, ToolbarPanelHub components & related tests & references r=desktop-theme-reviewers,omc-reviewers,aminomancer,pdahiya,emilio,devtools-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D201867
2024-03-21 22:05:28 +00:00
Mark Banner
23a339fc7c Bug 1885723 - Fix more jsm references in browser/. r=Gijs,credential-management-reviewers,omc-reviewers,aminomancer,mtigley
Differential Revision: https://phabricator.services.mozilla.com/D204843
2024-03-19 22:08:29 +00:00
Mark Banner
1bb7ccda05 Bug 1881816 - Rename ActorConstants.sys.mjs to ActorConstants.mjs. r=amy,omc-reviewers,aminomancer
This better reflects the file is being accessed from both content and system scopes.

Differential Revision: https://phabricator.services.mozilla.com/D203401
2024-03-19 17:01:38 +00:00
Mark Banner
d1d1eca18d Bug 1881816 - Rename Actions.sys.mjs to Actions.mjs. r=amy,omc-reviewers,aminomancer
This better reflects the file is being accessed from both content and system scopes.

Differential Revision: https://phabricator.services.mozilla.com/D203400
2024-03-19 17:01:37 +00:00
scottdowne
608254ba8f Bug 1882830 - Home and newtab adding message variants for sponsored content. r=nbarrett
Differential Revision: https://phabricator.services.mozilla.com/D203297
2024-03-15 06:50:09 +00:00
Natalia Csoregi
0bcdbff582 Backed out changeset 4707e617d389 (bug 1876173) for causing newtab failures on aboutwelcome. CLOSED TREE 2024-03-14 00:38:01 +02:00
Jason Prickett
15df8fdca5 Bug 1876173 - Add attribute to allow RDM to be disabled for aboutwelcome spotlight r=omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D201902
2024-03-13 21:28:06 +00:00
Natalia Csoregi
b3b324182c Backed out changeset d488b0a57d95 (bug 1876173) for causing fxms failures. CLOSED TREE 2024-03-13 21:17:52 +02:00
Jason Prickett
115ad6c443 Bug 1876173 - Add attribute to allow RDM to be disabled for aboutwelcome spotlight r=omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D201902
2024-03-13 18:23:44 +00:00
Mark Banner
f4ce4f5c95 Bug 1885041 - Expand disallowing JSM based imports via ESLint to everything except for devtools. r=arai,omc-reviewers,aminomancer,zombie
Differential Revision: https://phabricator.services.mozilla.com/D204441
2024-03-13 17:38:28 +00:00
Jason Prickett
0656e54e74 Bug 1882662 - Add checkDefaultBrowser pref check to fox doodle message targeting r=omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D204268
2024-03-11 19:42:05 +00:00
Mark Banner
9fe8bde13c Bug 1884623 - Update more jsm references in production code and docs in browser/. r=mossop,extension-reviewers,omc-reviewers,migration-reviewers,robwu,mconley,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D204182
2024-03-11 15:26:28 +00:00
Punam Dahiya
7772ab2d99 Bug 1877210 - Remove unused asrouter components r=omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D204122
2024-03-08 23:06:14 +00:00
hanna alemu
27955f6b8b Bug 1877788 - Record reach for all messaging experiment features r=omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D203829
2024-03-08 16:51:20 +00:00
Shane Hughes
d5888b2c7b Bug 1775847 - Fix Glean timeout in browser_asrouter_cfr.js. r=omc-reviewers,pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D202078
2024-03-07 19:03:28 +00:00
negin
b8931ee527 Bug 1878072 - Increase karma.mc branch coverage to 80 percent r=omc-reviewers,dmose
Differential Revision: https://phabricator.services.mozilla.com/D202631
2024-03-07 19:00:18 +00:00
Mark Banner
4f1d29d324 Bug 1883371 - Enable ESLint rule no-console on production code. r=mossop,webcompat-reviewers,devtools-reviewers,omc-reviewers,twisniewski,nchevobbe,aminomancer
Allow for console.error, console.warn and console.createInstance, but fail for everything else.

Differential Revision: https://phabricator.services.mozilla.com/D203456
2024-03-05 16:56:57 +00:00
Dave Townsend
1fe4db4a69 Bug 1864896: Autofix unused function arguments (browser/components/newtab). r=omc-reviewers,aminomancer,thecount
Differential Revision: https://phabricator.services.mozilla.com/D202950
2024-03-03 09:09:08 +00:00
Punam Dahiya
ef18155aa8 Bug 1879638 - Update Old references to asrouter and aboutwelcome files r=omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D203330
2024-03-02 02:36:24 +00:00
negin
718fd74a85 Bug 1877557 - Extra configurations for LinkParagraph component for about:welcome r=omc-reviewers,emcminn,pdahiya
Adds styling for legal copy and updates above_button_config so it renders after tiles/MultiSelect but before action buttons.

Differential Revision: https://phabricator.services.mozilla.com/D200078
2024-03-01 21:03:23 +00:00
Natalia Csoregi
96b1b25a39 Backed out 2 changesets (bug 1864896) for causing node failures. CLOSED TREE
Backed out changeset adba0b352699 (bug 1864896)
Backed out changeset 153146ce081c (bug 1864896)
2024-03-01 18:25:05 +02:00
Dave Townsend
c7318b4cf2 Bug 1864896: Autofix unused function arguments (browser/components/newtab). r=omc-reviewers,aminomancer,thecount
Differential Revision: https://phabricator.services.mozilla.com/D202950
2024-03-01 15:20:17 +00:00
Iulian Moraru
97fd2dad96 Backed out 5 changesets (bug 1864896) for causing newtab failures related to bundles. CLOSED TREE
Backed out changeset 2cd1cc279f99 (bug 1864896)
Backed out changeset e48d6928bdcb (bug 1864896)
Backed out changeset 1abbcaf91693 (bug 1864896)
Backed out changeset 06a05e5257d5 (bug 1864896)
Backed out changeset b1955ae3e9e2 (bug 1864896)
2024-03-01 12:58:03 +02:00
Dave Townsend
f4705b2208 Bug 1864896: Autofix unused function arguments (browser/components/newtab). r=omc-reviewers,aminomancer,thecount
Differential Revision: https://phabricator.services.mozilla.com/D202950
2024-03-01 10:10:08 +00:00
Shane Hughes
f197e62f41 Bug 1881106 - Move ModalOverlay.test.jsx to newtab directory. r=omc-reviewers,negin
Differential Revision: https://phabricator.services.mozilla.com/D202255
2024-02-27 18:52:20 +00:00
Shane Hughes
1db9e8ef32 Bug 1879655 - Fix microsurvey group structure, a11y, and randomization. r=omc-reviewers,emcminn
Change how microsurveys are structured. This ensures that screen readers
perceive a single logical collection, which contains all the radio
buttons and is labeled by the question, which is no longer defined by
subtitle but by tiles.label. This also changes how survey randomization
works. Instead of randomizing the entire set, we randomize specific
items. Any adjacent items with randomize will be randomized in-place. So
if there are 4 items with randomize, followed by 1 nonrandom item, the 4
will be randomized but the 5th will stay at the bottom. Finally, this
patch saves the randomized order so that it persists between back and
forward navigation on about:welcome. That should avoid some jank if we
show surveys in about:welcome.

Differential Revision: https://phabricator.services.mozilla.com/D202513
2024-02-27 03:29:29 +00:00
Mark Banner
fa86f5170e Bug 1881265 - Enable ESLint recommended rule getter-return. r=mossop,extension-reviewers,devtools-reviewers,omc-reviewers,nchevobbe,aminomancer,robwu
Differential Revision: https://phabricator.services.mozilla.com/D202318
2024-02-26 11:35:40 +00:00
Mark Banner
5b9b9f7203 Bug 1881901 - Update asrouter/aboutwelcome to use latest node_modules to fix issues building with node 18. r=aminomancer,omc-reviewers
An out-of-date webpack was causing the issue, but updating generally is probably a good idea.

Differential Revision: https://phabricator.services.mozilla.com/D202656
2024-02-24 12:21:20 +00:00
Mark Banner
6a15dea4e8 Bug 1881573 - Drop use of ESLint rule max-depth from newtab/asrouter/aboutwelcome. r=pdahiya,thecount,Gijs,devtools-reviewers,omc-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D202474
2024-02-24 10:04:46 +00:00
Mark Banner
c1641790d9 Bug 1881817 - Move all asrouter/content-src/*.js files which are modules to use .mjs extensions. r=aminomancer,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D202622
2024-02-24 10:00:59 +00:00
Mark Banner
fb52e933e4 Bug 1881819 - Remove now redundant inject-loader from asrouter/aboutwelcome/newtab code. r=aminomancer,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D202621
2024-02-24 10:00:58 +00:00
Mark Banner
25ccfc2279 Bug 1881818 - Remove various modules from asrouter/aboutwelcome/newtab as they are now unused. r=aminomancer,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D202620
2024-02-24 10:00:58 +00:00
Mike Conley
cbbf040ffb Bug 1878783 - Retire babel-jsm-to-commonjs since browser JSMs are gone now. r=Standard8,omc-reviewers,emcminn
Differential Revision: https://phabricator.services.mozilla.com/D201828
2024-02-15 21:30:05 +00:00
Nick Alexander
2814902b49 Bug 1868676 - Part 1: Allow snapshots of multiple contexts. r=barret,omc-reviewers,aminomancer
`ASRouterTargeting` does _not_ include the experiment details that
supply `activeExperiments`, `activeRollouts`, etc.  Those are combined
from additional contexts.  This patch makes it easy to do that
combination.

N.b.: the use of `Proxy` instances makes iteration tricky, so we avoid
it entirely.

Differential Revision: https://phabricator.services.mozilla.com/D200124
2024-02-14 21:31:19 +00:00
Jason Prickett
5535557e05 Bug 1879390 - Add screen ID to fox doodle r=omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D201750
2024-02-14 01:13:23 +00:00
Shane Hughes
a53c204f88 Bug 1877995 - Move feature callout dismiss button so the tab order makes more sense. r=omc-reviewers,negin
Differential Revision: https://phabricator.services.mozilla.com/D200714
2024-02-13 23:26:16 +00:00
Mike Conley
79b7216c91 Bug 1878731 - Make it so that ResourceUriPlugin can do multiple path replacements. r=Standard8,omc-reviewers,emcminn
Differential Revision: https://phabricator.services.mozilla.com/D201139
2024-02-12 18:49:38 +00:00
Mike Conley
24da9bffd2 Bug 1878731 - Convert ASRouter to an ESM. r=emcminn,pip-reviewers,fxview-reviewers,omc-reviewers,sfoster,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D201138
2024-02-12 18:49:38 +00:00
Mike Conley
5ab28b68b9 Bug 1878731 - Convert ASRouterPreferences to an ESM. r=emcminn,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D201134
2024-02-12 18:49:37 +00:00
Mike Conley
3e82da1fda Bug 1878731 - Convert ASRouterTargeting to an ESM. r=emcminn,application-update-reviewers,omc-reviewers,bytesized
Differential Revision: https://phabricator.services.mozilla.com/D201133
2024-02-12 18:49:37 +00:00
Mike Conley
78b1c85ec9 Bug 1878731 - Convert ASRouterTriggerListeners to an ESM. r=emcminn,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D201129
2024-02-12 18:49:36 +00:00
Mike Conley
24defeb8da Bug 1878731 - Convert ASRouterDefaultConfig to an ESM. r=emcminn,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D201128
2024-02-12 18:49:36 +00:00