nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity
834609 commits 1 branch 98 tags 6.4 GiB
Commit graph

166 commits

Author SHA1 Message Date
Mark Banner
3a07fcf436 Bug 1806503 - Automatically replace Cu.reportError with console.error (browser/actors, browser/base). r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D165068
 2022-12-27 10:08:58 +00:00
Emilio Cobos Álvarez
13572bce66 Bug 1788273 - Tweak popup alignment so that it looks good on mirrored wayland popups. r=dao,mak 
When these panels had arrows, I guess the bottomcenter topleft alignment
made sense so that you could precisely align the arrow, but that's not
what we do now.

Don't use bottomcenter / leftcenter / rightcenter, since we really want
the sides to align.

This shouldn't change behavior on any platform except Linux + Wayland,
where the alignment looks good now in the case of bug 1784876.

Differential Revision: https://phabricator.services.mozilla.com/D156099
 2022-09-02 20:26:29 +00:00
Butkovits Atila
c520b707bd Backed out changeset 368a7ce1b104 (bug 1788273) for causing failures at browser_recently_closed_tabs.js. CLOSED TREE 2022-09-02 16:35:55 +03:00
Emilio Cobos Álvarez
0777329f69 Bug 1788273 - Tweak popup alignment so that it looks good on mirrored wayland popups. r=dao,mak 
When these panels had arrows, I guess the bottomcenter topleft alignment
made sense so that you could precisely align the arrow, but that's not
what we do now.

Don't use bottomcenter / leftcenter / rightcenter, since we really want
the sides to align.

This shouldn't change behavior on any platform except Linux + Wayland,
where the alignment looks good now in the case of bug 1784876.

Differential Revision: https://phabricator.services.mozilla.com/D156099
 2022-09-02 11:18:54 +00:00
Mark Banner
5a872b77c5 Bug 1779981 - Migrate search consumers to use ESM imports directly. r=mcheang,preferences-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D152001
 2022-07-19 17:12:43 +00:00
Harry Twyford
a639abe1b3 Bug 1706479 - Simplify page action style rules. r=desktop-theme-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D114642
 2021-07-13 15:03:19 +00:00
Gijs Kruitbosch
a9281aec97 Bug 1711519 - remove trivial gProton and gProtonDoorhangers checks, r=jaws 
Differential Revision: https://phabricator.services.mozilla.com/D116630
 2021-06-03 11:41:54 +00:00
Gijs Kruitbosch
cd50b177a7 Bug 1711523 - remove private proton tracking flags in frontend modules, r=mak,emalysz,desktop-theme-reviewers,harry 
Differential Revision: https://phabricator.services.mozilla.com/D116009
 2021-05-28 19:33:38 +00:00
Harry Twyford
a06f041cc3 Bug 1706479 - Wrap page action icons in an hbox. r=morgan,adw 
To resolve this bug, we need page action icons and semantic page action nodes to be separate. That way, we can apply filters to the icons without also filtering the nodes' outlines. This means the semantic meaning of the page action button must move up a level, to the enclosing hbox. This means reverting bug 1482025, so I'd like a11y review on this patch.

Differential Revision: https://phabricator.services.mozilla.com/D114131
 2021-05-19 20:37:19 +00:00
Csoregi Natalia
d7ca7f4485 Backed out changeset e90263d64998 (bug 1706479) for failures on browser_parsable_css.js. CLOSED TREE 2021-05-18 18:21:47 +03:00
Harry Twyford
8cb8e99863 Bug 1706479 - Wrap page action icons in an hbox. r=morgan,adw 
To resolve this bug, we need page action icons and semantic page action nodes to be separate. That way, we can apply filters to the icons without also filtering the nodes' outlines. This means the semantic meaning of the page action button must move up a level, to the enclosing hbox. This means reverting bug 1482025, so I'd like a11y review on this patch.

Differential Revision: https://phabricator.services.mozilla.com/D114131
 2021-05-18 13:33:06 +00:00
Dão Gottwald
725e4d8466 Bug 1701306 - Remove custom code setting the "open" attribute on panel anchors. r=mconley 
Differential Revision: https://phabricator.services.mozilla.com/D110817
 2021-04-14 13:57:34 +00:00
Harry Twyford
4c430fb4a6 Bug 1704474 - Remove pin/unpin page action context menu items. r=adw,fluent-reviewers,extension-reviewers,flod,zombie 
The bug calls for these items to be hidden with JS, but they were going to be removed anyways post-Proton. The removal of some subtests in browser/base/content/test/pageActions tests is consistent with [this comment](https://searchfox.org/mozilla-central/rev/d9f6cded535d202a9ade4a530e653e659bcb5bbd/browser/base/content/test/pageActions/browser.ini#7), which says that were are removing that test coverage post-Proton anyways.

Differential Revision: https://phabricator.services.mozilla.com/D111713
 2021-04-13 13:24:59 +00:00
Marco Bonardo
3271b9d803 Bug 1702034 - Extension buttons in the location bar are very hard to see with the Proton Dark theme. r=harry,desktop-theme-reviewers,rpl 
Differential Revision: https://phabricator.services.mozilla.com/D111422
 2021-04-12 15:42:15 +00:00
Luca Greco
1bdc1299b6 Bug 1703889 - Ensure hidden extension pageAction are not visible in the urlbar overflow menu on Proton. r=mixedpuppy,mak 
Differential Revision: https://phabricator.services.mozilla.com/D111423
 2021-04-12 12:06:59 +00:00
Marco Bonardo
2c982d3c01 Bug 1703274 - Enable Proton Urlbar. r=jaws,extension-reviewers,zombie,rpl 
Differential Revision: https://phabricator.services.mozilla.com/D110998
 2021-04-09 18:20:21 +00:00
Cosmin Sabou
13826a4c50 Backed out changeset bd396182f84a (bug 1703274) for causing wpt failures on shape-outside-shape-arguments-000.html. CLOSED TREE 2021-04-09 17:51:48 +03:00
Marco Bonardo
af19ef5dc4 Bug 1703274 - Enable Proton Urlbar. r=jaws,extension-reviewers,zombie,rpl 
Differential Revision: https://phabricator.services.mozilla.com/D110998
 2021-04-09 11:05:17 +00:00
smolnar
6524a17cb9 Backed out changeset 034a69e0a73e (bug 1701306) for causing browser-chrome failures in browser_page_action_menu. CLOSED TREE 2021-04-08 17:16:21 +03:00
Dão Gottwald
ce1716242b Bug 1701306 - Remove custom code setting the "open" attribute on panel anchors. r=mconley 
Differential Revision: https://phabricator.services.mozilla.com/D110817
 2021-04-08 12:53:08 +00:00
Edgar Chen
9dc32348bb Bug 1677334 - Part 3: Remove Mac-specific check for click event; r=Gijs 
Now we won't dispatch click event at all when ctrl key is pressed on Mac, so we
don't need those Mac-specific checks.

This patch reverts part of https://hg.mozilla.org/mozilla-central/rev/69785d2dfbf2
and revise the tests accordingly.

Differential Revision: https://phabricator.services.mozilla.com/D110609
 2021-04-07 11:23:46 +00:00
Alexandru Michis
8c30456526 Backed out changeset 8d8aa8575c1d (bug 1701306) for causing multiple bc failures. 
CLOSED TREE
 2021-04-06 19:45:27 +03:00
Dão Gottwald
53e4be34d5 Bug 1701306 - Remove custom code setting the "open" attribute on panel anchors. r=mconley 
Differential Revision: https://phabricator.services.mozilla.com/D110817
 2021-04-06 13:22:50 +00:00
Marco Bonardo
c304d1cd46 Bug 1691454 - Hide the Page actions overflow (meatball) menu from the address bar. r=adw 
The page actions menu is normally hidden.
When the window is smaller than a threshold, and there's more than one action,
the single actions are hidden while the menu is shown. This allows for a nicer
overflow experience.

This patch introduces a pageActions-proton test folder where we'll move proton
tests temporarily. The head.js file is just a copy of the original one, we'll
clean it up in bug 1700582 after porting the other tests.

Differential Revision: https://phabricator.services.mozilla.com/D109606
 2021-03-24 23:19:14 +00:00
Marco Bonardo
4819ead6eb Bug 1700364 - Page action buttons should not be remove-able in Proton. r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D109519
 2021-03-24 09:48:45 +00:00
Drew Willcoxon
f0fcc77c53 Bug 1697191 - Remove remaining built-in page actions when Proton is enabled. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D107763
 2021-03-12 20:48:30 +00:00
Micah Tigley
78b48e4781 Bug 1690569 - Replace sync's isSendableURI checks with BrowserUtils.isShareableURL. r=markh 
Depends on D104558

Differential Revision: https://phabricator.services.mozilla.com/D105640
 2021-02-25 02:51:04 +00:00
Dave Townsend
2459f40c64 Bug 1682593: Remove the site specific browser feature. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D101860
 2021-01-15 11:11:19 +00:00
Emma Malysz
4ddaa9986e Bug 1634042, Part 2: lazify page action panel r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D91187
 2020-10-06 00:40:51 +00:00
Dorel Luca
f348e0a63d Backed out changeset d4c1abcfbba0 (bug 1634042) for Browser-chrome failures in browser/base/content/test/touch/browser_menu_touch.js. CLOSED TREE 2020-10-02 02:50:31 +03:00
Emma Malysz
7fb79b4804 Bug 1634042, Part 2: lazify page action panel r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D91187
 2020-10-01 15:00:55 +00:00
Csoregi Natalia
f21850ca45 Backed out changeset 0798aa08c2cb (bug 1634042) for failures on browser_menu_touch.js. CLOSED TREE 2020-09-30 09:47:33 +03:00
Emma Malysz
254dec264a Bug 1634042, Part 2: lazify page action panel r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D91187
 2020-09-29 22:09:09 +00:00
Emma Malysz
f73e3431ed Bug 1634042, Part 1: migrate page action titles to fluent. r=Gijs,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D87822
 2020-09-24 17:29:16 +00:00
Mark Banner
02ae3b9de6 Bug 863474 - Centralise OpenSearch install failure prompts into SearchUIUtils. r=daleharvey,flod,geckoview-reviewers,esawin 
Differential Revision: https://phabricator.services.mozilla.com/D89879
 2020-09-14 11:08:43 +00:00
Razvan Maries
e3020a8f57 Backed out 2 changesets (bug 863474) for build bustages on search.properties. CLOSED TREE 
Backed out changeset 5f00eaaa4e2d (bug 863474)
Backed out changeset 42d66b1f9b82 (bug 863474)
 2020-09-12 19:41:12 +03:00
Mark Banner
d1abbfeaf8 Bug 863474 - Centralise OpenSearch install failure prompts into SearchUIUtils. r=daleharvey,flod 
Differential Revision: https://phabricator.services.mozilla.com/D89879
 2020-09-12 14:57:34 +00:00
Mark Banner
e70637b6d9 Bug 1632448 - Remove now unused confirm and extensionID parameters for nsISearchService.addEngine, and rename it. r=daleharvey 
Renaming to addOpenSearchEngine to make it more explicit about what it is actually doing.

Depends on D82524

Differential Revision: https://phabricator.services.mozilla.com/D82525
 2020-07-09 09:56:25 +00:00
Dave Townsend
e07f989e6c Bug 1620358: Gather telemetry on toolbar state. r=Gijs,zombie 
Differential Revision: https://phabricator.services.mozilla.com/D78393
 2020-06-16 21:06:15 +00:00
pbz
cd0b28883f Bug 1615588 - pageActions: Use prompt service instead of nsIPrompt. r=johannh 
Differential Revision: https://phabricator.services.mozilla.com/D66448
 2020-04-16 14:44:33 +00:00
Csoregi Natalia
954b969608 Backed out 5 changesets (bug 1615588) for browser-chrome failures e.g. browser_beforeunload_duplicate_dialogs.js. CLOSED TREE 
Backed out changeset 751cca7566a8 (bug 1615588)
Backed out changeset 474aca043834 (bug 1615588)
Backed out changeset 7839b95ef76c (bug 1615588)
Backed out changeset 32bb87f48b13 (bug 1615588)
Backed out changeset 264e642042b1 (bug 1615588)

--HG--
extra : rebase_source : 41ed149c97382bc1cf823abc56811b382cae0207
 2020-04-10 21:19:15 +03:00
pbz
ff02656f6f Bug 1615588 - pageActions: Use prompt service instead of nsIPrompt. r=johannh 
Differential Revision: https://phabricator.services.mozilla.com/D66448

--HG--
extra : moz-landing-system : lando
 2020-04-10 16:45:12 +00:00
William Durand
b90b5b3778 Bug 1489430 - Add "Remove Extension" context menu item for pageAction. r=robwu,mstriemer,fluent-reviewers,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D69831

--HG--
extra : moz-landing-system : lando
 2020-04-08 14:18:53 +00:00
Edgar Chen
e2aca2c26d Bug 1615732 - Don't handle click event on Mac when ctrl key is pressed; r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D68775

--HG--
extra : moz-landing-system : lando
 2020-04-06 20:56:14 +00:00
Edgar Chen
a32ab22c8c Bug 1615732 - Don't show page action panel on Mac when ctrl key is pressed; r=Gijs 
On Mac, ctrl-click will send a context menu event from the widget, so we don't
want to bring up the panel when ctrl key is pressed.

Differential Revision: https://phabricator.services.mozilla.com/D66384

--HG--
extra : moz-landing-system : lando
 2020-04-06 20:56:26 +00:00
Cosmin Sabou
3b3f1af25e Backed out 7 changesets (bug 1615732) for bc failures on browser_ext_pageAction_click_types.js. CLOSED TREE 
Backed out changeset 031b8abf43a8 (bug 1615732)
Backed out changeset 297d82b338dc (bug 1615732)
Backed out changeset bbcb173e6c44 (bug 1615732)
Backed out changeset d7c5824d4579 (bug 1615732)
Backed out changeset f648cf0653a7 (bug 1615732)
Backed out changeset fcd441a2a860 (bug 1615732)
Backed out changeset fa861e50f198 (bug 1615732)

--HG--
extra : histedit_source : 16a05a43f3a9666c4fcf244062c28a5dc81061fd
 2020-04-06 23:49:58 +03:00
Edgar Chen
0de61803a3 Bug 1615732 - Don't handle click event on Mac when ctrl key is pressed; r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D68775

--HG--
extra : moz-landing-system : lando
 2020-03-30 12:53:42 +00:00
Edgar Chen
feb7fe3776 Bug 1615732 - Don't show page action panel on Mac when ctrl key is pressed; r=Gijs 
On Mac, ctrl-click will send a context menu event from the widget, so we don't
want to bring up the panel when ctrl key is pressed.

Differential Revision: https://phabricator.services.mozilla.com/D66384

--HG--
extra : moz-landing-system : lando
 2020-03-13 17:42:04 +00:00
Drew Willcoxon
ae8bef8c20 Bug 1619228 - Prevent the context menu from opening on separators in the page action panel. r=Gijs 
Separators are technically actions, so we should ignore them when deciding whether to open the context menu.

Differential Revision: https://phabricator.services.mozilla.com/D65050

--HG--
extra : moz-landing-system : lando
 2020-03-03 13:39:35 +00:00
Marco Bonardo
8e3ea27643 Bug 1612653 - Update 'Bookmark This Page' menuitems when the star state changes. r=Standard8 
Instead of updating the Bookmark This Page / Edit Bookmark menuteitems on popupshowing,
update them when the star button is suppposed to change. This better supports MacOS behavior
where the native menubar can't be updated after being shown, and avoids many callpoints in
favor of just a few.

Differential Revision: https://phabricator.services.mozilla.com/D64399

--HG--
extra : moz-landing-system : lando
 2020-02-27 12:04:15 +00:00