Done mostly automatically via find/replace following the conversions
specified here:
https://groups.google.com/a/mozilla.org/g/firefox-dev/c/9sGpF1TNbLk/m/QpU3oTUuAgAJ
For the most part I think the "flex: N N" usage could be simplified to
just "flex: N", but I wanted to preserve behavior (-moz-box-flex sets
both flex-grow and flex-shrink).
I changed legacy layout to also look at the order property rather than
-moz-box-ordinal-group because it made splitters and treecols easier (we
don't need to deal with both orders).
Differential Revision: https://phabricator.services.mozilla.com/D171715
Done mostly automatically via find/replace following the conversions
specified here:
https://groups.google.com/a/mozilla.org/g/firefox-dev/c/9sGpF1TNbLk/m/QpU3oTUuAgAJ
For the most part I think the "flex: N N" usage could be simplified to
just "flex: N", but I wanted to preserve behavior (-moz-box-flex sets
both flex-grow and flex-shrink).
I changed legacy layout to also look at the order property rather than
-moz-box-ordinal-group because it made splitters and treecols easier (we
don't need to deal with both orders).
Differential Revision: https://phabricator.services.mozilla.com/D171715
I have fixed the underlying XPConnect issue, so these workarounds should
no longer be needed.
There are also two more in browser/base/content/browser-siteProtections.js
that I have not fixed.
Differential Revision: https://phabricator.services.mozilla.com/D158158
In the regressing change part of Bug 1755181 (https://hg.mozilla.org/mozilla-central/rev/00c77cbfd73a),
SidebarUI observes "intl:app-locales-changed" and calls `SidebarUI.hide` and `SidebarUI._show(this.lastOpenedId)`
if the sidebar was open, that is enough to correctly refresh sidebar panels part of the browser but it is missing
the additional call to `SidebarUI._loadSidebarExtension(commandID)` that both `SidebarUI.show` and `SidebarUI.showInitially`
call once `SidebarUI._show(...)` promise is resolved.
This patch includes a new test case to explicitly cover the behavior expected on extension sidebar panels
(added to browser_sidebar_app_locale_changed.js along with the tests covering the expected behavior for
the browser integrated sidebars) and replaces the call to `SidebarUI._show(...)` with a call to `SidebarUI.showInitially`
(mainly because the associated jsdoc inline comments explicitly states that showInitially is intended to be used
when the sidebar is opened automatically and not triggered by a user interaction with the sidebar UI, which seems
to fit better then show for this particular case).
Differential Revision: https://phabricator.services.mozilla.com/D155575
This patch adds a CSS rule to override rules that set background-color on
"checked" toolbar buttons, while in customize mode. Because the checked state is
no longer visible in customize mode (which mainly affects the sidebar toggle
widget), we could use the Accel+B hotkey to hide or show the sidebar without any
visual feedback, potentially causing confusion.
So this patch also adds a check for customize mode in SidebarUI.toggle(). It
might be more sophisticated to wrap the method in a command element that can be
updated by CustomizeMode.jsm, and link the key elements to that command, so it
only impacts the shortcuts. But for now I think a more minimal change is fine.
Also add a test to confirm that the above works correctly.
Differential Revision: https://phabricator.services.mozilla.com/D139625
This also fixes unintended behavior for which clicking the selected item in the sidebar selector would hide the sidebar.
Differential Revision: https://phabricator.services.mozilla.com/D3145
--HG--
extra : rebase_source : 891c99ab68f4689513801a1957a3d3846b7ffe58
The immediate goal is only to remove the broadcasters, so we still require the labels to be set manually on the "toolbarbutton" and "menuitem" elements. Generating these elements programmatically from the new SidebarUI.sidebars object, both for built-in sidebars and extensions, can be a future improvement.
The autoCheck attribute is also unnecessary since it is only intended for the menu items, and they are already properly updated after their command is invoked. Since the attribute was written with the wrong capitalization, it already had no effect.
The persistence of the label of the sidebar selector is also unnecessary since it is already set on startup. Removing this does not seem to cause any additional flickering.
Differential Revision: https://phabricator.services.mozilla.com/D3143
--HG--
extra : rebase_source : a5712b8e9bbdea29ab9e9a1bbd93217b24c354b4
This allows the JS to work in HTML documents, where whitespace is preserved. In XUL
documents, whitespace is ignored when parsing so text nodes are generally not returned.
The following changes were made, with manual cleanups as necessary (i.e. when firstChild actually
refers to a text node, or when firstChild is used in a loop to empty out an element):
firstChild->firstElementChild
lastChild->lastElementChild
nextSibling->nextElementSibling
previousSibling->previousElementSibling
childNodes->children
MozReview-Commit-ID: 95NQ8syBhYw
--HG--
extra : rebase_source : 186d805f7a2a56694dda9032aceac2dfe5424753
This lets us use Services.xulStore instead of requiring
Cc["@mozilla.org/xul/xulstore;1"].getService(Ci.nsIXULStore);
MozReview-Commit-ID: 2eXifCPhlGs
--HG--
extra : rebase_source : c65b9395cc192d05d1a348cfbf92f7f59d41dc8f
If the sidebar is being opened during startup (either at delayedLoad or when being
adopted from another window), we don't want sidebar panels to steal focus from the page
MozReview-Commit-ID: 4mBP2dQdyKY
--HG--
extra : rebase_source : 1349ddcac55fc7bf7e02ff410e6d49d1c03facb3
