nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity
585845 commits 1 branch 98 tags 6.4 GiB
Commit graph

440 commits

Author SHA1 Message Date
Brendan Dahl
8a6f97c45c Bug 1442302 - Remove placesOverlay.xul. r=Gijs,mak,standard8 
The overlay was responsible for script loading and defining three elements
(bhTooltip, placesCommands, placesContext). In the majority of places where
the overlay was included only part of it was used. To remove the overlay, the
elements were each split into include files and moved into where they
were used. For the scripts, a JS file was added that defines all the lazy
modules and then this script, globalOverlay.js and utilityOverlay.js were
inlined to everywhere that would have included them from the overlay.

MozReview-Commit-ID: 8T5D46oYWLn

--HG--
rename : browser/components/places/content/placesOverlay.xul => browser/components/places/content/placesCommands.inc.xul
rename : browser/components/places/content/placesOverlay.xul => browser/components/places/content/placesContextMenu.inc.xul
extra : rebase_source : c1071af4ea264a95183cbc65caae98feb23d58e5
 2018-03-12 10:43:35 -07:00
manikishan
92de2db258 Bug 1431050 - Replace NS_ASSERT with conditional exceptions/console.assert and remove the debug.js module. r=mak 
console.assert keeps the same semantics as NS_ASSERT in that it doesn't throw an exception,
but a lot of the places code was using it in a way that would be better served by throwing
an exception when the condition is false.

MozReview-Commit-ID: DEF5HSfYO36
 2018-02-03 11:32:25 +05:30
Michael Kaply
b7a354c792 Bug 1432355 - Add a policy to disable private browsing. r=Gijs 
MozReview-Commit-ID: AprbL6usEv5

--HG--
extra : rebase_source : d0a9255aae8b8d038c69978cbeabbfc394ad46cd
 2018-03-01 10:20:38 -06:00
Marco Bonardo
039ea5e750 Bug 1439315 - 6 - Move some utils into PlacesController or PlacesUIUtils. r=standard8 
MozReview-Commit-ID: D7J6hY7Akro

--HG--
extra : rebase_source : 9e9f885db98c72a857c941b2eb6b8a294d1b570e
 2018-02-28 13:51:28 +01:00
Marco Bonardo
66361b299d Bug 1439315 - 5 - defineLazyScriptGetter controller.js. r=standard8 
MozReview-Commit-ID: 4Kq3XvJNNGB

--HG--
extra : rebase_source : a72bbdee84965d716b14d5ddbb020579cdc83f8c
 2018-02-28 12:31:37 +01:00
Marco Bonardo
19f9286fc5 Bug 1439315 - 3 - Don't use NetUtil.newURI. r=standard8 
MozReview-Commit-ID: 58jYURt7EWF

--HG--
extra : rebase_source : e215b0a8890b3dc2169d82fbf63ba2fba4e65b4f
 2018-02-28 12:28:54 +01:00
Marco Bonardo
a49f4669c5 Bug 1439315 - 2 - Move command utils to PlacesUIUtils. r=standard8 
MozReview-Commit-ID: 6hN9LxVQunX

--HG--
extra : rebase_source : 7dacee00aecf5cfb00a6977a88ecea5334958022
 2018-02-28 12:27:21 +01:00
Marco Bonardo
388f9e4090 Bug 1439315 - 1 - rename InsertionPoint to PlacesInsertionPoint. r=standard8 
MozReview-Commit-ID: 1NfkueEUPXC

--HG--
extra : rebase_source : 9e3e6f58742a0900fdd73e6c5ed5089f7d01da63
 2018-02-28 12:10:12 +01:00
Florian Quèze
c714053d73 Bug 1433175 - scripted patch to replace Components.classes[, Components.interfaces.nsI, Components.utils. and Components.results. with Cc, Ci, Cu and Cr, r=Mossop. 2018-02-28 18:51:33 +01:00
Mark Banner
93a5b36959 Bug 1434261 - Disable user actions on the places trees not in the library window to avoid accidential/unintentional actions. r=mak 
MozReview-Commit-ID: ILo09hwWRsZ

--HG--
extra : rebase_source : 3231ff9ab3b7f4a036b208daffe8f72418951566
 2018-02-21 17:51:23 +00:00
Mark Banner
ad636194ef Bug 1437310 - Fix moving bookmarks across special folders. r=mak 
MozReview-Commit-ID: dj6dOwDxOT

--HG--
extra : rebase_source : 6cadd7079e935d20db9089cdc08f4bc19cfdd95c
 2018-02-12 21:51:08 +00:00
Francesco Lodolo (:flod)
5417ea18be Bug 1437583 - Split plural forms for Delete/Add bookmarks in separate strings r=standard8 
Since the number of tabs is not actually displayed, having two separate strings from 1 vs many is preferable.

MozReview-Commit-ID: y1dgvsCxmC

--HG--
extra : rebase_source : ad694b2dc7bc44128f909e91a90c4822c0698770
 2018-02-12 19:04:59 +01:00
Jared Wein
c8d331f4c9 Bug 1436575 - Autofix errors from no-compare-against-boolean-literal. r=standard8 
MozReview-Commit-ID: 66sXxnOWDgw

--HG--
extra : rebase_source : a0bf26e37a03a1e77476bdeedfc1af3ebec32f2a
 2018-02-08 12:57:31 -05:00
Mark Banner
50e5b04547 Bug 1437651 - Remove unused simulated-places-node references. r=mak 
MozReview-Commit-ID: 6JzFXRykF2W

--HG--
extra : rebase_source : c7fa0ce9f6c9f0fe611ed49644a02042c9c80a12
 2018-02-12 20:33:07 +00:00
Mark Banner
362505f227 Bug 1423896 - Make the All Bookmarks folder for the left pane of the Library a virtual query. r=mak 
MozReview-Commit-ID: HzJ9y1fiEz1

--HG--
extra : rebase_source : 27b0280e9dfef2626d187f9b8a81f23e4583302f
 2017-12-07 14:15:39 +00:00
Coroiu Cristina
1c85c04c62 Backed out 5 changesets (bug 1423896) for bustage at /src/toolkit/components/places/nsNavHistoryResult.cpp on a CLOSED TREE 
Backed out changeset 4012bc74e900 (bug 1423896)
Backed out changeset 12239646395f (bug 1423896)
Backed out changeset abf61cd5fb77 (bug 1423896)
Backed out changeset 569173c95238 (bug 1423896)
Backed out changeset 6401e950298d (bug 1423896)
 2018-02-07 14:07:31 +02:00
Mark Banner
7785b2e489 Bug 1423896 - Make the All Bookmarks folder for the left pane of the Library a virtual query. r=mak 
MozReview-Commit-ID: HzJ9y1fiEz1

--HG--
extra : rebase_source : 27b0280e9dfef2626d187f9b8a81f23e4583302f
 2017-12-07 14:15:39 +00:00
Kris Maglione
918ed6c474 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian 
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
extra : intermediate-source : 34c999fa006bffe8705cf50c54708aa21a962e62
extra : histedit_source : b2be2c5e5d226e6c347312456a6ae339c1e634b0
 2018-01-29 15:20:18 -08:00
Cosmin Sabou
9a65a40178 Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE 
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
 2018-01-30 07:17:48 +02:00
Kris Maglione
6476f95b13 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian 
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
 2018-01-29 15:20:18 -08:00
Brindusan Cristian
af8879d1eb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE 
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
 2018-01-30 02:32:43 +02:00
Kris Maglione
c276bb9375 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian 
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : rebase_source : c004a023389f1f6bf3d2f3efe93c13d423b23ccd
 2018-01-29 15:20:18 -08:00
Mark Banner
aa95c289e7 Bug 1432407 - Merge loops in PlacesController.onDrop now that sync transactions have been removed. r=mak 
MozReview-Commit-ID: JXaxRv10HQs

--HG--
extra : rebase_source : a161a002ebc2baf241e26badad295db3aeac8046
 2018-01-25 21:00:34 +00:00
Mark Banner
412e825e77 Bug 1131491 - Remove browser.places.useAsyncTransactions preference - async transactions are now the only version. r=mak 
MozReview-Commit-ID: 9EKNvA8Q9jo

--HG--
extra : rebase_source : 289082be4a1f086620bf0fe3008c2eacbdc6a9fa
 2018-01-22 13:36:41 +00:00
Mark Banner
a52122f988 Bug 1432112 - Remove the Move Bookmarks dialog as it doesn't work properly and has alternatives. r=mak 
MozReview-Commit-ID: LRqyjJeuoVt

--HG--
extra : rebase_source : 6f5d225f124fc0ecd3ed3fbeab46f951bd405a89
 2018-01-22 13:48:14 +00:00
Mark Banner
c0dcb9675d Bug 1425339 - Allow Places tree's selectItems() function to handle guids as well as ids. r=mak 
MozReview-Commit-ID: LmZ7AYXBsJ4

--HG--
extra : rebase_source : 0c238470a32341e32db928a0c9b726c7f60f8a5a
 2017-12-14 13:56:26 -06:00
Mark Banner
eb29a6ebba Bug 1425437 - Improve view batching when dropping/pasting to tags, use the actual bookmarks count, not the count of transactions. r=mak 
MozReview-Commit-ID: B6Bt8bHhh3e

--HG--
extra : rebase_source : 88e9fe36acb672bbfb92c24c844fb1f3171584b4
 2017-11-08 15:32:51 +00:00
Mark Banner
b0a7a885a6 Bug 1422724 - Remove unused constants in Places' controller.js. r=mak 
MozReview-Commit-ID: AWTTksnPUp8

--HG--
extra : rebase_source : 74747cd754f89ef42579d6f13884fa91db4ac641
 2017-12-04 12:09:03 +00:00
Mark Banner
eeb3c2a9bd Bug 1415877 - Merge transaction handling into one function for onDrop/paste. r=mak 
MozReview-Commit-ID: AMhuLyc98WO

--HG--
extra : rebase_source : c899e2804f016ac0629de7075537c3e5c5ac28d9
 2017-11-08 14:48:45 +00:00
Mark Banner
b71430bdda Bug 1415877 - Rework PlacesControllerDragHelper#onDrop and PlacesController#paste to make the transaction handling parts similar. r=mak 
MozReview-Commit-ID: BInw5oT0Ja5

--HG--
extra : rebase_source : ff7d351f4bb251a0bb75670704f806102114394c
 2017-11-08 12:02:30 +00:00
Mark Banner
a518974a10 Bug 1415877 - Remove unused type parameter to PlacesUIUtils#getTransactionForData. r=mak 
MozReview-Commit-ID: 3kZQ4vnCk3b

--HG--
extra : rebase_source : 2f3b2d190806ecd9d7cba40a0fed96f6b6b46b12
 2017-11-08 11:25:26 +00:00
Mark Banner
3c55451f9e Bug 1413843 - Improve speed of operations when pasting to the left-hand library pane by getting the right-hand pane to use for batching. r=mak 
MozReview-Commit-ID: 2Q1rIpIhmmM

--HG--
extra : rebase_source : 77239ba65f050a4272e58bf7d5d16bfd54ca6933
 2017-11-02 10:37:14 +00:00
Mark Banner
899903b124 Bug 1410940 - Unify the parts of onDrop and paste that get the transaction information. r=mak 
This also fixes inserting bookmarks on paste at the right insertion points.

MozReview-Commit-ID: Km93oZt1UHm

--HG--
extra : rebase_source : 1623c4e5402383f0189800bcb2e70c74703aff59
 2017-10-23 18:18:00 +01:00
Mark Banner
4af8c94122 Bug 1410940 - Make PlacesController#paste and PlacesControllerDragHelper#onDrop more similar to each other. r=mak 
MozReview-Commit-ID: EEFizNPmKpr

--HG--
extra : rebase_source : 9edd8bf17586e994e67959404c739e2f8ee57477
 2017-10-23 15:50:52 +01:00
Sebastian Hengst
46d4f832b2 Backed out 2 changesets (bug 1410940) for failing browser-chrome's browser/components/places/tests/browser/browser_controller_onDrop_tagFolder.js. r=backout 
Backed out changeset 1c78029ded02 (bug 1410940)
Backed out changeset 37ceb314b2b3 (bug 1410940)

--HG--
extra : rebase_source : af00f68a156b90ab4be05a3a283df450604daeaa
 2017-11-03 11:52:54 +01:00
Mark Banner
b4fcc3b3f9 Bug 1410940 - Unify the parts of onDrop and paste that get the transaction information. r=mak 
This also fixes inserting bookmarks on paste at the right insertion points.

MozReview-Commit-ID: Km93oZt1UHm

--HG--
extra : rebase_source : f37574dc8b38d3a39862735f4278eda4112ef2f3
 2017-10-23 18:18:00 +01:00
Mark Banner
4f75b383de Bug 1410940 - Make PlacesController#paste and PlacesControllerDragHelper#onDrop more similar to each other. r=mak 
MozReview-Commit-ID: EEFizNPmKpr

--HG--
extra : rebase_source : 7494eb65cdd422703a9a329e3b819cc7d41794a2
 2017-10-23 15:50:52 +01:00
Mark Banner
0e947c9d32 Bug 1411891 - Improve the performance of deleting bookmarks with async transactions. r=mak 
MozReview-Commit-ID: GL9nKfypie1

--HG--
extra : rebase_source : 5cd1c4d848dc32611349e25eb7297ba50890f0a9
 2017-10-26 10:14:14 +01:00
Margareta Eliza Balazs
1d0ba383ae Backed out changeset e17a2bca5391 (bug 1411891) for failing xpcshell in toolkit/modules/tests/xpcshell/test_NewTabUtils.js r=backout on CLOSED TREE 2017-10-31 14:19:52 +02:00
Mark Banner
d059b763bb Bug 1411891 - Improve the performance of deleting bookmarks with async transactions. r=mak 
MozReview-Commit-ID: GL9nKfypie1

--HG--
extra : rebase_source : ca8ec95e51899bc1fb18e7a39f42a96569a2d4d1
 2017-10-26 10:14:14 +01:00
Marco Bonardo
e3fddaf049 Bug 1405722 - Remove the IsLivemark() bookmarks observer from PlacesUIUtils. r=standard8 
MozReview-Commit-ID: 586IR54ggbm

--HG--
extra : rebase_source : f3d3c3e71bf92c0eecbd2e129517b7eefd70224d
 2017-10-10 12:05:19 +02:00
Sebastian Hengst
0a305fd2d1 Backed out changeset af8fdfac66fa (bug 1405722) for failing xpcshell's browser/components/places/tests/unit/test_PUIU_livemarksCache.js, at least on OS X 10.10 opt. r=backout on a CLOSED TREE 
--HG--
extra : amend_source : 57bce00f5654ad7abca1774d2be153e95492a58b
 2017-10-17 00:55:53 +02:00
Marco Bonardo
bf0fb7d1e7 Bug 1405722 - Remove the IsLivemark() bookmarks observer from PlacesUIUtils. r=standard8 
MozReview-Commit-ID: 586IR54ggbm

--HG--
extra : rebase_source : 6a714c0ab4154b219195cafee6cdfe8c3c9c5211
 2017-10-10 12:05:19 +02:00
Dan Banner
7caa92d5d8 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8 
MozReview-Commit-ID: Jm8BRgt6mIv
 2017-10-15 20:50:39 +01:00
Peter Van der Beken
c705293c1c Bug 1383059 - Remove instanceof for supplemental interfaces. Part 1: add Window.isChromeWindow and switch |instanceof [nsIDOM]ChromeWindow| to use it instead. r=bz. 
--HG--
extra : rebase_source : 1efc83abae922c1a7b7eb855fd10a6333615044b
extra : source : 32277b160af4739c812ca2750a39ca111b16ea69
 2017-10-06 13:47:27 +02:00
Marco Bonardo
e5991df3ec Bug 1405687 - Remove some deprecated code from Places related code. r=standard8 
MozReview-Commit-ID: 411z07otlfN

--HG--
extra : rebase_source : 43f91cb30a7ad85f633b653d153a657ebdad1893
 2017-10-04 16:33:46 +02:00
Mark Banner
50a5c3faec Bug 1392533 - Make the places tree view directly communicate batch notifications to the results. r=mak 
MozReview-Commit-ID: HpN0v0jSwdK

--HG--
extra : rebase_source : 49a4810e5a85cf9f040fd544546479ad19ddf5b8
 2017-09-27 15:26:35 +01:00
Mark Banner
83d88f0a96 Bug 1400846 - Fix ordering of bookmarks with Async Transactions when dropping into different folders. r=mak 
MozReview-Commit-ID: GjnehR5PumZ

--HG--
extra : rebase_source : a913bf0584803993f9c5ecd061acdc1b40264254
 2017-09-19 06:54:16 +01:00
Mark Banner
8332d2278d Bug 1401242 - Fix removing bookmarks from tag groups - when getting the tagGuid from the node, we must get it async, rather than using the concrete guid. r=mak 
MozReview-Commit-ID: 7fGS6jFNVPl

--HG--
extra : rebase_source : 67306adaa925b32bae8fe928b77692842304be9a
 2017-09-19 20:47:26 +01:00
Michael Layzell
c24551af0d Bug 1398471 - Read data from DataTransfer before yielding, r=gijs 
Previously the code looped and yielded between each loop. This caused the
DataTransfer to be cleared before the read completed.

This splits the loop into 2 sections such that we read all important data from
the DataTransfer before it is cleared.
 2017-09-13 11:45:48 -04:00