Commit graph

52 commits

Author SHA1 Message Date
Victor Porof
1f830c96da Bug 1561435 - Format browser/components/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36042

--HG--
extra : source : d3afcafdce650a6f36cebbc126ee93b17f13cf52
2019-07-05 09:53:32 +02:00
Kris Maglione
e930b89c34 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750

--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
2019-01-17 10:18:31 -08:00
Mark Banner
691543ee89 Bug 1486739 - Add missing dangling commas in browser/, services/, taskcluster/ and toolkit/. r=mossop
Automatic changes by ESLint, except for manual corrections for .xml files.

Differential Revision: https://phabricator.services.mozilla.com/D4439

--HG--
extra : moz-landing-system : lando
2018-08-31 05:59:17 +00:00
Brian Grinstead
abf1620630 Bug 1479125 - Migrate calls that expect an element to be returned to use element variation firstChild etc to firstElementChild etc;r=Paolo
This allows the JS to work in HTML documents, where whitespace is preserved. In XUL
documents, whitespace is ignored when parsing so text nodes are generally not returned.

The following changes were made, with manual cleanups as necessary (i.e. when firstChild actually
refers to a text node, or when firstChild is used in a loop to empty out an element):

  firstChild->firstElementChild
  lastChild->lastElementChild
  nextSibling->nextElementSibling
  previousSibling->previousElementSibling
  childNodes->children

MozReview-Commit-ID: 95NQ8syBhYw

--HG--
extra : rebase_source : 186d805f7a2a56694dda9032aceac2dfe5424753
2018-08-08 15:22:53 -07:00
Amy Chan
d494f855f6 Bug 1446975 - Replace synced Tabs sidebar device icons. r=eoger
MozReview-Commit-ID: GnawrVrfpEz


--HG--
rename : browser/themes/shared/icons/device-mobile.svg => browser/themes/shared/icons/device-phone.svg
2018-04-12 19:22:38 -04:00
Gurzau Raul
50d002961a Backed out 2 changesets (bug 1446975) for failing xpcshell on sync/tests/unit/test_syncedtabs.js and browser-chrome failures e.g. test/urlbar/browser_page_action_menu.js on a CLOSED TREE
Backed out changeset 69653800c483 (bug 1446975)
Backed out changeset 44e3e7446b02 (bug 1446975)

--HG--
rename : browser/themes/shared/icons/device-phone.svg => browser/themes/shared/icons/device-mobile.svg
2018-04-13 01:28:22 +03:00
Amy Chan
711220e6e7 Bug 1446975 - Replace synced Tabs sidebar device icons. r=eoger
MozReview-Commit-ID: GnawrVrfpEz


--HG--
rename : browser/themes/shared/icons/device-mobile.svg => browser/themes/shared/icons/device-phone.svg
2018-04-12 16:18:22 -04:00
Edouard Oger
9b6026748b Bug 1184265 - Make last sync date be relative. r=markh
MozReview-Commit-ID: 2hB9F7Elynh

--HG--
extra : rebase_source : dbf962b1fd3f4121f0bcc8276e932f0c49ab90b3
2018-03-20 17:08:16 -04:00
Michael Kaply
b7a354c792 Bug 1432355 - Add a policy to disable private browsing. r=Gijs
MozReview-Commit-ID: AprbL6usEv5

--HG--
extra : rebase_source : d0a9255aae8b8d038c69978cbeabbfc394ad46cd
2018-03-01 10:20:38 -06:00
Florian Quèze
682b1ec3b2 Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
Andrew McCreight
5dec0e0beb Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG

--HG--
extra : rebase_source : d9c41878036c1ef7766ef5e91a7005025bc1d72b
2018-02-06 09:36:57 -08:00
Kris Maglione
918ed6c474 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
extra : intermediate-source : 34c999fa006bffe8705cf50c54708aa21a962e62
extra : histedit_source : b2be2c5e5d226e6c347312456a6ae339c1e634b0
2018-01-29 15:20:18 -08:00
Cosmin Sabou
9a65a40178 Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
6476f95b13 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
2018-01-29 15:20:18 -08:00
Brindusan Cristian
af8879d1eb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
c276bb9375 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : rebase_source : c004a023389f1f6bf3d2f3efe93c13d423b23ccd
2018-01-29 15:20:18 -08:00
Dale Harvey
39fa8271ed Bug 1411230 - Move synctab sidebar search icon to left. r=dao
MozReview-Commit-ID: 39ctqQlNNOG

--HG--
extra : rebase_source : bdbfe31ddbcf7359984b2d64151ab2f1e9f29449
2017-11-14 14:05:40 +00:00
Edouard Oger
b3b3ff9cc5 Bug 1353571 part 3 - Refactor browser-syncui and browser-fxaccounts. r=markh
MozReview-Commit-ID: K790Ag8WZgv

--HG--
rename : browser/base/content/test/general/accounts_testRemoteCommands.html => browser/base/content/test/sync/accounts_testRemoteCommands.html
rename : browser/base/content/test/general/browser_fxa_web_channel.html => browser/base/content/test/sync/browser_fxa_web_channel.html
rename : browser/base/content/test/general/content_aboutAccounts.js => browser/base/content/test/sync/content_aboutAccounts.js
extra : rebase_source : dcba087df94d06b15c9f073ff2df3324fd646c57
2017-04-18 14:15:43 -04:00
Sebastian Hengst
18253e3fa2 Backed out changeset 0a0138825fb5 (bug 1353571)
--HG--
rename : browser/base/content/test/sync/accounts_testRemoteCommands.html => browser/base/content/test/general/accounts_testRemoteCommands.html
rename : browser/base/content/test/sync/browser_fxa_web_channel.html => browser/base/content/test/general/browser_fxa_web_channel.html
rename : browser/base/content/test/sync/content_aboutAccounts.js => browser/base/content/test/general/content_aboutAccounts.js
2017-05-03 21:56:44 +02:00
Edouard Oger
c11e66021d Bug 1353571 part 3 - Refactor browser-syncui and browser-fxaccounts. r=markh
MozReview-Commit-ID: K790Ag8WZgv

--HG--
rename : browser/base/content/test/general/accounts_testRemoteCommands.html => browser/base/content/test/sync/accounts_testRemoteCommands.html
rename : browser/base/content/test/general/browser_fxa_web_channel.html => browser/base/content/test/sync/browser_fxa_web_channel.html
rename : browser/base/content/test/general/content_aboutAccounts.js => browser/base/content/test/sync/content_aboutAccounts.js
extra : rebase_source : aa6cb209d312c6ef3f45589b0fd8fa8a39c612e3
2017-04-18 14:15:43 -04:00
Edouard Oger
a014194719 Bug 1269277 - Add Manage Device button in Synced Tabs menu/sidebar. r=markh
MozReview-Commit-ID: 2BMgLeI0DNF

--HG--
extra : rebase_source : d8e1bb4f52723071d395db3ac3c896096ca6df2a
2017-03-10 20:14:51 -05:00
Wes Kocher
7c2b508df2 Backed out changeset cfe8ab5f1c08 (bug 1269277) for failures in browser_aboutAccounts.js a=backout
MozReview-Commit-ID: FgcSoHPCnoH
2017-03-10 16:55:36 -08:00
Edouard Oger
812a782093 Bug 1269277 - Add Manage Device button in Synced Tabs menu/sidebar. r=markh
MozReview-Commit-ID: 2BMgLeI0DNF

--HG--
extra : rebase_source : e5ace2f6dfd828c14edfd3f3d84da2b5043361b2
2017-03-09 15:53:08 -05:00
Wes Kocher
4894923a57 Backed out changeset 805da5d5567f (bug 1269277) for failures in browser_device_connected.js and browser_aboutAccounts.js a=backout
MozReview-Commit-ID: 1xafqaoxNWG
2017-03-10 12:31:13 -08:00
Edouard Oger
a28ba6f4da Bug 1269277 - Add Manage Device button in Synced Tabs menu/sidebar. r=markh
MozReview-Commit-ID: 2BMgLeI0DNF

--HG--
extra : rebase_source : 048e6b5ede97b4908a65997cb674153c5e34c21d
2017-03-09 15:53:08 -05:00
Florian Quèze
9d62681259 Bug 1345253 - Use element.firstChild.remove() instead of element.removeChild(element.firstChild), r=jaws. 2017-03-08 10:17:52 +01:00
Jared Wein
43bac26d30 Bug 1331661 - Enable the 'quotes' rule for eslint and fix most of the errors with --fix. r=Gijs
MozReview-Commit-ID: 6tv0Z06CO4a

--HG--
extra : rebase_source : 014c0b04d8538dc5f15bc6dd4ed6bd220c55c5d4
2017-01-17 09:48:17 -06:00
Edouard Oger
99b4c17c30 Bug 1324895 - Add 'Open All in Tabs' to client context menu in Synced Tabs. r=markh
MozReview-Commit-ID: IFWtIfl0QZI

--HG--
extra : rebase_source : aae696de42e4afd2990f286b353d8f0b2232c34d
2017-01-05 15:40:36 -05:00
Kit Cambridge
f97b3eef3b Bug 1322408 - Use gBrowser.loadTabs to open all tabs when middle-clicking a client in Synced Tabs. r=markh
MozReview-Commit-ID: 6phgHjAAXUs

--HG--
extra : rebase_source : 44260c7a8f407c1efa869912e6407e81e68fb2eb
2016-12-07 11:46:36 -10:00
Edouard Oger
f88ca738b7 Bug 1288247 - Open synced tabs in a new tab on middle click. r=markh
MozReview-Commit-ID: LTE5NolY8V3

--HG--
extra : rebase_source : cf071b7d106e8a59ca1df0bc43aa37d18cad4d82
2016-08-19 17:10:45 -07:00
Sebastian Hengst
a8200eb0d2 Backed out changeset bbe3a00528ed (bug 1288247) for failing test_TabListComponent.js. r=backout 2016-08-24 18:22:40 +02:00
Edouard Oger
549037950e Bug 1288247 - Open synced tabs in a new tab on middle click. r=markh
MozReview-Commit-ID: LTE5NolY8V3

--HG--
extra : rebase_source : 01d32e7ec192bf38a62e39c362917aa532ebe33f
2016-08-19 17:10:45 -07:00
Edouard Oger
894ae051dc Bug 1297473 - Check for first tab in synced tabs sidebar before assigning tabindex. r=markh
MozReview-Commit-ID: 9FkT0HpoB8r

--HG--
extra : rebase_source : 31776337e33f6d55ed60d4ab2e535172a2de2395
2016-08-23 11:11:29 -07:00
Edouard Oger
78c5f8dca1 Bug 1269348 - Show last sync date tooltip on Synced Tabs sidebar device names. r=markh
MozReview-Commit-ID: LkGNdSF8Znm

--HG--
extra : transplant_source : qn%AA%7Ec%3AS%A7%A8%F4%E3%DE%00p%F7%00%3B%EC%1C%0C
2016-05-18 15:45:29 -07:00
Phil Ringnalda
74f134854f Back out e7c3a1d7ce27 (bug 1269348) on suspicion of causing failures in test_tab_store.js
CLOSED TREE
2016-05-17 23:20:47 -04:00
Edouard Oger
60cb7c8705 Bug 1269348 - Show last sync date tooltip on Synced Tabs sidebar device names. r=markh
MozReview-Commit-ID: GG34hPxDKcy
2016-05-17 14:15:32 -07:00
Edouard Oger
7cfd572f3e Bug 1260482 - Use SVGs instead of bitmaps for devices in Synced Tabs menu. r=markh 2016-05-10 10:59:00 -04:00
Edouard Oger
bf53149b02 Bug 1269352 - Synced Tabs sidebar does not register duplicate listeners. r=markh 2016-05-04 11:52:00 -04:00
Edouard Oger
be199c0753 Bug 1247110 - Synced Tabs Sidebar - Fixed keyboard navigation. r=markh 2016-04-14 09:33:00 -04:00
Edouard Oger
2fc076517e Bug 1261223 - Synced Tabs now uses HiDPI default favicons. r=markh 2016-04-05 09:36:00 -04:00
Kit Cambridge
1b26f871ce Bug 1257008 - Don't collapse the tab list when right-clicking on a device in the Synced Tabs sidebar. r=markh
MozReview-Commit-ID: JsaWLfMOYyC

--HG--
extra : rebase_source : 420fbc43630f308e5b8117f58bacb6529eccd9e5
2016-03-15 16:56:52 -07:00
Kit Cambridge
b9d8f2d371 Bug 1262310 - Fix opening synced tabs from the sidebar. r=markh
MozReview-Commit-ID: 8VHbEqsyuF2

--HG--
extra : rebase_source : 04924f295134834cf66c0d9c4a31d43c614b3abf
2016-04-05 17:06:00 -07:00
Carsten "Tomcat" Book
0c8ce93507 Backed out changeset 902ee4a0983d (bug 1261223) for XPC failures 2016-04-05 09:18:57 +02:00
Edouard Oger
b5e12e8fc6 Bug 1261223 - Synced Tabs now uses HiDPI default favicons. r=markh 2016-04-04 11:33:00 +02:00
Kit Cambridge
81cb8e12e4 Bug 1246156 - Show additional link options in the synced tabs sidebar context menu. r=markh
MozReview-Commit-ID: 44KlEasJiLc

--HG--
extra : rebase_source : ccd6b124d5d8159d47ad8918710ad7060e63b750
2016-03-10 15:56:25 -08:00
Mark Hammond
119228f973 Bug 1247345 - arrange for the searchbox to not scroll in the SyncedTabs sidebar. r=Gijs 2016-03-29 22:08:13 +11:00
Carsten "Tomcat" Book
c2beaa7285 Backed out changeset c325569a1f4d (bug 1247345) for test failures in browser_sidebar_syncedtabslist.js 2016-03-29 11:55:33 +02:00
Mark Hammond
8bc86039bc Bug 1247345 - arrange for the searchbox to not scroll in the SyncedTabs sidebar. r=Gijs
--HG--
extra : rebase_source : 54e0babbe19bb5fba2f8b61f4564545e2174b9dd
2016-03-24 08:52:12 +11:00
Kit Cambridge
85bc9bbd3f Bug 1254544 - Show clipboard commands in the synced tabs filter context menu. r=markh
MozReview-Commit-ID: 9XTYrU0xp9E

--HG--
extra : transplant_source : %08n%86%F3%C7%B7j%E2%C5%A7W%D5%91%A2Zs%A1%D9%DD%F1
2016-03-16 16:31:19 -07:00
Kit Cambridge
496b5ed2af Bug 1252054 - Sort "Synced Tabs" sidebar entries by last used date. r=markh
MozReview-Commit-ID: BvmQfQMHlMw

--HG--
extra : rebase_source : 167fecace1c6d45f300f14abade3986caeff2c6a
extra : histedit_source : 7c29e76072f8ea7dc64e16055187df783ba8a2c7
2016-03-07 14:13:41 -08:00