Commit graph

57 commits

Author SHA1 Message Date
Mark Banner
93aef2d7b3 Bug 1803756 - Automatically replace Cu.reportError with console.error (preferences). r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D163701
2022-12-06 02:26:51 +00:00
Mark Banner
a24dca9645 Bug 1798212 - Replace defineModuleGetter in Integration.sys.mjs with a ES version. r=settings-reviewers,mossop
Differential Revision: https://phabricator.services.mozilla.com/D161014
2022-11-07 17:56:10 +00:00
Mark Banner
18753bfe42 Bug 1798212 - Convert consumers of downloads code to ES modules. r=mak,geckoview-reviewers,extension-reviewers,settings-reviewers,credential-management-reviewers,sgalich,mconley,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D161013
2022-11-07 17:56:10 +00:00
Drew Willcoxon
cbe56de83c Bug 1798595 - Refactor quick suggest [Part 4]: Move help URL from UrlbarProviderQuickSuggest to QuickSuggest and change how the test utils are initialized. r=daisuke
This moves the help URL const out of UrlbarProviderQuickSuggest in order to make
UrlbarProviderQuickSuggest focused on being a urlbar provider.

It also changes how QuickSuggestTestUtils is initialized to be more similar to
MerinoTestUtils. There's no need for a separate `init()` method when the
constructor will do. I'd like to make this change in a different revision but I
did it here because I want to include all changes to about:preferences in one
revision for easier review.

Please see bug 1798595 for details.

Depends on D160984

Differential Revision: https://phabricator.services.mozilla.com/D160985
2022-11-02 06:50:14 +00:00
Mark Banner
2ffde1e92f Bug 1792341 - Migrate more toolkit/modules consumers to use direct ES module import. r=Gijs,webdriver-reviewers,perftest-reviewers,necko-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,sgalich,owlish,bytesized,AlexandruIonescu,whimboo,mconley,mixedpuppy
Mainly automated changes. Some manual ESLint fixes and whitespace cleanup.

Differential Revision: https://phabricator.services.mozilla.com/D158452
2022-10-18 11:21:26 +00:00
Mark Banner
8d1ebcb9d6 Bug 1792365 - Convert toolkit/modules consumers to use ES module imports directly. r=webdriver-reviewers,perftest-reviewers,geckoview-reviewers,extension-reviewers,preferences-reviewers,desktop-theme-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,robwu,Gijs,sgalich,bytesized,AlexandruIonescu,dao,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D158094
2022-09-29 06:52:34 +00:00
Dale Harvey
e998bc6483 Bug 1783452 - Add section in preferences to enable/disable QuickActions. r=adw,fluent-reviewers,preferences-reviewers,flod,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D154795
2022-08-17 22:47:54 +00:00
Mark Banner
8a275d4d92 Bug 1780017 - Migrate urlbar consumers to use ESM imports directly. r=adw,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D152057
2022-07-26 15:11:30 +00:00
smolnar
dc4f2d6a41 Backed out 5 changesets (bug 1780017, bug 1780347) for causing bc failures in browser/base/content/test/performance/browser_preferences_usage.js CLOSED TREE
Backed out changeset 86c3a9142535 (bug 1780347)
Backed out changeset 35abe35417a0 (bug 1780017)
Backed out changeset f448f044f028 (bug 1780017)
Backed out changeset a400cbe83084 (bug 1780017)
Backed out changeset 0a23c9e27f01 (bug 1780017)
2022-07-25 21:00:07 +03:00
Mark Banner
539b5dac0d Bug 1780017 - Migrate urlbar consumers to use ESM imports directly. r=adw,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D152057
2022-07-25 12:46:48 +00:00
Mark Banner
4bfafd41fa Bug 1779982 - Migrate places consumers to use ESM imports directly. r=mak,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D152005
2022-07-20 22:34:21 +00:00
smolnar
102b779608 Backed out 8 changesets (bug 1779982, bug 1780017, bug 1780347) for causing doc generate failures. CLOSED TREE
Backed out changeset 3f22c0f99cf1 (bug 1780347)
Backed out changeset 6f20b7e4b21b (bug 1780017)
Backed out changeset ae6062c69aeb (bug 1780017)
Backed out changeset e668d7778d97 (bug 1780017)
Backed out changeset e158fc41594b (bug 1780017)
Backed out changeset d4c69c956271 (bug 1779982)
Backed out changeset 145212fd826d (bug 1779982)
Backed out changeset 54079aaa1857 (bug 1779982)
2022-07-20 22:43:53 +03:00
Mark Banner
fd37e0e9da Bug 1780017 - Migrate urlbar consumers to use ESM imports directly. r=adw,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D152057
2022-07-20 15:50:42 +00:00
Mark Banner
23086da9b9 Bug 1779982 - Migrate places consumers to use ESM imports directly. r=mak,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D152005
2022-07-20 15:50:40 +00:00
Iulian Moraru
1108246986 Backed out 7 changesets (bug 1779982, bug 1780017) for causing multiple failures. CLOSED TREE
Backed out changeset f33a58aa2f3f (bug 1780017)
Backed out changeset e21c85d61b91 (bug 1780017)
Backed out changeset 213ee5578e7c (bug 1780017)
Backed out changeset ea9b3bf42ea1 (bug 1780017)
Backed out changeset d2d8530f3c4d (bug 1779982)
Backed out changeset 088e5148c307 (bug 1779982)
Backed out changeset 267e08f3868a (bug 1779982)
2022-07-20 15:44:53 +03:00
Mark Banner
ac90e83952 Bug 1780017 - Migrate urlbar consumers to use ESM imports directly. r=adw,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D152057
2022-07-20 10:36:51 +00:00
Mark Banner
e84aaa1b85 Bug 1779982 - Migrate places consumers to use ESM imports directly. r=mak,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D152005
2022-07-20 10:36:49 +00:00
Gijs Kruitbosch
adb544b7f9 Bug 1778127 - remove obsolete non-functioning import, r=jaws,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D151518
2022-07-11 15:54:39 +00:00
Tooru Fujisawa
bf93d07148 Bug 1667455 - Part 5: Stop importing Services.jsm from chrome-priv JS code, top-level single-line cases. r=kmag,webdriver-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,extension-reviewers,application-update-reviewers,pip-reviewers,twisniewski,m_kato,jdescottes,mconley,AlexandruIonescu,mossop
Differential Revision: https://phabricator.services.mozilla.com/D150894
2022-07-11 12:41:50 +00:00
Tooru Fujisawa
7119718780 Bug 1771463 - Do not export lazy getter "fxAccounts" from services/fxaccounts/FxAccounts.jsm. r=markh,preferences-reviewers,Mardak
Instead of exporting lazy getter, export a function that returns the FxAccount
singleton, lazily creating on the first call, and define the lazy getter on the
consumer side that calls the function.

Differential Revision: https://phabricator.services.mozilla.com/D147634
2022-05-31 14:09:10 +00:00
Cosmin Sabou
290da6c4fc Backed out changeset 697ab99d1c61 (bug 1771463) for causing node newtab failures. CLOSED TREE 2022-05-31 07:16:41 +03:00
Tooru Fujisawa
cb429a0be1 Bug 1771463 - Do not export lazy getter "fxAccounts" from services/fxaccounts/FxAccounts.jsm. r=markh,preferences-reviewers
Instead of exporting lazy getter, export a function that returns the FxAccount
singleton, lazily creating on the first call, and define the lazy getter on the
consumer side that calls the function.

Differential Revision: https://phabricator.services.mozilla.com/D147634
2022-05-31 03:12:22 +00:00
Hanna Jones
3c062fde3d Bug 1766318 - replace is='text-link' with <html:a> in preferences.xhtml r=preferences-reviewers,Gijs
These changes replicate the exact appearance and behaviour of `<label is="text-link">`. There are a few possible enhancements not tackled here, as this is the simplest possible migration implementation:

* We could switch to using `button` elements in this case, based on the styling and the fact that the `addonsButton` has some additional behaviour on top of navigation. This would necessitate re-working the current style rules a bit.
* Somewhat relatedly, we could change the `helpButton` and `about:policies` anchor elements to always switch tabs if the link has already been clicked/opened, rather than always opening in a new tab

Differential Revision: https://phabricator.services.mozilla.com/D144624
2022-05-04 17:53:27 +00:00
Gijs Kruitbosch
3d9050fbb5 Bug 1766156 - stop adding '#general' to the about:preferences URL when going back to the main pane, to fix back/fwd navigation, r=sclements,preferences-reviewers,jaws
Differential Revision: https://phabricator.services.mozilla.com/D144993
2022-04-29 10:09:22 +00:00
Greg Tatum
f30d9ead28 Bug 1764920 - Install the langpack even if it is the fallback; r=platform-i18n-reviewers,preferences-reviewers,mstriemer,dminor
The fallback locale is not guaranteed to have all of the strings for
non-fluent files, even if it is one of the available locales. This patch
shares the logic with about:preferences for getting the available
locales.

Differential Revision: https://phabricator.services.mozilla.com/D143910
2022-04-28 15:00:57 +00:00
Punam Dahiya
2b39c9ff18 Bug 1751093 - Clean up Cloud Storage API and its usage in about:preferences r=preferences-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D137248
2022-04-07 10:17:13 +00:00
Mark Banner
4f4dd2fbae Bug 1750974 - Extend our ESLint import-globals-from function to support absolute directories. r=Gijs,mossop
Differential Revision: https://phabricator.services.mozilla.com/D136368
2022-01-20 14:15:34 +00:00
Neil Deakin
5f1ff58926 Bug 371900, remove more now-unneeded empty oncommand attributes, r=bgrins,preferences-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D135243
2022-01-11 20:02:30 +00:00
criss
e2948093fb Backed out 2 changesets (bug 371900) for causing bug 1749182 . CLOSED TREE
Backed out changeset e59035c65af3 (bug 371900)
Backed out changeset 6434bce9c7d4 (bug 371900)
2022-01-09 16:26:02 +02:00
Neil Deakin
64a4726936 Bug 371900, remove more now-unneeded empty oncommand attributes, r=bgrins,preferences-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D135243
2022-01-08 18:07:21 +00:00
Meg Viar
e17e8bbbde Bug 1741741 - Avoid showing Mozilla VPN in unsupported countries r=dmose,preferences-reviewers,pdahiya,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D133903
2021-12-22 19:55:29 +00:00
Gijs Kruitbosch
1e8fa9e7f9 Bug 1400420 - fix tabbing backwards in prefs to not hide items behind the search/policies sticky header, r=preferences-reviewers,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D133071
2021-12-14 22:01:51 +00:00
Norisz Fay
93687cfe81 Backed out changeset 4c040d6dff93 (bug 1400420) for causing mochitest failures on browser_containers_name_input.js CLOSED TREE 2021-12-13 16:54:02 +02:00
Gijs Kruitbosch
1de6d8f845 Bug 1400420 - fix tabbing backwards in prefs to not hide items behind the search/policies sticky header, r=preferences-reviewers,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D133071
2021-12-13 13:49:03 +00:00
Gijs Kruitbosch
e0197fccf4 Bug 1425539 - fix scrollTop assignment causing style flush in the prefs, r=florian
Differential Revision: https://phabricator.services.mozilla.com/D133072
2021-12-08 00:56:21 +00:00
Punam Dahiya
00d26b7582 Bug 1740377 - Update More From Mozilla section inside about:preferences to use new UI template r=preferences-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D131560
2021-12-03 20:30:52 +00:00
Gijs Kruitbosch
3b0145da09 Bug 1294999 - put module getters in preferences.js and de-duplicate them, r=jaws,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D132529
2021-12-01 16:35:25 +00:00
Punam Dahiya
eaeec96d4b Bug 1738187 - Add telemetry for MoreFromMozilla section inside about:preferences r=preferences-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D130409
2021-11-09 21:53:02 +00:00
Punam Dahiya
2728a5995f Bug 1737873 - Add More From Mozilla in about:preferences r=preferences-reviewers,Gijs,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D128289
2021-10-28 20:25:42 +00:00
Katherine Patenio
b436694249 Bug 1476664 - fix search term tooltip for Add button in saved addresses dialog r=preferences-reviewers,jaws
Differential Revision: https://phabricator.services.mozilla.com/D129079
2021-10-21 16:33:22 +00:00
Florian Quèze
7ae782d0c7 Bug 1722561 - Avoid calling document.querySelectorAll repeatedly when loading about:preferences, r=Gijs,preferences-reviewers.
Differential Revision: https://phabricator.services.mozilla.com/D120995
2021-07-28 11:21:13 +00:00
Neil Deakin
eeec967af7 Bug 1667858, preference search filter should hide experiments that don't match the search terms, r=preferences-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D95775
2020-11-10 16:36:23 +00:00
pbz
5c65d2dbca Bug 1650794 - Refactor subdialogs.js to reusable SubDialog.jsm. r=Gijs,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D82405
2020-07-10 00:01:50 +00:00
Razvan Maries
e23631e029 Backed out 2 changesets (bug 1650794) for perma failures on browser_masterpassword.js .CLOSED TREE
Backed out changeset 5ffeb4bf7fa5 (bug 1650794)
Backed out changeset 45b3d9917fb3 (bug 1650794)
2020-07-09 15:04:47 +03:00
pbz
650149a70d Bug 1650794 - Refactor subdialogs.js to reusable SubDialog.jsm. r=Gijs,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D82405
2020-07-09 10:10:18 +00:00
Jared Wein
88ae5ca939 Bug 1648222 - Hide the experimental features category if there are no available experimental features. r=mstriemer,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D80949
2020-06-30 19:49:46 +00:00
Jared Wein
347ee7ec89 Bug 1648223 - Enable the Experimental Preferences by default. r=mstriemer,preferences-reviewers,ntim
Differential Revision: https://phabricator.services.mozilla.com/D81111
2020-06-26 18:23:24 +00:00
Kris Maglione
3bda67deab Bug 1638153: Part 2 - Fix uses of .rootTreeItem to get top browser window. r=geckoview-reviewers,nika,snorp
Differential Revision: https://phabricator.services.mozilla.com/D75429
2020-06-17 17:17:16 +00:00
Jared Wein
d8bc963e63 Bug 1644537 - Use FeatureGates for templating the Experimental Features section. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D79025
2020-06-17 03:39:48 +00:00
Razvan Maries
eef39502e0 Backed out changeset 7f701cee12e7 (bug 1644537) for perma failures on browser_sync_disabled.js. CLOSED TREE 2020-06-17 05:55:10 +03:00