Commit graph

165 commits

Author SHA1 Message Date
André Bargull
50d9348a9e Bug 1841314 - Part 3: Prefer JS::NewArrayBufferWithContents with UniquePtr. r=sfink,saschanaz
Replace the existing callers of `JS::NewArrayBufferWithContents` with the new
`UniquePtr` alternative.

Three callers to the old `JS::NewArrayBufferWithContents` function were left
unchanged:
- `mozilla::dom::FileReader::OnLoadEndArrayBuffer()` and
  `mozilla::dom::ArrayBufferBuilder::TakeArrayBuffer()` both store the data
  buffer as members and therefore have a more complicated lifetime.
- `JSStructuredCloneReader::readTransferMap()` because it's not clear if the
  data can be free'ed when `ArrayBuffectObject` allocation fails.

Differential Revision: https://phabricator.services.mozilla.com/D182588
2023-07-06 20:50:59 +00:00
Sandor Molnar
a6c121377b Backed out 7 changesets (bug 1841314) for causing hazard failures. CLOSED TREE
Backed out changeset 82a53d6ea95a (bug 1841314)
Backed out changeset 524607b471a2 (bug 1841314)
Backed out changeset ce128e10bddb (bug 1841314)
Backed out changeset cdae4fbbdaff (bug 1841314)
Backed out changeset f1035b6c08fe (bug 1841314)
Backed out changeset 5897ad8ef181 (bug 1841314)
Backed out changeset 09618a767080 (bug 1841314)
2023-07-06 16:59:47 +03:00
André Bargull
412b9d7c45 Bug 1841314 - Part 3: Prefer JS::NewArrayBufferWithContents with UniquePtr. r=sfink,saschanaz
Replace the existing callers of `JS::NewArrayBufferWithContents` with the new
`UniquePtr` alternative.

Three callers to the old `JS::NewArrayBufferWithContents` function were left
unchanged:
- `mozilla::dom::FileReader::OnLoadEndArrayBuffer()` and
  `mozilla::dom::ArrayBufferBuilder::TakeArrayBuffer()` both store the data
  buffer as members and therefore have a more complicated lifetime.
- `JSStructuredCloneReader::readTransferMap()` because it's not clear if the
  data can be free'ed when `ArrayBuffectObject` allocation fails.

Differential Revision: https://phabricator.services.mozilla.com/D182588
2023-07-06 12:26:53 +00:00
Cristina Horotan
f77c6f3e48 Backed out 7 changesets (bug 1841314) for causing hazard failures at js.cpp CLOSED TREE
Backed out changeset becc2fa2c186 (bug 1841314)
Backed out changeset e5b723317177 (bug 1841314)
Backed out changeset 61ae850b25e5 (bug 1841314)
Backed out changeset 9ff320c779b8 (bug 1841314)
Backed out changeset debf1172f794 (bug 1841314)
Backed out changeset 8ac4fa317006 (bug 1841314)
Backed out changeset eccacbb3b620 (bug 1841314)
2023-07-06 15:11:47 +03:00
André Bargull
0c386d5c4b Bug 1841314 - Part 3: Prefer JS::NewArrayBufferWithContents with UniquePtr. r=sfink,saschanaz
Replace the existing callers of `JS::NewArrayBufferWithContents` with the new
`UniquePtr` alternative.

Three callers to the old `JS::NewArrayBufferWithContents` function were left
unchanged:
- `mozilla::dom::FileReader::OnLoadEndArrayBuffer()` and
  `mozilla::dom::ArrayBufferBuilder::TakeArrayBuffer()` both store the data
  buffer as members and therefore have a more complicated lifetime.
- `JSStructuredCloneReader::readTransferMap()` because it's not clear if the
  data can be free'ed when `ArrayBuffectObject` allocation fails.

Differential Revision: https://phabricator.services.mozilla.com/D182588
2023-07-06 11:41:17 +00:00
Andi-Bogdan Postelnicu
10f49d4180 Bug 1660405 - Move away from mozilla::IsNaN in favor of std::isnan. r=nbp,media-playback-reviewers,sergesanspaille,padenot
Differential Revision: https://phabricator.services.mozilla.com/D173035
2023-03-22 11:35:33 +00:00
Stanca Serban
e31a178029 Backed out 7 changesets (bug 1660405) for causing bustages on Linux x64 opt. CLOSED TREE
Backed out changeset ad1a5f59214f (bug 1660405)
Backed out changeset a39e95f0aafe (bug 1660405)
Backed out changeset 48629ee0d70d (bug 1660405)
Backed out changeset 8419b99aab60 (bug 1660405)
Backed out changeset 535cc12c8bed (bug 1660405)
Backed out changeset e27052da4927 (bug 1660405)
Backed out changeset 11b0f9cf8091 (bug 1660405)
2023-03-22 13:05:53 +02:00
Andi-Bogdan Postelnicu
a5d28acdd6 Bug 1660405 - Move away from mozilla::IsNaN in favor of std::isnan. r=nbp,media-playback-reviewers,sergesanspaille,padenot
Differential Revision: https://phabricator.services.mozilla.com/D173035
2023-03-22 09:27:56 +00:00
Jens Stutte
bf3f183ac7 Bug 1813284 - Check KEY_MAXIMUM_BUFFER_LENGTH in EncodeNumber and propagate errors. r=dom-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D168366
2023-02-01 11:22:47 +00:00
Jens Stutte
161a998270 Bug 1774462 - Limit maximum key length to INT32_MAX. r=dom-storage-reviewers,jesup
Depends on D158929

Differential Revision: https://phabricator.services.mozilla.com/D158644
2022-10-14 17:52:23 +00:00
Narcis Beleuzu
1b59ca4f2a Backed out 2 changesets (bug 1774462) for xpcshell failure on test_keys.js . CLOSED TREE
Backed out changeset adfa13e465e6 (bug 1774462)
Backed out changeset ee137407c8b4 (bug 1774462)
2022-10-14 17:04:29 +03:00
Jens Stutte
a412f7c31c Bug 1774462 - Limit maximum key length to INT32_MAX. r=dom-storage-reviewers,jesup
Depends on D158929

Differential Revision: https://phabricator.services.mozilla.com/D158644
2022-10-14 12:47:35 +00:00
Norisz Fay
471359df88 Backed out 2 changesets (bug 1774462) for causing python related failures CLOSED TREE
Backed out changeset 98b981aedf23 (bug 1774462)
Backed out changeset d84cad727397 (bug 1774462)
2022-10-12 16:12:40 +03:00
Jens Stutte
0454144334 Bug 1774462 - Limit maximum key length to INT32_MAX. r=dom-storage-reviewers,jesup
Differential Revision: https://phabricator.services.mozilla.com/D158644
2022-10-12 12:52:49 +00:00
Marian-Vasile Laza
35b5ab0f34 Backed out changeset 01cef4e1c0f0 (bug 1774462) for causing xpcshell failures on test_keys.js. CLOSED TREE 2022-10-07 01:28:37 +03:00
Jens Stutte
43a1b9242d Bug 1774462 - Limit maximum key length to INT32_MAX. r=dom-storage-reviewers,jesup
Differential Revision: https://phabricator.services.mozilla.com/D158644
2022-10-06 21:40:42 +00:00
Marian-Vasile Laza
329f8a47c8 Backed out changeset 1424e1ec0927 (bug 1774462) for causing bustages on Key.obj. CLOSED TREE
Key.obj
2022-10-06 20:07:16 +03:00
Jens Stutte
be85f699c5 Bug 1774462 - Limit maximum key length to INT32_MAX. r=dom-storage-reviewers,jesup
Differential Revision: https://phabricator.services.mozilla.com/D158644
2022-10-06 16:26:12 +00:00
Kagami Sascha Rosylight
6abe98f452 Bug 1769290 - Part 8: Apply mozilla-js-handle-rooted-typedef against dom/canvas,crypto,fetch,gamepad,geolocation,indexedDB,ipc r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D148281
2022-06-05 20:54:59 +00:00
Serge Guelton
804d415fde Bug 1769311 - Cleanup dom/indexedDB headers r=sylvestre DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D146339
2022-05-30 10:02:39 +00:00
Jan Varga
adc8da34e9 Bug 1731960 - Move all Result extensions from QMResult.h to a dedicated file; r=dom-storage-reviewers,jari
Differential Revision: https://phabricator.services.mozilla.com/D126324
2021-11-30 05:05:51 +00:00
Yoshi Cheng-Hao Huang
817bdf1566 Bug 1719542 - Part 4: Make calling nsTArray::SetCapacity fallible. r=platform-i18n-reviewers,dminor
Originally nsCollation::AllocateRawSortKey used an infallible nsTArray[1],
however, for IndexedDB it used a fallible nsTArray instead[2], so making
SetCapacity fallible.

[1]: https://hg.mozilla.org/mozilla-central/rev/1a74809df6b9#l3.150
[2]: https://searchfox.org/mozilla-central/rev/ff5309e67b20a9976ea762f9ec5f657da0801490/dom/indexedDB/Key.cpp#673

Differential Revision: https://phabricator.services.mozilla.com/D129378
2021-10-25 18:23:12 +00:00
Yoshi Cheng-Hao Huang
f3f6bce604 Bug 1719542 - Part 3: Unify IndexedDB key. r=platform-i18n-reviewers,gregtatum
For Key::EncodeLocaleString change, the test should be convered in
dom/indexedDB/test/gtest/TestKey.cpp.

Differential Revision: https://phabricator.services.mozilla.com/D129000
2021-10-25 18:23:11 +00:00
Jan Varga
590fd74ae2 Bug 1728267 - Remove implicit ToResult from QM_TRY when no extra argument is passed in dom/indexedDB; r=dom-storage-reviewers,jstutte,jari
Differential Revision: https://phabricator.services.mozilla.com/D125318
2021-09-24 13:08:30 +00:00
Tooru Fujisawa
cc92ef732d Bug 1708448 - Move property and element functions into js/public/PropertyAndElement.h. r=nbp
Differential Revision: https://phabricator.services.mozilla.com/D119619
2021-07-13 11:52:42 +00:00
Jan Varga
42a2a6727f Bug 1709067 - IDB: Remove module specific QM_TRY macros; r=dom-storage-reviewers,jstutte
Differential Revision: https://phabricator.services.mozilla.com/D114080
2021-05-03 19:44:38 +00:00
Jan de Mooij
c7c11c1992 Bug 1674777 part 5 - Change GetObjectAs* APIs to use size_t for outparam instead of uint32_t. r=sfink,sg
Note that in the IndexedDB code we pass a Span to Key::EncodeAsString where we check
for large lengths.

Differential Revision: https://phabricator.services.mozilla.com/D103679
2021-02-01 17:15:00 +00:00
Simon Giesecke
64635ee87f Bug 1665347 - Do not indicate SpecialValues::Invalid could be returned on functions that never return it. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D90962
2020-10-06 08:39:04 +00:00
Simon Giesecke
9ad924671b Bug 1665347 - Make IDBResult based on mozilla::Result. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D90562
2020-10-06 08:37:59 +00:00
Sebastian Hengst
ae5e3a0d7c Backed out 5 changesets (bug 1666219, bug 1665347) for crashing hazard task. CLOSED TREE.
Backed out changeset c261ec06a826 (bug 1665347)
Backed out changeset 212c9df41410 (bug 1665347)
Backed out changeset 435f02d9f1d7 (bug 1665347)
Backed out changeset 7b36a79247b7 (bug 1666219)
Backed out changeset af8025162523 (bug 1665347)
2020-10-01 23:17:19 +02:00
Simon Giesecke
8841a4bec8 Bug 1665347 - Do not indicate SpecialValues::Invalid could be returned on functions that never return it. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D90962
2020-10-01 15:30:36 +00:00
Simon Giesecke
bac8dea615 Bug 1665347 - Make IDBResult based on mozilla::Result. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D90562
2020-10-01 15:30:36 +00:00
Bogdan Tara
104db9798f Backed out 5 changesets (bug 1666219, bug 1665347) for indexedDB related bustage CLOSED TREE
Backed out changeset 5cd7e2d67f91 (bug 1665347)
Backed out changeset 9159fdd05097 (bug 1665347)
Backed out changeset 64a086636738 (bug 1665347)
Backed out changeset 5ef18af381ec (bug 1666219)
Backed out changeset 3b81349a5f39 (bug 1665347)
2020-10-01 17:41:23 +03:00
Simon Giesecke
697e5f8715 Bug 1665347 - Do not indicate SpecialValues::Invalid could be returned on functions that never return it. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D90962
2020-10-01 12:04:27 +00:00
Simon Giesecke
7f8f90331d Bug 1665347 - Make IDBResult based on mozilla::Result. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D90562
2020-10-01 12:00:51 +00:00
Jeff Walden
6d5beafab1 Bug 1663365 - Move various Object-related functions to a new js/public/Object.h header. r=jandem
Differential Revision: https://phabricator.services.mozilla.com/D89333
2020-09-08 22:55:38 +00:00
Jeff Walden
e8f3f74ef6 Bug 1656411 - Move typed array, ArrayBuffer, and dataview-related functions out of jsfriendapi.h to two new headers. r=mgaudet,jgilbert
Differential Revision: https://phabricator.services.mozilla.com/D85524
2020-07-31 16:37:27 +00:00
Jan Varga
39831220cc Bug 1651016 - Convert remaining NS_ENSURE_SUCCESS to IDB_TRY in dom/indexedDB; r=dom-workers-and-storage-reviewers,ttung,sg
Differential Revision: https://phabricator.services.mozilla.com/D84315
2020-07-24 11:49:27 +00:00
Simon Giesecke
c9a11309ae Bug 1652002 - Remove ambiguity between mozilla::dom::indexedDB::Exception and mozilla::dom::Exception. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D83483
2020-07-15 12:45:37 +00:00
Simon Giesecke
880c2f04e1 Bug 1650765 - Perform optimization for strings encoded as single-bytes only. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D82355
2020-07-07 14:06:00 +00:00
Simon Giesecke
8156f04bd4 Bug 1650765 - Iterate over raw ranges in EncodeAsString. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D82354
2020-07-07 12:18:25 +00:00
Mihai Alexandru Michis
b0a62934ab Backed out 2 changesets (bug 1650765) for causing failures in EncodeAsString.
CLOSED TREE

Backed out changeset 784be0839695 (bug 1650765)
Backed out changeset 05f1ba04a8f4 (bug 1650765)
2020-07-07 15:15:57 +03:00
Simon Giesecke
a9a7e7d12b Bug 1650765 - Perform optimization for strings encoded as single-bytes only. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D82355
2020-07-07 11:13:04 +00:00
Simon Giesecke
3d46157ca7 Bug 1650765 - Iterate over raw ranges in EncodeAsString. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D82354
2020-07-07 10:59:20 +00:00
Simon Giesecke
56ce33133e Bug 1644379 - Change DecodeString to return string by value. r=dom-workers-and-storage-reviewers,asuth
Differential Revision: https://phabricator.services.mozilla.com/D78881
2020-06-30 10:03:11 +00:00
Simon Giesecke
0f183e6ce2 Bug 1644379 - Move ConvertArrayValueToKey to cpp file. r=dom-workers-and-storage-reviewers,asuth
Differential Revision: https://phabricator.services.mozilla.com/D78880
2020-06-30 10:02:53 +00:00
Simon Giesecke
0a6c4207a2 Bug 1644379 - Change ToLocaleAwareKey to return new Key by value. r=dom-workers-and-storage-reviewers,asuth
Differential Revision: https://phabricator.services.mozilla.com/D78879
2020-06-30 14:18:15 +00:00
Simon Giesecke
baeca05425 Bug 1644379 - Change IDBResult(Base) to contain the ErrorResult. r=dom-workers-and-storage-reviewers,asuth
Differential Revision: https://phabricator.services.mozilla.com/D78707
2020-06-30 11:17:40 +00:00
Narcis Beleuzu
03245fe61b Backed out 6 changesets (bug 1644379) for bustages on IDBResult.h . CLOSED TREE
Backed out changeset df76fe2ab8bf (bug 1644379)
Backed out changeset a22f8c2a1fe7 (bug 1644379)
Backed out changeset 1244dc147bb7 (bug 1644379)
Backed out changeset 88afa250d734 (bug 1644379)
Backed out changeset e90b2d69b818 (bug 1644379)
Backed out changeset c9690f97b893 (bug 1644379)
2020-06-30 13:54:22 +03:00
Simon Giesecke
5e5ea484e9 Bug 1644379 - Change IDBResult(Base) to contain the ErrorResult. r=dom-workers-and-storage-reviewers,asuth
Differential Revision: https://phabricator.services.mozilla.com/D78707
2020-06-30 10:01:03 +00:00