Some crash reports appear to be indicating that initializing NSS' certificate
and key databases is taking on the order of minutes in some cases, which is
unexpected. One hypothesis is that third-party software is opening these DBs at
the same time that NSS is operating on them, causing contention and thus
slowness. This patch experimentally (in Nightly only) renames these DBs in the
hopes that third-party software might not recognize them as the DBs it's
looking for, and will thus leave them alone.
Differential Revision: https://phabricator.services.mozilla.com/D126028
Doing so will prevent the leak checker from reporting an error when it
fails to find a leak log.
This test was previously disabled on Windows due to the failures, so we
can re-enable it now, hopefully.
Differential Revision: https://phabricator.services.mozilla.com/D126954
Depends on D126371
Now that the MarionetteEvents actors remain registered, MarionetteEventsChild.jsm and its Log.jsm dependencies both show up in the test browser_startup_content.js
Differential Revision: https://phabricator.services.mozilla.com/D126519
Some crash reports appear to be indicating that initializing NSS' certificate
and key databases is taking on the order of minutes in some cases, which is
unexpected. One hypothesis is that third-party software is opening these DBs at
the same time that NSS is operating on them, causing contention and thus
slowness. This patch experimentally (in Nightly only) renames these DBs in the
hopes that third-party software might not recognize them as the DBs it's
looking for, and will thus leave them alone.
Differential Revision: https://phabricator.services.mozilla.com/D126028
Depends on D126371
Now that the MarionetteEvents actors remain registered, MarionetteEventsChild.jsm and its Log.jsm dependencies both show up in the test browser_startup_content.js
Differential Revision: https://phabricator.services.mozilla.com/D126519
Some crash reports appear to be indicating that initializing NSS' certificate
and key databases is taking on the order of minutes in some cases, which is
unexpected. One hypothesis is that third-party software is opening these DBs at
the same time that NSS is operating on them, causing contention and thus
slowness. This patch experimentally (in Nightly only) renames these DBs in the
hopes that third-party software might not recognize them as the DBs it's
looking for, and will thus leave them alone.
Differential Revision: https://phabricator.services.mozilla.com/D126028
This is pretty much impossible to review as-is, so it may be more useful to review the script that made them. The repo is at https://github.com/htwyford/create-theme-script. parse-themes-script.js is the main script. It reads input.json. input.json is pulled from https://github.com/FirefoxUX/themes/blob/main/tokens/color/base.json, with some light edits to fix inconsistencies. The file in the FirefoxUX repo is an export of the colors in the Figma file: https://www.figma.com/file/xaRff6432QsirRftX8NZgb/MR2-Themes?node-id=86%3A17747.
The themes aren't perfect yet. For example, the text color in the Urlbar chiclet is sometimes wrong. They also don't consider the UX spec on badge colors, since UX is still actively updating that part of the spec. Since these themes are behind a pref, I think we should land it and fix the issues in followups. It will make it more clear what is changing when they're not being added en masse like this. Getting them in the tree ASAP also lets UX and QA get a head start on testing them.
Differential Revision: https://phabricator.services.mozilla.com/D125755
This is pretty much impossible to review as-is, so it may be more useful to review the script that made them. The repo is at https://github.com/htwyford/create-theme-script. parse-themes-script.js is the main script. It reads input.json. input.json is pulled from https://github.com/FirefoxUX/themes/blob/main/tokens/color/base.json, with some light edits to fix inconsistencies. The file in the FirefoxUX repo is an export of the colors in the Figma file: https://www.figma.com/file/xaRff6432QsirRftX8NZgb/MR2-Themes?node-id=86%3A17747.
The themes aren't perfect yet. For example, the text color in the Urlbar chiclet is sometimes wrong. They also don't consider the UX spec on badge colors, since UX is still actively updating that part of the spec. Since these themes are behind a pref, I think we should land it and fix the issues in followups. It will make it more clear what is changing when they're not being added en masse like this. Getting them in the tree ASAP also lets UX and QA get a head start on testing them.
Differential Revision: https://phabricator.services.mozilla.com/D125755
