nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity
771516 commits 1 branch 98 tags 6.4 GiB
Commit graph

250 commits

Author SHA1 Message Date
Gijs Kruitbosch
057a1bac29 Bug 1732446 - fix multiple tab warning for quit shortcut usage on Windows, r=NeilDeakin,mhowell 
Differential Revision: https://phabricator.services.mozilla.com/D126677
 2021-09-28 10:44:37 +00:00
Geoff Brown
019c21f335 Bug 1730213 - Explicitly skip tests under browser/ on android; r=ahal 
These tests are excluded from android test runs in moz.build. Including
an explicit annotation in each manifest avoids scheduling confusion.
browser-chrome and plain-chrome tests in browser/ are of no concern,
since those test types are never scheduled on android.

Differential Revision: https://phabricator.services.mozilla.com/D125266
 2021-09-13 15:22:27 +00:00
Neil Deakin
da4a527847 Bug 1726736, test for quit keyboard shortcut opening confirmation dialog, r=mhowell 
Depends on D124223

Differential Revision: https://phabricator.services.mozilla.com/D124856
 2021-09-08 12:32:58 +00:00
Christoph Kerschbaumer
4a6250387f Bug 1719272: Annotate failing browser/ tests to potentially enable https-first mode in Nightly r=webcompat-reviewers,denschub,webdriver-reviewers,preferences-reviewers,Gijs,whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D119177
 2021-07-28 19:16:16 +00:00
Sandor Molnar
68cdec0548 Backed out changeset 7eb8945dd8e3 (bug 1719272) for causing bustages in gecko decision task. CLOSED TREE 2021-07-28 19:47:06 +03:00
Christoph Kerschbaumer
bb716f0701 Bug 1719272: Annotate failing browser/ tests to potentially enable https-first mode in Nightly r=webcompat-reviewers,denschub,webdriver-reviewers,preferences-reviewers,Gijs,whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D119177
 2021-07-28 16:08:07 +00:00
Andrei Oprea
a66714326b Bug 1716736 - Add schema validation for experiment enrollments in tests r=k88hudson 
Differential Revision: https://phabricator.services.mozilla.com/D118367
 2021-07-26 14:48:22 +00:00
Dorel Luca
5a8b32e3c6 Backed out changeset e7dffca31fa7 (bug 1716736) for Browser-chrome failures in browser/components/shell/test/browser_setDefaultBrowser.js. CLOSED TREE 2021-07-26 14:08:51 +03:00
Andrei Oprea
9ae9067efe Bug 1716736 - Add schema validation for experiment enrollments in tests r=k88hudson 
Differential Revision: https://phabricator.services.mozilla.com/D118367
 2021-07-26 09:43:28 +00:00
Sandor Molnar
1fb5cc9576 Backed out changeset e5cfc59f9063 (bug 1716736) for causing bc failures in browser_setDefaultBrowser. CLOSED TREE 2021-07-26 01:17:51 +03:00
Andrei Oprea
cb62f517d4 Bug 1716736 - Add schema validation for experiment enrollments in tests r=k88hudson 
Differential Revision: https://phabricator.services.mozilla.com/D118367
 2021-07-25 21:01:16 +00:00
Ed Lee
43592e9cc2 Bug 1714466 - Relax upgrade dialog dependency on unrelated/deprecated prefs, e.g., whatsNewPanel and aboutwelcome r=pdahiya 
Check default pref branch instead of user when looking for enterprise policy changes.

Differential Revision: https://phabricator.services.mozilla.com/D118089
 2021-06-17 22:23:28 +00:00
Emily McMinn
ce4e4163cb Bug 1712869 - Set keyboard focus on the correct button for each screen of the upgrade modal r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D117364
 2021-06-15 17:12:23 +00:00
Ed Lee
9930a18c9b Bug 1633883 - TelemetryTestUtils.assertScalar assumes Number (so behaves odd for boolean, strings) r=chutten 
Split assertScalar to assertScalarUnset to allow the former to plain check the value including strings, false and 0.

Differential Revision: https://phabricator.services.mozilla.com/D117457
 2021-06-11 21:06:26 +00:00
Ed Lee
442a2844ac Bug 1715348 - Add telemetry environment boolean scalar for kept in macOS Dock r=pdahiya 
Add BrowserGlue task and telemetry Scalar matching is_taskbar_pinned but for macOS as is_kept_in_dock.

Differential Revision: https://phabricator.services.mozilla.com/D117346
 2021-06-10 20:58:08 +00:00
Ed Lee
a70a1dd61a Bug 1699842 - Keep Firefox in Dock for macOS where windows would Pin without showing images r=pdahiya,flod 
Update ShellService to also check mac pinned but only from the main process, so have AboutWelcomeChild request pinned for use in getDefaults and prepareContent. Remove windows images and consolidate back to single shared css without spacers and instead use margin: auto with logo that is no longer fixed. Split out pin strings to own screen/section and use PLATFORM. Add macOS default prompt message without touching existing windows one.

Differential Revision: https://phabricator.services.mozilla.com/D115967
 2021-05-28 11:04:22 +00:00
Ed Lee
43b619e124 Bug 1706963 - Close other window modal subdialog before quit/close window prompts r=Gijs 
Allow quit/close dialogs to jump the queue with new method gDialogBox.replaceDialogIfOpen().

Differential Revision: https://phabricator.services.mozilla.com/D114654
 2021-05-21 17:56:20 +00:00
Michelle Goossens
16dd2093e1 Bug 1711497 - Remove browser.proton.enabled checks/setters from tests r=Gijs,marionette-reviewers,whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D115539
 2021-05-20 13:03:51 +00:00
Ed Lee
30aa92212a Bug 1710955 - Also disable welcome in addition to upgrade for whats_new_page test r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D115325
 2021-05-18 04:41:51 +00:00
Ed Lee
851ab05cae Bug 1710955 - Change MR1 upgrade onboarding to Pin then Default then Theme screens r=fluent-reviewers,flod,pdahiya,k88hudson 
Copy / migrate strings from onboarding/defaultBrowserNotification. Add updated ltr/rtl images and show them for pin and pin+default. Dynamically adjust steps and record telemetry to identify what was shown. Handle button actions based on string ids. Alias upgradeDialog to aboutwelcome for now. Avoid oddness with scrollbars by hiding horizontal scroll.

Differential Revision: https://phabricator.services.mozilla.com/D115142
 2021-05-18 03:16:34 +00:00
Mike Conley
211654cace Bug 1708056 - Add a dedicated primary button string for the upgrade dialog for Win7. r=Mardak,fluent-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D114783
 2021-05-10 23:49:53 +00:00
Ed Lee
a1d5820111 Bug 1706279 - Tighten up upgrade dialog spacing on short windows to be more usable before showing scrollbar r=pdahiya 
Detect if there's not enough vertical space to switch to compact mode. Use selectors and variables to adjust font-sizes, margins, etc.

Differential Revision: https://phabricator.services.mozilla.com/D114421
 2021-05-06 19:10:48 +00:00
Andrei Oprea
118c11c21f Bug 1708652 - Add checks to remote defaults helper to ensure proper init r=k88hudson 
Differential Revision: https://phabricator.services.mozilla.com/D113945
 2021-05-05 15:54:57 +00:00
Ed Lee
49421f15f3 Bug 1707141 - [win7] Remove theme screen from upgrade onboarding r=pdahiya 
Detect old windows version to change content reusing an asrouter "Okay" string for now.

Differential Revision: https://phabricator.services.mozilla.com/D113583
 2021-04-29 06:30:11 +00:00
Alexandru Michis
68263598ff Backed out changeset 48f696159514 (bug 1707141) for causing bc failures in browser_browserGlue_upgradeDialog.js 
CLOSED TREE
 2021-04-29 07:32:43 +03:00
Ed Lee
95fc0ef210 Bug 1707141 - [win7] Remove theme screen from upgrade onboarding r=pdahiya 
Detect old windows version to change content reusing an asrouter "Okay" string for now.

Differential Revision: https://phabricator.services.mozilla.com/D113583
 2021-04-27 23:37:37 +00:00
Andrei Oprea
b49430337e Bug 1681130 - Remove the Set to Default notification bar r=Mardak,jaws 
Differential Revision: https://phabricator.services.mozilla.com/D112350
 2021-04-22 19:27:55 +00:00
Ed Lee
dde1e1b541 Bug 1706489 - Allow for calculating upgrade dialog funnel by first screen primary action r=nanj 
Reuse existing "show" event object to track which primary button was shown on the first screen. Update Events.yaml with longer description of expected values.

Differential Revision: https://phabricator.services.mozilla.com/D112837
 2021-04-21 07:42:13 +00:00
smolnar
928326cbad Backed out changeset 3ac594597045 (bug 1706489) for causing bc failures in browser_browserGlue_upgradeDialog. CLOSED TREE 2021-04-21 09:10:07 +03:00
Ed Lee
5f3fc79d7f Bug 1706489 - Allow for calculating upgrade dialog funnel by first screen primary action r=nanj 
Reuse existing "show" event object to track which primary button was shown on the first screen. Update Events.yaml with longer description of expected values.

Differential Revision: https://phabricator.services.mozilla.com/D112837
 2021-04-21 01:38:46 +00:00
Ed Lee
4ac931c5bc Bug 1705334 - Dismiss upgrade dialog on quit to allow quit window modal prompt to show r=andreio 
Observe "quit-application-requested" to close the dialog. Use TelemetryTestUtils.assertEvents to check all events.

Differential Revision: https://phabricator.services.mozilla.com/D112303
 2021-04-16 13:39:49 +00:00
Andrei Oprea
6a29893c48 Bug 1701948 - Early startup cache should work for Nimbus remote defaults r=k88hudson 
Differential Revision: https://phabricator.services.mozilla.com/D111320
 2021-04-15 19:50:39 +00:00
Csoregi Natalia
4fa1ee7dc0 Backed out changeset 90163e505c3f (bug 1701948) for failures on browser_remotesettingsexperimentloader_remote_defaults.js. CLOSED TREE 2021-04-15 21:58:41 +03:00
Andrei Oprea
61dd9a487a Bug 1701948 - Early startup cache should work for Nimbus remote defaults r=k88hudson 
Differential Revision: https://phabricator.services.mozilla.com/D111320
 2021-04-15 17:28:14 +00:00
Andrei Oprea
9e2dcb6f77 Bug 1702004 - Add Firefox logo to the default browser prompt title r=Gijs 
Check for headerIconURL in asyncConfirmEx to show a custom icon.

Differential Revision: https://phabricator.services.mozilla.com/D111233
 2021-04-14 20:08:45 +00:00
Andrei Oprea
459f8ef74c Bug 1702000 - Add pin to taskbar action to the primary button r=andreio 
Share needPin and pin methods from ShellService and reuse from default prompt, upgrade dialog and special message actions. Use these to show "primary" vs "default" in the prompt.

Differential Revision: https://phabricator.services.mozilla.com/D111244
 2021-04-14 15:09:34 +00:00
smolnar
f3478d8e96 Backed out changeset d39717cd014e (bug 1702000) for causing mochitest bc failures in browser_aboutNewTab_defaultBrowserNotification. CLOSED TREE 2021-04-14 15:27:51 +03:00
Andrei Oprea
04ea21b82b Bug 1702000 - Add pin to taskbar action to the primary button r=andreio 
Share needPin and pin methods from ShellService and reuse from default prompt, upgrade dialog and special message actions. Use these to show "primary" vs "default" in the prompt.

Differential Revision: https://phabricator.services.mozilla.com/D111244
 2021-04-14 10:24:19 +00:00
Ed Lee
3c994ce8a2 Bug 1701867 - Change set to default prompt from an infobar to a modal r=andreio 
Differential Revision: https://phabricator.services.mozilla.com/D111969
 2021-04-14 09:26:00 +00:00
Andrei Oprea
992e14ccbf Bug 1701998 - Change the checkbox behavior for the default browser prompt r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D111104
 2021-04-13 15:45:48 +00:00
Ed Lee
ada4e82ed0 Bug 1697222 - Record telemetry events for various upgrade dialog interactions. r=nanj 
Add new Events.yaml upgrade_dialog category and use various methods/objects to record behaviors.

Differential Revision: https://phabricator.services.mozilla.com/D111295
 2021-04-13 00:04:30 +00:00
Ed Lee
4d6ce279b5 Bug 1697222 - Show upgrade dialog without conflicting with existing default browser prompt. r=andreio 
Add new NimbusFeatures.upgradeDialog with fallback enabled pref. Remember if the browser just did a major uprgade and check other conditions for showing before other default browser messages.

Differential Revision: https://phabricator.services.mozilla.com/D111041
 2021-04-13 00:04:30 +00:00
Ed Lee
a6630203ad Bug 1697222 - Add window modal dialog for existing users on upgrade highlighting Proton improvements r=pdahiya,flod,sfoster 
Add new dialog with related scripts, strings and styles that can adjust the window modal backdrop to show off themes.

Differential Revision: https://phabricator.services.mozilla.com/D110330
 2021-04-13 00:04:30 +00:00
Adam Gashlin
98961ef486 Bug 1701542 - Use the correct default for the removed recentlyUsedOrder pref. r=mconley 
Differential Revision: https://phabricator.services.mozilla.com/D110051
 2021-03-29 02:33:53 +00:00
Bernard Igiri
3cf8013f16 Bug 1692303 - Flip default value to browser.ctrlTab.recentlyUsedOrder to false r=mstriemer,mconley,preferences-reviewers 
Changed default Ctrl+Tab preference to false and added UI migration to reset it for users who haven't not used the feature before.

Differential Revision: https://phabricator.services.mozilla.com/D109653
 2021-03-26 21:56:41 +00:00
Tom Schuster
98018ecb9a Bug 1692716 - Make browser_quit_disabled.js more robust. r=Gijs 
I realized that we wouldn't notice if the quit-application-requested observer wasn't called.

Differential Revision: https://phabricator.services.mozilla.com/D105121
 2021-02-23 21:23:24 +00:00
smolnar
834440de2e Backed out changeset b17481ba70ba (bug 1692716) for causing bc failures in browser_quit_disabled. CLOSED TREE 2021-02-15 17:12:36 +02:00
Tom Schuster
eabfd6e3f1 Bug 1692716 - Make browser_quit_disabled.js more robust. r=Gijs 
I realized that we wouldn't notice if the quit-application-requested observer wasn't called.

Differential Revision: https://phabricator.services.mozilla.com/D105121
 2021-02-15 10:28:36 +00:00
Mark Banner
263d555274 Bug 1608272 - Remove 'this' as the second argument to 'ChromeUtils.import', use object destructuring instead (test-only changes). r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D104683
 2021-02-11 22:02:15 +00:00
Tom Schuster
cb04d0eac4 Bug 52821 - Add a pref to disable the quit application shortcut. r=Gijs 
browser.quitShortcut.disabled=true will disable the Ctrl + Q shortcut on all platforms.

Differential Revision: https://phabricator.services.mozilla.com/D104189
 2021-02-10 17:02:57 +00:00