Commit graph

54 commits

Author SHA1 Message Date
Emilio Cobos Álvarez
e7931a521e Bug 1821871 - Remove redundant box in profiler panel. r=dao
This panel contained an inflexible <vbox> which wasn't allowed to
shrink. Adding flex-shrink to that would also work, but it's better to
just remove the redundant box.

To be honest I haven't fully worked out why this used to work (that
<vbox> had -moz-box-flex: 0 effectively, so this shouldn't work before
either).

However it's Saturday night and this is inside a popup, which still uses
legacy layout until bug 1809084 lands, so I'm going to guess a weird
interaction with that. I'm mildly curious, so I might properly debug
this on monday but... :)

Differential Revision: https://phabricator.services.mozilla.com/D172364
2023-03-13 16:16:34 +00:00
Sammy Khamis
679788710c Bug 1703053: Syncing spinner should be right-aligned r=markh,desktop-theme-reviewers,Itiel
Differential Revision: https://phabricator.services.mozilla.com/D171796
2023-03-08 20:01:48 +00:00
Itiel
1367cf8302 Bug 1577257 - Share logic behind panel headers across the UI r=willdurand,Gijs,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D160972
2022-11-17 21:34:34 +00:00
Mike Conley
d5e58d8433 Bug 1797548 - Move Unified Extensions panelview into its own dedicated lazily created panel. r=cmkm,willdurand
Differential Revision: https://phabricator.services.mozilla.com/D160403
2022-10-27 17:13:43 +00:00
Itiel
8178468355 Bug 1796992 - Improve CSS and appearance of the profiler popup r=julienw
Differential Revision: https://phabricator.services.mozilla.com/D159980
2022-10-26 17:13:49 +00:00
Emilio Cobos Álvarez
5be309d7fb Bug 1796735 - Remove useless flex attributes from panelviews. r=dao
These are probably copy-pasta. All panelviews flex because of:

  https://searchfox.org/mozilla-central/rev/c5c002f81f08a73e04868e0c2bf0eb113f200b03/browser/themes/shared/customizableui/panelUI-shared.css#135

Differential Revision: https://phabricator.services.mozilla.com/D159933
2022-10-21 12:52:12 +00:00
Emilio Cobos Álvarez
e83fac1f59 Bug 1795944 - Remove descriptionheightworkaround. r=Gijs
Stuff wraps properly now with flexbox emulation.

Differential Revision: https://phabricator.services.mozilla.com/D159621
2022-10-19 11:55:29 +00:00
Emilio Cobos Álvarez
f3801205ec Bug 1791691 - Don't close the menu when targeting the profiler info button. r=julienw
This already didn't work for keyboard uses. The button needs
closemenu="none" to do what it says.

Differential Revision: https://phabricator.services.mozilla.com/D157768
2022-09-21 16:43:17 +00:00
Itiel
cb90e8d127 Bug 1787666 - Make the panel/addon banner items a proper subviewbutton r=sfoster,desktop-theme-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D155796
2022-09-20 21:10:09 +00:00
Itiel
67c100af64 Bug 1789144 - Fix .panel-subview-body spacing issues r=dao
Differential Revision: https://phabricator.services.mozilla.com/D156377
2022-09-05 14:04:07 +00:00
William Durand
ca4e603ef2 Bug 1777484 - Allow to close unified extensions panel programmatically. r=rpl,Gijs
I also tried to defer the loading of the panel when it is about to be
open for the first time.

Differential Revision: https://phabricator.services.mozilla.com/D152401
2022-07-27 20:12:38 +00:00
Itiel
72978cc0a4 Bug 1705199 - Adjust padding for the Zoom menu item in order to have its height the same as the rest of the menu items r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D150336
2022-06-28 20:06:21 +00:00
Julien Wajsberg
ff988ebecd Bug 1639716 - [profiler] Remove the profiler disabling by private browsing r=jdescottes,gerald,devtools-backward-compat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D129417
2022-01-26 17:26:21 +00:00
Dão Gottwald
bfdf5027f7 Bug 1749717 - Let the profiler popup use more shared colors and relative font sizes instead of hardcoded ones. r=Itiel
Differential Revision: https://phabricator.services.mozilla.com/D135699
2022-01-13 09:09:50 +00:00
Jonathan Watt
2a9a0b264a Bug 1702501 - Remove print.tab_modal.enabled pref and old frontend print preview code. r=mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D134699
2022-01-06 18:55:38 +00:00
Gijs Kruitbosch
c132b26482 Bug 1745398 - fix fullscreen button in hamburger panel now that hiding panels from click events inhibits command events, r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D133486
2021-12-14 21:27:59 +00:00
Gijs Kruitbosch
19fa3ca917 Bug 1745348 - bookmark subview items shouldn't try to hide the panel themselves, breaking the command/oncommand handling, r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D133471
2021-12-14 21:27:51 +00:00
Rob Wu
d6767c7c9e Bug 1714846 - Really hide panels on hide, r=robwu,emilio
Differential Revision: https://phabricator.services.mozilla.com/D132574
2021-12-07 11:50:19 +00:00
Tooru Fujisawa
0a19cba72a Bug 1706650 - Split localization item for update banner label for each notification. r=zbraniecki,fluent-reviewers,Gijs
Instead of copying from label-* attributes, set data-l10n-id for each
notification

Also, stop using attributes for checking if the notification is supported.

Differential Revision: https://phabricator.services.mozilla.com/D129270
2021-10-26 18:32:36 +00:00
Julien Wajsberg
cc3ace47ca Bug 1730893 - [devtools profiler] Properly localize buttons in the profiler popup r=jdescottes,fluent-reviewers,desktop-theme-reviewers,nbaumgardner,harry,flod
This fixes a warning when Fluent translates these buttons: previously it
was removing the content, which we don't control. The proper way is
assigning attributes instead.

This also required touching the style a bit.

Differential Revision: https://phabricator.services.mozilla.com/D127678
2021-10-08 11:47:34 +00:00
Julien Wajsberg
ece5495dbe Bug 1681539 - [devtools performance] Localize all presets r=jdescottes,fluent-reviewers,flod
This uses the new FTL file to provide localizations for all presets in
all profiler UIs.

Differential Revision: https://phabricator.services.mozilla.com/D125216
2021-10-05 09:13:13 +00:00
Neil Deakin
97d95e925f Bug 1724962, when the uitour highlight opens from the show how button on the session restore infobar, also highlight the restore session option from the history menu when it is opened, r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D127198
2021-10-02 12:20:08 +00:00
Scott
2724568ff8 Bug 1729847 - Fixing Pocket panel auto closing on enter r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D125278
2021-09-10 23:38:34 +00:00
Molly Howell
cbafe2ba39 Bug 1727916 - Convert several customizable toolbar item names to sentence case. r=fluent-reviewers,flod,emalysz
This required migrating several strings to Fluent, and the bulk of this patch
is those migrations. The rest of the items matched up with an entry in the app
menu, so those items were switched over to use the app menu strings, and one
had to be copied in order to avoid adding a tooltip to the app menu item.

Differential Revision: https://phabricator.services.mozilla.com/D124270
2021-09-09 16:39:37 +00:00
Scott
f492bcff55 Bug 1693582 - Moving Pocket button panels to remote content process r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D122128
2021-09-08 16:11:34 +00:00
Katherine Patenio
416c5975bd Bug 1728460 - Migrate appmenu-viewcache.inc.xhtml to Fluent. r=mtigley,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D124404
2021-09-07 17:46:19 +00:00
Sandor Molnar
e3e47f564b Backed out changeset 63c10baf1578 (bug 1727916) for causing browser-chrome failures in en-US/appmenuitem. 2021-09-03 23:22:36 +03:00
Molly Howell
84c9447e39 Bug 1727916 - Convert several customizable toolbar item names to sentence case. r=fluent-reviewers,flod,emalysz
This required migrating several strings to Fluent, and the bulk of this patch
is those migrations. The rest of the items matched up with an entry in the app
menu, so those items were switched over to use the app menu strings.

Differential Revision: https://phabricator.services.mozilla.com/D124270
2021-09-03 19:26:59 +00:00
Katherine Patenio
8f2c7d787b Bug 1625478 - Convert appMenu* strings from browser.dtd to appmenu.ftl. r=mtigley,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D123167
2021-08-30 02:36:44 +00:00
Sam Foster
5206e479d9 Bug 1719463 - Part 12: Remove the Quit button(s) from the pre-proton appMenu view. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D121812
2021-08-10 05:29:34 +00:00
Sam Foster
b65024a336 Bug 1719463 - Part 11: Remove the Help button from the pre-proton appMenu view. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D121811
2021-08-10 05:29:34 +00:00
Sam Foster
ba9f1e0d39 Bug 1719463 - Part 10: Remove the devtools button from the pre-proton appMenu view. r=jdescottes,Gijs,mkaply
Differential Revision: https://phabricator.services.mozilla.com/D121810
2021-08-10 05:29:33 +00:00
Sam Foster
d59eb94ce3 Bug 1719463 - Part 9: Remove the More items button and its sub-view from the pre-proton appMenu view. r=Gijs,flod
Differential Revision: https://phabricator.services.mozilla.com/D121809
2021-08-10 05:29:33 +00:00
Sam Foster
a99e4754f2 Bug 1719463 - Part 8: Remove the File open, File save and Find buttons from the pre-proton appMenu view. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D121808
2021-08-10 05:29:33 +00:00
Sam Foster
9302af6664 Bug 1719463 - Part 7: Remove the Logins, Addons, Preferences and Print buttons from the pre-proton appMenu view. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D121807
2021-08-10 05:29:32 +00:00
Sam Foster
7e355195be Bug 1719463 - Part 6: Remove the Library item from the pre-proton appMenu view. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D121806
2021-08-10 05:29:32 +00:00
Sam Foster
d81c1b741c Bug 1719463 - Part 5: Remove the edit and zoom items from the pre-proton appMenu view. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D121805
2021-08-10 05:29:31 +00:00
Sam Foster
102b49c644 Bug 1719463 - Part 4: Remove the new window and session restore items from the pre-proton appMenu view. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D121804
2021-08-10 05:29:31 +00:00
Sam Foster
05f6d6a8d7 Bug 1719463 - Part 3: Remove the Protections Report items from the pre-proton appMenu view. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D121803
2021-08-10 05:29:31 +00:00
Sam Foster
47c7137278 Bug 1719463 - Part 2: Remove the Fxa items from the pre-proton appMenu view. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D121802
2021-08-10 05:29:30 +00:00
Sam Foster
873cf793d2 Bug 1719463 - Part 1: Remove the update banner items from the pre-proton appMenu view. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D121801
2021-08-10 05:29:30 +00:00
Gijs Kruitbosch
6e1012d2e4 Bug 1711508 - remove PanelUI.protonAppMenuEnabled property, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D117058
2021-07-07 22:15:50 +00:00
Emma Malysz
47957a154b Bug 1703150, ensure dev tools subview is shown when opening developer tools panel r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D118773
2021-06-25 18:50:47 +00:00
Mike Conley
2400d6b254 Bug 1700198 - Remove subviewbutton-iconic class from History and Synced Tabs panels. r=Gijs
Depends on D118623

Differential Revision: https://phabricator.services.mozilla.com/D118624
2021-06-24 20:27:48 +00:00
Mike Conley
d8bdffca8b Bug 1700198 - Remove most subviewbutton-iconic class usage from FxA panel. r=markh
This also removes code that handled the case where a Send Tab or Send Link to Device
menu needed to be populated when in the STATUS_NOT_CONFIGURED state. Since those menus
should be unavailable when in the STATUS_NOT_CONFIGURED state, we throw instead.

Depends on D118622

Differential Revision: https://phabricator.services.mozilla.com/D118623
2021-06-24 20:27:47 +00:00
Mike Conley
fe2f862a54 Bug 1700198 - Remove subviewbutton-iconic class from Bookmarks panel. r=mak
Depends on D118621

Differential Revision: https://phabricator.services.mozilla.com/D118622
2021-06-24 20:27:47 +00:00
Mike Conley
958f051aed Bug 1700198 - Remove subviewbutton-iconic class from Library panel markup. r=mhowell
Differential Revision: https://phabricator.services.mozilla.com/D118621
2021-06-24 20:27:46 +00:00
Henri Sivonen
7df7939f77 Bug 1713627 - Remove code obsoleted by the replacing the Text Encoding menu with one item. r=jaws,emk
Differential Revision: https://phabricator.services.mozilla.com/D116391
2021-06-21 12:09:01 +00:00
Dorel Luca
2118316ba4 Backed out changeset 4891a17c55e2 (bug 1713627) for Browser-chrome failures in docshell/test/browser/browser_bug673087-1.js. CLOSED TREE 2021-06-21 12:10:54 +03:00
Henri Sivonen
abbbf94915 Bug 1713627 - Remove code obsoleted by the replacing the Text Encoding menu with one item. r=jaws,emk
Differential Revision: https://phabricator.services.mozilla.com/D116391
2021-06-21 08:09:43 +00:00