nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity
839476 commits 1 branch 98 tags 6.4 GiB
Commit graph

146 commits

Author SHA1 Message Date
Otto Länd
31f5847a44 Bug 1821512: apply code formatting via Lando 
# ignore-this-changeset
 2023-04-16 15:45:26 +00:00
Lee Salzman
17121ddfaa Bug 1821512 - Update fuzz for Skia update. r=jrmuizel 
Differential Revision: https://phabricator.services.mozilla.com/D173326
 2023-04-16 15:34:50 +00:00
Natalia Csoregi
53631b0cfb Backed out 6 changesets (bug 1821512) for failures on browser_screenshots_test_full_page.js. CLOSED TREE 
Backed out changeset a31f2795710e (bug 1821512)
Backed out changeset 3985c29a6490 (bug 1821512)
Backed out changeset 0d9814a43a4d (bug 1821512)
Backed out changeset e5570884e8e4 (bug 1821512)
Backed out changeset efc92c86fafd (bug 1821512)
Backed out changeset 3222f6498a44 (bug 1821512)
 2023-04-16 11:30:32 +03:00
Lee Salzman
f678652f3c Bug 1821512 - Update fuzz for Skia update. r=jrmuizel 
Differential Revision: https://phabricator.services.mozilla.com/D173326
 2023-04-16 04:00:01 +00:00
Marco Bonardo
b5fd4292c5 Bug 1824117 - Use a custom content prefs group parser in DownloadLastDir. r=Gijs 
Make all file: URIs point to the same destination folder.
Make data: URIs point to a destination folder per mime-type. If a mime-type is
not provided it defaults to text/plain, per the data URI spec.
Introduce a migration path in content prefs to remove existing data and file
URIs, users will have to set them again though current ones are not particularly
useful.
Make getFileAsync an async function to simplify the code.

Differential Revision: https://phabricator.services.mozilla.com/D173472
 2023-04-14 16:15:59 +00:00
Abhishek Tiwari
a0830c7eed Bug 1820878 - Convert toolkit/mozapps/downloads to ESmodules . r=Standard8,extension-reviewers,application-update-reviewers,bytesized,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D172245
 2023-04-12 17:32:30 +00:00
Niklas Baumgardner
f4c184e905 Bug 1814917 - Crop screenshots from overlay when they are too big. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D174896
 2023-04-11 13:16:22 +00:00
Iulian Moraru
6e2eff1bc5 Backed out 6 changesets (bug 1821512) for causing multiple failures. CLOSED TREE 
Backed out changeset 97295a57babe (bug 1821512)
Backed out changeset 698104c7a5d1 (bug 1821512)
Backed out changeset 09aa18e47bf6 (bug 1821512)
Backed out changeset 20b46afb225f (bug 1821512)
Backed out changeset b531f604ea4c (bug 1821512)
Backed out changeset 0a7c0b0773d4 (bug 1821512)
 2023-04-11 10:10:41 +03:00
Lee Salzman
aea7f2d006 Bug 1821512 - Update fuzz for Skia update. r=jrmuizel 
Differential Revision: https://phabricator.services.mozilla.com/D173326
 2023-04-11 05:00:06 +00:00
Niklas Baumgardner
cb1468a860 Bug 1824430 - Update screenshots buttons styling. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D173708
 2023-03-30 15:30:21 +00:00
Niklas Baumgardner
7af2440201 Bug 1812631 - Use shared icons for screenshots buttons. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D172043
 2023-03-30 15:30:21 +00:00
Iulian Moraru
7b8409fc77 Backed out 2 changesets (bug 1824430, bug 1812631) for causing multiple mochitest failures. CLOSED TREE 
Backed out changeset 500e6e1d7092 (bug 1824430)
Backed out changeset 6d0d5de3be6e (bug 1812631)
 2023-03-30 04:44:53 +03:00
Niklas Baumgardner
b5b1a040f1 Bug 1824430 - Update screenshots buttons styling. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D173708
 2023-03-30 00:36:32 +00:00
Niklas Baumgardner
167ba02296 Bug 1812631 - Use shared icons for screenshots buttons. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D172043
 2023-03-30 00:36:31 +00:00
CanadaHonk
91709586ba Bug 1801379 - Migrate Sinon.jsm to an ES module r=extension-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,fxview-reviewers,devtools-reviewers,Standard8,nchevobbe,sclements,dimi,mconley,bytesized,robwu 
Migrated `testing/modules/Sinon.sys.mjs` to an ES module.

`testing` should now be 100% ESM 🎉

Differential Revision: https://phabricator.services.mozilla.com/D173643
 2023-03-29 07:34:10 +00:00
Niklas Baumgardner
190d1e4964 Bug 1811953 - Scroll when resizing near the edge. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D167614
 2023-03-22 21:02:49 +00:00
Niklas Baumgardner
56c696e37f Bug 1813394 - Updated screenshots overlay shrinks with window. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D168315
 2023-03-14 17:23:53 +00:00
Niklas Baumgardner
921a1dd0ad Bug 1781912 - Fix failing browser_screenshots_drag_test.js test. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D172460
 2023-03-14 17:23:29 +00:00
Mark Banner
80295c5a70 Bug 1812098 - Fix ESLint raised issues with no-shadow of builtinGlobals in browser .mjs files. r=Gijs,credential-management-reviewers,sgalich,fxview-reviewers,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D169463
 2023-03-14 09:13:48 +00:00
Niklas Baumgardner
d646763c9e Bug 1819306 - Set quickactions prefs for screenshots tests. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D171777
 2023-03-09 19:05:28 +00:00
Niklas Baumgardner
f4582ad433 Bug 1820234 - Add margin to screenshots panel buttons. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D172046
 2023-03-08 21:31:08 +00:00
Stanca Serban
cdaf1de237 Backed out changeset 47a62f76fe40 (bug 1813394) for causing mochitests failures in browser_screenshots_drag_test.js. 2023-03-08 17:37:43 +02:00
Niklas Baumgardner
0fd7834bac Bug 1813394 - Updated screenshots overlay shrinks with window. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D168315
 2023-03-07 21:25:10 +00:00
Noemi Erli
93ca893555 Backed out changeset a33c121cae89 (bug 1813394) for causing failures in browser_screenshots_test_downloads.js CLOSED TREE 2023-03-07 00:27:21 +02:00
Niklas Baumgardner
d57de84fe6 Bug 1813394 - Updated screenshots overlay shrinks with window. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D168315
 2023-03-06 21:23:27 +00:00
Neil Deakin
70cdb525f0 Bug 1815062, modify callers of DownloadPaths.sanitize so that some use the allowInvalidFilenames argument, r=Gijs 
Callers that use the filename to assign the default filename in a filepicker or save without a filepicker should use the default arguments, callers that validate a filename entered from a filepicker should supply false for compressWhitespaces, and true for allowInvalidFilenames

Differential Revision: https://phabricator.services.mozilla.com/D171002
 2023-02-28 18:57:24 +00:00
Niklas Baumgardner
c057486ca0 Bug 1801019 - Add telemetry for screenshots component. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D164948
 2023-02-25 17:26:34 +00:00
Sam Foster
ecb9ef18d8 Bug 1799211 - Place focus on the first panel button when opening screenshots UI. r=niklas 
Differential Revision: https://phabricator.services.mozilla.com/D168497
 2023-02-24 02:35:25 +00:00
Marian-Vasile Laza
5a3faecdb0 Backed out changeset d853ddfd853e (bug 1801019) for bc failures on browser_screenshots_telemetry_tests.js. CLOSED TREE 2023-02-23 21:11:16 +02:00
Niklas Baumgardner
26e4c6bc8a Bug 1801019 - Add telemetry for screenshots component. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D164948
 2023-02-23 17:37:01 +00:00
Butkovits Atila
f8a9ce74db Backed out changeset aaf82d1483ad (bug 1801019) for causing failures at browser_screenshots_telemetry_tests.js. CLOSED TREE 2023-02-21 23:04:05 +02:00
Niklas Baumgardner
ab7aa855c8 Bug 1801019 - Add telemetry for screenshots component. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D164948
 2023-02-21 19:59:09 +00:00
Niklas Baumgardner
f50ece2128 Bug 1799215 - Screenshots overlay buttons should have focus states. r=cmkm 
Differential Revision: https://phabricator.services.mozilla.com/D167583
 2023-01-31 16:20:48 +00:00
Gijs Kruitbosch
efef52fc92 Bug 1795255 - autofix duplicate imports in tests under browser/, r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D166179
 2023-01-31 11:48:41 +00:00
Csoregi Natalia
f58879060d Backed out changeset 13175567352f (bug 1811953) for failures on browser_screenshots_drag_scroll_test.js. CLOSED TREE 2023-01-26 19:21:30 +02:00
Niklas Baumgardner
fea63a2dbb Bug 1811953 - Scroll when resizing near the edge. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D167614
 2023-01-26 15:55:32 +00:00
Niklas Baumgardner
c8835ab0a7 Bug 1743887 - Crop screenshots when larger than max canvas size. r=sfoster,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D160565
 2023-01-24 23:51:33 +00:00
Neil Deakin
1d2e8169a6 Bug 1808918, use Untitled as the default filename when saving a file rather than index, r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D167028
 2023-01-23 14:53:21 +00:00
Butkovits Atila
9268f063c3 Backed out changeset 39f3534179a7 (bug 1743887) for causing failures at browser_screenshots_test_screenshot_too_big.js. 2023-01-18 03:30:07 +02:00
Niklas Baumgardner
405651327c Bug 1743887 - Crop screenshots when larger than max canvas size. r=sfoster,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D160565
 2023-01-17 19:03:33 +00:00
Niklas Baumgardner
7a6e5d7f03 Bug 1799546 - Screenshots buttons have proper contrast on hover. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D166567
 2023-01-12 14:41:18 +00:00
Niklas Baumgardner
febe5c1f27 Bug 1806590 - Downloading screenshot now shows panel in private windows. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D166341
 2023-01-10 22:00:17 +00:00
Emilio Cobos Álvarez
a14c746228 Bug 1805415 - Use activateItem() rather than click() to activate menuitems. r=Gijs,extension-reviewers,pip-reviewers,search-reviewers 
Bug 1805414 will move menu event handling to the DOM.

With that change the current synthetic click behavior of XUL menuitems
breaks. On current central, we rely on nsMenuFrame::HandleEvent not
getting called at all for synthetic clicks, and instead we just fire a
command event synchronously here:

  https://searchfox.org/mozilla-central/rev/a0d4f8f112c5c792ae272bf6ce50763ddd23ffa2/dom/xul/nsXULElement.cpp#1071

After my patch the command event is fired properly (potentially
asynchronously too) by the regular menu activation machinery, which is
preferable.

 * They fire a command event synchronously (even though on some
   platforms like macOS activating a context menu item is async).

 * They use a totally different codepath from what a user does.

 * They don't deal with native menus, etc.

We have a proper API for this (activateItem) which takes a much more
closer codepath to what users do, requires that the menu is shown, etc.
Use that API instead for testing.

As a benefit, tests now do not need to close the context menu manually
when clicking on a menu item (because we trigger the same code path as
users clicking the menu).

Differential Revision: https://phabricator.services.mozilla.com/D164567
 2022-12-15 03:11:55 +00:00
Cristian Tuns
b638ccfac9 Backed out 2 changesets (bug 1805415) for causing dt failures on browser_net_telemetry_throttle_changed.js CLOSED TREE 
Backed out changeset 5056d7df9f1e (bug 1805415)
Backed out changeset e13513500184 (bug 1805415)
 2022-12-14 08:52:21 -05:00
Emilio Cobos Álvarez
be1f057109 Bug 1805415 - Use activateItem() rather than click() to activate menuitems. r=Gijs,extension-reviewers,pip-reviewers,search-reviewers 
Bug 1805414 will move menu event handling to the DOM.

With that change the current synthetic click behavior of XUL menuitems
breaks. On current central, we rely on nsMenuFrame::HandleEvent not
getting called at all for synthetic clicks, and instead we just fire a
command event synchronously here:

  https://searchfox.org/mozilla-central/rev/a0d4f8f112c5c792ae272bf6ce50763ddd23ffa2/dom/xul/nsXULElement.cpp#1071

After my patch the command event is fired properly (potentially
asynchronously too) by the regular menu activation machinery, which is
preferable.

 * They fire a command event synchronously (even though on some
   platforms like macOS activating a context menu item is async).

 * They use a totally different codepath from what a user does.

 * They don't deal with native menus, etc.

We have a proper API for this (activateItem) which takes a much more
closer codepath to what users do, requires that the menu is shown, etc.
Use that API instead for testing.

As a benefit, tests now do not need to close the context menu manually
when clicking on a menu item (because we trigger the same code path as
users clicking the menu).

Differential Revision: https://phabricator.services.mozilla.com/D164567
 2022-12-14 10:25:17 +00:00
Niklas Baumgardner
f75d08ab66 Bug 1785293 - Downloading screenshot respects 'Always ask you where to save files'. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D158678
 2022-12-06 00:06:20 +00:00
Stanca Serban
7515134a78 Backed out changeset b080b41aecf4 (bug 1785293) for causing bc failures on browser_screenshots_test_escape.js. CLOSED TREE 2022-12-02 16:39:01 +02:00
Niklas Baumgardner
42e1023b26 Bug 1785293 - Downloading screenshot respects 'Always ask you where to save files'. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D158678
 2022-12-02 13:45:57 +00:00
Niklas Baumgardner
8e924f4f3d Bug 1801193 - Focus panel buttons when screenshots UI is opened. r=sfoster,cmkm 
Differential Revision: https://phabricator.services.mozilla.com/D162333
 2022-12-01 15:14:21 +00:00
Niklas Baumgardner
c7a9b55d2e Bug 1799212 - Escape screenshots when panel is focused. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D162879
 2022-12-01 15:14:21 +00:00