nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity
839476 commits 1 branch 98 tags 6.4 GiB
Commit graph

1637 commits

Author SHA1 Message Date
James Teow
06c6f14e38 Bug 1829877 - Remove browser from browserContentSourceMap after source has been used - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D176420
 2023-04-26 13:48:22 +00:00
James Teow
8329a650e3 Bug 1829672 - Ensure network event is from a top level load - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D176390
 2023-04-25 11:16:59 +00:00
James Teow
67d2b60534 Bug 1829578 - Allow hrefs of SERPs to be classified as non_ads_link - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D176243
 2023-04-24 14:54:29 +00:00
James Teow
26c970ec24 Bug 1816736 - Add in-content search tracking to SERP impression event - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D176242
 2023-04-24 14:54:28 +00:00
James Teow
62944933ed Bug 1828786 - Allow component categorization and ad_impression to occur on pages without ads - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D176159
 2023-04-24 14:54:28 +00:00
James Teow
8e9b6d5099 Bug 1824543 - Add shopping_tab_displayed and is_shopping_page to Impression Event - r=Standard8 
Since we rely on the child process to parse this information, we need to
wait until the child has reported the presence of the shopping page
before sending the Impression event.

Differential Revision: https://phabricator.services.mozilla.com/D175576
 2023-04-21 21:19:39 +00:00
James Teow
b447eb856c Bug 1816735 - Add expanded and submitted states - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D175546
 2023-04-21 20:22:21 +00:00
James Teow
9345673523 Bug 1816730 - Step 2: Allow targets in content process to register click events - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D175311
 2023-04-21 16:54:22 +00:00
James Teow
2a3dfda4ee Bug 1816730 - Step 1: Add target property for click events that can be detected in network processes - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D175160
 2023-04-21 16:54:21 +00:00
Marco Bonardo
d971eef683 Bug 1829192 - use PlacesTestUtils.getDatabaseValue more extensively. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D176075
 2023-04-21 08:42:26 +00:00
Mark Banner
d9eb36c440 Bug 1827624 - Restrict search SERP telemetry actors to https only pages. r=jteow 
We only monitor telemetry from sites that are already https-only.

Depends on D175422

Differential Revision: https://phabricator.services.mozilla.com/D175423
 2023-04-14 18:04:50 +00:00
Stephanie Cunnane
3962ebb39d Bug 1814776 - Implement the SERP abandonment event. r=Standard8,jteow 
Differential Revision: https://phabricator.services.mozilla.com/D171884
 2023-04-12 19:25:31 +00:00
James Teow
6b5742e06e Bug 1816729 - Implement the impression event for refinement buttons and shopping tabs - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D173691
 2023-04-03 14:01:26 +00:00
James Teow
cab323cdc1 Bug 1816729 - Implement the impression event for ad_sitelink, ad_sidebar - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D172753
 2023-04-03 14:01:26 +00:00
Barret Rennie
a85bf46599 Bug 1788954 - Convert toolkit/components/nimbus to ES modules r=Standard8,pip-reviewers,credential-management-reviewers,sgalich 
Differential Revision: https://phabricator.services.mozilla.com/D172850
 2023-03-30 20:51:58 +00:00
CanadaHonk
91709586ba Bug 1801379 - Migrate Sinon.jsm to an ES module r=extension-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,fxview-reviewers,devtools-reviewers,Standard8,nchevobbe,sclements,dimi,mconley,bytesized,robwu 
Migrated `testing/modules/Sinon.sys.mjs` to an ES module.

`testing` should now be 100% ESM 🎉

Differential Revision: https://phabricator.services.mozilla.com/D173643
 2023-03-29 07:34:10 +00:00
Dale Harvey
f5338ca629 Bug 1823543 - Add telemetry to distinguish trending results. r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D173093
 2023-03-28 13:28:44 +00:00
Mark Banner
36ab6611df Bug 1824173 - Enable ESLint configuration valid-jsdocs across the tree, disabling for currently failing locations. r=mossop,webcompat-reviewers,extension-reviewers,credential-management-reviewers,denschub,dimi,robwu 
Depends on D173450

Differential Revision: https://phabricator.services.mozilla.com/D173451
 2023-03-24 19:35:25 +00:00
James Teow
8e41ca6d42 Bug 1816728 - Add additional conditions on whether an ad is visible - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D171821
 2023-03-24 14:04:05 +00:00
James Teow
66a685a8aa Bug 1816728 - Add impression event for carousels - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D171820
 2023-03-24 14:04:04 +00:00
Emilio Cobos Álvarez
30e1917e4c Bug 1823187 - Don't asynchronously size searchbar popup. r=mak 
After bug 1809084, the popup positioning code became more sound,
including reliably positioning once after opening.

This code was asynchronously reducing the size of the popup, sometimes
after popup positioning.

Which means that if the popup had to slide (due to having many one-off
buttons), and we then shrunk it, the popup would be mispositioned.

There's no reason the getBoundsWithoutFlushing call has to be async
afaict, so just size the popup up-front.

Differential Revision: https://phabricator.services.mozilla.com/D172928
 2023-03-20 14:44:18 +00:00
Dale Harvey
66849540fe Bug 1822326 - Add ability to configure maximum trending suggestions. r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D172766
 2023-03-17 11:41:28 +00:00
Mark Banner
3803a78064 Bug 1775916 - Improve console message checking for browser_search_telemetry_sources_ads.js to avoid intermittent issues. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D172776
 2023-03-16 14:48:23 +00:00
Leslie Orellana
45f35c199c Bug 1821160 - Convert browser/actors/SearchSERPTelemetry. r=kpatenio,search-reviewers,Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D172099
 2023-03-13 16:30:27 +00:00
Mark Banner
b77c8a5a22 Bug 1781766 - Remove unnecessary parameters from searchForm urls in search engines. r=search-reviewers,mcheang 
Depends on D171990

Differential Revision: https://phabricator.services.mozilla.com/D172005
 2023-03-10 19:12:54 +00:00
Noah
3e5c4be1ba Bug 1821392 - Change Search and Address Bar telemetry docs to use titles for the probe names. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D172203
 2023-03-10 12:31:59 +00:00
Lina Butler
90aec3a9ca Bug 1817105 - Collect all New Tab Glean metrics permanently. r=daleharvey,chutten 
Original patch by Dale Harvey <dale@arandomurl.com>.

Differential Revision: https://phabricator.services.mozilla.com/D171661
 2023-03-08 23:52:21 +00:00
Dale Harvey
8a81a95209 Bug 1819775 - Add icon for trending suggestions. r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D171404
 2023-03-08 21:00:27 +00:00
Mark Banner
d6c71041f6 Bug 1821022 - Remove redundant search engine locales that were used for experiments. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D171990
 2023-03-08 17:46:53 +00:00
James Teow
43d503becd Bug 1819321 - Add meta attribute to .html files used in search tests - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D171571
 2023-03-03 15:45:48 +00:00
James Teow
24186697a2 Bug 1781888 - Prevent persist search tip from showing in telemetry test - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D165337
 2023-03-02 11:50:33 +00:00
James Teow
fb969de225 Bug 1814773 - Implement a basic SERP engagement event - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D169542
 2023-02-28 11:30:37 +00:00
Dale Harvey
31edb5e98c Bug 1811931 - Add support for trending suggestions. r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D167618
 2023-02-23 10:07:08 +00:00
Mark Banner
8acde8d74e Bug 1816934 - Update consumers of services/settings to import ES modules directly. r=leplatrem,extension-reviewers,settings-reviewers,credential-management-reviewers,sgalich,mconley,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D169934
 2023-02-17 19:32:06 +00:00
Cristian Tuns
b3bf09cc0d Backed out 6 changesets (bug 1816934, bug 1817182, bug 1817179, bug 1817183) for causing dt failures in browser_jsterm_autocomplete_null.js CLOSED TREE 
Backed out changeset 17d4c013ed92 (bug 1817183)
Backed out changeset cfed8d9c23f3 (bug 1817183)
Backed out changeset 62fe2f589efe (bug 1817182)
Backed out changeset 557bd773fb85 (bug 1817179)
Backed out changeset 7f8a7865868b (bug 1816934)
Backed out changeset d6c1d4c0d2a0 (bug 1816934)
 2023-02-17 10:51:33 -05:00
ogiorgis
690fadc913 Bug 1810702 - remove circular reference warnings r=firefox-source-docs-reviewers,sylvestre DONTBUILD 
Moreover it fixes the behavior of the right menu.

Depends on D170178

Differential Revision: https://phabricator.services.mozilla.com/D170179
 2023-02-17 12:38:03 +00:00
Mark Banner
aec4c1293b Bug 1816934 - Update consumers of services/settings to import ES modules directly. r=leplatrem,extension-reviewers,settings-reviewers,credential-management-reviewers,sgalich,mconley,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D169934
 2023-02-17 09:01:43 +00:00
Mark Banner
ab326b1b2a Bug 1816077 - Remove browser_healthreport.js as the test is covered elsewhere. r=search-reviewers,daleharvey 
The telemetry recording is already covered by test_source_searchbar in browser_search_telemetry_sources.js.

Depends on D169434

Differential Revision: https://phabricator.services.mozilla.com/D169435
 2023-02-11 09:48:34 +00:00
Mark Banner
186df6a70c Bug 1511273 - Re-enable browser_google_behavior.js on Linux code coverage. r=search-reviewers,daleharvey 
Testing on try, the issues appear to have gone away. If not we can investigate further or disable again.

Depends on D169433

Differential Revision: https://phabricator.services.mozilla.com/D169434
 2023-02-11 09:48:33 +00:00
Mark Banner
edfbf67767 Bug 1584886 - Remove browser_oneOffContextMenu_setDefault.js disabling for a test suite that is no longer run. r=search-reviewers,daleharvey 
This was originally disabled as it was a perma test failure on aarch64. However, those tests have now been disabled in bug 1620460

Therefore remove the restriction line as there's no use for it. If the tests are re-enabled in future, then we can re-assess if necessary.

Differential Revision: https://phabricator.services.mozilla.com/D169433
 2023-02-11 09:48:33 +00:00
Stephanie Cunnane
71b6b6b395 Bug 1813162 - Implement the SERP impression event. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D168172
 2023-02-09 04:03:37 +00:00
Marian-Vasile Laza
8b8b467a26 Backed out changeset 7d610bc570cd (bug 1813162) as requested by the dev, issue with the patch. CLOSED TREE 2023-02-08 21:17:51 +02:00
Stephanie Cunnane
fc95891f96 Bug 1813162 - Implement the SERP impression event. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D168172
 2023-02-08 18:53:28 +00:00
Gregory Pappas
b4f9754abc Bug 1804357 - Implement browser.search.query r=robwu,search-reviewers,Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D164700
 2023-02-02 21:47:27 +00:00
James Teow
76e9e9179b Bug 1807039 - Update telemetry.rst with urlbar-persisted specific info - r=Standard8 DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D165405
 2023-02-01 14:56:50 +00:00
Gijs Kruitbosch
efef52fc92 Bug 1795255 - autofix duplicate imports in tests under browser/, r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D166179
 2023-01-31 11:48:41 +00:00
Olivier Tilloy
6b81196ea8 Bug 1792816 - Always update the search engine placeholder name. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D165795
 2023-01-24 22:51:21 +00:00
Stephanie Cunnane
8b6bc39996 Bug 1806539 - Consolidate existing partner codes for Duck Duck Go and add a new partner code for ESR. r=Standard8,mcheang 
Differential Revision: https://phabricator.services.mozilla.com/D165342
 2023-01-20 17:24:08 +00:00
Gijs Kruitbosch
9946c4fcbb Bug 1810995 - update BrowserTestUtils.loadURI consumers to use loadURIString (automated) - browser - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D167153
 2023-01-19 20:16:42 +00:00
Mark Banner
d691c51a0d Bug 1808173 - Convert prompts imports to direct ES imports. r=Gijs,webdriver-reviewers,necko-reviewers,application-update-reviewers,credential-management-reviewers,valentin,whimboo,dimi,bytesized 
Differential Revision: https://phabricator.services.mozilla.com/D165794
 2023-01-16 13:32:20 +00:00