nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity
717538 commits 1 branch 98 tags 6.4 GiB
Commit graph

480 commits

Author SHA1 Message Date
Mark Banner
ad636194ef Bug 1437310 - Fix moving bookmarks across special folders. r=mak 
MozReview-Commit-ID: dj6dOwDxOT

--HG--
extra : rebase_source : 6cadd7079e935d20db9089cdc08f4bc19cfdd95c
 2018-02-12 21:51:08 +00:00
Francesco Lodolo (:flod)
5417ea18be Bug 1437583 - Split plural forms for Delete/Add bookmarks in separate strings r=standard8 
Since the number of tabs is not actually displayed, having two separate strings from 1 vs many is preferable.

MozReview-Commit-ID: y1dgvsCxmC

--HG--
extra : rebase_source : ad694b2dc7bc44128f909e91a90c4822c0698770
 2018-02-12 19:04:59 +01:00
Jared Wein
c8d331f4c9 Bug 1436575 - Autofix errors from no-compare-against-boolean-literal. r=standard8 
MozReview-Commit-ID: 66sXxnOWDgw

--HG--
extra : rebase_source : a0bf26e37a03a1e77476bdeedfc1af3ebec32f2a
 2018-02-08 12:57:31 -05:00
Mark Banner
50e5b04547 Bug 1437651 - Remove unused simulated-places-node references. r=mak 
MozReview-Commit-ID: 6JzFXRykF2W

--HG--
extra : rebase_source : c7fa0ce9f6c9f0fe611ed49644a02042c9c80a12
 2018-02-12 20:33:07 +00:00
Mark Banner
362505f227 Bug 1423896 - Make the All Bookmarks folder for the left pane of the Library a virtual query. r=mak 
MozReview-Commit-ID: HzJ9y1fiEz1

--HG--
extra : rebase_source : 27b0280e9dfef2626d187f9b8a81f23e4583302f
 2017-12-07 14:15:39 +00:00
Coroiu Cristina
1c85c04c62 Backed out 5 changesets (bug 1423896) for bustage at /src/toolkit/components/places/nsNavHistoryResult.cpp on a CLOSED TREE 
Backed out changeset 4012bc74e900 (bug 1423896)
Backed out changeset 12239646395f (bug 1423896)
Backed out changeset abf61cd5fb77 (bug 1423896)
Backed out changeset 569173c95238 (bug 1423896)
Backed out changeset 6401e950298d (bug 1423896)
 2018-02-07 14:07:31 +02:00
Mark Banner
7785b2e489 Bug 1423896 - Make the All Bookmarks folder for the left pane of the Library a virtual query. r=mak 
MozReview-Commit-ID: HzJ9y1fiEz1

--HG--
extra : rebase_source : 27b0280e9dfef2626d187f9b8a81f23e4583302f
 2017-12-07 14:15:39 +00:00
Kris Maglione
918ed6c474 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian 
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
extra : intermediate-source : 34c999fa006bffe8705cf50c54708aa21a962e62
extra : histedit_source : b2be2c5e5d226e6c347312456a6ae339c1e634b0
 2018-01-29 15:20:18 -08:00
Cosmin Sabou
9a65a40178 Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE 
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
 2018-01-30 07:17:48 +02:00
Kris Maglione
6476f95b13 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian 
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
 2018-01-29 15:20:18 -08:00
Brindusan Cristian
af8879d1eb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE 
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
 2018-01-30 02:32:43 +02:00
Kris Maglione
c276bb9375 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian 
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : rebase_source : c004a023389f1f6bf3d2f3efe93c13d423b23ccd
 2018-01-29 15:20:18 -08:00
Mark Banner
aa95c289e7 Bug 1432407 - Merge loops in PlacesController.onDrop now that sync transactions have been removed. r=mak 
MozReview-Commit-ID: JXaxRv10HQs

--HG--
extra : rebase_source : a161a002ebc2baf241e26badad295db3aeac8046
 2018-01-25 21:00:34 +00:00
Mark Banner
412e825e77 Bug 1131491 - Remove browser.places.useAsyncTransactions preference - async transactions are now the only version. r=mak 
MozReview-Commit-ID: 9EKNvA8Q9jo

--HG--
extra : rebase_source : 289082be4a1f086620bf0fe3008c2eacbdc6a9fa
 2018-01-22 13:36:41 +00:00
Mark Banner
a52122f988 Bug 1432112 - Remove the Move Bookmarks dialog as it doesn't work properly and has alternatives. r=mak 
MozReview-Commit-ID: LRqyjJeuoVt

--HG--
extra : rebase_source : 6f5d225f124fc0ecd3ed3fbeab46f951bd405a89
 2018-01-22 13:48:14 +00:00
Mark Banner
c0dcb9675d Bug 1425339 - Allow Places tree's selectItems() function to handle guids as well as ids. r=mak 
MozReview-Commit-ID: LmZ7AYXBsJ4

--HG--
extra : rebase_source : 0c238470a32341e32db928a0c9b726c7f60f8a5a
 2017-12-14 13:56:26 -06:00
Mark Banner
eb29a6ebba Bug 1425437 - Improve view batching when dropping/pasting to tags, use the actual bookmarks count, not the count of transactions. r=mak 
MozReview-Commit-ID: B6Bt8bHhh3e

--HG--
extra : rebase_source : 88e9fe36acb672bbfb92c24c844fb1f3171584b4
 2017-11-08 15:32:51 +00:00
Mark Banner
b0a7a885a6 Bug 1422724 - Remove unused constants in Places' controller.js. r=mak 
MozReview-Commit-ID: AWTTksnPUp8

--HG--
extra : rebase_source : 74747cd754f89ef42579d6f13884fa91db4ac641
 2017-12-04 12:09:03 +00:00
Mark Banner
eeb3c2a9bd Bug 1415877 - Merge transaction handling into one function for onDrop/paste. r=mak 
MozReview-Commit-ID: AMhuLyc98WO

--HG--
extra : rebase_source : c899e2804f016ac0629de7075537c3e5c5ac28d9
 2017-11-08 14:48:45 +00:00
Mark Banner
b71430bdda Bug 1415877 - Rework PlacesControllerDragHelper#onDrop and PlacesController#paste to make the transaction handling parts similar. r=mak 
MozReview-Commit-ID: BInw5oT0Ja5

--HG--
extra : rebase_source : ff7d351f4bb251a0bb75670704f806102114394c
 2017-11-08 12:02:30 +00:00
Mark Banner
a518974a10 Bug 1415877 - Remove unused type parameter to PlacesUIUtils#getTransactionForData. r=mak 
MozReview-Commit-ID: 3kZQ4vnCk3b

--HG--
extra : rebase_source : 2f3b2d190806ecd9d7cba40a0fed96f6b6b46b12
 2017-11-08 11:25:26 +00:00
Mark Banner
3c55451f9e Bug 1413843 - Improve speed of operations when pasting to the left-hand library pane by getting the right-hand pane to use for batching. r=mak 
MozReview-Commit-ID: 2Q1rIpIhmmM

--HG--
extra : rebase_source : 77239ba65f050a4272e58bf7d5d16bfd54ca6933
 2017-11-02 10:37:14 +00:00
Mark Banner
899903b124 Bug 1410940 - Unify the parts of onDrop and paste that get the transaction information. r=mak 
This also fixes inserting bookmarks on paste at the right insertion points.

MozReview-Commit-ID: Km93oZt1UHm

--HG--
extra : rebase_source : 1623c4e5402383f0189800bcb2e70c74703aff59
 2017-10-23 18:18:00 +01:00
Mark Banner
4af8c94122 Bug 1410940 - Make PlacesController#paste and PlacesControllerDragHelper#onDrop more similar to each other. r=mak 
MozReview-Commit-ID: EEFizNPmKpr

--HG--
extra : rebase_source : 9edd8bf17586e994e67959404c739e2f8ee57477
 2017-10-23 15:50:52 +01:00
Sebastian Hengst
46d4f832b2 Backed out 2 changesets (bug 1410940) for failing browser-chrome's browser/components/places/tests/browser/browser_controller_onDrop_tagFolder.js. r=backout 
Backed out changeset 1c78029ded02 (bug 1410940)
Backed out changeset 37ceb314b2b3 (bug 1410940)

--HG--
extra : rebase_source : af00f68a156b90ab4be05a3a283df450604daeaa
 2017-11-03 11:52:54 +01:00
Mark Banner
b4fcc3b3f9 Bug 1410940 - Unify the parts of onDrop and paste that get the transaction information. r=mak 
This also fixes inserting bookmarks on paste at the right insertion points.

MozReview-Commit-ID: Km93oZt1UHm

--HG--
extra : rebase_source : f37574dc8b38d3a39862735f4278eda4112ef2f3
 2017-10-23 18:18:00 +01:00
Mark Banner
4f75b383de Bug 1410940 - Make PlacesController#paste and PlacesControllerDragHelper#onDrop more similar to each other. r=mak 
MozReview-Commit-ID: EEFizNPmKpr

--HG--
extra : rebase_source : 7494eb65cdd422703a9a329e3b819cc7d41794a2
 2017-10-23 15:50:52 +01:00
Mark Banner
0e947c9d32 Bug 1411891 - Improve the performance of deleting bookmarks with async transactions. r=mak 
MozReview-Commit-ID: GL9nKfypie1

--HG--
extra : rebase_source : 5cd1c4d848dc32611349e25eb7297ba50890f0a9
 2017-10-26 10:14:14 +01:00
Margareta Eliza Balazs
1d0ba383ae Backed out changeset e17a2bca5391 (bug 1411891) for failing xpcshell in toolkit/modules/tests/xpcshell/test_NewTabUtils.js r=backout on CLOSED TREE 2017-10-31 14:19:52 +02:00
Mark Banner
d059b763bb Bug 1411891 - Improve the performance of deleting bookmarks with async transactions. r=mak 
MozReview-Commit-ID: GL9nKfypie1

--HG--
extra : rebase_source : ca8ec95e51899bc1fb18e7a39f42a96569a2d4d1
 2017-10-26 10:14:14 +01:00
Marco Bonardo
e3fddaf049 Bug 1405722 - Remove the IsLivemark() bookmarks observer from PlacesUIUtils. r=standard8 
MozReview-Commit-ID: 586IR54ggbm

--HG--
extra : rebase_source : f3d3c3e71bf92c0eecbd2e129517b7eefd70224d
 2017-10-10 12:05:19 +02:00
Sebastian Hengst
0a305fd2d1 Backed out changeset af8fdfac66fa (bug 1405722) for failing xpcshell's browser/components/places/tests/unit/test_PUIU_livemarksCache.js, at least on OS X 10.10 opt. r=backout on a CLOSED TREE 
--HG--
extra : amend_source : 57bce00f5654ad7abca1774d2be153e95492a58b
 2017-10-17 00:55:53 +02:00
Marco Bonardo
bf0fb7d1e7 Bug 1405722 - Remove the IsLivemark() bookmarks observer from PlacesUIUtils. r=standard8 
MozReview-Commit-ID: 586IR54ggbm

--HG--
extra : rebase_source : 6a714c0ab4154b219195cafee6cdfe8c3c9c5211
 2017-10-10 12:05:19 +02:00
Dan Banner
7caa92d5d8 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8 
MozReview-Commit-ID: Jm8BRgt6mIv
 2017-10-15 20:50:39 +01:00
Peter Van der Beken
c705293c1c Bug 1383059 - Remove instanceof for supplemental interfaces. Part 1: add Window.isChromeWindow and switch |instanceof [nsIDOM]ChromeWindow| to use it instead. r=bz. 
--HG--
extra : rebase_source : 1efc83abae922c1a7b7eb855fd10a6333615044b
extra : source : 32277b160af4739c812ca2750a39ca111b16ea69
 2017-10-06 13:47:27 +02:00
Marco Bonardo
e5991df3ec Bug 1405687 - Remove some deprecated code from Places related code. r=standard8 
MozReview-Commit-ID: 411z07otlfN

--HG--
extra : rebase_source : 43f91cb30a7ad85f633b653d153a657ebdad1893
 2017-10-04 16:33:46 +02:00
Mark Banner
50a5c3faec Bug 1392533 - Make the places tree view directly communicate batch notifications to the results. r=mak 
MozReview-Commit-ID: HpN0v0jSwdK

--HG--
extra : rebase_source : 49a4810e5a85cf9f040fd544546479ad19ddf5b8
 2017-09-27 15:26:35 +01:00
Mark Banner
83d88f0a96 Bug 1400846 - Fix ordering of bookmarks with Async Transactions when dropping into different folders. r=mak 
MozReview-Commit-ID: GjnehR5PumZ

--HG--
extra : rebase_source : a913bf0584803993f9c5ecd061acdc1b40264254
 2017-09-19 06:54:16 +01:00
Mark Banner
8332d2278d Bug 1401242 - Fix removing bookmarks from tag groups - when getting the tagGuid from the node, we must get it async, rather than using the concrete guid. r=mak 
MozReview-Commit-ID: 7fGS6jFNVPl

--HG--
extra : rebase_source : 67306adaa925b32bae8fe928b77692842304be9a
 2017-09-19 20:47:26 +01:00
Michael Layzell
c24551af0d Bug 1398471 - Read data from DataTransfer before yielding, r=gijs 
Previously the code looped and yielded between each loop. This caused the
DataTransfer to be cleared before the read completed.

This splits the loop into 2 sections such that we read all important data from
the DataTransfer before it is cleared.
 2017-09-13 11:45:48 -04:00
Mark Banner
087ed06f51 Bug 1396888 - Handle async moving of bookmarks in the caller for the move dialog, to avoid going out of scope whilst async actions are happening. r=mak 
MozReview-Commit-ID: JhETMnmxNOD

--HG--
extra : rebase_source : ff7b201900d06c7d9feafb791dea03d19ec4bdcd
 2017-09-05 17:15:58 +01:00
Mark Banner
54aa7112b3 Bug 1391166 - Fix the order of bookmarks via drag and drop when moving a bookmark down in the list. r=mak 
MozReview-Commit-ID: 7Adz2Et0NQn

--HG--
extra : rebase_source : 5354b6c0799d84562e49f26225ecfdd47be29782
 2017-08-23 12:24:53 +01:00
Mark Banner
e83b03bdda Bug 1392189 - Fix deleting bookmark tags from the Library view with Places Transactions enabled. r=mak 
MozReview-Commit-ID: unNGjPpTX6

--HG--
extra : rebase_source : 21fee324ede6d516b0ae4dccc093644c2f738b8b
 2017-08-23 13:40:44 +01:00
Marco Bonardo
f32ef43797 Bug 1382991 - Cleanup Places controller InsertionPoint. r=standard8 
MozReview-Commit-ID: 2pSbYtPGtYx

--HG--
extra : rebase_source : a66e444f03ad45ff9d9a0e622d1951cff5964082
 2017-08-03 12:16:36 +02:00
Rajesh Kathiriya
48e6bc2124 Bug 1374620 - Enabled the ESLint dot-notation rule across mozilla-central r=standard8 
MozReview-Commit-ID: FadrI2li43G

--HG--
extra : rebase_source : b455e846ab79c8141150517e67e542e3e06d630e
 2017-07-25 23:45:41 +05:30
Marco Bonardo
7f236c3765 Bug 1094818 - Use Bookmarks.jsm in controller.js. r=standard8 
MozReview-Commit-ID: 7vli02K19bt

--HG--
extra : rebase_source : a28bfe52ea3672b5342b44890198703c455e92cb
 2017-07-18 19:18:02 +02:00
Sebastian Hengst
804a36e668 Backed out changeset f5922a7ed25a (bug 1374620) for failing eslint at telemetry/tests/unit/test_TelemetrySend.js:358: ["os"] is better written in dot notation. r=backout 2017-07-31 14:44:34 +02:00
Rajesh Kathiriya
22dfa54ef4 Bug 1374620 - Enabled the ESLint dot-notation rule across mozilla-central r=standard8 
MozReview-Commit-ID: FadrI2li43G

--HG--
extra : rebase_source : 5992bdde34bcc2421350433bc8c1e498a6bba848
 2017-07-25 23:45:41 +05:30
Mark Banner
10e375a830 Bug 1376531 - Fix some issues when enabling async places transactions - updating bookmarks names and pasting bookmarks. r=mak 
MozReview-Commit-ID: 4sqbSMtMkDD

--HG--
extra : rebase_source : a227a56c8da60c748cd5543dae37bc95bb07923e
 2017-06-27 12:54:16 -07:00
Paolo Amadini
10ee6a5c4e Bug 1362970 - Part 2 - Script-generated patch to convert .then(null, ...) to .catch(...). r=florian 
Changes to Promise tests designed to test .then(null) have been reverted, and the browser/extensions directory was excluded because the projects it contains have a separate process for accepting changes.

MozReview-Commit-ID: 1buqgX1EP4P

--HG--
extra : rebase_source : 3a9ea310d3e4a8642aabbc10636c04bfe2e77070
 2017-06-19 11:32:37 +01:00
Rajesh Kathiriya
fafb858b26 Bug 1370225 - Enabled the ESLint comma-style rule across mozilla-central. r=standard8 
MozReview-Commit-ID: 9OhLgBpYS4L

--HG--
extra : rebase_source : 5155e715934e7acd2ffadb4856eb91f481cbf56c
 2017-06-15 18:24:17 +01:00
Florian Quèze
5e3539e504 Bug 1353542 - massive script-generated patch converting Task.async and Task.spawn calls, and generators clearly identifiable as tasks, rs=Mossop. 2017-05-12 14:42:39 +02:00
milindl
d901d9c90a Bug 1247201 - Run cleaners async to clear as much as possible r=mak 
Amended to fix review changes
(stylistic + other)
Turns all cleaners into promises so they run asyc

MozReview-Commit-ID: DV5ug6vNXkS

--HG--
extra : rebase_source : df9d9cd98f25e2a899c0a74f836f217d3ad52426
 2017-03-27 19:27:35 +05:30
Marco Bonardo ext:(%20%3Cmbonardo%40mozilla.com%3E)
6ed7963bc1 Bug 1306276 - Deprecate History RemovePage and RemovePages. r=standard8 
MozReview-Commit-ID: 3NSaXKy1hP3

--HG--
extra : rebase_source : da03f694db3b690cfceba3a7a6c62832b8b1930c
 2017-03-22 12:44:54 +01:00
David Rajchenbach-Teller
5279acbebf Bug 1087255 - Convert browser/components/places JS clients of RemovePage(s) to History.remove; Patch by Yoric, updated by Standard8. r=mak 
MozReview-Commit-ID: GcVajWOyvkT
 2014-10-31 12:39:02 +01:00
Tooru Fujisawa
d2037e755b Bug 1302661 - Add multiple bookmark items when multiple URLs are dropped as single item. r=mak 2014-02-06 01:38:31 +09:00
Jared Wein
9141469edf Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN 
MozReview-Commit-ID: FuVu8skcqOe

--HG--
extra : rebase_source : 8ab34c4e46a7c3075b459bf44786ec184d10d203
 2016-12-30 21:47:25 -05:00
Jared Wein
ecab54a7c9 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN 
MozReview-Commit-ID: 7E7LPorrEje

--HG--
extra : rebase_source : 0572a35415a766a3f31d266760ecd07f0dcc3f72
 2016-12-29 18:34:54 -05:00
Wes Kocher
0dfb7c2b5c Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout 
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
 2016-12-29 14:05:44 -08:00
Jared Wein
7255df4e9a Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN 
MozReview-Commit-ID: 8WoGr8i6oCR

--HG--
extra : rebase_source : da7172285d43b820421557ed3b05887e091ff939
 2016-12-29 15:20:47 -05:00
Pavan
45820e1605 Bug 1196395 - No plurals form for context menus when multiple pages are selected in Library. r=mak 2016-12-21 10:06:00 +01:00
Jared Wein
3718f00db1 Bug 1316870 - Enable no-shadow eslint rule for browser/. r=mossop 2016-11-15 22:58:30 -05:00
Dave Townsend
8de07a19a0 Bug 1316882: Turn on space-before-function-paren eslint rule (browser). r=jaws 
MozReview-Commit-ID: 2ZvTiZDHchz

--HG--
extra : rebase_source : db6482481b7338df491afd6f6fd376eccec84d7e
 2016-11-11 08:10:51 -08:00
Dave Townsend
0a2c8f9b78 Bug 1316882: Turn on space-infix-ops eslint rule. r=jaws 
MozReview-Commit-ID: HBpjT2uHJaZ

--HG--
extra : rebase_source : 78fe71a1d673a1c698520a9c82c6f35959614f8f
 2016-11-10 14:48:04 -08:00
Mark Banner
a41b5adcb0 Bug 1314918 - Fix most of the remaining no-unused-vars issues for local scope in browser/. r=mossop 
MozReview-Commit-ID: LdoXLniNeT7

--HG--
extra : rebase_source : d2418b8cfab0a399d0dfb5a96ea50c62fac63e70
 2016-11-03 11:51:48 +00:00
Jared Wein
fd84c776c7 Bug 1292042 - Enable the keyword-spacing rule for eslint. Most of this patch was autogenerated by 'eslint --fix'. Files with .xml extension needed to be changed by hand due to limitations of custom plugin. r=markh 
MozReview-Commit-ID: EMjJ3yWt9Wt

--HG--
extra : rebase_source : 2b8327e5a7cf0bfd190d696ad5fe475f13faa3cc
 2016-08-04 03:28:58 -04:00
Pushpankar
c6670d980f Bug 1286854 - Replace ownerDocument.defaultView with ownerGlobal in browser/. r=dao 
--HG--
extra : rebase_source : 72d50e73baf595840a2aade57ae782e4c40d4c27
 2016-07-16 10:20:04 +02:00
Mike de Boer
da651f3cb1 Bug 1248616 - move simulated places nodes after a successful drag 'n drop operation, which applies to Recently Bookmarked items. r=mak 2016-05-31 11:06:37 +02:00
Sebastian Hengst
242a48ea88 Backed out changeset 4dbe106594fa (bug 1248616) for failing browser_423515.js. r=backout 2016-05-30 20:28:52 +02:00
Mike de Boer
daf1b7bb29 Bug 1248616 - move simulated places nodes after a successful drag 'n drop operation, which applies to Recently Bookmarked items. r=mak 2016-05-30 16:47:09 +02:00
Mike de Boer
08e2673c63 Bug 1248267 - allow Recently Bookmarked items to be special root nodes to allow primitive contextual actions. r=mak,dao 2016-05-19 12:37:33 +02:00
Dão Gottwald
ac879e2e39 Bug 1248268 - Add option for disabling the "Recently Bookmarked" UI. r=mak 2016-04-29 13:43:59 +02:00
Marco Bonardo
1a2184ee13 Bug 1251446 - Can't delete more than 300 items from history treeviews. r=trivial-typo-fix 
MozReview-Commit-ID: CoMlnL0Wwht

--HG--
extra : rebase_source : f34984362c5bd2b9940a2241702168bd8c4abad5
extra : amend_source : a34e9cf5a878bc772c5b6decd40e8782d9024a57
 2016-02-26 16:16:48 +01:00
Dave Townsend
0a6414b898 Bug 1245649: Turn on no-trailing-spaces. r=Gijs 
--HG--
extra : commitid : F2OWKTvXUO4
extra : rebase_source : ec68631342e0edc59d77b6bab1cdc975ad175327
 2016-02-03 14:22:33 -08:00
Marco Bonardo
7eb562e238 Bug 1230471 - Basic eslint fixes in places. r=mconley 
--HG--
extra : commitid : 3qDaDd3cKSc
extra : rebase_source : 8dc99f1b7dc0bb7bb7b9059ff4d8527685a50291
 2015-12-10 06:46:49 -05:00
simplyblue
34af26c5b6 Bug 1228976 - Remove array comprehensions from Places .r=mak 2015-12-03 16:26:58 +05:30
Hassen ben tanfous
45492f28fb Bug 1074804 - Replace arrays .indexOf with .includes in Places. r=mak 2015-10-11 20:24:32 +02:00
Kapeel Sable
8b36eb6981 Bug 1212171 - Change for referencing a different object Component.utils. instead of Cu. r=mak 2015-10-08 06:53:00 +02:00
Tooru Fujisawa
3fc2581f0c Bug 1207491 - Part 10: Remove use of expression closure from browser/components/places/content/. r=Gijs 
--HG--
extra : commitid : LlW5LSkRgzy
extra : rebase_source : 1b1038758a0c4b83fe8e00ebe397065def10cf7c
 2015-09-23 18:36:21 +09:00
Shu-yu Guo
64db2267cf Bug 1202902 - Mass replace toplevel 'let' with 'var' in preparation for global lexical scope. (rs=jorendorff) 2015-09-15 11:19:45 -07:00
Marco Bonardo
27836eca10 Bug 1095411 - PlacesUtils.wrapNode is using synchronous getKeywordForBookmark. r=ttaubert 2015-05-22 19:02:41 +02:00
Asaf Romano
3e864279a2 Bug 951651 - Make bookmarkProperties, Star UI and Library info pane work with PlacesTransactions. r=mak 2015-04-23 16:34:55 +03:00
Carsten "Tomcat" Book
113727c6bc Backed out changeset 7f9114a84892 (bug 951651) for bc2 test bustage on a CLOSED TREE 2015-04-23 08:52:56 +02:00
Asaf Romano
7f68adcfa1 Bug 951651 - Make bookmarkProperties, Star UI and Library info pane work with PlacesTransactions. r=mak. 2015-04-23 08:15:21 +03:00
Marco Bonardo
cb44324272 Bug 1144571 - Pasting multiple bookmarks should retain their order. r=ttaubert 2015-03-28 14:00:11 +01:00
Tom Schuster
25b1ed7fdf Bug 821724 - Implement a menuitem for places/bookmarks to open them in a private window. r=mak 2015-01-13 21:18:33 +01:00
Marco Bonardo
b34a02ceac Bug 1095069 - Cannot copy or delete bookmarks from search results in library. r=mano 
--HG--
rename : browser/components/places/tests/browser/browser_library_left_pane_commands.js => browser/components/places/tests/browser/browser_library_commands.js
 2014-11-13 10:19:19 +01:00
Asaf Romano
a63486fa3f Bug 982115 - PlacesTransactions: (1) Decouple |transact| and |batch|, and make batch work like Task.spawn, rather than the custom solution we had so far (yielding transactions rather than calling |transact| for the batched transactions). so that |transact| may be called during a batch from any function, not limiting the batch 'context' to the function passed to |batch|; (2) Rename the uri input property to URL, and allow passing DOM URL objects for it (in addition to plain specs and nsIURI objects) - this matches recent Bookmark.jsm and History.jsm work; (3) Improve the module documentation. r=mak. 2014-11-10 10:36:56 +02:00
Gijs Kruitbosch
386c4ea334 Bug 1090609 - don't disable open in tabs when there's only one item there, r=mak 2014-11-03 10:44:47 +00:00
Asaf Romano
d83f8d60e1 Bug 1068671 - folderReadOnly doesn't pertain to bookmarks or results. r=mak 2014-10-14 17:03:28 +03:00
Carsten "Tomcat" Book
459781f902 Backed out changeset b30d47d94a85 (bug 1068671) for bc1 test failures 2014-10-01 13:14:06 +02:00
Asaf Romano
896f516dd7 Bug 1068671 - Remove 'read-only' folders support from places. r=mak 2014-10-01 12:19:06 +03:00
Asaf Romano
464d71888d Bug 1070503 - Async Places Transactions: Delete command implementation. r=mak. 2014-09-23 09:11:26 +03:00
Asaf Romano
5786c4db38 Bug 1069235 - make guid and parentGuid naming consistent. r=mak 2014-09-20 10:57:34 +03:00
Asaf Romano
268a8a3563 Fix the 'bustage' of browser_parsable_script.js coming from bug 1067954 by whitelisting controller.js. It broke due to bug 1015578 (see mak's comment 2 there). CLOSED TREE 2014-09-19 18:23:20 +03:00
Asaf Romano
00c2d6bc3f Bug 1067956 - Async Places Transactions: Drop functionality. r=mak. 2014-09-19 17:04:51 +03:00
Asaf Romano
0493c2157b Bug 1067954 - Async Places Transactions: Paste functionality. r=mak 2014-09-19 16:53:27 +03:00
Gijs Kruitbosch
e0a07f062e Bug 1006989 - hide and disable cut/copy/delete/properties when opening bookmarks context menu with no selection, r=mano 2014-06-05 15:28:07 +01:00
Jim Blandy
7e20285e70 Bug 914753: Make Emacs file variable header lines correct, or at least consistent. DONTBUILD r=ehsan 
The -*- file variable lines -*- establish per-file settings that Emacs will
pick up. This patch makes the following changes to those lines (and touches
nothing else):

 - Never set the buffer's mode.

   Years ago, Emacs did not have a good JavaScript mode, so it made sense
   to use Java or C++ mode in .js files. However, Emacs has had js-mode for
   years now; it's perfectly serviceable, and is available and enabled by
   default in all major Emacs packagings.

   Selecting a mode in the -*- file variable line -*- is almost always the
   wrong thing to do anyway. It overrides Emacs's default choice, which is
   (now) reasonable; and even worse, it overrides settings the user might
   have made in their '.emacs' file for that file extension. It's only
   useful when there's something specific about that particular file that
   makes a particular mode appropriate.

 - Correctly propagate settings that establish the correct indentation
   level for this file: c-basic-offset and js2-basic-offset should be
   js-indent-level. Whatever value they're given should be preserved;
   different parts of our tree use different indentation styles.

 - We don't use tabs in Mozilla JS code. Always set indent-tabs-mode: nil.
   Remove tab-width: settings, at least in files that don't contain tab
   characters.

 - Remove js2-mode settings that belong in the user's .emacs file, like
   js2-skip-preprocessor-directives.
 2014-06-24 22:12:07 -07:00
Asaf Romano
971075f2a7 Bug 993391 - Places async transactions: Implement "move bookmarks" command. r=mak. 2014-04-22 08:42:23 +03:00