Commit graph

138 commits

Author SHA1 Message Date
Ciure Andrei
befcb6cb4f Merge mozilla-central to mozilla-inbound. a=merge CLOSED TREE 2018-02-23 02:06:26 +02:00
Paolo Amadini
f37e407659 Bug 1439358 - Part 2 - Don't use the "current" property when restoring focus from the blocked downloads subview. r=Gijs
MozReview-Commit-ID: ASmmdQMctr5

--HG--
extra : rebase_source : 7d990c407e63e6c5a2db3c644e84da7f243e9909
2018-02-22 12:20:53 +00:00
Brendan Dahl
aa526601d4 Bug 1434077 - Inline indicators overlay. r=Paolo
This is part of the work to remove XUL overlays. The overlay was originally
created to help startup performance, but inlining the overlay seems to
no longer have detrimental effects to performance and is more straightforward.

MozReview-Commit-ID: 7sfVel6qvgv

--HG--
extra : rebase_source : b6311cf1fb98851b4f4203c314ae9ecc8160d766
2018-02-14 12:20:58 -08:00
Brendan Dahl
bd38c4bf4c Bug 1434077 - Inline downloads overlay. r=Paolo
This is part of the work to remove XUL overlays. The overlay was originally
created to help startup performance, but using a hidden panel instead seems to
have no detrimental effects to performance and is more straightforward.

MozReview-Commit-ID: JlWcZEhPXyH

--HG--
rename : browser/components/downloads/content/downloadsOverlay.xul => browser/components/downloads/content/downloadsPanel.inc.xul
extra : rebase_source : 60a9fec344b1e346594015cd36947fe1779257a7
2018-02-06 15:55:50 -08:00
Boris Zbarsky
fce30e834b Bug 1436508 part 10. Remove use of nsIDOMKeyEvent in JS. r=masayuki
MozReview-Commit-ID: GGciORX62Yh
2018-02-09 11:17:09 -05:00
Paolo Amadini
d59df3cdd5 Bug 1434883 - Part 2 - Use an asynchronous API to open PanelMultiView panels. r=Gijs
MozReview-Commit-ID: 3VzoxJ3Ociy

--HG--
extra : source : 22c83b1d417d7c7bd21a71109f4800f5d37bbb77
extra : intermediate-source : 6de7133c267288a468804f67f91df68b10b9793e
2018-02-06 09:02:27 +00:00
Andrew McCreight
5dec0e0beb Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG

--HG--
extra : rebase_source : d9c41878036c1ef7766ef5e91a7005025bc1d72b
2018-02-06 09:36:57 -08:00
Florian Quèze
2b1c8dccb6 Bug 1339461 - script-generated patch to convert foo.indexOf(...) == -1 to foo.includes(), r=Mossop. 2018-02-01 20:45:22 +01:00
Kris Maglione
918ed6c474 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
extra : intermediate-source : 34c999fa006bffe8705cf50c54708aa21a962e62
extra : histedit_source : b2be2c5e5d226e6c347312456a6ae339c1e634b0
2018-01-29 15:20:18 -08:00
Cosmin Sabou
9a65a40178 Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
6476f95b13 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
2018-01-29 15:20:18 -08:00
Brindusan Cristian
af8879d1eb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
c276bb9375 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : rebase_source : c004a023389f1f6bf3d2f3efe93c13d423b23ccd
2018-01-29 15:20:18 -08:00
Erica Wright
ca7e87e24c Bug 1033395 - Panels Should Be Anchored from the Same Height on the Toolbar. r=johannh
MozReview-Commit-ID: 6bhlfeD1esE

--HG--
extra : rebase_source : 9f6eeffb105baf8fe54c509369c6b5eadc88c598
2017-09-13 15:49:32 -04:00
Phil Ringnalda
dcda41b943 Backed out changeset 5b9d2ebcf44e (bug 1033395) for failures in browser_overflow_anchor.js
MozReview-Commit-ID: LfhmJLydnaF
2017-10-16 22:01:54 -07:00
Erica Wright
d29984c27b Bug 1033395 - Panels Should Be Anchored from the Same Height on the Toolbar. r=johannh
MozReview-Commit-ID: 6bhlfeD1esE

--HG--
extra : rebase_source : 6e2d645505f154ae556827032af2e51f32657484
2017-09-13 15:49:32 -04:00
Dan Banner
7caa92d5d8 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
Boris Zbarsky
624fdefa57 Bug 1400898 part 1. Remove the one script use of nsIDOMChromeWindow. r=farre
MozReview-Commit-ID: I31eceiJP55
2017-09-19 10:13:22 -04:00
Gijs Kruitbosch
ecf2be01ab Bug 1397447 - make downloads button autohide by default, r=mak
MozReview-Commit-ID: E9izQpa4fFZ

--HG--
extra : rebase_source : 11dc3f1b98f53f5897a3185253b68d2cf7d5083b
extra : source : 97f7f5175b2fc3adfb193783f7ecb70b5b9b4562
2017-09-08 14:16:36 +01:00
Mike de Boer
0fcde6db9c Bug 1354532 - Part 1 - Implement a new Downloads view as part of the Library widget. r=Paolo
MozReview-Commit-ID: AqH8Zj8XCQl

--HG--
extra : rebase_source : a78764e9ab25af06c5652d13065e3f8944998025
2017-09-06 16:23:00 +02:00
Sebastian Hengst
c3dc29271d Backed out changeset f1d18c741b2c (bug 1354532) for eslint failure at browser/components/downloads/DownloadsCommon.jsm:671: Expected property shorthand. r=backout 2017-09-06 16:48:00 +02:00
Mike de Boer
bfdabc36cf Bug 1354532 - Part 1 - Implement a new Downloads view as part of the Library widget. r=Paolo
MozReview-Commit-ID: AqH8Zj8XCQl

--HG--
extra : rebase_source : a78764e9ab25af06c5652d13065e3f8944998025
2017-09-06 16:23:00 +02:00
Wes Kocher
7ea5ed6e6a Merge m-c to autoland, a=merge
MozReview-Commit-ID: LEKykpTAKjv
2017-08-25 17:32:33 -07:00
Gijs Kruitbosch
e47e6f071c Back out changeset 97f7f5175b2f (bug 1371765) because we're changing the plan for the downloads button, rs=backout,firebot,paolo
MozReview-Commit-ID: FTvFDV5nuG6

--HG--
extra : rebase_source : af8ed6b6da9adc1badbdc5016aacb877511875f0
2017-08-25 13:32:47 +01:00
Blake Winton
fff59923b4 Bug 1384692 - Update the download doorhanger style. ui-r=amylee, r=Paolo.
MozReview-Commit-ID: 4pY9JxnLNYk

--HG--
extra : rebase_source : a6573e33298e84fca2fc8de92c932f770dcc53b2
2017-08-01 09:18:11 -04:00
Gijs Kruitbosch
ace9ca19d1 Bug 1371765 - make downloads button non-customizable, r=jaws,Paolo
MozReview-Commit-ID: E9izQpa4fFZ

--HG--
extra : rebase_source : f2c8a292c5bddb2dfde656b0f37fe2abee371ea0
2017-08-16 15:54:36 +01:00
Paolo Amadini
a0fc00495b Bug 1381411 - Implement the DownloadHistoryList object. r=mak
This also changes the Library window to use the newly added back-end object. The only user-visible change should be how the selection behaves when retrying downloads.

MozReview-Commit-ID: 7CQr1m21rcB

--HG--
extra : rebase_source : e36faf63dadeba0c897b769cb7e14a2d01d0f628
extra : amend_source : 2c7a88b6e3d6de50b37c34a5579b3ab6fb0c10dd
2017-08-04 14:48:53 +01:00
Florian Quèze
b5647ed1c0 Bug 1381853 - lazy load downloads scripts into the browser window, r=mconley. 2017-07-23 00:18:00 +02:00
Paolo Amadini
137d61ddbb Bug 1381409 - Part 3 - Use DownloadList notifications directly in front-end download views. r=mak
The DownloadList object now provides batch notifications directly, in preparation for linking front-end views to other types of download lists without having to use the DownloadsData indirection.

MozReview-Commit-ID: FOTz1YwGRE1

--HG--
extra : rebase_source : df2d50d50c45a98e257caaa6efa9d0da2fa79237
extra : source : 278858e3d78b5e371f865adac043d07b770f1d3f
2017-07-17 12:05:12 +01:00
Paolo Amadini
64bb3feb3b Bug 1381409 - Part 2 - Let each view keep the state of downloads relevant to it. r=mak
The front-end download views now maintain the old download state themselves, instead of relying on the DownloadsData object dispatching the onDownloadStateChanged notification.

This allows each view to keep only the state relevant to it, for example the Downloads Panel already keeps the state only for the visible items. This also makes it possible for each view to use a different hash than the one provided by the legacy stateOfDownload method, and allows bypassing the DownloadsData indirection entirely.

MozReview-Commit-ID: 2D1ixsZCkCa

--HG--
extra : rebase_source : f429fe475ea1887180e269ee8aa0addcee76704d
extra : source : df5f46c825a10587149a7bbac2e126c3906e0393
2017-07-17 12:07:17 +01:00
Paolo Amadini
180e05ac9f Bug 1381409 - Part 1 - Always add Download objects in their original order. r=mak
When a new front-end view is added to the DownloadsData object, the Download objects it contains are loaded into the view starting with the newest, which is the opposite of the order used by the underlying DownloadList.

This was originally implemented as an optimization for the Downloads Panel, at a time when the full list of completed downloads was persisted in the same SQLite database as session downloads. This difference is now unnecessary given the low number of session downloads, and can be removed in preparation for bypassing the DownloadsData indirection entirely.

MozReview-Commit-ID: 5EBkqvyXFq4

--HG--
extra : rebase_source : 44b8783e5c44460d3aa4fb9bd0834c981110e98e
extra : source : 56b8e456797c56c45ed791c0d40f43031e94dc22
2017-07-16 17:36:00 +01:00
Paolo Amadini
33ebc4466d Bug 1009116 - Redo resizing architecture of panelmultiview. r=Gijs
The height of the "panelmultiview" binding is now determined by the stack layout code, and doesn't have to be calculated manually via JavaScript anymore. This allows the removal of mutation and overflow observers, and reduces the number of synchronous layouts being made.

There is still a workaround included for wrapping blocks not being taken into account in height calculations.

MozReview-Commit-ID: 9rrPU5O5hUx

--HG--
extra : rebase_source : b872c14a553c4293ac476d5d22c634a5a0f6cb24
extra : intermediate-source : bf96469b6ea7daee29eb75a60d11f017a1c86a64
extra : source : 719bb4e7286fbd3baf32061929e4b7d9f953c671
2017-05-23 17:08:01 +01:00
Paolo Amadini
68c4637db8 Bug 1362207 - Remove the dropdown menu from the footer of the Downloads Panel. r=mak
MozReview-Commit-ID: CFrHklbB7TK

--HG--
extra : rebase_source : 307502b673bd06e8beb57866a69661ca1784d4f6
2017-05-05 15:37:00 +01:00
Yiren Wang
5f88f7294a Bug 1264206 - Enable ESLint for browser/components/downloads and fix the existing issues. r=Standard8
MozReview-Commit-ID: HDjTxdFCnRp
2017-04-03 10:25:05 +01:00
David Rajchenbach-Teller
4e3f201503 Bug 1087255 - Convert Download JS clients of RemovePage(s) to History.remove;r=paolo
MozReview-Commit-ID: KpXAh74W12E
2014-10-31 12:39:28 +01:00
Sean Lee
f72579d769 Bug 1282662 - Part 2: Implement the detail description in hover button case.; r=Paolo
MozReview-Commit-ID: G3L0sULmRLD

--HG--
extra : rebase_source : adcc3455504ec506482d74f51032a6f123ebd2d2
2016-12-21 22:50:07 +08:00
George Pîrlea
34e7abc036 Bug 991965 - Inhibit item selection and update commands when the DownloadsBlockedSubview is open. r=paolo
MozReview-Commit-ID: Akly0NenY8Z

--HG--
extra : rebase_source : 0a02a747ec86e17a3218fdb00ed3ba018adc0a99
2017-01-21 17:42:36 +00:00
George Pîrlea
9647092161 Bug 991965 - Use event.target and inhibit item selection if the context menu is open. r=paolo
1) In the Downloads Panel, hovering over an item would sometimes not trigger an
actual selection, due to an error in how 'onDownloadMouseOver()' events were
processed - 'aEvent.orginalTarget' doesn't take retargets into account. Fixed
by using 'aEvent.target' instead of 'aEvent.originalTarget'.

2) In the Downloads Panel, right-clicking an item opens a context menu that
lets you act on the selected item. However, if you unintentionally hover over a
different item when the context menu is open, the selection changes. You may,
for example, 'Remove From History' a different, unintended item. Fixed by
inhibiting item selection when a context menu is open for a download item.

MozReview-Commit-ID: DLIAFNcs33N

--HG--
extra : rebase_source : c4021fc7634836a0b7739f8cf0c9524d732b18b9
2017-01-21 12:21:51 +00:00
Florian Quèze
85611a7b6d Bug 1331081 - script generated patch to omit addEventListener/removeEventListener's third parameter when it's false, r=jaws.
--HG--
extra : rebase_source : a22344ee1569f58f1f0a01017bfe0d46a6a14602
2017-01-17 11:50:25 +01:00
Rex Lee
daf6e74a28 Bug 1269957 - Unify height of download items and allow maximum 5 items to show in downloads panel. r=Paolo
MozReview-Commit-ID: 1EoBfLXyDVN

--HG--
extra : rebase_source : 2a44c65eff7122f0c6f2096e6e9dba0be05a778f
2016-12-01 20:42:05 +08:00
Sean Lee
15f00ba1a2 Bug 1282664 - Redesign the right-menu on a download item in Downloads Panel.; r=Paolo
MozReview-Commit-ID: DyTisE3dX1A

--HG--
extra : rebase_source : d87b91cb9a8b7875eddc42c4e2bad6234f433af7
2016-10-14 14:07:00 +08:00
Paolo Amadini
4c9c5a6db6 Bug 1300556 - Adjust the height of the Downloads Panel if downloads are removed while the panel is hidden. r=jaws
MozReview-Commit-ID: JpW9G6MAGwM

--HG--
extra : rebase_source : ad1cd03928d959757151fd46e25a8412c13b2511
2016-09-07 15:00:46 +01:00
Sean Lee
51322da3c0 Bug 1298276 - Change the hover behavior in summary section with downloading files. r=paolo
MozReview-Commit-ID: 1hKBRXOBH6c

--HG--
extra : transplant_source : %21%1E%80%E6%D5%A2%C52%E6%9B%D1%A4%1D%D3%27%8C%C7Q%F9%A1
2016-08-18 14:45:57 +08:00
Drew Willcoxon
d14c6b15aa Bug 1292345 - Downloads panel didn't shrink to the fit height after all items are downloaded. r=me
MozReview-Commit-ID: AV0S8GM0ztj

--HG--
extra : rebase_source : e8d01256b994368b72c73344232f64cb26d6a357
2016-08-26 16:36:56 -07:00
Drew Willcoxon
d07b49ff57 Bug 1292573 - Broken keyboard interaction with the subview in the Downloads Panel. r=Paolo
MozReview-Commit-ID: 3jiqzlzLuWM

--HG--
extra : rebase_source : 46560a17b66d8ddff04795422a7c9a1a3bf6471a
2016-08-26 09:59:11 -07:00
Drew Willcoxon
1a22b3ba23 Bug 1292566 - The "open" button in the subview for uncommon and potentially unwanted downloads should not ask for confirmation. r=Paolo
MozReview-Commit-ID: AVDyaQSbriX

--HG--
extra : rebase_source : 1e151511068dc708e27f60216b6b055a90d72ef9
2016-08-24 17:56:44 -07:00
Sean Lee
ab824e0228 Bug 1297039 - Implement the preference for showing dropmarker or not in Downloads Panel., r=Paolo
MozReview-Commit-ID: ArmPPgLABtA

--HG--
extra : rebase_source : 8a15572df32954306b8484dbe3bf7be0c077b88e
2016-08-22 18:44:24 +08:00
Sean Lee
9b70990ee3 Bug 1269962 - Implement a popup menu for showing a submenu in Downloads Panel Footer., r=Paolo
MozReview-Commit-ID: 7K1W15039W8

--HG--
extra : rebase_source : 01b66909876cb22ea8442d037ebd8b8f3f5748ec
2016-07-13 13:39:00 +08:00
Drew Willcoxon
a21a61d78d Bug 1287914 - Buttons in sliding panel overlay are not clickable. r=jaws
MozReview-Commit-ID: 91yoPxiMIy8
2016-07-28 11:51:53 -07:00
Drew Willcoxon
01dbcb42ca Bug 1280709 - Downloads panel's "Show All Downloads" menu item is no longer clickable below its text label. r=gijs
MozReview-Commit-ID: HgTiDObq2JU

--HG--
extra : rebase_source : 546203ad5f899d66eab70dd7b86cd2a90c124978
2016-07-25 12:25:52 -07:00