Commit graph

59 commits

Author SHA1 Message Date
Ganesh Chaitanya Kale
e44c888947 Bug 1282770 - Convert uses of PU.asyncHistory.updatePlaces in browser/components/migration to PU.history.insertMany. r=mak
Patch originally by Ganesh, updated by Standard8

MozReview-Commit-ID: AihTLo5OyK1

--HG--
extra : rebase_source : f5a886326dd7f2fb2dba3309199ef277affe6b77
2018-03-20 12:36:31 +00:00
Gijs Kruitbosch
7dd5677adc Bug 1437940 - fix where we look for a 'Local State' file for non-release Chrome data, r=dthayer
MozReview-Commit-ID: CXghkKKhHfx

--HG--
extra : rebase_source : 8050e98033da4b265c61b7f612f906828b9241e9
2018-03-01 15:07:28 +00:00
Gijs Kruitbosch
21074e3307 Bug 1437940 - include Chrome Beta and Chrome Dev in migration list on Linux, r=dthayer
MozReview-Commit-ID: HDTkdXdYos3

--HG--
extra : rebase_source : c5e9abdd2f8c3077e38a716d26d6afa7cdc93914
2018-03-01 14:03:06 +00:00
Gijs Kruitbosch
ac1ce88bcf Bug 1434167 - remove getSourceHomePageURL implementations and callsites, r=dthayer
MozReview-Commit-ID: 98p2Iy70EPv

--HG--
extra : rebase_source : 7980fffb74a3deff1493353c610d03a506c392d9
2018-02-07 10:18:46 +00:00
Andrew McCreight
5dec0e0beb Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG

--HG--
extra : rebase_source : d9c41878036c1ef7766ef5e91a7005025bc1d72b
2018-02-06 09:36:57 -08:00
Kris Maglione
918ed6c474 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
extra : intermediate-source : 34c999fa006bffe8705cf50c54708aa21a962e62
extra : histedit_source : b2be2c5e5d226e6c347312456a6ae339c1e634b0
2018-01-29 15:20:18 -08:00
Cosmin Sabou
9a65a40178 Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
6476f95b13 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
2018-01-29 15:20:18 -08:00
Brindusan Cristian
af8879d1eb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
c276bb9375 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : rebase_source : c004a023389f1f6bf3d2f3efe93c13d423b23ccd
2018-01-29 15:20:18 -08:00
Doug Thayer
57731e3f90 Bug 1426721 - Encrypt Chrome logins in background thread r=keeler,MattN
A significant chunk of migration jank that I observe locally
happens due to login encryption. This patch reduces the locally
observed jank (measured importing 100 logins) from 180ms to 25ms.

Try is green, and as far as I can tell I don't see any thread
safety issues, but I'm not 100% sure on that. I don't see any
red flags inside the SecretDecoderRing::Encrypt implementation.

I only moved Chrome logins over since I wanted to frontload any
potential issues with the whole approach. It shouldn't be too
hard to move the MSMigrationUtils and IEProfileMigrator uses
over though.


MozReview-Commit-ID: 75edUqJlk8x

--HG--
extra : rebase_source : 0a8e16c46e05972fb01c9703b52cdb5755b0b40b
2018-01-04 15:10:54 -08:00
Doug Thayer
9cae8e6dac Bug 862127 - Remove all sync IO from Chrome migration r=Gijs
Now that the interfaces are all async, we can simply replace all
the sync IO in the Chrome migrator with the equivalent async IO.
Other browsers will be addressed in separate patches.

MozReview-Commit-ID: FyGRRKY57Gm

--HG--
extra : rebase_source : 0228b9b72c7217e3f6e607256cb3828bf5819189
2018-01-11 09:52:56 -08:00
Doug Thayer
efdd84d094 Bug 862127 - Make migration interfaces more async r=Gijs
In order to clean up sync IO within our profile migrators, we
need to have async interfaces for those parts which are currently
doing sync IO. This converts the sync interfaces and adjusts most
of the call sites (migration.js call site changes are addressed
in a separate patch to break it out a bit).


MozReview-Commit-ID: 2Kcrxco4iYr

--HG--
extra : rebase_source : 53d123c435e43622a999a7e849dddbe1919061e0
2018-01-12 09:06:21 -08:00
Sam R-T, Joseph F, Robin H
b6f7cc8e46 Bug 1432062 - Require dangling commas via eslint for the migration component. r=MattN 2018-01-22 15:22:35 -08:00
Evan Tseng
9e8a45eb49 Bug 1410839 - Add the ChromeMigrationUtils.jsm module and implement the getExtensionList and related functions to export all extensions information installed in a specific profile. r=Gijs
MozReview-Commit-ID: AqlJzKkTjWp

--HG--
extra : rebase_source : 85d2ca1550297fcc57eb625552eb93d13aa99181
2017-11-23 10:48:18 +08:00
Dan Banner
b2e847755c Bug 1367704 - Enable the semi ESLint rule across the tree. r=standard8
MozReview-Commit-ID: GrlcOI9K2hJ

--HG--
extra : rebase_source : 6574cf3c67eb11733ffd9999c260f71c8551abc4
2017-05-28 19:57:46 +01:00
Mark Banner
4fb45e5b8c Bug 1365412 - Clean up various ESLint global definitions in browser/. r=mossop
MozReview-Commit-ID: JqAm9x1XGCM

--HG--
extra : rebase_source : e9215288195f1fe683832db53d87dbe77c697b4c
2017-05-16 22:22:42 +01:00
Florian Quèze
5e3539e504 Bug 1353542 - massive script-generated patch converting Task.async and Task.spawn calls, and generators clearly identifiable as tasks, rs=Mossop. 2017-05-12 14:42:39 +02:00
Gijs Kruitbosch
6e21985362 Bug 1344759 - batch-insert bookmarks when importing from Edge, IE, Safari or Chrome, r=dao
MozReview-Commit-ID: Dhvw0Y0fm5x

--HG--
extra : rebase_source : 284e016c0ae26b6e58859500ce36ba7c63f51b8d
2017-03-13 23:46:16 +00:00
Gijs Kruitbosch
288e9a57a7 Bug 1341097 - part 2: allow turning off notifications for individual inserted results when calling updatePlaces, r=mak
This sets a property on the callback object rather than passing an argument
to handleCompletion, to avoid accidentally breaking consumers who don't
expect arguments. The downside is that this required more changes to C++
consumers, but we control all of those so that seemed an acceptable
trade-off.

We should probably actually report errors for all the migrators, but I didn't
want to add risk (what if in some edge-case there are lots?) so I didn't. I'll
file a followup to update them to Cu.reportError() any errors.

MozReview-Commit-ID: Hue9Ci3hyVz

--HG--
extra : rebase_source : e853911e2ec8fe2e1273baa1f31fd557935ef896
2017-02-21 14:20:21 +00:00
Dão Gottwald
f7593c2488 Bug 1339413 - Implement prefs for capping the amount of history we import from Chrome. r=Gijs
MozReview-Commit-ID: BdlNxS76Ko9

--HG--
extra : rebase_source : 242297a27bf5b363b0e3883de79da72485c8b490
2017-02-15 18:42:15 +01:00
Gijs Kruitbosch
02a488dd3f Bug 1333734 - fix chrome password import if it contains items we can't read as a URI, r=mak
MozReview-Commit-ID: CAwIVNz70hs

--HG--
extra : rebase_source : f6b7998f9edf69d96c8fd2c312c84b3b8bf071e6
2017-01-30 10:51:21 +01:00
Jared Wein
f64146d9d7 Bug 1329014 - Enable the no-extra-bind rule and use eslint --fix to autofix the errors. r=standard8
MozReview-Commit-ID: BwK94W2mHXS

--HG--
extra : rebase_source : a905658829084d3a4018df81f51bb210ef1e645b
2017-01-05 16:43:29 -05:00
Jared Wein
9141469edf Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN
MozReview-Commit-ID: FuVu8skcqOe

--HG--
extra : rebase_source : 8ab34c4e46a7c3075b459bf44786ec184d10d203
2016-12-30 21:47:25 -05:00
Jared Wein
ecab54a7c9 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje

--HG--
extra : rebase_source : 0572a35415a766a3f31d266760ecd07f0dcc3f72
2016-12-29 18:34:54 -05:00
Wes Kocher
0dfb7c2b5c Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
7255df4e9a Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR

--HG--
extra : rebase_source : da7172285d43b820421557ed3b05887e091ff939
2016-12-29 15:20:47 -05:00
Gijs Kruitbosch
8d66045e8d Bug 1285577 - part 0a: make login manager return the login we're creating with addLogin, r=MattN
This patch also addresses logic issues in LoginHelper.maybeImportLogin, renames
a parameter of maybeImportLogin to be consistent and adds a test.

MozReview-Commit-ID: 12llkOyF7ne

--HG--
extra : rebase_source : 371688e1112a91b6068bbd4780d33231dbaef7fd
2016-11-30 11:03:21 +00:00
Sebastian Hengst
db0773ee3e Backed out changeset 61029bd1995a (bug 1285577) for failing test_autofill_https_upgrade.html at least on Linux. r=backout 2016-12-20 22:56:02 +01:00
Gijs Kruitbosch
00c227d626 Bug 1285577 - part 0a: make login manager return the login we're creating with addLogin, r=MattN
This patch also addresses logic issues in LoginHelper.maybeImportLogin, renames
a parameter of maybeImportLogin to be consistent and adds a test.

MozReview-Commit-ID: 12llkOyF7ne

--HG--
extra : rebase_source : 46ef58193bbf5586d2d00c6faea98ea50181c403
2016-11-30 11:03:21 +00:00
Gijs Kruitbosch
9437918402 Bug 1279501 - add telemetry for the number of bookmarks, history visits and logins are imported from another browser, r=bsmedberg,mak
MozReview-Commit-ID: EiZfkj6AsVL

--HG--
extra : rebase_source : ce2776740d29ae6eb5e93d8d791ca917510352b8
2016-10-22 14:40:48 +01:00
Wes Kocher
7e9c4a34c8 Backed out changeset 77012ce07e57 (bug 1279501) a=gijs 2016-11-01 10:47:59 -07:00
Gijs Kruitbosch
8aab2885d4 Bug 1279501 - add telemetry for the number of bookmarks, history visits and logins are imported from another browser, r=bsmedberg,mak
MozReview-Commit-ID: EiZfkj6AsVL

--HG--
extra : rebase_source : 288154d79b230fd1205449af81b8361215c04161
2016-10-22 14:40:48 +01:00
Gijs Kruitbosch
8d23ab9355 Bug 1311043 - make eslint much more strict in browser/components/migration/, and fix issues, r=mikedeboer
MozReview-Commit-ID: RXO68w3Kv3

--HG--
extra : rebase_source : b25a1976f2be89f12c2ad14e649270bacd17d174
2016-10-18 16:03:06 +01:00
Gijs Kruitbosch
2ec44a95d1 Bug 1310596 - actually import OS.File in the 360se profile migrator code, r=mikedeboer
Also removing a useless console.jsm import from the chrome migrator that I spotted when looking through the changes from bug 1276694

MozReview-Commit-ID: 78qkflg4KWn

--HG--
extra : rebase_source : ba8c24e3710b82f95a3aca2728bda5ca8c4d485e
2016-10-18 11:55:30 +01:00
Gijs Kruitbosch
25c200c77f Bug 1305770 - make cookies and passwords import from Chrome without locking, r=mak
MozReview-Commit-ID: CbozmZHwAgz

--HG--
extra : rebase_source : 489a800ad1381bd6daa99040008fba24861d99ff
2016-10-03 16:17:06 +01:00
Gijs Kruitbosch
ae4301ef96 Bug 1285041 - ignore locking when trying to read chrome DB file, r=mak
MozReview-Commit-ID: 89f0YCxxgC8

--HG--
extra : rebase_source : 53efa0f0258728df54fc17a773cbf74c712b51e4
2016-07-18 16:46:45 +01:00
Phil Ringnalda
7287d4600d Backed out changeset ef7939c0332e (bug 1285041) for failures in test_storage_connection.js
CLOSED TREE
2016-09-15 20:04:30 -07:00
Gijs Kruitbosch
fff8403f8a Bug 1285041 - ignore locking when trying to read chrome DB file, r=mak
MozReview-Commit-ID: 89f0YCxxgC8

--HG--
extra : rebase_source : be3ee58b00b4c8ae6ec41db9459f50abdce816f6
2016-07-18 16:46:45 +01:00
Jared Wein
fd84c776c7 Bug 1292042 - Enable the keyword-spacing rule for eslint. Most of this patch was autogenerated by 'eslint --fix'. Files with .xml extension needed to be changed by hand due to limitations of custom plugin. r=markh
MozReview-Commit-ID: EMjJ3yWt9Wt

--HG--
extra : rebase_source : 2b8327e5a7cf0bfd190d696ad5fe475f13faa3cc
2016-08-04 03:28:58 -04:00
Gijs Kruitbosch
579b36016a Bug 1276694 - store recency of browser data in telemetry when importing to see how good a predictor default browser is, r=dolske,bsmedberg
MozReview-Commit-ID: 16uPNGGDE68

--HG--
extra : rebase_source : fdb3ad8a3429079cb23cddd4a003b03043a95728
2016-05-30 17:10:54 +01:00
Tim Huang
8ec727cd19 Bug 1267910 - Part 2: Update all existing functions of add() and getCookiesFromHost() to make them origin attributes aware. r=jdm, r=mratcliffe
--HG--
extra : rebase_source : 288c9cab8340c5cc06861d4f2c7ee43ae4de608e
2016-05-25 11:54:21 +08:00
Marco Bonardo
6961882734 Bug 1272652 - Firefox fails to import bookmarks from Chrome if it also imports a large history. r=gijs
MozReview-Commit-ID: 3w5TIPi2S8d

--HG--
extra : rebase_source : 616e2fe71ab04404608f06475752e50c9d4b2b92
extra : histedit_source : bcd1e9d41927a72a9dcf3c804ad75454b8948db6%2C852a5b150616724887b4d2ea37d4aa3a1f3006da
2016-05-24 17:29:30 +02:00
Wes Kocher
71155ee202 Backed out changeset 684824592e64 (bug 1272652) for marionette failures 2016-05-23 15:13:08 -07:00
Marco Bonardo
2f9de36860 Bug 1272652 - Firefox fails to import bookmarks from Chrome if it also imports a large history. r=gijs
MozReview-Commit-ID: 3w5TIPi2S8d

--HG--
extra : rebase_source : 923d3b65cd5f5d74f0ecea8db6b8a68c71012981
2016-05-20 17:00:43 +02:00
Wes Kocher
2596f34110 Backed out 3 changesets (bug 1267910) for reports of it breaking session restore a=backout
Backed out changeset 5962f8e6d030 (bug 1267910)
Backed out changeset f8afc5cf9e0e (bug 1267910)
Backed out changeset cc202e0ac0dd (bug 1267910)
2016-05-20 21:15:17 -07:00
Tim Huang
ad550d017f Bug 1267910 - Part 2: Update all existing functions of add() and getCookiesFromHost() to make them origin attributes aware. r=jdm, r=mratcliffe
--HG--
extra : rebase_source : 3d8b306dfa83363c01c4db5d018c55fddf6d1595
2016-05-18 20:42:00 -04:00
Gijs Kruitbosch
dc4b4997fd Bug 1246591 - remove preprocessing and fix any other issues, r=MattN
--HG--
extra : commitid : ERDudjbCnHC
extra : rebase_source : df5f44f84c5c56f76a65c887cd5b374284562a61
2016-02-08 12:54:38 +00:00
Tooru Fujisawa
8ed7719ea4 Bug 1216775 - Remove for-each from browser/. r=Gijs
--HG--
extra : commitid : 5KlVHJwTU1Q
extra : rebase_source : 6526234004427109c826cb63f42c9def8ca31281
2015-10-19 01:27:39 +09:00
Gijs Kruitbosch
2352be03b3 Bug 1212297 - improve error handling in Chrome bookmarks migration code, r=MattN
--HG--
extra : commitid : BEgGX9o3KPB
extra : rebase_source : e6c4de4e72db8aab771864d453409b02cdcc067e
2015-10-07 13:24:50 +01:00