nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity
915912 commits 1 branch 98 tags 6.4 GiB
Commit graph

4550 commits

Author SHA1 Message Date
Issam Mani
1469fa6282 Bug 1893360 - Convert browser/extensions/formautofill/content/*.js to ESMs. r=credential-management-reviewers,mtigley 
Differential Revision: https://phabricator.services.mozilla.com/D209980
 2024-05-09 22:45:00 +00:00
acseh
e39c868227 Backed out 4 changesets (bug 1884632, bug 1895467) for causing gv-junit-fis failures CLOSED TREE 
Backed out changeset f5a7db15ee4f (bug 1884632)
Backed out changeset 082a2bed994a (bug 1884632)
Backed out changeset 8b53ac9b4590 (bug 1884632)
Backed out changeset 26268f4f3f9d (bug 1895467)
 2024-05-08 12:40:05 +03:00
jneuberger
a5d535e7f3 Bug 1884632 - P3. Update tests to align with the form submission on subtree navigation heuristic r=credential-management-reviewers,dimi 
Differential Revision: https://phabricator.services.mozilla.com/D208134
 2024-05-08 07:24:27 +00:00
jneuberger
e41f625d02 Bug 1884632 - P2. Rename browser_active_window_navigation.js r=credential-management-reviewers,dimi 
We extract the renaming of this test file to a separate patch, because P3 modifies and adds test cases and we want to keep the diff (to simplify review of P3).

Differential Revision: https://phabricator.services.mozilla.com/D208133
 2024-05-08 07:24:27 +00:00
jneuberger
618cdfa04e Bug 1884632 - P1. Handle heuristic for page navigations centrally in FormHandlerChild r=dimi,credential-management-reviewers,sgalich 
FormHandler is a central place for heuristics that other components like the LoginManager and FormAutofill
rely on. This patch moves the heuristics that detect page navigations to the FormHandler.
It also applies two changes:
- Heuristic to capture on page navigation no longer relies on the process' active element in FormAutofill
- Capturing in cross-origin frames is introduced

Introduced page navigation heuristic:
When LoginManager/FormAutofill detect a form that they expect a submission for, a FormHandler actor pair is
created in the current window context, which registers the web progress listener that listens for "page navigations",
e.g. location changes of the observed window/document or history session changes.
- If the form is in a same-orign frame, we register the listener only at the top level.
- If the form is in a cross-origin frame, we additionally set up a listener with the root
  of the cross-origin process, so that we are aware of page navigations in both processes.
When a page navigation is observed, all existing (same-origin and cross-origin) FormHandler parents in the
browsing context subtree notify their children.
(Note: We don't create any new actors in this step, because they won't have any form to submit anyway).
When the corresponding FormHandlerChild(ren) are notified of the page navigation, they fire the "form-submission-detected" event.

On "form-submission-detected" event:
- The LoginManagerChild instance(s) kept track of all modified login forms and infers capturing them.
- The FormAutofillChild instance(s) kept track of all identified formautofill forms and infers capturing them.

Differential Revision: https://phabricator.services.mozilla.com/D204927
 2024-05-08 07:24:27 +00:00
Sidharth Sachdev
46c58895d1 Bug 1877717 - Fix failing tests. r=issammani 
Differential Revision: https://phabricator.services.mozilla.com/D209560
 2024-05-07 04:21:33 +00:00
Sidharth Sachdev
6529368b3e Bug 1877717 - Update tests for cc formautofill os auth. r=joschmidt,credential-management-reviewers,issammani 
Depends on D199544

Differential Revision: https://phabricator.services.mozilla.com/D200452
 2024-05-07 04:21:32 +00:00
Sidharth Sachdev
073033f94a Bug 1802809 - Maintaining OS Authentication functionality for credit cards. r=sgalich,dimi,fluent-reviewers,flod 
Depends on D202473

Differential Revision: https://phabricator.services.mozilla.com/D199544
 2024-05-07 04:21:32 +00:00
Cristina Horotan
964835af40 Backed out 7 changesets (bug 1802809, bug 1890883, bug 1877720, bug 1403081, bug 1877717) for causing bc failures at browser_primaryPassword.js CLOSED TREE 
Backed out changeset 7bdafce80724 (bug 1877717)
Backed out changeset 4969f17f935c (bug 1877717)
Backed out changeset d700fbbd7541 (bug 1877717)
Backed out changeset 98e31d4cd373 (bug 1802809)
Backed out changeset c1e8c6c34fcc (bug 1877720)
Backed out changeset 0d8d5e77a93c (bug 1403081)
Backed out changeset 594b7bbecd22 (bug 1890883)
 2024-05-06 20:59:20 +03:00
Sidharth Sachdev
2fb03ebf2a Bug 1877717 - ci debug. r=issammani 
Differential Revision: https://phabricator.services.mozilla.com/D209560
 2024-05-06 15:58:25 +00:00
Sidharth Sachdev
bfdb01dd4d Bug 1877717 - Update tests for cc formautofill os auth. r=joschmidt,credential-management-reviewers,issammani 
Depends on D199544

Differential Revision: https://phabricator.services.mozilla.com/D200452
 2024-05-06 15:58:24 +00:00
Sidharth Sachdev
e99eb93c6a Bug 1802809 - Maintaining OS Authentication functionality for credit cards. r=sgalich,dimi,fluent-reviewers,flod 
Depends on D202473

Differential Revision: https://phabricator.services.mozilla.com/D199544
 2024-05-06 15:58:24 +00:00
Stanca Serban
75c7d87370 Backed out 7 changesets (bug 1802809, bug 1877717, bug 1403081, bug 1890883, bug 1877720) for causing localization checks failures in aboutLogins.ftl. CLOSED TREE 
Backed out changeset 62eeb65b23bd (bug 1877717)
Backed out changeset 4fde845a1182 (bug 1877717)
Backed out changeset d3124d383693 (bug 1877717)
Backed out changeset 344ac200b360 (bug 1802809)
Backed out changeset 754a1bf3b55e (bug 1877720)
Backed out changeset 961a1121017e (bug 1403081)
Backed out changeset 19b2252a4ccf (bug 1890883)
 2024-05-06 18:27:03 +03:00
Sidharth Sachdev
5763261d80 Bug 1877717 - ci debug. r=issammani 
Depends on D209394

Differential Revision: https://phabricator.services.mozilla.com/D209560
 2024-05-06 14:54:20 +00:00
Sidharth Sachdev
5cafb028ae Bug 1877717 - Update tests for cc formautofill os auth. r=joschmidt,credential-management-reviewers,issammani 
Depends on D199544

Differential Revision: https://phabricator.services.mozilla.com/D200452
 2024-05-06 14:54:18 +00:00
Sidharth Sachdev
41bd44beb0 Bug 1802809 - Maintaining OS Authentication functionality for credit cards. r=sgalich,dimi,fluent-reviewers,flod 
Depends on D202473

Differential Revision: https://phabricator.services.mozilla.com/D199544
 2024-05-06 14:54:17 +00:00
Cosmin Sabou
e69f323af8 Backed out 6 changesets (bug 1877717, bug 1802809, bug 1890883, bug 1877720, bug 1403081) for causing failures on browser_creditCard_doorhanger_action. 
Backed out changeset 8ee572259ac8 (bug 1877717)
Backed out changeset dad0f115e953 (bug 1877717)
Backed out changeset d792b9335db3 (bug 1802809)
Backed out changeset 7610115f0011 (bug 1877720)
Backed out changeset 9c53bcd6a763 (bug 1403081)
Backed out changeset aa4981999347 (bug 1890883)
 2024-05-05 20:37:16 +03:00
Sidharth Sachdev
7b1391c317 Bug 1877717 - Update tests for cc formautofill os auth. r=joschmidt,credential-management-reviewers,issammani 
Depends on D199544

Differential Revision: https://phabricator.services.mozilla.com/D200452
 2024-05-05 15:59:37 +00:00
Sidharth Sachdev
a3a471d3d6 Bug 1802809 - Maintaining OS Authentication functionality for credit cards. r=sgalich,dimi,fluent-reviewers,flod 
Depends on D202473

Differential Revision: https://phabricator.services.mozilla.com/D199544
 2024-05-05 15:59:36 +00:00
Stanca Serban
bba4ccb254 Backed out 6 changesets (bug 1802809, bug 1890883, bug 1877717, bug 1403081, bug 1877720) multiple mochitests failures. CLOSED TREE 
Backed out changeset 8b238dd69206 (bug 1877717)
Backed out changeset c6e16bf303ed (bug 1877717)
Backed out changeset e4d8856edf45 (bug 1802809)
Backed out changeset 9a6a418a1e45 (bug 1877720)
Backed out changeset b587dcaf8f9f (bug 1403081)
Backed out changeset 17febe56cad6 (bug 1890883)
 2024-05-03 22:01:28 +03:00
Sidharth Sachdev
df15ee1c20 Bug 1877717 - Update tests for cc formautofill os auth. r=joschmidt,credential-management-reviewers,issammani 
Depends on D199544

Differential Revision: https://phabricator.services.mozilla.com/D200452
 2024-05-03 17:23:49 +00:00
Sidharth Sachdev
8662a93c9b Bug 1802809 - Maintaining OS Authentication functionality for credit cards. r=sgalich,dimi,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D199544
 2024-05-03 17:23:49 +00:00
Joe Webster
efc2bb3785 Bug 1894063 - Add PiP captions support for additional sites that use JWPlayer r=kpatenio 
Differential Revision: https://phabricator.services.mozilla.com/D208933
 2024-05-02 15:21:42 +00:00
kpatenio
2be0a0659d Bug 1888691 - add video wrapper for canalplus with captions support. r=pip-reviewers,mconley 
This patch disables live seeking (scrubber, seek left and right buttons) and the timestamp if watching a live video. Canal+ live videos are found in canalplus.com/live whereas Timvision ones are found in timvision.it/TV.

The patch also adds captions support for PiP.

Differential Revision: https://phabricator.services.mozilla.com/D208421
 2024-04-30 17:05:27 +00:00
Joe Webster
b6022f00ea Bug 1893061 - Add PiP captions support for additional sites that use JWPlayer r=kpatenio 
Differential Revision: https://phabricator.services.mozilla.com/D208545
 2024-04-29 15:28:27 +00:00
Issam Mani
818f56bfc9 Bug 1891731 - Fix failing test. r=sgalich 
Differential Revision: https://phabricator.services.mozilla.com/D208543
 2024-04-25 12:53:16 +00:00
Issam Mani
0f4935b101 Bug 1891731 - Refactor address add/edit dialog. r=sgalich,dimi 
Differential Revision: https://phabricator.services.mozilla.com/D207565
 2024-04-25 12:53:16 +00:00
Issam Mani
5852a240e4 Bug 1891731 - Pass l10nStrings map to dialog. r=dimi,sgalich 
Differential Revision: https://phabricator.services.mozilla.com/D207564
 2024-04-25 12:53:16 +00:00
Dimi
4f45f856b4 Bug 1892357 - Update search string while handling key event in autocomplete controller r=credential-management-reviewers,sgalich 
As previously commented - "Some script may have changed the value of the
text field", this also applies to "clear form" autocomplete action.

We should update search string before comparing the old search string
and the new search string in `HandleKeyNavigation` so when the input
value is changed, we trigger a new search instead of reusing the previous popup.

Differential Revision: https://phabricator.services.mozilla.com/D208327
 2024-04-24 09:19:36 +00:00
Stanca Serban
902f1b5727 Backed out changeset cbff87ac70e9 (bug 1892357) for causing mochitests failures in test_clear_form.html. 2024-04-23 22:12:51 +03:00
Dimi
0ec557d68c Bug 1892357 - Update search string while handling key event in autocomplete controller r=credential-management-reviewers,sgalich 
As previously commented - "Some script may have changed the value of the
text field", this also applies to "clear form" autocomplete action.

We should update search string before comparing the old search string
and the new search string in `HandleKeyNavigation` so when the input
value is changed, we trigger a new search instead of reusing the previous popup.

Differential Revision: https://phabricator.services.mozilla.com/D208327
 2024-04-23 17:35:55 +00:00
Joe Webster
d4b1fd6542 Bug 1891599 - Create PiP JWPlayer Wrapper r=niklas 
Differential Revision: https://phabricator.services.mozilla.com/D207774
 2024-04-23 17:27:58 +00:00
Neil Deakin
3299d8a614 Bug 1889851, read the status label after the address info within the autofill dropdown, r=credential-management-reviewers,ssachdev 
Differential Revision: https://phabricator.services.mozilla.com/D207438
 2024-04-22 19:33:20 +00:00
Johannes Jörg Schmidt
145dba1c71 Bug 1891454 - remove test_address_line_shows_name_in_save_doorhanger r=dimi 
for assumably causing intermittant test failures. That's fine, since this task was a drive by anyway.

Differential Revision: https://phabricator.services.mozilla.com/D207447
 2024-04-22 12:49:55 +00:00
Joe Webster
35c7b7691d Bug 1825105 - Add support for other Yahoo sites compatible with PiP Yahoo site-specific wrapper. r=pip-reviewers,niklas 
Differential Revision: https://phabricator.services.mozilla.com/D206965
 2024-04-15 19:18:27 +00:00
Johannes Jörg Schmidt
2028dd0eb2 Bug 1887730 - display abbreviated address-level1 in save address doorhanger if possible r=dimi 
Differential Revision: https://phabricator.services.mozilla.com/D207144
 2024-04-15 09:28:05 +00:00
Neil Deakin
6052b367ff Bug 1883549, remove formautofill autocomplete item components and create one based on MozAutocompleteTwoLineRichlistitem, r=credential-management-reviewers,sgalich,geckoview-reviewers,owlish 
Differential Revision: https://phabricator.services.mozilla.com/D203612
 2024-03-29 01:23:25 +00:00
Neil Deakin
65ed3e5559 Bug 1883549, remove special MozAutocompleteCreditcardInsecureField type and replace it with the generic insecure warning, r=credential-management-reviewers,sgalich 
Differential Revision: https://phabricator.services.mozilla.com/D203611
 2024-03-29 01:23:24 +00:00
Iulian Moraru
cc9e275424 Backed out 2 changesets (bug 1883549) for causing mochitest-plain failures on test_creditcard_autocomplete_off.html. CLOSED TREE 
Backed out changeset e6d3be50ec4e (bug 1883549)
Backed out changeset de04a3bb3935 (bug 1883549)
 2024-03-28 20:27:22 +02:00
Neil Deakin
344b219b61 Bug 1883549, remove formautofill autocomplete item components and create one based on MozAutocompleteTwoLineRichlistitem, r=credential-management-reviewers,sgalich,geckoview-reviewers,owlish 
Differential Revision: https://phabricator.services.mozilla.com/D203612
 2024-03-28 16:06:26 +00:00
Neil Deakin
e39fc06d8e Bug 1883549, remove special MozAutocompleteCreditcardInsecureField type and replace it with the generic insecure warning, r=credential-management-reviewers,sgalich 
Differential Revision: https://phabricator.services.mozilla.com/D203611
 2024-03-28 16:06:25 +00:00
Cristina Horotan
fcd187264b Backed out 2 changesets (bug 1883549) for causing mochitest failures at test_basic_creditcard_autocomplete_form.html 
Backed out changeset 068452b591ba (bug 1883549)
Backed out changeset 985c0e227dd9 (bug 1883549)
 2024-03-28 01:47:01 +02:00
Neil Deakin
4a96c8beb8 Bug 1883549, remove formautofill autocomplete item components and create one based on MozAutocompleteTwoLineRichlistitem, r=credential-management-reviewers,sgalich,geckoview-reviewers,owlish 
Differential Revision: https://phabricator.services.mozilla.com/D203612
 2024-03-27 22:48:15 +00:00
Neil Deakin
57afd910ac Bug 1883549, remove special MozAutocompleteCreditcardInsecureField type and replace it with the generic insecure warning, r=credential-management-reviewers,sgalich 
Differential Revision: https://phabricator.services.mozilla.com/D203611
 2024-03-27 22:48:15 +00:00
Johannes Jörg Schmidt
236729d247 Bug 1873202 - fix address capture doorhanger issues with province normalization r=dimi 
Fix of punctuation problems in the normalization of Province and its
deviation of the abbreviation. Additionaly, make use of the
`findAddressSelectOption` helper for address editing form in doorhanger.

Differential Revision: https://phabricator.services.mozilla.com/D204913
 2024-03-22 13:36:00 +00:00
Dimi
b8cdbda709 Bug 1885311 - [refactor] Do not pass collection name from child to parent while searching for formautofill records r=credential-management-reviewers,sgalich 
Differential Revision: https://phabricator.services.mozilla.com/D204614
 2024-03-22 10:38:02 +00:00
Dave Townsend
8ffdcc93a4 Bug 1864896: Fix more unused arguments in browser and toolkit. r=mconley,webcompat-reviewers,places-reviewers,Standard8,denschub,twisniewski 
Differential Revision: https://phabricator.services.mozilla.com/D205193
 2024-03-21 08:35:36 +00:00
Neil Deakin
9c868d9c84 Bug 1881582, implement the address autofill warning on the popup as a separate row and remove the implementation based on the custom class MozAutocompleteProfileListitemFooter, r=credential-management-reviewers,fluent-reviewers,desktop-theme-reviewers,reusable-components-reviewers,mstriemer,bolsson,sgalich,dao 
Differential Revision: https://phabricator.services.mozilla.com/D202750
 2024-03-20 15:37:15 +00:00
Neil Deakin
38db64d9ae Bug 1881582, replace the Manage button in the address/credit card autocomplete dropdown with a simpler implementation based on MozAutocompleteTwoLineRichlistitem, r=credential-management-reviewers,sgalich 
Differential Revision: https://phabricator.services.mozilla.com/D202748
 2024-03-20 15:37:15 +00:00
Neil Deakin
b45b93ca73 Bug 1881582, replace MozAutocompleteProfileListitemClearButton with an implementation based on the generic MozAutocompleteTwoLineRichlistitem type, r=credential-management-reviewers,fluent-reviewers,bolsson,tgiles,sgalich 
Differential Revision: https://phabricator.services.mozilla.com/D202747
 2024-03-20 15:37:14 +00:00