nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity
911575 commits 1 branch 98 tags 6.4 GiB
Commit graph

795 commits

Author SHA1 Message Date
Nika Layzell
a48079cd72 Bug 1881863 - Part 1: Standardize on boolean over bool in xpidl, r=xpcom-reviewers,necko-reviewers,valentin,extension-reviewers,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,search-reviewers,anti-tracking-reviewers,places-reviewers,nalexander,emilio,zombie,sgalich,karlt,lina,Standard8 
Previously the `boolean` type was also declared using a `bool` typedef in
xpidl, meaning that both were used in various places. This patch standardizes
on the built-in `boolean` type, removing the typedef.

Differential Revision: https://phabricator.services.mozilla.com/D206382
 2024-04-04 18:45:21 +00:00
Dave Townsend
a9a51bf046 Bug 1864896: Autofix unused function arguments (browser). r=webcompat-reviewers,mconley,fxview-reviewers,desktop-theme-reviewers,omc-reviewers,migration-reviewers,twisniewski,aminomancer,dao,sclements,firefox-desktop-core-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D203005
 2024-03-19 09:36:35 +00:00
Nicholas Rishel
781b2008f8 Bug 1882413 - Part 3: Modify powershell set default to more accurately mirror the Win32 API set default implementation. r=nalexander,mhughes 
This modifies the implementation to delete the registry keys via `DeleteSubKey` instead of `DeleteSubKeyTree`. This no longer throws when the DENY permission is set on a registry key as is the case for file association keys. This does throw when we are unable to delete a registry key as has been observed in newer versions of windows. Similar to the Win32 API implementation, this now halts execution and returns an error to the invoking process.

Differential Revision: https://phabricator.services.mozilla.com/D203069
 2024-03-01 23:36:55 +00:00
Nicholas Rishel
f0292a2828 Bug 1882413 - Part 1: Re-enable MSIX one-click set to default (no change from backout). r=nalexander,mhughes 
Backed out changeset 897f98487b4f

Differential Revision: https://phabricator.services.mozilla.com/D203068
 2024-03-01 23:36:54 +00:00
Michael Hughes
82527350b3 Bug 1863636 - mochi tests for filename validation to prevent callers of new functions from creating bad file paths r=nshukla,gstoll 
Added in mochi tests to validate that the C++ filename validation for taskbar tab shortcut paths works.

Differential Revision: https://phabricator.services.mozilla.com/D199689
 2024-01-29 22:26:21 +00:00
Michael Hughes
e9fb897ab6 Bug 1863636 - adding filename validation to prevent callers of new functions from creating bad file paths r=nshukla,gstoll 
As per comments on this diff about getTaskbarTabShortcutPath () I added validation on the C++ side to ensure that the shortcut name passed in can be used as a filename. Tested the changes in the browser console window and confirmed that regular names "abcd" work and confirmed that bad names ("..\\something", ".\\s", ".s", "some?") failed and generated an exception in Javascript.

Differential Revision: https://phabricator.services.mozilla.com/D199590
 2024-01-26 00:10:40 +00:00
Joel Maher
3ad5072cf1 Bug 1873732 - remove outdated manifest conditions and use consistent conditions. r=aryx,necko-reviewers,jgilbert,settings-reviewers,credential-management-reviewers,devtools-reviewers,sessionstore-reviewers,dom-storage-reviewers,sgalich,kershaw,nchevobbe,janv,dao 
Differential Revision: https://phabricator.services.mozilla.com/D198082
 2024-01-25 00:27:05 +00:00
Stanca Serban
221d7acc5b Backed out changeset 54462970f797 (bug 1873732) for causing web platform tests failures. 2024-01-24 21:08:19 +02:00
Gijs Kruitbosch
96fbfbdfb0 Bug 1780071 - autofix browser/ violations of no-comparison-or-assignment-inside-ok, r=Standard8,webcompat-reviewers,extension-reviewers,settings-reviewers,credential-management-reviewers,fxview-reviewers,sessionstore-reviewers,places-reviewers,sgalich,dao,twisniewski,mconley,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D198974
 2024-01-24 17:03:13 +00:00
Joel Maher
807575f8e1 Bug 1873732 - remove outdated manifest conditions and use consistent conditions. r=aryx,necko-reviewers,jgilbert,settings-reviewers,credential-management-reviewers,devtools-reviewers,sessionstore-reviewers,dom-storage-reviewers,sgalich,kershaw,nchevobbe,janv,dao 
Differential Revision: https://phabricator.services.mozilla.com/D198082
 2024-01-24 16:35:54 +00:00
Nipun Shukla
41645fcb5c Bug 1863636 - Part 2: Added native code changes for taskbar tabs r=win-reviewers,mhughes,gstoll 
Differential Revision: https://phabricator.services.mozilla.com/D197342
 2024-01-22 22:00:13 +00:00
Narcis Beleuzu
6964a15142 Backed out changeset f83bd0235854 (bug 1863636) for causing Bug 1875554 2024-01-22 12:52:17 +02:00
Nipun Shukla
832b5d627b Bug 1863636 - Part 2: Added native code changes for taskbar tabs r=win-reviewers,mhughes,gstoll 
Differential Revision: https://phabricator.services.mozilla.com/D197342
 2024-01-19 20:58:16 +00:00
Michael Hughes
ed4adb0e4f Bug 1870047, Bug 1870895 - Fix for 1-click set to default on MSIX builds causing the default browser to become Edge r=nalexander 
This is a revision to remove the functionality that was added over 3 or 4 previous revisions to ultimately use Powershell to set the default browser in MSIX builds. On Windows with a new feature enabled by Microsoft, this results in the HTTP and HTTPS handler being reset to Edge, which is a terrible experience.
Since there's no solve, this is rolling that all back. Done as one set of changes here because it's all deleted code except for one line, a rollback isn't clean, and it would change the Javascript side to be non-async again, which isn't necessary.

This will effectively be reopening Bug 1818418 - Allow to use Windows UserChoice default mechanisms for MSIX packages. All of the bugs created in between were side effects of that change / fix.
I will not reopen that bug because we don't plan to fix it. Microsoft is rolling out new changes that explicitly disallow that mechanism. When it hits 100%, it won't work on any build type (MSIX or not).

Differential Revision: https://phabricator.services.mozilla.com/D197747
 2024-01-05 21:29:34 +00:00
Nipun Shukla
e0bee69cbb Bug 1872543 - Fixed tab freeze due to getLaunchOnLoginShortcuts r=nalexander,mhughes 
Differential Revision: https://phabricator.services.mozilla.com/D197590
 2024-01-03 22:59:55 +00:00
Nipun Shukla
b156154948 Bug 1870852 - Fixed about:welcome pinning regression r=mhughes 
Differential Revision: https://phabricator.services.mozilla.com/D196897
 2023-12-20 18:13:30 +00:00
Michael Hughes
92a471167c Bug 1868410 - MSIX set to default browser takes too long r=nalexander,nrishel 
This fix addresses cleanup work from https://phabricator.services.mozilla.com/D194828
It also makes it so that all file/protocol handlers get set with one launch of Powershell, to speed things up. Which it does. A lot.

It also:
* makes somethings use of nsString (where it was easy to do)
* moves the thread managing code out of SetDefaultBrowser.cpp and into DefaultAgent.cpp
* puts auto in a couple of places to make the code easier to read
* removes some logging statements in the powershell script code

Differential Revision: https://phabricator.services.mozilla.com/D195839
 2023-12-13 19:52:37 +00:00
Robin Steuber
5e115d3464 Bug 1858729 - Add Edge identifier AppXd4nrz8ff68srnhf9t5a8sbjyar1cr723 r=nalexander 
Differential Revision: https://phabricator.services.mozilla.com/D190982
 2023-12-13 03:11:33 +00:00
Nipun Shukla
b6b703dee7 Bug 1860271 - Resolved launch on login checkbox and infobar bugs when user created Startup shortcut exists r=nalexander,settings-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D191763
 2023-12-12 00:22:08 +00:00
Sandor Molnar
580c448874 Backed out changeset 677c3005fd69 (bug 1860271) for causing node newtab failures at browser/components/newtab CLOSED TREE 2023-12-11 23:31:08 +02:00
Nipun Shukla
954e579287 Bug 1860271 - Resolved launch on login checkbox and infobar bugs when user created Startup shortcut exists r=nalexander,settings-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D191763
 2023-12-11 20:59:45 +00:00
Nipun Shukla
4de68492d1 Bug 1867080 - Implemented macOS functionality to find all other installed applications which support a protocol r=mhughes 
Differential Revision: https://phabricator.services.mozilla.com/D195203
 2023-12-05 05:38:34 +00:00
Iulian Moraru
320ef0c8d6 Backed out changeset 978a1152fffd (bug 1867080) for causing build bustages on nsMacShellService.cpp. CLOSED TREE 2023-12-05 01:30:10 +02:00
Nipun Shukla
41a15ef193 Bug 1867080 - Implemented macOS functionality to find all other installed applications which support a protocol r=mhughes 
Differential Revision: https://phabricator.services.mozilla.com/D195203
 2023-12-04 21:54:20 +00:00
Michael Hughes
be184998f5 Bug 1863980 - [msix] Make ShellService.setDefaultBrowser async. r=nalexander,mconley,dmose,omc-reviewers 
This commit includes the changes to call into the new asynchronous code to set the browser as default, using powershell.

While here, we add more logging to this interaction to allow easier
debugging with QA.

Differential Revision: https://phabricator.services.mozilla.com/D194949
 2023-12-01 20:07:08 +00:00
Cosmin Sabou
12fba69a84 Backed out 2 changesets (bug 1801954, bug 1863980) for bc failures on browser_setDefaultBrowser.js. CLOSED TREE 
Backed out changeset b96506a6d950 (bug 1801954)
Backed out changeset 306a649fcc00 (bug 1863980)
 2023-12-01 02:34:26 +02:00
Michael Hughes
0ff75af53b Bug 1863980 - [msix] Make ShellService.setDefaultBrowser async. r=nalexander,mconley,dmose,omc-reviewers 
This commit includes the changes to call into the new asynchronous code to set the browser as default, using powershell.

While here, we add more logging to this interaction to allow easier
debugging with QA.

Differential Revision: https://phabricator.services.mozilla.com/D194949
 2023-11-30 22:22:16 +00:00
Joel Maher
2cae29b76e Bug 1859869 - batch 12 - browser/* xpcshell .ini manifests to .toml. r=aryx,extension-reviewers,credential-management-reviewers,search-reviewers,sessionstore-reviewers,places-reviewers,issammani,Standard8,robwu,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D193996
 2023-11-21 17:35:23 +00:00
Nipun Shukla
8a0825c269 Bug 1863636 - Folded shortcut creation required for taskbar tabs into nsWindowsShellService r=mhughes 
Differential Revision: https://phabricator.services.mozilla.com/D192998
 2023-11-20 16:26:03 +00:00
Nick Alexander
cfde427e23 Bug 1818418 - Use reg.exe to implement MSIX 1-click set-to-default. r=mhughes 
This approach uses `reg.exe` to delete and recreate the relevant HKCU
registry key-value pairs.

Differential Revision: https://phabricator.services.mozilla.com/D170717
 2023-11-04 22:58:30 +00:00
Noemi Erli
b4087580aa Backed out changeset 45ab2db62a65 (bug 1818418) for causing bustages in WindowsUserChoice.h 2023-11-04 11:07:26 +02:00
Nick Alexander
24147f6234 Bug 1818418 - Use reg.exe to implement MSIX 1-click set-to-default. r=mhughes 
This approach uses `reg.exe` to delete and recreate the relevant HKCU
registry key-value pairs.

Differential Revision: https://phabricator.services.mozilla.com/D170717
 2023-11-04 02:49:46 +00:00
Butkovits Atila
f137cf6896 Backed out changeset e0f1fa408c70 (bug 1818418) for causing bustages at WindowsUserChoice.cpp. CLOSED TREE 2023-11-04 02:00:16 +02:00
Nick Alexander
8d8a560a71 Bug 1818418 - Use reg.exe to implement MSIX 1-click set-to-default. r=mhughes 
This approach uses `reg.exe` to delete and recreate the relevant HKCU
registry key-value pairs.

Differential Revision: https://phabricator.services.mozilla.com/D170717
 2023-11-03 22:48:57 +00:00
Dave Townsend
be1eb3c4b8 Bug 1857999: Move XML stylesheet processing instructions to link elements. r=Gijs,webdriver-reviewers,settings-reviewers,application-update-reviewers,devtools-reviewers,places-reviewers,Standard8,whimboo,bytesized,ochameau 
The result of running the automated script available at https://github.com/Mossop/depi

Differential Revision: https://phabricator.services.mozilla.com/D190681
 2023-10-18 07:04:41 +00:00
Sandor Molnar
9ac67f260f Backed out 4 changesets (bug 1857999) for causing dt failures on browser_theme_switching.js & Mn failures at test_element_state_chrome.py CLOSED TREE 
Backed out changeset 75f5e6e3d917 (bug 1857999)
Backed out changeset 0d0c1d1e80e7 (bug 1857999)
Backed out changeset b8a03d31ecea (bug 1857999)
Backed out changeset dd5a10f9cfff (bug 1857999)
 2023-10-16 14:12:22 +03:00
Dave Townsend
f71c7b369a Bug 1857999: Move XML stylesheet processing instructions to link elements. r=Gijs,webdriver-reviewers,settings-reviewers,application-update-reviewers,devtools-reviewers,places-reviewers,Standard8,whimboo,bytesized,ochameau 
The result of running the automated script available at https://github.com/Mossop/depi

Differential Revision: https://phabricator.services.mozilla.com/D190681
 2023-10-16 09:43:26 +00:00
stransky
18bd527479 Bug 1532281 [Linux] Don't build with dbus-glib r=glandium 
Differential Revision: https://phabricator.services.mozilla.com/D187208
 2023-10-12 12:59:08 +00:00
Emilio Cobos Álvarez
fed4a076d6 Bug 1857340 - Fix GVariant reference confusion. r=stransky 
Another bug caused by GObject floating references :')

The GVariant returned by builder_end() is floating, and the way
g_variant_builder_add_value works is that it _only_ takes a reference if
floating.

So basically if you have a RefPtr<GVariant> with a floating reference,
then pass it to g_variant_builder_add_value, the reference is "stolen",
but RefPtr doesn't know about it.

It really sucks.

Differential Revision: https://phabricator.services.mozilla.com/D190240
 2023-10-06 10:51:36 +00:00
Masatoshi Kimura
bcd7d268c4 Bug 1856104 - Remove useless version checks from JavaScript code. r=Gijs,webcompat-reviewers,settings-reviewers,search-reviewers,Standard8,twisniewski 
Differential Revision: https://phabricator.services.mozilla.com/D189696
 2023-10-02 19:00:07 +00:00
Noemi Erli
26e0b0be0a Backed out 3 changesets (bug 1856187, bug 1856100, bug 1856104) for causing newtab failures 
Backed out changeset db28784a1734 (bug 1856187)
Backed out changeset bd11e14dca63 (bug 1856104)
Backed out changeset 2741311b6055 (bug 1856100)
 2023-10-02 21:16:25 +03:00
Masatoshi Kimura
7ad48d61dd Bug 1856104 - Remove useless version checks from JavaScript code. r=Gijs,webcompat-reviewers,settings-reviewers,search-reviewers,Standard8,twisniewski 
Differential Revision: https://phabricator.services.mozilla.com/D189696
 2023-10-02 17:36:27 +00:00
Masatoshi Kimura
3e8c44dd66 Bug 1845057 - Remove aClaimAllTypes from setDefaultBrowser. r=nrishel,settings-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D189678
 2023-10-02 16:56:42 +00:00
stransky
7a0d3c3674 Bug 1854450 [Linux] Migrate nsGNOMEShellSearchProvider to GIO/DBus r=emilio 
Differential Revision: https://phabricator.services.mozilla.com/D189355
 2023-10-02 11:35:27 +00:00
stransky
f9a3e573c7 Bug 1854450 [Linux] Migrate GNOMEShellDBusHelper from dbus messages composition to GVariant r=emilio 
Differential Revision: https://phabricator.services.mozilla.com/D189354
 2023-10-02 11:35:26 +00:00
stransky
398cb0f7cc Bug 1851393 [Linux] Update distro related instructions and files for Firefox GNOME Search provider service r=emilio DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D189359
 2023-09-27 10:39:08 +00:00
Tom Marble
d596ebea8e Bug 1853243 - convert .ini manifests to .toml: batch 5 browser/**/browser.ini r=jmaher,mossop,webcompat-reviewers,twisniewski,search-reviewers,Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D188427
 2023-09-21 22:47:07 +00:00
Masatoshi Kimura
1be02e87d5 Bug 1852806 - Remove macros for older Windows SDK from browser/components/shell/. r=nalexander 
Depends on D188019

Differential Revision: https://phabricator.services.mozilla.com/D188020
 2023-09-15 03:19:26 +00:00
Cosmin Sabou
f8c16a8f94 Backed out 15 changesets (bug 1852806) for causing mda failures on test_video_low_power_telemetry.html. CLOSED TREE 
Backed out changeset faea1f4cb9a9 (bug 1852806)
Backed out changeset 4db93c374f9b (bug 1852806)
Backed out changeset 7e40e0e04921 (bug 1852806)
Backed out changeset b0a66c4269ce (bug 1852806)
Backed out changeset 4ff3545936f9 (bug 1852806)
Backed out changeset 02c0a8eb3fd6 (bug 1852806)
Backed out changeset ae2c7b33acfb (bug 1852806)
Backed out changeset 2b89ba254a1a (bug 1852806)
Backed out changeset dfa4f73fc548 (bug 1852806)
Backed out changeset daffcc4c1877 (bug 1852806)
Backed out changeset 33855bcdf15e (bug 1852806)
Backed out changeset 694f29707f3e (bug 1852806)
Backed out changeset 1891eda22a59 (bug 1852806)
Backed out changeset 1b854941389c (bug 1852806)
Backed out changeset 2f7cfe04be59 (bug 1852806)
 2023-09-15 09:48:27 +03:00
Masatoshi Kimura
ecc9aa05c7 Bug 1852806 - Remove macros for older Windows SDK from browser/components/shell/. r=nalexander 
Depends on D188019

Differential Revision: https://phabricator.services.mozilla.com/D188020
 2023-09-15 03:19:26 +00:00