Commit graph

407 commits

Author SHA1 Message Date
Jared Wein
3dd99bad30 Bug 1294799 - Disable the autoclosing of the bookmark popup if there is any interaction with it such as mousedown or keypress. r=mak
MozReview-Commit-ID: JRo5ZVu0uFD

--HG--
extra : rebase_source : ffb0d7a8323595fe61e85fee200a2aca5bc63310
2017-02-10 11:11:57 -05:00
Jared Wein
fdfcbce1e7 Bug 1335043 - Prevent the bookmark panel from closing automatically if the mouse is hovering over it. r=mak
MozReview-Commit-ID: 2jor6H2cQck

--HG--
extra : rebase_source : 970215308ca95d07c13179dcc5106e4e5eae14db
2017-01-30 10:34:53 -05:00
Thom Chiovoloni
c197835bcf Bug 1295237 - Add 'Mobile Bookmarks' root to the bookmark menus if we have it. r=markh
MozReview-Commit-ID: 3ybnskOID1O

--HG--
extra : rebase_source : 3faec9e53939626dc89c039706aaa2f003571d18
2017-01-17 13:15:49 -05:00
Ehsan Akhgari
b3e5ce4a2d Bug 1319908 - Load the menu icons for the bookmarks menu with the correct content type and principal on OSX; r=baku
This patch makes nsMenuItemIconX also participate in the setup
introduced in bug 1277803.
2017-01-20 10:55:23 -05:00
Masayuki Nakano
4515205f36 Bug 1331798 Bookmark panel for new bookmark shouldn't be closed automatically during composition and after text input without keyboard events nor composition events r=jaws
Bookmark panel for a new bookmark shouldn't be closed automatically during composition even if mouse cursor is moved outside the panel because user may click in IME's UI.

Additionally, editor might be modified without keyboard events nor composition events.  In such case, the bookmark panel shouldn't be closed automatically too.

MozReview-Commit-ID: 1FAUmkXjid

--HG--
extra : rebase_source : b4bc6eeeebfeeafe12d9cb16df7b3d31e60c5ae5
2017-01-19 15:04:56 +09:00
Jared Wein
feee0e79ef Bug 1327938 - Clear the existing timeout before creating a new one, as we should only have one autoclose timer running at a time. r=mak
MozReview-Commit-ID: 9HdSMGWRvb1

--HG--
extra : rebase_source : ab1aa61dd0eb9899baf3659841d8dc09be6f66b3
2017-01-18 11:17:10 -05:00
Jared Wein
43bac26d30 Bug 1331661 - Enable the 'quotes' rule for eslint and fix most of the errors with --fix. r=Gijs
MozReview-Commit-ID: 6tv0Z06CO4a

--HG--
extra : rebase_source : 014c0b04d8538dc5f15bc6dd4ed6bd220c55c5d4
2017-01-17 09:48:17 -06:00
Florian Quèze
85611a7b6d Bug 1331081 - script generated patch to omit addEventListener/removeEventListener's third parameter when it's false, r=jaws.
--HG--
extra : rebase_source : a22344ee1569f58f1f0a01017bfe0d46a6a14602
2017-01-17 11:50:25 +01:00
Florian Quèze
a03918c148 Bug 1330147 - automatic removal of the third boolean parameter in removeObserver calls, r=jaws. 2017-01-11 22:27:42 +01:00
Jared Wein
33317c9d1b Bug 1326712 - Allow hitting Enter on the Remove Bookmark button to remove the bookmark instead of performing the default action on the popup. r=mossop
MozReview-Commit-ID: AQ0Q4zb2g2Q

--HG--
extra : rebase_source : b44f6ab87fc0d264fb04f0de22cfba5023530e0d
2017-01-03 17:02:09 -05:00
Phil Ringnalda
cfa6520d74 Backed out changeset 83d895c1c1ea (bug 1326712) for failures in browser_bookmark_popup.js 2017-01-03 19:36:42 -08:00
Jared Wein
5670df04ee Bug 1326712 - Allow hitting Enter on the Remove Bookmark button to remove the bookmark instead of performing the default action on the popup. r=mossop
MozReview-Commit-ID: AQ0Q4zb2g2Q

--HG--
extra : rebase_source : 642233413f4656683799e31398c9dd88dc2896d9
2017-01-03 17:02:09 -05:00
Jared Wein
9141469edf Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN
MozReview-Commit-ID: FuVu8skcqOe

--HG--
extra : rebase_source : 8ab34c4e46a7c3075b459bf44786ec184d10d203
2016-12-30 21:47:25 -05:00
Jared Wein
ecab54a7c9 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje

--HG--
extra : rebase_source : 0572a35415a766a3f31d266760ecd07f0dcc3f72
2016-12-29 18:34:54 -05:00
Wes Kocher
0dfb7c2b5c Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
7255df4e9a Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR

--HG--
extra : rebase_source : da7172285d43b820421557ed3b05887e091ff939
2016-12-29 15:20:47 -05:00
Marco Bonardo
975f9b571e Bug 1321556 - Remove unused bindings from urlbarbindings.xml. r=dao
MozReview-Commit-ID: FfIsoh76ajn

--HG--
extra : rebase_source : cfc30eb7a1d9961d108dbad9ca0fb32d5c208043
2016-12-09 14:17:12 -10:00
Dave Townsend
8de07a19a0 Bug 1316882: Turn on space-before-function-paren eslint rule (browser). r=jaws
MozReview-Commit-ID: 2ZvTiZDHchz

--HG--
extra : rebase_source : db6482481b7338df491afd6f6fd376eccec84d7e
2016-11-11 08:10:51 -08:00
Dave Townsend
0a2c8f9b78 Bug 1316882: Turn on space-infix-ops eslint rule. r=jaws
MozReview-Commit-ID: HBpjT2uHJaZ

--HG--
extra : rebase_source : 78fe71a1d673a1c698520a9c82c6f35959614f8f
2016-11-10 14:48:04 -08:00
Jared Wein
87b2d4c295 Bug 1315013 - part 1, remove unnecessary double-slash comments that don't add value and look out of place with the spaced-comment eslint rule. r=mossop
MozReview-Commit-ID: HIUTSdkXxbY

--HG--
extra : rebase_source : 2f05e2f275ac7f293f9c650bdec8943189e3ce01
2016-11-03 14:42:06 -04:00
Mark Banner
09ab00a94f Bug 1313998 - Turn on no-unused-vars for local variable scopes in browser/base/content. r=mossop
MozReview-Commit-ID: IyFGBotfd11

--HG--
extra : rebase_source : aa43e5aea9e7fd7223fc59e941ecdc067abdb48f
2016-10-31 10:33:38 +00:00
Jared Wein
5040f17e00 Bug 1312486 - Enable no-extra-boolean-cast, no-new-object, no-shadow-restricted-names, and spaced-comment rules for eslint. r=standard8
MozReview-Commit-ID: 7Gx90a5y8t6

--HG--
extra : rebase_source : 9c8a6b15c19982d720b0163fbbf19d465da786fe
2016-10-24 13:14:19 -04:00
Mark Banner
709dd68567 Bug 1313626 - Clean up more issues found by eslint no-undef rule. r=mossop
MozReview-Commit-ID: HGiOmpyN5zV

--HG--
extra : rebase_source : f09a308b4c34b3cd3c28e170440bd1012176ef08
2016-10-28 11:40:32 +01:00
Dão Gottwald
dfd29d920e Bug 1304617 - Avoid using the ordinal attribute for positioning the Hide / Show Recently Bookmarked menu items. r=mak 2016-10-13 18:47:52 +02:00
Kirk Steuber
ad4b55af1f Bug 1206133 - Add popuppositioning state and popuppositioned event to improve arrow panel position handling. r=enndeakin
MozReview-Commit-ID: Dh1npORCQ6J

--HG--
extra : rebase_source : 5df6076561a746791c44d249afa31009d0e1b30a
2016-08-16 15:33:05 -07:00
Katie Broida[:ktbee]
07f2d654fe Bug 1171746 - Ensure tab-specific panels close when you switch the tab. r=jaws
--HG--
extra : amend_source : 8c8bd60be44132befa37a50422086d9ffdae3cbe
2016-08-19 07:27:00 -04:00
Wes Kocher
7636e9aaaf Backed out changeset 33fcf83eefe4 (bug 1171746) for browser_visibleFindSelection.js failures a=backout 2016-08-12 19:11:21 -07:00
Katie Broida[:ktbee]
b9d80840e4 Bug 1171746 - ensure tab specific panels close when you switch the tab r=jaws
Adds a tabspecific attribute to the edit bookmarks panel and the Pocket subview panel to signal that these popups should close when the user navigates away from the tab. It also specifies that the localized keyboard short cut for closing a  window should close the edit bookmarks panel and the tab by adding a general function to check whether a certain <key> has been pressed. Adds tests for both closing specific tabs and checking keys.

MozReview-Commit-ID: AxW5uQgDQQB

--HG--
extra : rebase_source : 76f649492e719317a9ef71895e9cb1d600ea67b1
2016-08-11 16:51:45 -04:00
Dão Gottwald
347cc05845 Bug 1289659 - Account for placesContext not existing in non-browser windows on Mac. r=mdeboer 2016-08-10 13:49:20 +02:00
Jared Wein
fd84c776c7 Bug 1292042 - Enable the keyword-spacing rule for eslint. Most of this patch was autogenerated by 'eslint --fix'. Files with .xml extension needed to be changed by hand due to limitations of custom plugin. r=markh
MozReview-Commit-ID: EMjJ3yWt9Wt

--HG--
extra : rebase_source : 2b8327e5a7cf0bfd190d696ad5fe475f13faa3cc
2016-08-04 03:28:58 -04:00
Pushpankar
c6670d980f Bug 1286854 - Replace ownerDocument.defaultView with ownerGlobal in browser/. r=dao
--HG--
extra : rebase_source : 72d50e73baf595840a2aade57ae782e4c40d4c27
2016-07-16 10:20:04 +02:00
Jared Wein
78099b5a1b Bug 1251071 - "New bookmark" popup disappears if I reopen it after creating bookmark. r=mak
MozReview-Commit-ID: DNqcu5vxrBG
* * *


MozReview-Commit-ID: 3KoNVklCK8d
2016-07-06 07:27:00 +02:00
Scott Wu
14183e306e Bug 754623 - Get page title from tab label; r=mak
MozReview-Commit-ID: BOXUKUcA0fZ

--HG--
extra : transplant_source : C%15%EB%C50%A3%E4eK%C7%60%965l%F5u%A3%F3%B9%0F
2016-05-19 12:45:21 +08:00
Dão Gottwald
f0ad31722f Bug 1257087 - Middle mouse click on history item should open it. r=mak 2016-05-25 18:15:15 +02:00
Dão Gottwald
b2ab89a79b Bug 1219788 - Show bookmarks toolbar when adding a bookmark to the bookmarks toolbar folder. r=mak 2016-05-24 14:31:33 +02:00
Sebastian Hengst
5a53f34fe3 Backed out changeset 54ebf85e8731 (bug 1219788) for leaks in many mochitests on Linux. r=backout 2016-05-21 09:35:06 +02:00
Dão Gottwald
377084b710 Bug 1219788 - Show bookmarks toolbar when adding a bookmark to the bookmarks toolbar folder. r=mak
--HG--
extra : rebase_source : d7fc47340b6655ac5050d5e742dc39565e147e82
2016-05-20 14:41:49 +02:00
Mike de Boer
08e2673c63 Bug 1248267 - allow Recently Bookmarked items to be special root nodes to allow primitive contextual actions. r=mak,dao 2016-05-19 12:37:33 +02:00
Dão Gottwald
ab3bd282d9 Bug 1250203 - Re-populate recent bookmarks when a bookmark gets deleted while the menu is open. r=mak 2016-05-04 16:52:40 +02:00
Carsten "Tomcat" Book
548d98c27e merge mozilla-inbound to mozilla-central a=merge 2016-05-02 11:25:32 +02:00
Matt Brubeck
a17fb5bfed Bug 943888 - Always keep the bookmark star button enabled [r=mak]
MozReview-Commit-ID: 27ee1dbLSM1

--HG--
extra : rebase_source : 2d9a4aa005d585fa6ceafe174bbbd5f8c6b8f5ec
2016-04-25 13:59:00 -07:00
Scott Wu
ca33d182f4 Bug 446171 - Part 1: Get page titles from tab and not depend on history; r=mak
MozReview-Commit-ID: EUQv2p9LxtY

--HG--
extra : rebase_source : 0967a5d7b3fcb6cfd74c00f6252a6cca1a85b77b
extra : histedit_source : 6ee3667d3a79284058e2f9628e0b5d1c365ff7a9
2016-03-21 14:57:18 +08:00
Dão Gottwald
ac879e2e39 Bug 1248268 - Add option for disabling the "Recently Bookmarked" UI. r=mak 2016-04-29 13:43:59 +02:00
Wes Kocher
5b1e4f68c2 Backed out changeset fec92924befb (bug 1250203) for bc leaks
MozReview-Commit-ID: BMq0vBarOQZ
2016-04-15 12:19:44 -07:00
Dão Gottwald
10bc69ffda Bug 1250203 - Re-populate recent bookmarks when a bookmark has been deleted. r=mak 2016-04-15 16:50:20 +02:00
Sebastian Hengst
c515d4ce79 Backed out changeset 81df156cb345 (bug 1250203) for test failures in mochitest-5 test_ext_bookmarks.html, browser-chrome browser_views_liveupdate.js, OS X xpcshell test_browserGlue_migrate.js and maybe more. r=backout on a CLOSED TREE 2016-04-08 18:42:07 +02:00
Dão Gottwald
02c6656bf9 Bug 1250203 - Re-populate recent bookmarks when a bookmark has been deleted. r=mak 2016-04-08 16:33:21 +02:00
malayaleecoder
b3deb181bb Bug 1254496 - Remove gURLBar null-checks. r=dao 2016-03-10 23:15:49 +05:30
Marco Bonardo
6cc886e9f3 Bug 1253930 - Recently bookmarked items have the default favicon instead of the correct one. r=dao
MozReview-Commit-ID: LMTVQetQL9Q

--HG--
extra : rebase_source : 76bc5e0eb24bfd0e6c26e7d577100a566dda94de
2016-03-07 12:06:40 +01:00
Dão Gottwald
d97fcaaba2 Bug 1250806 - Add menuitems for recent bookmarks synchronously so that they show up in the native menubar on OS X. r=mak 2016-03-02 17:16:59 +01:00