Commit graph

179 commits

Author SHA1 Message Date
Mats Palmgren
a901b05850 Bug 1542807 part 1 - Create generated content and use normal box construction for list-style-type/list-style-image ::markers. r=emilio
The change from 0x25FE to 0x25AA for list-style-type:square
was approved here:
https://github.com/w3c/csswg-drafts/issues/6200#issuecomment-828616747

Differential Revision: https://phabricator.services.mozilla.com/D111691
2021-06-14 01:22:04 +00:00
Kagami Sascha Rosylight
55dbc99e55 Bug 1713491 - Return std::pair from nsIFrame::GetOffsets r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D117520
2021-06-11 23:54:06 +00:00
Butkovits Atila
ed3da455ae Backed out 7 changesets (bug 1542807) for causing failures at inert-retargeting-iframe.tentative.html. CLOSED TREE
Backed out changeset e9ef32fa2f2e (bug 1542807)
Backed out changeset 8fa0cb199975 (bug 1542807)
Backed out changeset 38daf64afe59 (bug 1542807)
Backed out changeset e3aee052c495 (bug 1542807)
Backed out changeset a71056d4c7cc (bug 1542807)
Backed out changeset cf91e7d0a37f (bug 1542807)
Backed out changeset eee949e5fd67 (bug 1542807)
2021-06-12 01:38:25 +03:00
Butkovits Atila
53cb932555 Backed out changeset aa6c7477c4d2 (bug 1713491) for causing build bustages on nsIFrame.cpp. CLOSED TREE 2021-06-12 00:12:06 +03:00
Kagami Sascha Rosylight
9d0b659349 Bug 1713491 - Return std::pair from nsIFrame::GetOffsets r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D117520
2021-06-11 18:53:28 +00:00
Mats Palmgren
906fd4d388 Bug 1542807 part 1 - Create generated content and use normal box construction for list-style-type/list-style-image ::markers. r=emilio
The change from 0x25FE to 0x25AA for list-style-type:square
was approved here:
https://github.com/w3c/csswg-drafts/issues/6200#issuecomment-828616747

Differential Revision: https://phabricator.services.mozilla.com/D111691
2021-06-11 18:10:38 +00:00
Dorel Luca
e1f4d9bb38 Backed out changeset 17e7b969b830 (bug 1713491) for Linux build bustage in gecko/dom/events/ContentEventHandler.cpp. CLOSED TREE 2021-06-11 17:52:10 +03:00
Kagami Sascha Rosylight
74760a9a0e Bug 1713491 - Return std::pair from nsIFrame::GetOffsets r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D117520
2021-06-11 11:37:11 +00:00
Eitan Isaacson
349592fb91 Bug 1714390 - P6: Make more attribute keys static atoms. r=Jamie
Keys should be static atoms whenever possible.

Differential Revision: https://phabricator.services.mozilla.com/D116787
2021-06-10 23:07:07 +00:00
Eitan Isaacson
474a197205 Bug 1714390 - P4: Set non-string values in AccAttributes when possible. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D116785
2021-06-10 23:07:06 +00:00
Eitan Isaacson
62d0cdcad4 Bug 1714390 - P2: Use AccAttributes for accessible and text attributes. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D116783
2021-06-10 23:07:05 +00:00
Masayuki Nakano
4bc0632c23 Bug 1713758 - Make everyone outside editor module use EditorBase instead of TextEditor if the instance can be an HTMLEditor instance r=m_kato
Differential Revision: https://phabricator.services.mozilla.com/D117119
2021-06-09 23:51:37 +00:00
Eitan Isaacson
ffd5c8b856 Bug 1694566 - P3: Rename ChildAtPoint to LocalChildAtPoint. r=Jamie
This is in preparation for the next patch the virtualizes ChildAtPoint
in the Accessible class. LocalChildAtPoint allows us to house local-only
child at point implementations.

Differential Revision: https://phabricator.services.mozilla.com/D106679
2021-03-03 06:10:01 +00:00
Eitan Isaacson
d6fb8b1903 Bug 1694566 - P2: Make EWhichChildAtPoint an enum class and put it in Accessible. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D106678
2021-03-03 06:10:01 +00:00
Eitan Isaacson
b5f10ca9cb Bug 1694203 - P4: Move IsTextRole from HyperTextAccessible to base class. r=Jamie
This will allow us to more easily query IsTextRole in remote case.

Differential Revision: https://phabricator.services.mozilla.com/D104925
2021-03-02 16:32:22 +00:00
Eitan Isaacson
6e49732365 Bug 1693597 - P1: Rename Accessible to LocalAccessible. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D105670
2021-02-19 23:14:32 +00:00
Eitan Isaacson
f48f468cb7 Bug 1693607 - [Linux] Add braces around statements. r=morgan
This is a collaboration between clang-tidy and clang-format.

clang-tidy uses compiled code paths, so this patch is linux specific.

Differential Revision: https://phabricator.services.mozilla.com/D105669
2021-02-19 23:14:32 +00:00
Eitan Isaacson
8c842a59e3 Bug 1692523 - P1: Prefix local heirarchy functions with 'Local'. r=Jamie
Parent -> LocalParent
GetChildAt -> LocalChildAt
FirstChild -> LocalFirstChild
LastChild -> LocalLastChild
NextSibling -> LocalNextSibling
PrevSibling -> LocalPrevSibling

Differential Revision: https://phabricator.services.mozilla.com/D105034
2021-02-16 20:05:10 +00:00
Andi-Bogdan Postelnicu
8de41d8d26 Bug 1683561 - Make accessibility buildable outside of unified-build environment. r=sg
Differential Revision: https://phabricator.services.mozilla.com/D100212
2021-01-05 09:47:12 +00:00
Eitan Isaacson
f42d5e8b3d Bug 1672694 - P1: Query layout for selectable text state. r=morgan,Jamie,yzen
The SELECTABLE_TEXT state is currently under-utilized and probably wrong, since it simply relies on testing if a hypertext has any text. A more correct reflection of the state should be taken from layout's IsSelectable method.

Note, even if an element is styled `user-select: none`, the text will still be keyboard selectable if it is editable (eg. input or contenteditable), so we should consider that SELECTABLE_TEXT.

Differential Revision: https://phabricator.services.mozilla.com/D95783
2020-11-04 19:56:55 +00:00
Marco Zehe
19a10e117a Bug 1675172 - Prevent an infinite loop when finding the line end boundary for an offset of 0, r=Jamie
Use a safer looping method, walking forward from aOffset to tmpOffset to prevent wrapping around at 0.

Differential Revision: https://phabricator.services.mozilla.com/D95826
2020-11-04 07:09:59 +00:00
Razvan Maries
fd7d890c94 Backed out 2 changesets (bug 1672694) for Lint failures on browser_text_selection.js and perma failures on browser_accessibility_node.js. CLOSED TREE
Backed out changeset 0f340ea56805 (bug 1672694)
Backed out changeset b222e4ff438f (bug 1672694)
2020-11-04 03:15:17 +02:00
Eitan Isaacson
8a078f1f55 Bug 1672694 - P1: Query layout for selectable text state. r=morgan,Jamie
The SELECTABLE_TEXT state is currently under-utilized and probably wrong, since it simply relies on testing if a hypertext has any text. A more correct reflection of the state should be taken from layout's IsSelectable method.

Note, even if an element is styled `user-select: none`, the text will still be keyboard selectable if it is editable (eg. input or contenteditable), so we should consider that SELECTABLE_TEXT.

Differential Revision: https://phabricator.services.mozilla.com/D95783
2020-11-04 00:28:57 +00:00
James Teh
72da707476 Bug 1673919: Make ParagraphBoundaryRule skip over OuterDocAccessibles. r=MarcoZ
The browser test is really a crash test, but it's really difficult to test a11y APIs properly using the crashtest framework.

Differential Revision: https://phabricator.services.mozilla.com/D95107
2020-10-29 06:04:33 +00:00
Marco Zehe
f9e0ccb2a1 Bug 1525631 - Return correct line start and end offsets for inline-block elements with nested line breaks, r=Jamie
If an inline-block element contains nested elements that may contain line breaks, or whitespace that comes from how the HTML file is formatted, both start and end offsets returned from layout may be incorrect. Adjust for the following cases:

* The start offset goes too far back from the passed-in offset, overshooting a line boundary.
* The end offset returned is smaller than the passed-in offset, even though we want the start of the next line. Even on the last line, this should never happen.

Differential Revision: https://phabricator.services.mozilla.com/D94744
2020-10-27 06:10:33 +00:00
Marco Zehe
92ae4518de Bug 1670541 - Return the parent line end offset if an embedded character contains a line break, r=Jamie
If the offset for an embedded character is queried, and it is an inline element, such as a link, and it contains a line break, return the full parent line.

Likewise, if querying character offsets before that embedded character, include its line break in the end offset.

Differential Revision: https://phabricator.services.mozilla.com/D94024
2020-10-23 04:57:17 +00:00
James Teh
64ef64960b Bug 1672593: When calculating the paragraph end offset starting from an inline child and a block boundary is found, stop on the boundary, not after it. r=MarcoZ
Differential Revision: https://phabricator.services.mozilla.com/D94407
2020-10-22 04:58:46 +00:00
James Teh
29fd7c7753 Bug 1670846: Treat line break characters in pre-formatted text as a11y paragraph boundaries. r=MarcoZ
In pre-formatted text (including textareas), text leaf nodes can contain line break characters ("\n").
Therefore, when searching for a paragraph boundary, we must match these.
Pivot can't return an ofset, only an Accessible, so we store the offset for the last match on the rule.
Because our origin point might be within a text leaf which contains a line break before/after it, we must also pass in the offset in our origin in this case so we can begin the text search from the right place.

Differential Revision: https://phabricator.services.mozilla.com/D93719
2020-10-18 09:19:23 +00:00
Marco Zehe
0ada0a0e77 Bug 1668546 Part 2 - Remove the explicit class tag to Pivot from HyperTextAccessible and make it a normal assignment, r=eeejay
Depends on D92216

Differential Revision: https://phabricator.services.mozilla.com/D92217
2020-10-05 17:45:58 +00:00
Marco Zehe
ce4b2c115c Bug 1666998 - Implement layout-independent paragraph offset search, r=Jamie
This uses the Pivot class to search backwards and forwards from the current offsets until either end is reached, or an accessible that is either a line break or has a block frame, is found, and therefore constitutes a boundary of interest.

Differential Revision: https://phabricator.services.mozilla.com/D91407
2020-10-01 14:16:07 +00:00
Cosmin Sabou
1fa6714a17 Backed out changeset 1b8515b4548c (bug 1666998) for bustages on HyperTextAccessible.cpp. CLOSED TREE 2020-10-01 14:56:38 +03:00
Marco Zehe
77c3d1eac2 Bug 1666998 - Implement layout-independent paragraph offset search, r=Jamie
This uses the Pivot class to search backwards and forwards from the current offsets until either end is reached, or an accessible that is either a line break or has a block frame, is found, and therefore constitutes a boundary of interest.

Differential Revision: https://phabricator.services.mozilla.com/D91407
2020-10-01 10:41:46 +00:00
James Teh
95f7af8423 Bug 872397: Work around inconsistencies in layout word movement to ensure that a11y word start boundaries are consistent around punctuation and white space. r=MarcoZ
Differential Revision: https://phabricator.services.mozilla.com/D90654
2020-09-22 11:11:15 +00:00
Eitan Isaacson
db323082ed Bug 1661765 - Part 1: Move selection and scroll functions to TextRange. r=Jamie
This gives us the flexibility of selecting and scrolling to any range, not just
offsets in a given container.

Differential Revision: https://phabricator.services.mozilla.com/D90591
2020-09-21 22:52:01 +00:00
Marco Zehe
0c2fda970a Bug 1665662 - Ensure that at the end of a paragraph, after a line break, we return empty line offsets, r=Jamie
If in a textarea, a blank line is inserted, we need to return the offsets of just that new inner paragraph, or the braille display of a screen reader will show the previous line and not a blank one.

Differential Revision: https://phabricator.services.mozilla.com/D90655
2020-09-18 06:58:33 +00:00
Marco Zehe
6fb51e8cb7 Bug 1520779 Part 6: Return consistent results for paragraphs that contain forced line breaks, r=Jamie
1. Make sure the paragraph text and start and end ofsets returned for offsets on either the text or its adjacent br always match.
2. For a single line break at the beginning of the enclosing paragraph, or two consecutive line breaks, treat the second one as its own paragraph without text, and its start offset corresponding to its offset, and end offset being 1 greater.
3. Add a test case exercising all cases.

Differential Revision: https://phabricator.services.mozilla.com/D90355
2020-09-17 04:51:31 +00:00
Marco Zehe
2209e8f5b2 Bug 1520779 Part 5: Expose both text and list bullet when requesting the paragraph from a list item, r=Jamie
Tagging onto what we already do for getting line offsets, also doing the same when the paragraph selection is requested.

Differential Revision: https://phabricator.services.mozilla.com/D90238
2020-09-17 00:02:22 +00:00
Marco Zehe
b3310a715c Bug 1520779 Part 2: Implement nsIAccessibleText::BOUNDARY_PARAGRAPH in HyperTextAccessible::GetTextAtOffset, r=Jamie,eeejay
For TextBeforeOffset and TextAfterOffset, bail out with an empty text and 0-initialized out integers if the boundary type is nsIAccessibleText::BOUNDARY_PARAGRAPH.

Differential Revision: https://phabricator.services.mozilla.com/D90115
2020-09-17 00:02:21 +00:00
Dorel Luca
87b04b7232 Backed out 6 changesets (bug 1520779) for Mochitest failures in accessible/tests/mochitest/tree/test_img.html. CLOSED TREE
Backed out changeset 1d5de85e5c45 (bug 1520779)
Backed out changeset 3e53ec41f414 (bug 1520779)
Backed out changeset 2e3924874d25 (bug 1520779)
Backed out changeset 6ddb6ee83467 (bug 1520779)
Backed out changeset 3ca759ecb3d7 (bug 1520779)
Backed out changeset 4cf65b0cd304 (bug 1520779)
2020-09-17 02:56:15 +03:00
Marco Zehe
e828bc6794 Bug 1520779 Part 6: Return consistent results for paragraphs that contain forced line breaks, r=Jamie
1. Make sure the paragraph text and start and end ofsets returned for offsets on either the text or its adjacent br always match.
2. For two consecutive line breaks, treat the second one as its own paragraph without text, and its start offset corresponding to its offset, and end offset being 1 greater.
3. Add a test case exercising all cases.

Differential Revision: https://phabricator.services.mozilla.com/D90355
2020-09-16 20:59:21 +00:00
Marco Zehe
58bbff873c Bug 1520779 Part 5: Expose both text and list bullet when requesting the paragraph from a list item, r=Jamie
Tagging onto what we already do for getting line offsets, also doing the same when the paragraph selection is requested.

Differential Revision: https://phabricator.services.mozilla.com/D90238
2020-09-16 08:09:39 +00:00
Marco Zehe
b1af3b9011 Bug 1520779 Part 2: Implement nsIAccessibleText::BOUNDARY_PARAGRAPH in HyperTextAccessible::GetTextAtOffset, r=Jamie,eeejay
For TextBeforeOffset and TextAfterOffset, bail out with an empty text and 0-initialized out integers if the boundary type is nsIAccessibleText::BOUNDARY_PARAGRAPH.

Differential Revision: https://phabricator.services.mozilla.com/D90115
2020-09-16 03:52:47 +00:00
Simon Giesecke
cd8b8939b9 Bug 1648010 - Replace uses of NS_LITERAL_STRING/NS_LITERAL_CSTRING macros by _ns literals. r=geckoview-reviewers,jgilbert,agi,hsivonen,froydnj
Differential Revision: https://phabricator.services.mozilla.com/D80860
2020-07-01 08:29:29 +00:00
Eitan Isaacson
ccdf272301 Bug 1647483 - Add a TextRange getter to text selection change events. r=Jamie
This includes 3 changes:
1. Add a lazy ranges getter to AccTextSelChangeEvent.
2. Create an XPCOM interface for testing purposes.
3. Add IPDL bindings for passing ranges in e10s.

Differential Revision: https://phabricator.services.mozilla.com/D80556
2020-06-23 18:52:42 +00:00
Simon Giesecke
ebbc7ae838 Bug 1642989 - Use RemoveLastElements instead of RemoveElementsAt where possible. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D78049
2020-06-08 08:50:15 +00:00
Simon Giesecke
13502cf27c Bug 1642991 - Use RemoveElementsBy where easily possible. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D78055
2020-06-08 09:01:48 +00:00
James Teh
b1c5fca60f Bug 1547657: Null check frame in HyperTextAccessible::TextBounds. r=MarcoZ
Differential Revision: https://phabricator.services.mozilla.com/D78631
2020-06-08 05:11:23 +00:00
Emilio Cobos Álvarez
b9c1bf761c Bug 312971 - Unprefix -moz-read-write / -moz-read-only. r=edgar
And remove some duplicated tests from WPT.

Differential Revision: https://phabricator.services.mozilla.com/D75231
2020-05-14 16:46:08 +00:00
Mirko Brodesser
81a6751c80 Bug 1634663: part 1) Declare Selection::GetRangeAt's callers const around dom/ code. r=masayuki
Only where possible, of course.

Differential Revision: https://phabricator.services.mozilla.com/D73444
2020-05-02 23:43:02 +00:00
Jonathan Watt
2d1fc3c186 Bug 1634217. Make accessible/ buildable outside of unified-build environment. r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D73176
2020-05-01 04:28:35 +00:00