Commit graph

111 commits

Author SHA1 Message Date
Connor Sheehan
676ffafaec Bug 1670031: update fallback fingerprint in run-task r=zeid
Differential Revision: https://phabricator.services.mozilla.com/D94018
2020-10-19 15:37:23 +00:00
Mike Hommey
8ae215f6f3 Bug 1669879 - Always use hg in run-task on mac. r=releng-reviewers,mtabara
All the workers that had hg under /tools/python27-mercurial are gone.
This also fixes run-task for workers running > 10.14.

Differential Revision: https://phabricator.services.mozilla.com/D92867
2020-10-08 09:40:25 +00:00
Bogdan Tara
6a589167f0 Backed out 2 changesets (bug 1669879) for docker failures CLOSED TREE
Backed out changeset f484bfd1ad97 (bug 1669879)
Backed out changeset 86061c7de217 (bug 1669879)
2020-10-09 07:50:02 +03:00
Mike Hommey
d9a9f5848c Bug 1669879 - Always use hg in run-task on mac. r=releng-reviewers,mtabara
All the workers that had hg under /tools/python27-mercurial are gone.
This also fixes run-task for workers running > 10.14.

Differential Revision: https://phabricator.services.mozilla.com/D92867
2020-10-08 09:40:25 +00:00
Tom Prince
5266998a5b Bug 1492362: [taskgraph] Don't delete fetches after running a task; r=glandium
In Bug 1466660, we started deleting the fetches after a task had run, to avoid
interference between tasks. It turns out the only tasks this was for were the
`source-test-jsshell` tasks, which were changed to use an absolute directory in
Bug 1465181. However, since Bug 1568460 we've always used a per-task directory
for fetches, so can remove the work-around of removing fethes.

Differential Revision: https://phabricator.services.mozilla.com/D86670
2020-08-19 11:02:22 +00:00
Narcis Beleuzu
9b1cd3b0bd Backed out 4 changesets (bug 1492362) for android wpt failures. CLOSED TREE
Backed out changeset ac0fdd0c661e (bug 1492362)
Backed out changeset 89ecd6ee8edd (bug 1492362)
Backed out changeset ae17b683bf71 (bug 1492362)
Backed out changeset 485f333bc3b7 (bug 1492362)
2020-08-19 13:54:36 +03:00
Tom Prince
3ffe1948d3 Bug 1492362: [taskgraph] Don't delete fetches after running a task; r=glandium
In Bug 1466660, we started deleting the fetches after a task had run, to avoid
interference between tasks. It turns out the only tasks this was for were the
`source-test-jsshell` tasks, which were changed to use an absolute directory in
Bug 1465181. However, since Bug 1568460 we've always used a per-task directory
for fetches, so can remove the work-around of removing fethes.

Differential Revision: https://phabricator.services.mozilla.com/D86670
2020-08-19 01:05:42 +00:00
Csoregi Natalia
2dd1b9f726 Backed out 4 changesets (bug 1492362) for gecko decision bustage. CLOSED TREE
Backed out changeset 8e6cf79c70f7 (bug 1492362)
Backed out changeset 225a6bfe8cbf (bug 1492362)
Backed out changeset ea667ccd4b19 (bug 1492362)
Backed out changeset a20562dbfece (bug 1492362)
2020-08-19 04:01:35 +03:00
Tom Prince
c76e62f3a3 Bug 1492362: [taskgraph] Don't delete fetches after running a task; r=glandium
In Bug 1466660, we started deleting the fetches after a task had run, to avoid
interference between tasks. It turns out the only tasks this was for were the
`source-test-jsshell` tasks, which were changed to use an absolute directory in
Bug 1465181. However, since Bug 1568460 we've always used a per-task directory
for fetches, so can remove the work-around of removing fethes.

Differential Revision: https://phabricator.services.mozilla.com/D86670
2020-08-18 07:49:40 +00:00
Simon Fraser
27e5ba55f3 Bug 1648051 Task resource monitor r=mtabara,tomprince
I've left the monitor disabled for now, so that we can have a smaller pushes for enabling and disabling it if needed. It should allow more fine grained control.

We may also want to include extracting the monitor tool from a github version instead, and also removing the assumption and it being forked from the parent, so that it's instead given a process ID to treat as the parent it should watch.

Differential Revision: https://phabricator.services.mozilla.com/D84374
2020-08-06 01:21:24 +00:00
Mike Hommey
4ae6ad3247 Bug 1616790 - Keep the hard limit for ulimit -n unchanged. r=froydnj
The hard limit prevents program to set a value higher than the soft
limit for themselves, and it turns out Firefox does that.

Also, keep the soft limit to its original value if it was already less
than 1024.

Differential Revision: https://phabricator.services.mozilla.com/D63623

--HG--
extra : moz-landing-system : lando
2020-02-21 16:25:13 +00:00
Mike Hommey
b5e7aae8d0 Bug 1615174 - Set ulimit to a reasonable value for tasks. r=dmajor
while allowing it to be tweakable without editing run-task each time
(rebuilding all docker images as a consequence)

Differential Revision: https://phabricator.services.mozilla.com/D62701

--HG--
extra : moz-landing-system : lando
2020-02-16 14:55:35 +00:00
Connor Sheehan
6a1f431ad6 Bug 1596479: teach run-task to get worker location from TASKCLUSTER_WORKER_LOCATION environment var r=tomprince
Previously we inspected the `TASKCLUSTER_WORKER_GROUP` environment variable,
which now only returns the cloud provider of the worker. This commit teaches
`run-task` to instead use the `TASKCLUSTER_WORKER_LOCATION` to gather
information about the location of the worker. We also use the extra data
about the cloud provider for the worker to construct a key for use in the
config, in the form `cloudprovider/region`, so GCP hgweb mirrors can be
amended to the `hgmointernal` config when they are ready.

While we're here we make the error handling for a missing environment
variable slightly nicer.

Differential Revision: https://phabricator.services.mozilla.com/D53209

--HG--
extra : moz-landing-system : lando
2019-11-21 19:48:32 +00:00
Brindusan Cristian
f8cfa641a5 Backed out changeset efb782988830 (bug 1596479) for wrench bustage (KeyError: 'region'). CLOSED TREE 2019-11-21 00:45:18 +02:00
Connor Sheehan
3adff2160f Bug 1596479: teach run-task to get worker location from TASKCLUSTER_WORKER_LOCATION environment var r=tomprince
Previously we inspected the `TASKCLUSTER_WORKER_GROUP` environment variable,
which now only returns the cloud provider of the worker. This commit teaches
`run-task` to instead use the `TASKCLUSTER_WORKER_LOCATION` to gather
information about the location of the worker. We also use the extra data
about the cloud provider for the worker to construct a key for use in the
config, in the form `cloudprovider/region`, so GCP hgweb mirrors can be
amended to the `hgmointernal` config when they are ready.

While we're here we make the error handling for a missing environment
variable slightly nicer.

Differential Revision: https://phabricator.services.mozilla.com/D53209

--HG--
extra : moz-landing-system : lando
2019-11-20 00:10:53 +00:00
Geoff Brown
ae5e32a41c Bug 1586262 - Ensure run-task logs very long task output lines; r=dustin
Check the return code of write() to determine if the output line has actually been written completely; if not, write the remainder.

Tests suggest that incomplete writes are possible when the buffer exceeds a few thousand bytes. Very long log lines are unusual but this is important for cases like reftest failures where an encoded screenshot is dumped to the log.

Differential Revision: https://phabricator.services.mozilla.com/D48218

--HG--
extra : moz-landing-system : lando
2019-10-16 15:56:09 +00:00
Mike Hommey
f56829593a Bug 1573375 - Normalize paths run-task sets in the environment on Windows. r=tomprince
Using forward slash for better support in shell scripts.

Differential Revision: https://phabricator.services.mozilla.com/D41707
2019-08-15 11:21:41 +09:00
Mike Hommey
94532ae09f Bug 1573375 - Wrap fetch-content output in run-task. r=tomprince
Like the output from other subcommands.

Differential Revision: https://phabricator.services.mozilla.com/D41706
2019-08-15 11:21:40 +09:00
Tom Prince
f5366339ef Bug 1570054: Specify UPLOAD_DIR explicitly in taskgraph for docker-worker built toolchains; r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D39903
2019-08-02 19:05:56 +09:00
Tom Prince
a09d72c850 Bug 1565725: Add an option to run-task to change the current directory for the command; r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D39599
2019-08-02 19:05:55 +09:00
Mike Hommey
633f41e4b0 Bug 1568460 - Set MOZ_FETCHES_DIR more appropriately. r=tomprince
For some tasks, the workdir known to the decision task doesn't actually match
the workdir used in the task, which makes MOZ_FETCHES_DIR wrong when the
decision task derives it from the workdir.

On other tasks, MOZ_FETCHES_DIR is set to a relative directory, which
may work in some places where MOZ_FETCHES_DIR is used, but not in
others, that happen to be executed from a different directory.

To solve both problems, we set MOZ_FETCHES_DIR as a relative directory
everywhere, and we make run-task normalize it to an absolute path
before executing the task.

Differential Revision: https://phabricator.services.mozilla.com/D39152

--HG--
extra : moz-landing-system : lando
2019-07-29 20:48:40 +00:00
shindli
1c380bd4ec Backed out changeset a2c0bed45b89 (bug 1568460) for causing spidermonkey failures "[Errno 2] No such file or directory" 2019-07-29 04:51:41 +03:00
Mike Hommey
54a61a549b Bug 1568460 - Set MOZ_FETCHES_DIR more appropriately. r=tomprince
For some tasks, the workdir known to the decision task doesn't actually match
the workdir used in the task, which makes MOZ_FETCHES_DIR wrong when the
decision task derives it from the workdir.

On other tasks, MOZ_FETCHES_DIR is set to a relative directory, which
may work in some places where MOZ_FETCHES_DIR is used, but not in
others, that happen to be executed from a different directory.

To solve both problems, we set MOZ_FETCHES_DIR as a relative directory
everywhere, and we make run-task normalize it to an absolute path
before executing the task.

Differential Revision: https://phabricator.services.mozilla.com/D39152

--HG--
extra : moz-landing-system : lando
2019-07-28 22:05:42 +00:00
Joel Maher
ec5f3f9ae1 Bug 1551957 - Allow for osx 10.14 in CI for source tasks. r=ahal
Allow for osx 10.14 in CI for source tasks.

Differential Revision: https://phabricator.services.mozilla.com/D31297

--HG--
extra : moz-landing-system : lando
2019-05-15 21:04:57 +00:00
Mike Hommey
ca39c407dd Bug 1545368 - Support fetches in run-task on generic-worker. r=tomprince
Differential Revision: https://phabricator.services.mozilla.com/D28048

--HG--
extra : moz-landing-system : lando
2019-04-27 21:56:47 +00:00
Mike Hommey
33a06d6450 Bug 1545344 - Don't change current directory when executing a command via run-task. r=tomprince
Currently, all things running via run-task don't really care that the
current directory is set to /. However, on generic-worker, many things
assume the current directory is the task directory, which varies by
task, and wrapping them with run-task fails because it resets the
current directory.

Differential Revision: https://phabricator.services.mozilla.com/D28018

--HG--
extra : moz-landing-system : lando
2019-04-27 21:51:53 +00:00
Mike Hommey
25920280d9 Bug 1544986 - Fall back more gracefully when TASKCLUSTER_WORKER_GROUP is not set. r=tomprince
Differential Revision: https://phabricator.services.mozilla.com/D27841

--HG--
extra : moz-landing-system : lando
2019-04-23 21:27:50 +00:00
Connor Sheehan
a8c491e89c Bug 1534463: patch run-task to clone from private hgweb mirrors r=tomprince
With tasks able to access the hgmointernal config from a Taskcluster
secret, we can now add functionality to `run-task` to support checking
out from the private hg service. Here we add add a `resolve_checkout_url`
function which takes the base/head repository URLs and determines
whether we should clone from the public or private service, returning
the resolved URL. The function pulls down the secret and checks that
the region the task is executing in is in the set of supported regions.
Then we generate a random number and default to the public service if
the number is lower than our "rate". If all the above conditions are
met, we replace `hg.mozilla.org` with the resolved domain name for the
given region.

We add a call to this function to `collect_vcs_options`, and skip
resolving the private URL if we aren't performing a checkout from
within `run-task`.

Differential Revision: https://phabricator.services.mozilla.com/D25002

--HG--
extra : moz-landing-system : lando
2019-04-11 17:19:36 +00:00
Kartikaya Gupta
3674245c97 Bug 1516568 - Provide path to python executable when invoking fetch-content script. r=ahal
The shebang at the top of fetch-content doesn't work on macOS because
the path to python3 is not /usr/bin. Using /usr/bin/env doesn't work
properly on all platforms either so instead we invoke the script using
the currently running python executable.

Differential Revision: https://phabricator.services.mozilla.com/D19744

--HG--
extra : source : f6413e576a2169855f766085704570c9fc851ee2
2019-02-15 01:30:48 +00:00
Dorel Luca
b73b2c4f67 Backed out 7 changesets (bug 1516568) for Docker and Toolchain failures. CLOSED TREE
Backed out changeset 79120d13e713 (bug 1516568)
Backed out changeset 028c0ed368b8 (bug 1516568)
Backed out changeset f06721b552a8 (bug 1516568)
Backed out changeset ee403c79877e (bug 1516568)
Backed out changeset 8990eef6c31e (bug 1516568)
Backed out changeset f6413e576a21 (bug 1516568)
Backed out changeset e9f887f489e5 (bug 1516568)
2019-02-15 05:16:55 +02:00
Kartikaya Gupta
a03acb6831 Bug 1516568 - Provide path to python executable when invoking fetch-content script. r=ahal
The shebang at the top of fetch-content doesn't work on macOS because
the path to python3 is not /usr/bin. Using /usr/bin/env doesn't work
properly on all platforms either so instead we invoke the script using
the currently running python executable.

Differential Revision: https://phabricator.services.mozilla.com/D19744

--HG--
extra : moz-landing-system : lando
2019-02-15 01:30:48 +00:00
Gregory Szorc
7db2ec0def Bug 1512188 - Consolidate VCS checkout from args logic; r=tomprince,dustin
We create a minimal wrapper function to call collect_vcs_options()
and vcs_checkout().

We could consolidate this logic into vcs_checkout(). But I don't have
strong feelings about doing that.

Differential Revision: https://phabricator.services.mozilla.com/D13821

--HG--
extra : moz-landing-system : lando
2018-12-31 18:50:34 +00:00
Gregory Szorc
2bf175f722 Bug 1512188 - Collect hg store path in collect_vcs_options(); r=tomprince,dustin
One step closer to making all state gathering and normalization in one
place.

Differential Revision: https://phabricator.services.mozilla.com/D13819

--HG--
extra : moz-landing-system : lando
2018-12-31 18:54:14 +00:00
Gregory Szorc
952e5d5655 Bug 1512188 - Move base repo normalization into collect_vcs_options(); r=tomprince,dustin
This is a generic normalization and doesn't need to be Firefox
specific.

Differential Revision: https://phabricator.services.mozilla.com/D13817

--HG--
extra : moz-landing-system : lando
2018-12-31 18:54:31 +00:00
Gregory Szorc
426f2868cd Bug 1512188 - Collect environment variables into VCS options; r=tomprince,dustin
This makes behavior consistent across all VCS checkouts. I'm still not
a fan of using environment variables here. But at least this gets us
1 step closer to being able to plug alternate logic in without having
to update use of environment variables outside a single function.

Differential Revision: https://phabricator.services.mozilla.com/D13816

--HG--
extra : moz-landing-system : lando
2018-12-31 18:52:32 +00:00
Gregory Szorc
b809920807 Bug 1512188 - make VCS checkout options generic; r=tomprince,dustin
We currently manage VCS checkout arguments as one-offs for each
project. This isn't scalable and results in a bit of copy-pasta.

Let's make the VCS checkout arguments generic so we can have the
same control for all repositories.

This commit focuses on consolidating the existing argument parser
code. It stops short of further unification, which will be done in
subsequent commits.

Differential Revision: https://phabricator.services.mozilla.com/D13815

--HG--
extra : moz-landing-system : lando
2018-12-31 18:52:30 +00:00
Tom Prince
94212a8c9a Bug 1512285: Stop checking out tools; r=nthomas,gps
This code was used by mozharness jobs to check out the tools repo.
However, those jobs aren't actually using the repository.

Differential Revision: https://phabricator.services.mozilla.com/D13855

--HG--
extra : moz-landing-system : lando
2018-12-31 18:52:28 +00:00
Gregory Szorc
1693cc73d8 Bug 1512188 - Rename --sparse-profile to --gecko-sparse-profile; r=tomprince,dustin
We have multiple source checkouts. --sparse-profile is ambiguous
as to which one it could refer to. Let's rename the argument so it
is prefixed with the repo/project we are checking out.

Differential Revision: https://phabricator.services.mozilla.com/D13814

--HG--
extra : moz-landing-system : lando
2018-12-31 18:52:26 +00:00
Gregory Szorc
fe09099db1 Bug 1512188 - Rename --vcs-checkout to --gecko-checkout; r=tomprince,dustin
We now have multiple things we may check out. "vcs" meaning "gecko"
is not obvious. Let's change the terminology to be more specific.

Differential Revision: https://phabricator.services.mozilla.com/D13813

--HG--
extra : moz-landing-system : lando
2018-12-31 18:51:27 +00:00
Bogdan Tara
8fb34de423 Backed out 8 changesets (bug 1512285, bug 1512188) for fetch bustages CLOSED TREE
Backed out changeset 5e7aa7d98012 (bug 1512188)
Backed out changeset 55874a956ae1 (bug 1512188)
Backed out changeset ac6e2cd6eb32 (bug 1512188)
Backed out changeset f68df074eac1 (bug 1512188)
Backed out changeset f01d2662582f (bug 1512188)
Backed out changeset 35d74dd16706 (bug 1512285)
Backed out changeset 9e95b9bf1201 (bug 1512188)
Backed out changeset ac4a49eb95f5 (bug 1512188)
2018-12-29 07:56:56 +02:00
Gregory Szorc
555c86c76d Bug 1512188 - Consolidate VCS checkout from args logic; r=tomprince,dustin
We create a minimal wrapper function to call collect_vcs_options()
and vcs_checkout().

We could consolidate this logic into vcs_checkout(). But I don't have
strong feelings about doing that.

Differential Revision: https://phabricator.services.mozilla.com/D13821

--HG--
extra : moz-landing-system : lando
2018-12-29 05:13:45 +00:00
Gregory Szorc
d87b04a55a Bug 1512188 - Collect hg store path in collect_vcs_options(); r=tomprince,dustin
One step closer to making all state gathering and normalization in one
place.

Differential Revision: https://phabricator.services.mozilla.com/D13819

--HG--
extra : moz-landing-system : lando
2018-12-29 05:13:38 +00:00
Gregory Szorc
7d0932f16a Bug 1512188 - Move base repo normalization into collect_vcs_options(); r=tomprince,dustin
This is a generic normalization and doesn't need to be Firefox
specific.

Differential Revision: https://phabricator.services.mozilla.com/D13817

--HG--
extra : moz-landing-system : lando
2018-12-29 05:13:36 +00:00
Gregory Szorc
8fb6cd08a8 Bug 1512188 - Collect environment variables into VCS options; r=tomprince,dustin
This makes behavior consistent across all VCS checkouts. I'm still not
a fan of using environment variables here. But at least this gets us
1 step closer to being able to plug alternate logic in without having
to update use of environment variables outside a single function.

Differential Revision: https://phabricator.services.mozilla.com/D13816

--HG--
extra : moz-landing-system : lando
2018-12-29 05:13:28 +00:00
Gregory Szorc
17d3010722 Bug 1512188 - make VCS checkout options generic; r=tomprince,dustin
We currently manage VCS checkout arguments as one-offs for each
project. This isn't scalable and results in a bit of copy-pasta.

Let's make the VCS checkout arguments generic so we can have the
same control for all repositories.

This commit focuses on consolidating the existing argument parser
code. It stops short of further unification, which will be done in
subsequent commits.

Differential Revision: https://phabricator.services.mozilla.com/D13815

--HG--
extra : moz-landing-system : lando
2018-12-29 05:13:26 +00:00
Tom Prince
d5999f77d3 Bug 1512285: Stop checking out tools; r=nthomas,gps
This code was used by mozharness jobs to check out the tools repo.
However, those jobs aren't actually using the repository.

Differential Revision: https://phabricator.services.mozilla.com/D13855

--HG--
extra : moz-landing-system : lando
2018-12-29 05:22:38 +00:00
Gregory Szorc
8c1a7bccef Bug 1512188 - Rename --sparse-profile to --gecko-sparse-profile; r=tomprince,dustin
We have multiple source checkouts. --sparse-profile is ambiguous
as to which one it could refer to. Let's rename the argument so it
is prefixed with the repo/project we are checking out.

Differential Revision: https://phabricator.services.mozilla.com/D13814

--HG--
extra : moz-landing-system : lando
2018-12-29 05:13:17 +00:00
Gregory Szorc
8fc5669189 Bug 1512188 - Rename --vcs-checkout to --gecko-checkout; r=tomprince,dustin
We now have multiple things we may check out. "vcs" meaning "gecko"
is not obvious. Let's change the terminology to be more specific.

Differential Revision: https://phabricator.services.mozilla.com/D13813

--HG--
extra : moz-landing-system : lando
2018-12-29 05:13:09 +00:00
Andrew Halberstadt
828485d8db Bug 1436037 - [taskgraph] Support OSX generic-worker in run-task, r=Callek
This enables OSX generic-worker based tasks to use the run-task script.

Differential Revision: https://phabricator.services.mozilla.com/D14900

--HG--
extra : moz-landing-system : lando
2018-12-21 13:43:04 +00:00
Dorel Luca
aab1a051ae Backed out 12 changesets (bug 1512285, bug 1512188) for toolchain failure. CLOSED TREE
Backed out changeset 59813ae1b6ea (bug 1512188)
Backed out changeset 1f56f1e581e2 (bug 1512188)
Backed out changeset 0b3259dc10bd (bug 1512188)
Backed out changeset d0eb311b3c8f (bug 1512188)
Backed out changeset d9585e5d7a3a (bug 1512188)
Backed out changeset b4f3dc9b0956 (bug 1512188)
Backed out changeset 7d88308ca069 (bug 1512285)
Backed out changeset 838f49d718a7 (bug 1512188)
Backed out changeset 6bd036a5166d (bug 1512188)
Backed out changeset 3bcedff402fa (bug 1512188)
Backed out changeset 4f546b3e0b18 (bug 1512188)
Backed out changeset bc4232cfcfb8 (bug 1512188)
2018-12-11 23:08:27 +02:00