- created tertiary button option for tab rows, styled by a class prop
- added close button to open tabs rows
- removed close tab from open tab context menu
- updated tests to reflect removed panel item in open tab context menu
- added test for the new open tabs close button
- added telemetry for close open tab (requires data review)
- added test suite for keyboard navigation across tab row buttons
Depends on D201652
Differential Revision: https://phabricator.services.mozilla.com/D200689
- created tertiary button option for tab rows, styled by a class prop
- added close button to open tabs rows
- removed close tab from open tab context menu
- updated tests to reflect removed panel item in open tab context menu
- added test for the new open tabs close button
- added telemetry for close open tab (requires data review)
- added test suite for keyboard navigation across tab row buttons
Differential Revision: https://phabricator.services.mozilla.com/D200689
- created tertiary button option for tab rows, styled by a class prop
- added close button to open tabs rows
- removed close tab from open tab context menu
- updated tests to reflect removed panel item in open tab context menu
- added test for the new open tabs close button
- added telemetry for close open tab (requires data review)
- added test suite for keyboard navigation across tab row buttons
Differential Revision: https://phabricator.services.mozilla.com/D200689
* Carry over lastAccessed times from tabs that haven't been seen/active this session.
* Use the lastSeenActive rather than lastAccessed timestamp for labeling open tabs in firefox view.
Differential Revision: https://phabricator.services.mozilla.com/D198892
* Carry over lastAccessed times from tabs that haven't been seen/active this session.
* Use the lastSeenActive rather than lastAccessed timestamp for labeling open tabs in firefox view.
Differential Revision: https://phabricator.services.mozilla.com/D198892
* Add the shared module. It uses EveryWindow to listen for tab-related events and collapses them
into a single dispatched event.
* The class extends EventTarget, and only monitors window and tab events when a listener is added.
* Update the firefox-view consumers and their tests to use the module. Note that triggering a
tab-state change and seeing the tab change/recency events is async now.
* Add a new browser mochitest for the module and both TabChange and TabRecencyChange events.
* The module provides a potential home for optimizations like smarter caching and sorting of the tab
lists, but implementing these will belong to other bugs.
Differential Revision: https://phabricator.services.mozilla.com/D191502
* Add the shared module. It uses EveryWindow to listen for tab-related events and collapses them
into a single dispatched event.
* The class extends EventTarget, and only monitors window and tab events when a listener is added.
* Update the firefox-view consumers and their tests to use the module. Note that triggering a
tab-state change and seeing the tab change/recency events is async now.
* Add a new browser mochitest for the module and both TabChange and TabRecencyChange events.
* The module provides a potential home for optimizations like smarter caching and sorting of the tab
lists, but implementing these will belong to other bugs.
Differential Revision: https://phabricator.services.mozilla.com/D191502
- record frequency and page of search
- record how often show all search results is clicked on recent browsing and from which section
- record how often sort by date or site is clicked on history
- record how many searches are made before clicking on a search result
Differential Revision: https://phabricator.services.mozilla.com/D199285
- rename files to exclude "next" suffix
- move tests out of firefoxview-next folder into parent folder
- updat AboutRedirector to point at firefoxview.html
- this patch also resolves Bug 1872919 by adding a scroll into view during the `search_synced_tabs_recent_browsing` test
Differential Revision: https://phabricator.services.mozilla.com/D196347
- rename files to exclude "next" suffix
- move tests out of firefoxview-next folder into parent folder
- updat AboutRedirector to point at firefoxview.html
Differential Revision: https://phabricator.services.mozilla.com/D196347
- rename files to exclude "next" suffix
- move tests out of firefoxview-next folder into parent folder
- updat AboutRedirector to point at firefoxview.html
Differential Revision: https://phabricator.services.mozilla.com/D196347
Several `show-all-link` controls lack interactive role - this would prevent users of speech-to-text/Voice Control from being able to send a click to it by calling its label and screen reader users and users of other assistive technology would not be able to get to this control via shortcuts like a list of controls, etc. Being focusable with keyboard does not guarantee that assistive technology could guess that this programmatically static text is, in fact, interactive.
While providing an explicit ARIA `role` to the element is going [against the First Rule of ARIA](https://www.w3.org/TR/using-aria/#rule1) while semantically appropriate HTML elements exist - `<a>` anchor (for the visual appearance of this control) or `<button>` (for the actual functionality that this control performs) - this patch would at least remove the barrier for assistive technology to be able to set interactivity expectations to this control appropriately.
No test manifests are being updated, because there are other elements in the updated test files that are failing a11y-checks, besides these `show-all-link` controls.
Differential Revision: https://phabricator.services.mozilla.com/D197349
Slightly different from the previous search revisions. In this case, rather than having their own search boxes, the recent browsing components share a single search box located within the parent element. Thus, `fxview-search-textbox-query` event listeners are added/removed from the //parent// component rather than the components themselves.
Differential Revision: https://phabricator.services.mozilla.com/D195596
* Create a new OpenTabsContextMenu to replace the inlined menu content in the open tabs template
* Fetch the devices list when the menu opens, rather than updating it in the background
* Add a getLogger to the helpers module to easily create named loggers
Differential Revision: https://phabricator.services.mozilla.com/D193138
- Moved "footer" to within sticky container above cards and renamed to "header".
- Update "Connect another device" button to use the `.small-button` styling
- Conditionally display `Recently closed tabs` `h2` on the corresponding view only (an existing bug revealed in this patch)
- Update `.sticky-container` to reflect upcoming styling with the inclusion of search and other secondary headers.
Please see link to bug for screenshot of intended appearance.
Differential Revision: https://phabricator.services.mozilla.com/D193930
* Add a type=page to the top-level ViewPage instances
* Rename viewTabVisibleCallback and viewTabHiddenCallback to view*Callback and call each when selectedness or visiblity changes
* Ensure active view/pages are always properly initialized during page load and category switching
* Add a test to verify no mutations happen when tabs change while firefox view is inactive
* Fix tests to better account for loading and readiness sequence when activating firefox view
Differential Revision: https://phabricator.services.mozilla.com/D193744
