nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity
987078 commits 1 branch 98 tags 6.4 GiB
Commit graph

40024 commits

Author SHA1 Message Date
Harshit Sohaney
637ec70396 Bug 1907783 - Use the new clear on shutdown branch to prevent losing pending shutdown items on unexpected shutdown. r=pbz,places-reviewers,Standard8, a=dmeehan 
Differential Revision: https://phabricator.services.mozilla.com/D216616
 2024-07-19 18:24:04 +00:00
Nika Layzell
07eb80a505 Bug 1834864 - Select BCG more consistently during COOP+COEP process switches, r=smaug,tabbrowser-reviewers,mak, a=dmeehan 
Previously it was possible to bypass specific BCG selection based on
cross-origin isolated status if the site was allowed to load file URIs
using enterprise policies, which could lead to a crash.

This patch changes the behaviour such that BCG selection now happens
correctly. The site will still not be cross-origin isolated due to being
loaded into a file content process.

Differential Revision: https://phabricator.services.mozilla.com/D217007
 2024-07-19 14:38:20 +00:00
Alexandre Lissy
7119cc28b9 Bug 1899516 - Warn user when missing unprivileged user namespace r=firefox-desktop-core-reviewers ,fluent-reviewers,Gijs,flod, a=dmeehan, l10n=bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D212024
 2024-07-15 12:11:54 +00:00
Rob Wu
029d6f68c3 Bug 1905505 - Remove unnecessary resetIdleOnEvent from child modules a=dmeehan 
This patch updates every use of EventManager in child/ext-*.js files
that can referenced from extension contexts of envType "addon_child".

Pre patch, these could trigger "background-script-reset-idle" and
result in triggering "background-script-reset-idle" in the parent
despite the background being stopped, and consequently trigger the
reported bug. The previous patch fixes the negative consequence of this
unexpected event, this patch fixes an underlying cause by removing the
triggers.

Forcing resetIdleOnEvent to false does not have any negative impact on
these modules, because all of these events are dependencies of an
EventManager in the parent, which already activates the functionality
associated with resetIdleOnEvent=true.

To minimize the likelihood of affecting unit tests, this patch keeps the
EventManager of test.onMessage at resetIdleOnEvent=true as before, and
defers to bug 1901294 for changing it to false.

Original Revision: https://phabricator.services.mozilla.com/D215298

Differential Revision: https://phabricator.services.mozilla.com/D216987
 2024-07-20 12:21:06 +00:00
Emilio Cobos Álvarez
ff5baf3e9e Bug 1906132 - Propagate BResize flag from viewport frame to root scroll frame. r=dholbert a=RyanVM 
The regression range is baffling, but it just shows a missing
invalidation.

The extension has worked around this upstream:

  a48ff54cf6

But the root cause is a bug in Firefox. The popup here had styles much
like:

```
html, body, #root {
  height: 100%;
  min-height: 100%;
  width: auto;
  min-width: 320px;
}
```

The popup starts off zero-sized, but then gets re-measured async at some
point by the extension code.

Main issue here is that, due to the bresize, we reflow the viewport,
then the html, but the html loses the bresize flag. So we don't reflow
the body element to give it the right height.

Before my patch, the body was reflowed because there was a BFC under it,
so it had the NS_BLOCK_HAS_CLEAR_CHILDREN flag, which ended up papering
over this bug.

I think this can only happen with the special shrink-wrap resize mode,
because it's the only thing that can turn a percentage bsize like 100%
from behaving like a percentage to behave like auto... So I haven't been
able to reproduce outside of our extension popup usage. Otherwise the
percentages resolving to different things would set the bresize flag
appropriately.

Differential Revision: https://phabricator.services.mozilla.com/D215842
 2024-07-05 17:50:41 +00:00
Gijs Kruitbosch
92d1876d53 Bug 1908312 - Make it clear in about:preferences that PPA is disabled when telemetry is disabled, a=RyanVM 
Right now the UI state for PPA remains checked and active even when the main telemetry
setting is disabled. This is confusing UX, since DAP submission is disabled when
telemetry is disabled.

Also migrate off the deprecated toolkit-private isTelemetryEnabled() accessor to the normal pref check.

Original Revision: https://phabricator.services.mozilla.com/D216801

Differential Revision: https://phabricator.services.mozilla.com/D216970
 2024-07-19 13:18:16 +00:00
Emilio Cobos Álvarez
0bebd295e2 Bug 1907709 - Add a search header for website advertising section. r=settings-reviewers,Gijs, a=dmeehan 
A bit weird that this doesn't work more automatically but...

Differential Revision: https://phabricator.services.mozilla.com/D216680
 2024-07-17 18:21:44 +00:00
Mark Banner
e619778a6b Bug 1822297 - Implement a SearchHistoryResult to remove dependency on satchel and fix deleting items from the search bar history. a=dmeehan 
Original Revision: https://phabricator.services.mozilla.com/D214956

Differential Revision: https://phabricator.services.mozilla.com/D216692
 2024-07-16 19:22:59 +00:00
Luca Greco
fa75917866 Bug 1905771 - switcherTarget element label set by SidebarController.registerExtension is still set when switching to a non extension sidebar. r=willdurand,sidebar-reviewers,Gijs, a=dmeehan 
Differential Revision: https://phabricator.services.mozilla.com/D215945
 2024-07-10 17:52:30 +00:00
Niklas Baumgardner
e2f7fdc56e Bug 1905468 - Prevent some more mouse events from reaching the content page. r=sfoster, a=dmeehan 
Differential Revision: https://phabricator.services.mozilla.com/D215515
 2024-07-08 14:41:02 +00:00
Luca Greco
82f5bf893a Bug 1851083 - Do not show the attention badge for mv3 extensions requiring the activeTab permission. r=robwu, a=dmeehan 
Differential Revision: https://phabricator.services.mozilla.com/D215038
 2024-07-01 11:40:34 +00:00
Dale Harvey
139c6f03ab Bug 1906192 - Only enable trending suggestions on 128 for en-US / en-CA users. r=adw a=RyanVM 
Differential Revision: https://phabricator.services.mozilla.com/D215699
 2024-07-03 22:19:54 +00:00
Shane Hughes
7a4cae215f Bug 1900486 - Re-render Review Checker messaging content when opt-in state changes. a=RyanVM 
Original Revision: https://phabricator.services.mozilla.com/D212498

Differential Revision: https://phabricator.services.mozilla.com/D215150
 2024-06-30 17:20:25 +00:00
Marco Bonardo
2e0b8c2bd2 Bug 1893568 - Tab open animation is skipped with preloaded content. a=dmeehan 
Original Revision: https://phabricator.services.mozilla.com/D212679

Differential Revision: https://phabricator.services.mozilla.com/D215055
 2024-06-27 19:06:35 +00:00
Nathan Barrett
aad7f1bca5 Bug 1904910 - fix typo for abstract label in wallpapers a=dmeehan 
Original Revision: https://phabricator.services.mozilla.com/D214998

Differential Revision: https://phabricator.services.mozilla.com/D215040
 2024-06-27 12:22:34 +00:00
Meg Viar
4b1e713247 Bug 1903416 - Add a pref to control the display of set default guidance notification a=dmeehan 
Add a pref and nimbus variable to control whether users see set to default guidance notifications when one-click set to default is disabled. Windows only.

This patch supports the [[ https://experimenter.services.mozilla.com/nimbus/one-click-set-to-default-new-users/summary | one-click set to default guidance experiment ]].

Original Revision: https://phabricator.services.mozilla.com/D214700

Differential Revision: https://phabricator.services.mozilla.com/D214758
 2024-06-25 17:20:07 +00:00
Nathan Barrett
ac2a0c2da8 Bug 1900418 - update thumbnails for wallpapers, use selectedWallpaper if availible a=RyanVM 
Original Revision: https://phabricator.services.mozilla.com/D214435

Differential Revision: https://phabricator.services.mozilla.com/D214672
 2024-06-22 20:55:25 +00:00
scottdowne
d26cf26a79 Bug 1896677 - Home and newtab weather widget fetch retry a=RyanVM 
Original Revision: https://phabricator.services.mozilla.com/D214314

Differential Revision: https://phabricator.services.mozilla.com/D214484
 2024-06-22 00:13:59 +00:00
scottdowne
852fdd765a Bug 1902109 - Home and newtab wallpapers v2 fixing lint rule for fluent dom a=RyanVM 
Original Revision: https://phabricator.services.mozilla.com/D214290

Differential Revision: https://phabricator.services.mozilla.com/D214485
 2024-06-22 00:13:15 +00:00
Nathan Barrett
d8c70fce78 Bug 1903123 - Update default temp unit based on locale a=RyanVM 
Original Revision: https://phabricator.services.mozilla.com/D214109

Differential Revision: https://phabricator.services.mozilla.com/D214486
 2024-06-22 00:12:41 +00:00
Moritz Beier
82dee7b55e Bug 1903608 - Pressing enter on search bar settings icon does not open settings. a=RyanVM 
Original Revision: https://phabricator.services.mozilla.com/D214287

Differential Revision: https://phabricator.services.mozilla.com/D214515
 2024-06-21 23:56:10 +00:00
DJ
2361bd68c9 Bug 1878038 - show entire viewport in tab preview. a=RyanVM 
Original Revision: https://phabricator.services.mozilla.com/D212709

Differential Revision: https://phabricator.services.mozilla.com/D214432
 2024-06-21 23:17:25 +00:00
Erik Nordin
64ea984262 Bug 1903838 - Fix change-to-language telemetry edge case a=RyanVM 
Fixes an edge case in the SelectTranslationsPanel where,
on Windows and Linux, if both the from-language and to-language
are changed via keyboard before triggering re-translation, then
only the change-from-language event is logged to telemetry.

Original Revision: https://phabricator.services.mozilla.com/D214419

Differential Revision: https://phabricator.services.mozilla.com/D214429
 2024-06-21 00:57:08 +00:00
Yazan Al Macki
8043a755f3 Bug 1902323 - Ensure mimetype info is passed when creating new blobs in order to correctly render application provided search engine icons if they are svg based. a=RyanVM 
Original Revision: https://phabricator.services.mozilla.com/D213671

Differential Revision: https://phabricator.services.mozilla.com/D214414
 2024-06-21 00:54:18 +00:00
Gijs Kruitbosch
aa15db38ef Bug 1054947 - Also check prefs.js last modified time before showing profile reset notification after a long absence, a=RyanVM 
Original Revision: https://phabricator.services.mozilla.com/D212960

Differential Revision: https://phabricator.services.mozilla.com/D214078
 2024-06-20 18:26:52 +00:00
Mark Banner
6ee0795092 Bug 1897142 - Fix test_UrlbarSearchUtils.js on Beta. a=RyanVM 
Differential Revision: https://phabricator.services.mozilla.com/D214410
 2024-06-20 15:46:14 +00:00
Mark Banner
76c337cc6f Bug 1897142 - Update Search Config tests. a=RyanVM 
Original Revision: https://phabricator.services.mozilla.com/D211926

Differential Revision: https://phabricator.services.mozilla.com/D214125
 2024-06-20 13:36:18 +00:00
Kelly Cochrane
19618faf81 Bug 1896988 - Fix for intermittent failure in browser_customize_sidebar.js r=sidebar-reviewers,nsharpley a=test-only 2024-06-19 00:10:52 -04:00
Jason Prickett
4f716e0a16 Bug 1901499 - Allow extensions success link to open in spotlight a=RyanVM 
This patch allows the extensions success link to also be opened when the migration wizard is running in the spotlight. The issue seems to be that the browser element used in `OpenAboutAddons` doesn't exist when running in spotlight, so I've opted to instead allow the event to be handled with `OpenURL` when running in the aboutwelcome bundle, and also adding a parameter to handle trusted links with OpenURL.

Original Revision: https://phabricator.services.mozilla.com/D213666

Differential Revision: https://phabricator.services.mozilla.com/D214182
 2024-06-19 03:45:12 +00:00
Erik Nordin
3a831aa110 Bug 1903393 - Send the text source to telemetry a=RyanVM 
Adds the ability for the SelectTranslationsPanel to send
to telemetry whether the source text came from an active
selection or from a right-clicked hyperlink's text.

Original Revision: https://phabricator.services.mozilla.com/D214161

Differential Revision: https://phabricator.services.mozilla.com/D214197
 2024-06-19 03:20:25 +00:00
Erik Nordin
dfa01e7bd5 Bug 1903392 - Send source-language changes to telemetry a=RyanVM 
Adds the ability for the SelectTranslationsPanel to send
telemetry events when the source language is changed and a
translation is requested from the unsupported-language view.

Original Revision: https://phabricator.services.mozilla.com/D214160

Differential Revision: https://phabricator.services.mozilla.com/D214196
 2024-06-19 03:20:25 +00:00
Erik Nordin
8d13b36dbc Bug 1903391 - Send from- and to-language changes to telemetry a=RyanVM 
Adds the ability for the SelectTranslationsPanel to send
telemetry events when the from-language or the to-language
is changed in the panel such that a new translation is triggered.

Original Revision: https://phabricator.services.mozilla.com/D214159

Differential Revision: https://phabricator.services.mozilla.com/D214194
 2024-06-19 03:20:24 +00:00
Erik Nordin
8c5b4dc839 Bug 1903151 - Await panel open in init-failure tests a=RyanVM 
This patch ensures that the init-failure telemetry
tests for the SelectTranslationsPanel properly await
the "popupshown" event when the try-again button is
pressed, since that re-opens the panel.

Original Revision: https://phabricator.services.mozilla.com/D214056

Depends on D213890

Differential Revision: https://phabricator.services.mozilla.com/D214148
 2024-06-19 01:42:51 +00:00
Erik Nordin
008d8a64cd Bug 1902717 - Attempt to fix Translations high-freq test failures a=RyanVM 
Attempts to fix some of the Translations high-freq test
failures that were introduced by Bug 1900023.

Original Revision: https://phabricator.services.mozilla.com/D213849

Depends on D213889

Differential Revision: https://phabricator.services.mozilla.com/D213890
 2024-06-19 01:42:50 +00:00
Erik Nordin
ad63f69e97 Bug 1902583 - Split up try-again-button keypress test a=RyanVM 
Splits up the tests for try-again-button keypresses
in the SelectTranslationsPanel to avoid an intermittent
test timeout failure in CI.

Original Revision: https://phabricator.services.mozilla.com/D213765

Depends on D213893

Differential Revision: https://phabricator.services.mozilla.com/D213889
 2024-06-19 01:42:50 +00:00
Erik Nordin
84bb27b512 Bug 1900023 - Fix SelectTranslationsPanel keyboard navigation on macOS a=RyanVM 
This patch ensures that every button in the SelectTranslationsPanel
can be invoked both with the Enter key or the space bar on all
operating systems.

Original Revision: https://phabricator.services.mozilla.com/D213635

Differential Revision: https://phabricator.services.mozilla.com/D213893
 2024-06-19 01:42:49 +00:00
Jason Prickett
0ef97dd55d Bug 1896090 - Fix about:welcome dismiss button position when in reverse-split mode a=RyanVM 
Original Revision: https://phabricator.services.mozilla.com/D213728

Differential Revision: https://phabricator.services.mozilla.com/D214169
 2024-06-18 21:12:49 +00:00
Erik Nordin
2892d24942 Bug 1903087 - Refresh languageInfo cache on every panel open a=RyanVM 
Ensures that the SelectTranslationsPanel languageInfo cache
is refreshed every time the panel would be opened. This prevents
a case where the incorrect (previous) document language tag
is reported to telemetry in some cases.

Original Revision: https://phabricator.services.mozilla.com/D214011

Differential Revision: https://phabricator.services.mozilla.com/D214139
 2024-06-18 17:38:12 +00:00
Niklas Baumgardner
6b44186ea0 Bug 1902683 - Early return on keydown when screenshots button is focused. r=sfoster a=RyanVM 
Differential Revision: https://phabricator.services.mozilla.com/D213811
 2024-06-15 13:40:07 +00:00
Eric Chen
b8288a50a7 Bug 1901840 - restore browser.privateWindowSeparation.enabled pref a=RyanVM 
Original Revision: https://phabricator.services.mozilla.com/D213651

Differential Revision: https://phabricator.services.mozilla.com/D214120
 2024-06-18 14:41:53 +00:00
scottdowne
182408d33f Bug 1902948 - Home and newtab fixing RTL issues in weather and wallpapers a=RyanVM 
Original Revision: https://phabricator.services.mozilla.com/D213907

Differential Revision: https://phabricator.services.mozilla.com/D214064
 2024-06-18 14:34:11 +00:00
scottdowne
4fdfcf7226 Bug 1901134 - Home and newtab wallpaper solid color selector a=RyanVM 
Original Revision: https://phabricator.services.mozilla.com/D212890

Differential Revision: https://phabricator.services.mozilla.com/D214063
 2024-06-18 14:33:13 +00:00
Dale Harvey
6ca49729fa Bug 1871054 - Dont show suggestions for single character query. a=RyanVM 
Original Revision: https://phabricator.services.mozilla.com/D213774

Differential Revision: https://phabricator.services.mozilla.com/D214093
 2024-06-18 14:27:48 +00:00
Nathan Barrett
50ae660151 Bug 1900103 - Add Weather telemetry event for location search a=RyanVM 
Original Revision: https://phabricator.services.mozilla.com/D213654

Differential Revision: https://phabricator.services.mozilla.com/D213905
 2024-06-18 03:00:25 +00:00
Amy Churchwell
4f2ddd1826 Bug 1900423 - Refine nested wallpapers styles. a=RyanVM 
Original Revision: https://phabricator.services.mozilla.com/D212611

Differential Revision: https://phabricator.services.mozilla.com/D213895
 2024-06-18 02:38:44 +00:00
Erik Nordin
0977764ccc Bug 1902254 - Increase SelectTranslationsPanel resize buffer a=RyanVM 
Increases the buffer kept between the bottom edge of the
panel and the bottom of the screen or window to be relative
to 1/5 of the panel's starting height upon open, rather than
an arbitrarily set 20 pixels.

Original Revision: https://phabricator.services.mozilla.com/D213589

Differential Revision: https://phabricator.services.mozilla.com/D213887
 2024-06-18 01:05:55 +00:00
Erik Nordin
3c51004d26 Bug 1901351 - Do not offer Translate Link Text for URLs a=RyanVM 
This patch ensures that the Translate Link Text
option is not offered in the context menu when
right clicking hyperlinked text that would result
in only a URL being translated.

Original Revision: https://phabricator.services.mozilla.com/D212980

Differential Revision: https://phabricator.services.mozilla.com/D213885
 2024-06-18 01:05:54 +00:00
Anna Yeddi
07eae88758 Bug 1901314 - Improve Select Translations panel labelling. a=RyanVM 
Ensure the Select Translations panel's label is including "Beta" marker (while it is present), that the description includes the Manage Settings button, and that the `<textarea>` is labeled.

Original Revision: https://phabricator.services.mozilla.com/D212966

Differential Revision: https://phabricator.services.mozilla.com/D213892
 2024-06-18 01:05:53 +00:00
Michael Kaply
4e591050fa Bug 1892961 - Add support for addons that can only be installed via policy. a=RyanVM 
Original Revision: https://phabricator.services.mozilla.com/D211987

Differential Revision: https://phabricator.services.mozilla.com/D213933
 2024-06-18 00:19:22 +00:00
Shane Hughes
003bd7527b Bug 1899757 - Allow targeting the trigger tab for feature callouts. a=RyanVM 
Also add a global `browserIsSelected` context property for all triggers,
so you can entirely avoid showing a message if the triggering browser
was in the background. You can use the selector and the context property
together or separately.

Context targeting:
`browserIsSelected`

Background tab selector:
`#tabbrowser-tabs:not([overflow]):not([haspinnedtabs]) %triggerTab%`

Current tab selector:
`#tabbrowser-tabs:not([overflow]):not([haspinnedtabs]) %triggerTab%[visuallyselected]`

Child of tab selector:
`#tabbrowser-tabs:not([overflow]):not([haspinnedtabs]) %triggerTab% .tab-icon-image`

Original Revision: https://phabricator.services.mozilla.com/D212494

Differential Revision: https://phabricator.services.mozilla.com/D213921
 2024-06-17 21:10:29 +00:00