Miko Mynttinen
aafa85ee9d
Bug 1512251 - Remove unused render only selection code r=mattwoodrow
...
Differential Revision: https://phabricator.services.mozilla.com/D13829
--HG--
extra : moz-landing-system : lando
2018-12-06 19:40:50 +00:00
Cameron McCormack
1ea7c3efc9
Bug 1511854 - Part 2: Fix some more formatting oddities in layout/ after the clang-format. r=TYLin
...
Depends on D13686
Differential Revision: https://phabricator.services.mozilla.com/D13775
--HG--
extra : moz-landing-system : lando
2018-12-05 18:44:05 +00:00
Sylvestre Ledru
265e672179
Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
...
# ignore-this-changeset
--HG--
extra : amend_source : 4d301d3b0b8711c4692392aa76088ba7fd7d1022
2018-11-30 11:46:48 +01:00
Shubham Kumaram
b87c4f4c0c
Bug 1509664 - Change Text Rendering constants to enum classes in nsStyleConsts.h. r=heycam
...
Differential Revision: https://phabricator.services.mozilla.com/D12839
--HG--
extra : moz-landing-system : lando
2018-11-30 05:08:46 +00:00
Jonathan Watt
e1daf3de62
Bug 1504918. Prevent TextNodeCorrespondenceRecorder::TraverseAndRecord crash. r=heycam
...
Differential Revision: https://phabricator.services.mozilla.com/D11107
--HG--
extra : rebase_source : 37402fd613be1ae8916434c7600252b391a45fbf
2018-11-13 16:49:21 +00:00
Jonathan Watt
469a9f409b
Bug 1508358. Avoid clang-format messing up Doxygen comments in SVG code. r=longsonr
...
Differential Revision: https://phabricator.services.mozilla.com/D12336
--HG--
extra : rebase_source : fcda515ec3fe76f38aa9b18d618f02b877aeabef
2018-11-05 07:03:55 +00:00
Jonathan Watt
5933668f75
Bug 1495877. Standardize the GetAndObserve* naming for SVGObserverUtils methods. r=longsonr
...
Differential Revision: https://phabricator.services.mozilla.com/D7538
--HG--
extra : rebase_source : c042fc33cc12ca59b55cdaaf59914ab91baa8b05
2018-09-25 21:16:49 +01:00
Robert Longson
1b9177a3e6
Bug 1474982 - Fix asertion failure when lengthAdjust value is empty r=heycam
2018-09-23 15:53:03 +01:00
Jonathan Watt
90314b1dd6
Bug 1492573. Make SVGTextFrame ignorant of the implementation details of SVG rendering observers. r=longsonr
...
Differential Revision: https://phabricator.services.mozilla.com/D6320
--HG--
extra : rebase_source : fb88b6e2a87dc2e766974cff1ffed1f11a86f5e5
2018-08-15 21:32:04 +01:00
Thomas Nguyen
fca5bf4852
Bug 1330487 - Part 6: Passing referrer information to svg style system r=heycam
...
We create new object URLExtraRefferINfo and pass it to svg system instead of
nsIURI. The object brings referrer and referrer policy so we can send correct
Referer headers.
MozReview-Commit-ID: 2gLnQPEE9t5
Differential Revision: https://phabricator.services.mozilla.com/D1925
--HG--
extra : moz-landing-system : lando
2018-09-17 05:37:01 +00:00
Jonathan Watt
d580509f71
Bug 1488700 p11. Rename nsSVGTextPathProperty to SVGTextPathObserver. r=longsonr
...
Differential Revision: https://phabricator.services.mozilla.com/D5624
--HG--
extra : rebase_source : c991e7eb377f97e994ad990b1e8cdfb1300bc9f6
2018-08-13 14:47:19 +02:00
Gerald Squelart
b099eab802
Bug 1488684 - Made nsIFrame-derived classes and some others 'final' where possible - r=dbaron
...
All classes deriving from nsIFrame that did not have any subclasses themselves
(at the time of writing this patch) have been marked with `final`.
Some other Layout classes have also been made final, but this was opportunistic
while working on nsIFrame subclasses, and is definitely not exhaustive, further
patches welcome; refer to bug 1332680.
Advantages of marking a class final include:
- Allowing the compiler to devirtualize some method calls (i.e., calling
virtual functions directly instead of going through the vtable),
- Indicating that the class is not currently subclassed,
- Preventing subclassing without being aware that this would remove the
finalization benefits of the parent class.
`final` does not signify that these classes should *never* be subclassed, this
is left for developers to decide.
Differential Revision: https://phabricator.services.mozilla.com/D5020
--HG--
extra : moz-landing-system : lando
2018-09-06 01:23:14 +00:00
Ting-Yu Lin
48d02834a5
Bug 1482665 Part 2 - Remove nsPresContext::AppUnitsPerCSSPixel() and replace it with mozilla::AppUnitsPerCSSPixel(). r=dholbert
...
Differential Revision: https://phabricator.services.mozilla.com/D3155
2018-08-13 14:29:28 -07:00
Jeff Gilbert
5b753da289
Bug 1470325 - s/FooBinding/Foo_Binding/g - r=qdot
...
MozReview-Commit-ID: JtTcLL5OPF0
2018-06-26 17:05:01 -07:00
Chris Peterson
2afd829d0f
Bug 1469769 - Part 6: Replace non-failing NS_NOTREACHED with MOZ_ASSERT_UNREACHABLE. r=froydnj
...
This patch is an automatic replacement of s/NS_NOTREACHED/MOZ_ASSERT_UNREACHABLE/. Reindenting long lines and whitespace fixups follow in patch 6b.
MozReview-Commit-ID: 5UQVHElSpCr
--HG--
extra : rebase_source : 4c1b2fc32b269342f07639266b64941e2270e9c4
extra : source : 907543f6eae716f23a6de52b1ffb1c82908d158a
2018-06-17 22:43:11 -07:00
Chris Peterson
f743d8e9dd
Bug 1469769 - Part 4: svg: Replace failing NS_NOTREACHED with NS_ERROR. r=heycam
...
I'm replacing non-failing calls to NS_NOTREACHED with MOZ_ASSERT_UNREACHABLE, but this NS_NOTREACHED fails when running the dom/svg/crashtests/412104-1.svg test. This assertion failure is bug 903785.
This patch DOES NOT fix the cause of the assertion failure (a missing TextNodeCorrespondenceProperty). It just replaces this failing NS_NOTREACHED with NS_ERROR because I can't replace with a fatal MOZ_ASSERT_UNREACHABLE.
MozReview-Commit-ID: 8ffEdO5W1zU
--HG--
extra : rebase_source : 618008591b516e3b4b51871debcd0cf177a3f5b1
extra : intermediate-source : 099e1bbbc5b43b67ad9324464e4eec2e33d7eaa3
extra : source : f95d808c6f81b656c680d1dd005236571dedee20
2018-05-26 17:11:02 -07:00
Botond Ballo
f5745eb2a5
Bug 1459696 - Improve const-correctness of nsIFrame methods and functions that accept an nsIFrame* argument. r=mstange
...
MozReview-Commit-ID: 9IcL8kfMdIH
--HG--
extra : rebase_source : f8f19f528fe42aa119659ed9cb3340a257bb3716
2018-05-28 19:58:25 -04:00
Andi-Bogdan Postelnicu
09ec36a025
Bug 1453795 - SVG - Initialize member fields in classes/ structures. r=jwatt
...
--HG--
extra : rebase_source : 244f0513af145c53fbc0177d2652cf68e20b64af
2018-06-16 13:54:44 +03:00
Boris Zbarsky
f7d68d6078
Bug 1387143 part 21. Remove nsISelection getters for anchor and focus points. r=mats
...
Instead of copying spec-duplicating comments from nsISelection.idl to
Selection.webidl, this just points the latter to the right spec.
2018-05-08 13:52:38 -04:00
Chris Peterson
71422dcaa9
Bug 1457813 - Part 2: Replace non-asserting NS_PRECONDITIONs with MOZ_ASSERTs. r=froydnj
...
s/NS_PRECONDITION/MOZ_ASSERT/ and reindent
MozReview-Commit-ID: KuUsnVe2h8L
--HG--
extra : source : c14655ab3df2c9b1465dd8102b9d25683359a37b
2018-04-28 12:50:58 -07:00
Emilio Cobos Álvarez
543a797d15
Bug 1421807: Wallpaper SVG text code which makes too many assumptions about the DOM. r=heycam
...
Second test-case is because I initially made this code work with
display: contents. But then realised that display: contents meant allowing
Shadow DOM in there, which I don't really want to deal with right now.
MozReview-Commit-ID: HSjFbWEbPAb
--HG--
extra : rebase_source : 51b950d5e74e17b0200112a7d447b3e3b9414602
2018-04-23 21:23:50 +02:00
Andrew McCreight
3f7472aec1
Bug 1449670, part 1 - Convert IsNodeOfType(nsINode::eTEXT) to IsText(). r=bz
...
This method is not a virtual call, and also looks nicer.
This patch was mostly generated by a Python script, but I manually
cleaned up the code in a few places where statements didn't need to be
split across multiple lines any more.
MozReview-Commit-ID: 8JExxqSRc59
--HG--
extra : rebase_source : df6330a89e8d65dfe7a6fda0c8cb9f9732302efc
2018-04-12 15:41:00 -07:00
Sebastian Hengst
0819f35e51
Backed out 4 changesets (bug 525063) on request from Andi. a=backout
...
Backed out changeset 516c4fb1e4b8 (bug 525063)
Backed out changeset 6ff8aaef2866 (bug 525063)
Backed out changeset bf13e4103150 (bug 525063)
Backed out changeset d7d2f08e051c (bug 525063)
2018-04-13 16:01:28 +03:00
Tristan Bourvon
a3a77c0312
Bug 525063 - Initialize uninitialized class attributes in m-c. r=ehsan
2018-04-10 21:11:02 +02:00
Robert Longson
f725679a94
Bug 1446617 - support the SVG 2 path attribute for textPath elements r=dholbert
2018-03-31 18:50:10 +01:00
Dorel Luca
4e6205407f
Backed out changeset cd40ea4d0a95 (bug 1446617) for Reftest failure on build/tests/reftest/tests/layout/reftests/svg/textPath-path-attribute-01.svg
2018-03-31 16:02:10 +03:00
Robert Longson
76c8556c39
Bug 1446617 - support the SVG 2 path attribute for textPath elements r=dholbert
2018-03-31 11:55:18 +01:00
Robert Longson
432b48c35a
Bug 1448774 - part 2 r=dholbert
2018-03-29 04:09:34 +01:00
Robert Longson
f627214d56
Bug 1448774 - part 1 r=dholbert
2018-03-29 03:12:05 +01:00
Robert Longson
8873201d39
Bug 1446617 - part 1 - remove unnecessary namespace usage r=dholbert
2018-03-23 18:17:09 +00:00
Noemi Erli
1270a21724
Merge mozilla-central to inbound. a=merge CLOSED TREE
2018-03-23 01:00:18 +02:00
Emilio Cobos Álvarez
e341b20ec4
Bug 1447483: Merge nsStyleContext and ServoStyleContext, rename to ComputedStyle. r=jwatt on a CLOSED TREE
...
MozReview-Commit-ID: JPopq0LudD
2018-03-22 20:06:24 +01:00
Emilio Cobos Álvarez
5dd797f154
Back out changeset b683bb3f22a1 (Bug 1447483) for not landing with all the files. r=me on a CLOSED TREE
...
This reverts commit 1808914126bb9f9e4a82d2c3d7ac961885fe7d62.
MozReview-Commit-ID: 5skESBseEvo
2018-03-22 20:05:22 +01:00
Emilio Cobos Álvarez
ca5ac79cca
Bug 1447483: Merge nsStyleContext and ServoStyleContext, rename to ComputedStyle. r=jwatt
...
MozReview-Commit-ID: JPopq0LudD
2018-03-22 19:48:42 +01:00
Robert Longson
fd2cceeb03
Bug 1446614 - textPath should not render if the path it uses is invalid r=dholbert
2018-03-19 23:34:50 +00:00
Robert Longson
c0bb15d317
Bug 1362417 - Pass imgDrawingParams into SVGTextDrawPathCallbacks r=jwatt
2018-03-18 20:35:13 +00:00
Sylvestre Ledru
fa45a3c670
Bug 1443080 - Use the static call for static methods (not instance) r=Ehsan
...
MozReview-Commit-ID: JwHh4bzxuTR
--HG--
extra : rebase_source : 5f5e37517aa80c2e7b5933962178d761074886e7
2018-03-16 14:29:15 +01:00
Robert Longson
898ce47974
Bug 1446650 - support the SVG 2 side attribute for textPaths r=dholbert
2018-03-22 18:43:50 +00:00
Robert Longson
797f6cb1a6
Bug 1325320 part 3 - move GetPathLengthScale to SVGGeometryElement and convert callers of SVGPathElement methods to work on the base SVGGeometryElement class and work for all shapes, not just paths r=dholbert
2018-03-13 19:52:03 +00:00
Emilio Cobos Álvarez
2988d4e66d
Bug 1442207: Remove unneeded arguments to nsIMutationObserver. r=smaug
...
aDocument is always content->OwnerDoc().
aContainer is always content->GetParent().
Differential Revision: https://phabricator.services.mozilla.com/D664
MozReview-Commit-ID: 4xwPCOnhyIL
2018-03-01 22:45:17 +01:00
Emilio Cobos Álvarez
9f26540cc4
Bug 1441547: Make character data change notifications use a const reference for the info parameter. r=smaug
...
It's not intended to be mutated.
MozReview-Commit-ID: 5nkD1YkidlV
--HG--
extra : rebase_source : 810d429208fa3eaf30e220e77a7d27107cb77346
2018-02-27 15:30:27 +01:00
Matt Woodrow
4183152e2d
Bug 1436904 - Part 1: Add a static constructor function for display items. r=Bas
2018-02-13 13:43:28 +13:00
Dorel Luca
bd05e3853c
Backed out 3 changesets (bug 1436904) for many crashes see bugs: 1440281, 1440302, 1440303, 1440313. a=backout
...
Backed out changeset 27f0762d4472 (bug 1436904)
Backed out changeset 27640f52e188 (bug 1436904)
Backed out changeset 2b4d117c27dc (bug 1436904)
2018-02-22 17:28:59 +02:00
Matt Woodrow
e485bba27f
Bug 1436904 - Part 1: Add a static constructor function for display items. r=Bas
2018-02-13 13:43:28 +13:00
Robert Longson
728a3f36fc
Bug 1435477 - Make the SVG dom code use the WebIDL constants from the bindings r=jwatt
2018-02-18 15:53:13 +00:00
Miko Mynttinen
7a19c4858c
Bug 1438165 - Ensure that all display items have a unique type r=mattwoodrow
...
MozReview-Commit-ID: HIlSQFcvG9A
--HG--
extra : rebase_source : aba9cdf8e578ed3fd98a77aef8a183dac08baea1
extra : amend_source : 329ff3b9124c05b35ff1e0807afe9ac455bbebce
2018-02-15 15:26:56 +01:00
Boris Zbarsky
13dda50f75
Bug 1435138 part 4. Remove nsIDOMSVGLength. r=qdot
...
MozReview-Commit-ID: HwKT9Bdby6F
2018-02-02 08:21:33 -05:00
Daniel Holbert
6fa9124425
Bug 1429915: Use RefPtr instead of NS_ADDREF to set refcounted outparams in SVGTextFrame. r=jwatt
...
MozReview-Commit-ID: 6eBacKkAitR
--HG--
extra : rebase_source : 52aceccd94b387e9499bd161b0163caa4da851c8
2018-01-30 16:47:22 -05:00
Mats Palmgren
60e745ae58
Bug 1424528 part 1 - Remove nsDidReflowStatus::FINISHED 3rd arg in DidReflow calls (automated change). r=dholbert
...
MozReview-Commit-ID: CiK7pV0OsGr
2017-12-14 16:21:49 +01:00
Miko Mynttinen
2fc0722497
Bug 1425078 - Remove nsDisplayList::AppendNewToTop and nsDisplayList::AppendNewToBottom r=mattwoodrow
...
MozReview-Commit-ID: E3neKT2sV4Q
--HG--
extra : rebase_source : 98b65e4c82f8a965df211e828bc68d46e7a6716e
2017-12-13 11:23:04 -06:00