Commit graph

108 commits

Author SHA1 Message Date
Harshit Sohaney
128ad67178 Bug 1881327 - (part 1) Added dialog box resizing for the new clear history dialog to account for wrapping due to localization. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D203033
2024-03-29 12:22:35 +00:00
Harshit Sohaney
9c91d11787 Bug 1868603 - (part 1) Unblock clear history dialog from data size loading. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D201986
2024-03-13 16:30:11 +00:00
Harshit Sohaney
11834a50d8 Bug 1879533 - Fixing telemetry async intermittent by awaiting for data size loading after collecting telemetry. r=pbz
We are possibly facing intermittent failures with the telemetry tests for the clear history dialog because we currently report the telemetry after waiting for the data sizes to load. This could mean that there are cases where the telemetry has not been done reporting and the test runs.

Differential Revision: https://phabricator.services.mozilla.com/D201989
2024-02-27 17:30:37 +00:00
Harshit Sohaney
246329c6f0 Bug 1878111 - Migrate prefs for clear history dialog in both clearHistory and clearOnShutdown contexts. r=pbz,mconley
Differential Revision: https://phabricator.services.mozilla.com/D201630
2024-02-26 21:29:36 +00:00
Harshit Sohaney
4252256e80 Bug 1878111 - (part 1) Remember user clearing options in the new clear history dialog. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D201274
2024-02-23 14:13:29 +00:00
Cristian Tuns
72fdfb86f5 Backed out 2 changesets (bug 1878111) for causing bc failures in browser_clearSiteData.js CLOSED TREE
Backed out changeset 81b85259c9fd (bug 1878111)
Backed out changeset 436b082f2e59 (bug 1878111)
2024-02-14 17:23:01 -05:00
Harshit Sohaney
e49879c59f Bug 1878111 - (part 1) Remember user clearing options in the new clear history dialog. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D201274
2024-02-14 17:16:00 +00:00
Harshit Sohaney
651629750d Bug 1876378 - Ensure the data size displayed in about:preferences#privacy is updated after data sanitization. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D199580
2024-01-30 14:45:24 +00:00
Harshit Sohaney
b8cb17c174 Bug 1876353 - Fixed clear history logic to prevent the warning box from displaying in the clear on shutdown context. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D199581
2024-01-29 15:04:54 +00:00
Harshit Sohaney
2a867dd1ab Bug 1876352 - Disable clearing button when no checkboxes are selected for clearing history. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D199579
2024-01-29 14:17:40 +00:00
Harshit Sohaney
396c4816a3 Bug 1876097 - Migrate old prefs to the new prefs for clear on shutdown in the new clear history dialog. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D199445
2024-01-29 14:17:40 +00:00
Harshit Sohaney
a50e7bbf86 Bug 1856417 - Add Telemetry for new clear data dialog. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D197211
2024-01-24 01:34:13 +00:00
Harshit Sohaney
4676f9c1d2 Bug 1869884 - Remerging downloads into history. r=pbz,fluent-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D198393
2024-01-19 06:30:02 +00:00
Natalia Csoregi
a46f2e0946 Backed out changeset 7969278ce39f (bug 1869884) for causing failures on browser_sanitizeDialog_v2.js. CLOSED TREE 2024-01-19 00:54:37 +02:00
Harshit Sohaney
6e22a02790 Bug 1869884 - Remerging downloads into history. r=pbz,fluent-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D198393
2024-01-18 20:10:01 +00:00
Harshit Sohaney
a8743a7f74 Bug 1856417 - Updated default pref code for new clear history dialog. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D197952
2024-01-16 06:50:47 +00:00
Harshit Sohaney
b677473962 Bug 1861450 - (Part 1) Create new prefs and categories in Sanitizer for the new dialog box. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D194136
2024-01-16 06:50:46 +00:00
Harshit Sohaney
bd7ae2cbc1 Bug 1856412 - (Part 1) Make all clear history entrypoints point to the new clear history dialog. r=pbz,fluent-reviewers,settings-reviewers,flod,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D192282
2024-01-15 13:10:05 +00:00
Harshit Sohaney
b47c8fb5fc Bug 1855068 - (Part 1) Added functionality to get all data sizes by time range. r=pbz,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D190862
2024-01-15 13:10:05 +00:00
Noemi Erli
e0cc765727 Backed out 4 changesets (bug 1855068, bug 1856412) for causing failures in test_SiteDataManager.js CLOSED TREE
Backed out changeset dbaf2b0da226 (bug 1856412)
Backed out changeset 8d040fd73abf (bug 1856412)
Backed out changeset 645f7ed438fb (bug 1855068)
Backed out changeset be41f5296dec (bug 1855068)
2024-01-11 03:20:27 +02:00
Harshit Sohaney
d43cbd3e1d Bug 1856412 - (Part 1) Make all clear history entrypoints point to the new clear history dialog. r=pbz,fluent-reviewers,settings-reviewers,flod,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D192282
2024-01-10 13:15:01 +00:00
Harshit Sohaney
173f01f1b0 Bug 1855068 - (Part 1) Added functionality to get all data sizes by time range. r=pbz,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D190862
2024-01-10 11:47:26 +00:00
Harshit Sohaney
ee785b88ad Bug 1856415 - (Part 1) Updating clear data dialog UI. r=pbz,fluent-reviewers,settings-reviewers,desktop-theme-reviewers,Gijs,dao,flod
Differential Revision: https://phabricator.services.mozilla.com/D189947
2023-12-18 14:41:11 +00:00
Sandor Molnar
53a6546034 Backed out 2 changesets (bug 1856415) for causing bc failures at browser/base/content/test/static/browser_all_files_referenced.js CLOSED TREE
Backed out changeset f5e458c049b9 (bug 1856415)
Backed out changeset ffd79f9e0881 (bug 1856415)
2023-12-11 20:20:33 +02:00
Harshit Sohaney
47cfad8fb4 Bug 1856415 - (Part 1) Updating clear data dialog UI. r=pbz,fluent-reviewers,settings-reviewers,desktop-theme-reviewers,Gijs,dao,flod
Differential Revision: https://phabricator.services.mozilla.com/D189947
2023-12-11 16:50:57 +00:00
Mark Banner
8219a5c503 Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish
Differential Revision: https://phabricator.services.mozilla.com/D177025
2023-05-20 12:26:49 +00:00
Emilio Cobos Álvarez
253c7c9e26 Bug 1828767 - Fix native sanitize dialog sizing. r=Gijs,fluent-reviewers,flod
The fluent migration is basically the one from bug 1792809 copy-pasted,
which is why it might be a bit over-generic.

Differential Revision: https://phabricator.services.mozilla.com/D176275
2023-04-24 11:36:24 +00:00
Mike Kaply
982e9f7ae8 Bug 1821042 - Downloads pref shouldn't impact enablement of sanitize dialog. r=hpeuckmann
Differential Revision: https://phabricator.services.mozilla.com/D172009
2023-03-14 19:45:31 +00:00
Butkovits Atila
92468077a2 Backed out changeset 4637d7a67afa (bug 1821042) for causing failures at browser_sanitizeDialog.js. CLOSED TREE 2023-03-13 20:04:16 +02:00
Mike Kaply
47f39c6330 Bug 1821042 - Downloads pref shouldn't impact enablement of sanitize dialog. r=hpeuckmann
Differential Revision: https://phabricator.services.mozilla.com/D172009
2023-03-13 16:43:29 +00:00
Mark Banner
3a07fcf436 Bug 1806503 - Automatically replace Cu.reportError with console.error (browser/actors, browser/base). r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D165068
2022-12-27 10:08:58 +00:00
Kagami Sascha Rosylight
f24fdbc09c Bug 1801346 - Esmify browser/modules/Sanitizer.jsm r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D162425
2022-11-19 01:45:42 +00:00
Tooru Fujisawa
bf93d07148 Bug 1667455 - Part 5: Stop importing Services.jsm from chrome-priv JS code, top-level single-line cases. r=kmag,webdriver-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,extension-reviewers,application-update-reviewers,pip-reviewers,twisniewski,m_kato,jdescottes,mconley,AlexandruIonescu,mossop
Differential Revision: https://phabricator.services.mozilla.com/D150894
2022-07-11 12:41:50 +00:00
Mark Banner
4f4dd2fbae Bug 1750974 - Extend our ESLint import-globals-from function to support absolute directories. r=Gijs,mossop
Differential Revision: https://phabricator.services.mozilla.com/D136368
2022-01-20 14:15:34 +00:00
Gijs Kruitbosch
0c1c818c13 Bug 1718435 - fix clear recent history dialog when there are no open windows, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D121842
2021-08-06 22:18:35 +00:00
Gijs Kruitbosch
e166a98fe3 Bug 1720262 - improve spacing in the window-modal clear recent history dialog, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D120985
2021-08-02 14:09:38 +00:00
Gijs Kruitbosch
a31bc9af69 Bug 1721466 - add title to clear recent history dialog when opened as a subdialog in the browser window, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D120984
2021-08-02 14:09:37 +00:00
Mike Conley
eaa75cbe8c Bug 1712750 - Make sure sanitize.xhtml gets to set its mozSubdialogReady. r=mtigley
The mozSubdialogReady was being set inside of sanitize.xhtml in
its load event handler, which would be scheduled to run AFTER the
SubDialog _onLoad handler (which is what awaits mozSubdialogReady).

The only reason this wasn't more obvious is because the first time
the dialog is opened, the SubDialog _onLoad handler awaits
translation of the document, which gives sanitize.xhtml a chance
to run its load event handler and set the mozSubdialogReady.
Subsequent opens of the dialog wouldn't need to re-run translation
due to document caching, and so the mozSubdialogReady wouldn't
be waited for, resulting in incorrect dialog layout.

Depends on D119329

Differential Revision: https://phabricator.services.mozilla.com/D119330
2021-07-12 13:50:03 +00:00
Mike Conley
1cdf3f0759 Bug 1712750 - Get rid of some old-modal condition handlers in sanitize.xhtml. r=mtigley
These handlers and markup were only ever relevant when opening the
dialog in an old-style modal. Now that we're opening the dialog as
a SubDialog, these conditions can be cleaned up.

Depends on D117567

Differential Revision: https://phabricator.services.mozilla.com/D119329
2021-07-12 13:50:02 +00:00
Harry Twyford
f4b848daab Bug 1708209 - Use native checkboxes in all native windows. r=Gijs,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D113678
2021-04-28 20:21:34 +00:00
pbz
5c65d2dbca Bug 1650794 - Refactor subdialogs.js to reusable SubDialog.jsm. r=Gijs,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D82405
2020-07-10 00:01:50 +00:00
Kris Maglione
3bda67deab Bug 1638153: Part 2 - Fix uses of .rootTreeItem to get top browser window. r=geckoview-reviewers,nika,snorp
Differential Revision: https://phabricator.services.mozilla.com/D75429
2020-06-17 17:17:16 +00:00
Razvan Maries
a36bb7751f Backed out 3 changesets (bug 1638153) for perma failures on cross-origin-objects.html. CLOSED TREE
Backed out changeset f7aedc92d396 (bug 1638153)
Backed out changeset 07ec713926c6 (bug 1638153)
Backed out changeset 5a656842e241 (bug 1638153)
2020-06-01 23:51:35 +03:00
Kris Maglione
b3fcd970ec Bug 1638153: Part 2 - Fix uses of .rootTreeItem to get top browser window. r=geckoview-reviewers,nika,snorp
Differential Revision: https://phabricator.services.mozilla.com/D75429
2020-06-01 17:59:01 +00:00
Brian Grinstead
28a659f010 Bug 1616179 - Assign an id to the <window> for the sanitize dialog to fix location persistence;r=Gijs
The [persist] attribute requires the element has an id, so it was failing to remember
screenX and screenY for the dialog before this change.

Depends on D63233

Differential Revision: https://phabricator.services.mozilla.com/D63236

--HG--
extra : moz-landing-system : lando
2020-02-18 23:29:04 +00:00
Brian Grinstead
c72cf26d0e Bug 1616179 - Fix JavaScript error: chrome://browser/content/sanitizeDialog.js, line 70: TypeError: right-hand side of 'in' should be an object, got null error when sanitize dialog is opened outside of preferences;r=Gijs
This error has been present since the initial landing in Bug 1523696.

This is unrelated to the fix in the next patch, just something I noticed when debugging it.

Differential Revision: https://phabricator.services.mozilla.com/D63233

--HG--
extra : moz-landing-system : lando
2020-02-18 23:27:30 +00:00
Kirk Steuber
589b7532ea Bug 1585482 - Restructure all <xul:dialog> usages such that they are not the top level element r=bgrins
This patch also includes necessary JS changes to support this. Most commonly, the dialog was accessed with document.documentElement, which needed to be changed now that the dialog is not the top level element.

Differential Revision: https://phabricator.services.mozilla.com/D52411

--HG--
extra : moz-landing-system : lando
2019-12-10 18:25:59 +00:00
Mark Hammond
3e61188103 Bug 1563552 (part 2) - remove support for the 'name' attribute from preferencesBindings.js. r=myk,jaws
Differential Revision: https://phabricator.services.mozilla.com/D38829

--HG--
extra : moz-landing-system : lando
2019-07-25 10:36:14 +00:00
Jonas Allmann
3feb30bb0d Bug 1547718, Remove preferenceBindings.js from eval()-whitelist, r=Gijs
Work in progress.
Add callback infrastructure to preferenceBindings to replace XUL-attributes.

Differential Revision: https://phabricator.services.mozilla.com/D32326

--HG--
extra : moz-landing-system : lando
2019-07-11 09:37:59 +00:00
Victor Porof
f9f5914039 Bug 1561435 - Format browser/base/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36041

--HG--
extra : source : 96b3895a3b2aa2fcb064c85ec5857b7216884556
2019-07-05 09:48:57 +02:00