Commit graph

695 commits

Author SHA1 Message Date
Florian Quèze
70bba4163d Bug 1371860 - The 'Search' placeholder should appear immediately on about:home and about:newtab, r=nhnt11. 2017-06-13 08:39:39 +02:00
Wes Kocher
07d7985523 Merge inbound to central, a=merge
MozReview-Commit-ID: IrZXJHbiqpa
2017-06-09 15:28:10 -07:00
Florian Quèze
dc628a8ae3 Bug 1369705 - avoid starting the search service or calling the search-one-offs XBL constructor before first paint, r=adw. 2017-06-09 15:11:03 +02:00
Ed Lee
c1a3be3fdc Bug 1371479 - Update search behavior about:newtab tests to work with activity-stream.enabled true and false. r=ursula
Update tests to select the search input for either about:newtab with a querySelector instead of specific id. Also removes gSearch checks that are always false anyway with the move to e10s contentSearch.

MozReview-Commit-ID: 8knCvfzA6yk

--HG--
extra : rebase_source : 484dd855dd96e587dbc1a61bf53fdad3759a7caf
2017-06-08 16:44:38 -07:00
Drew Willcoxon
6995e1d59d Bug 1357800 - The One-Off search buttons not visible in the search bar. r=florian
Rebuild the one-off search buttons when the theme changes.  See bug 1357800 for details.  Summary: On Linux, switching between themes can cause a row of buttons to disappear.

MozReview-Commit-ID: 8lfsUO00jYP

--HG--
extra : rebase_source : 5bdef5513a8c8f8f02fd9383867b0ed57610b606
2017-05-17 15:58:56 -07:00
Panos Astithas
f2dce5fda5 Bug 1359056 - Don't open the search panel when entering customization mode. r=Gijs
MozReview-Commit-ID: XmNZMrizET

--HG--
extra : rebase_source : 46bd79b6d915338c6a5bbead6f1614e5f790e2a8
2017-05-12 21:40:54 -04:00
Carsten "Tomcat" Book
e83697008e merge mozilla-inbound to mozilla-central a=merge 2017-05-16 15:04:38 +02:00
Christoph Kerschbaumer
e4f38c8d7c Bug 1362993 - Rewrite gBrowser.addTab() to use BrowserTestUtils.addTab(). r=florian 2017-05-15 21:49:50 +02:00
Fischer.json
c0472057e4 Bug 1330315 - Add a telemetry probe to track how the Preferences are opened, r=mconley
MozReview-Commit-ID: GfuGF4v30pI

--HG--
extra : rebase_source : e8b4399bd1e3fc5e5b220e80d6694c00a4b7e482
2017-05-09 10:43:48 -04:00
Florian Quèze
4e937e42a2 Bug 1353542 - Cleanup the script output and fix tests, r=Mossop. 2017-05-12 14:54:05 +02:00
Florian Quèze
5e3539e504 Bug 1353542 - massive script-generated patch converting Task.async and Task.spawn calls, and generators clearly identifiable as tasks, rs=Mossop. 2017-05-12 14:42:39 +02:00
Wes Kocher
ea3b6b9f1e Backed out changeset 75a14f02f6f7 (bug 1330315) for build failures in TelemetryHistogramData.inc a=backout
MozReview-Commit-ID: KKnLXDjgmqC

--HG--
extra : rebase_source : 29e2b567cd0bc75cc4e0b22af20c7efaeb73a259
2017-05-10 10:45:18 -07:00
Fischer.json
7102edfb97 Bug 1330315 - Add a telemetry probe to track how the Preferences are opened, r=mconley
MozReview-Commit-ID: GfuGF4v30pI

--HG--
extra : rebase_source : 68ed5ae4ff04c79aab70e288276ca527a807a435
2017-05-09 10:43:48 -04:00
Johann Hofmann
3de40d5fb3 Bug 1352364 - Disable browser_oneOffHeader.js on OSX. rs=dao
This test went intermittent through bug 1352364 but we can't
reproduce it locally and opened bug 1361276 to not block progress.

MozReview-Commit-ID: 60NG4j17279

--HG--
extra : rebase_source : 47a2b427f1fe7e9a223a226131dfad6b35136eb4
2017-05-02 09:31:42 +02:00
Florian Queze
4b1556a5f2 Bug 1355056 - replace (function(args) { /* do stuff using this */ }).bind(this) with arrow functions, r=jaws. 2017-04-27 00:25:45 +02:00
Sebastian Hengst
7fccfb74e9 merge mozilla-central to autoland. r=merge a=merge 2017-04-22 10:49:35 +02:00
Marco Bonardo
4f991dcba4 Bug 1358503 - memoize anon elements in the oneoffs binding. r=florian
MozReview-Commit-ID: JKmfd7cUfRx

--HG--
extra : rebase_source : d8c7c9ff9a63afdde135b608fddb51abc54d84ac
2017-04-21 16:05:46 +02:00
Wes Kocher
4a05296446 Merge m-c to inbound, a=merge
MozReview-Commit-ID: Cb0b59wJ0vy
2017-04-21 17:35:24 -07:00
Florian Queze
f596929f1c Bug 1358382 - Compute the searchbar panel size and position without sync reflow, r=adw. 2017-04-22 02:09:05 +02:00
Drew Willcoxon
6f20b4a138 Bug 1357458 - After Customization - typed text in the Awesome bar doesn't correspond with the text from One-Off-Searches bar. r=florian
MozReview-Commit-ID: KHAoxS1CsWj

--HG--
extra : rebase_source : ceff8abeeb94b082c6a7f6f3950a1c35767db0dd
2017-04-20 19:00:26 -07:00
Carsten "Tomcat" Book
44e9c21039 merge mozilla-inbound to mozilla-central a=merge 2017-04-19 10:32:48 +02:00
Florian Queze
e8bed3af2f Bug 1312999 - Cache one-off buttons instead of regenerating them at every popupopen, r=adw. 2017-04-19 00:04:07 +02:00
Drew Willcoxon
376e3a8e45 Bug 1295460 - Update the background color of the one-off search buttons. r=florian
MozReview-Commit-ID: 3iKLQcb59aT

--HG--
extra : rebase_source : 8d8df6e3bef12d2baba2165cfc12b81cb29ced30
2017-04-10 19:07:57 -07:00
Zibi Braniecki
a1a4f0b7c9 Bug 1346616 - Migrate callsites that are retrieving requested locale from pref, to use LocaleService::GetRequestedLocales. r=jfkthame,Pike
I'm adding a helper function mozILocaleService::GetRequestedLocale to simplify
most of the callsites that are looking for the first of the requested locales.

In most cases, I'm just matching the behavior of the code with reusing
LocaleService API instead of direct manipulation on the prefs.
That includes how I handle error case scenarios.

In case of sdk/l10n/locale.js I am reusing LocaleService heuristics over
the custom one from the file since the ones in LocaleService are just
more correct and unified accross the whole platform.

In case of FallbackEncoding I have to turn it into a nsIObserver to listen
to intl:requested-locales-changed.

MozReview-Commit-ID: 7rOr2CovLK

--HG--
extra : rebase_source : 883a91b249b6953b7872bfb9a8851e8be7257c7b
2017-03-11 18:43:11 -08:00
Sebastian Hengst
7b30105d39 Backed out changeset 60d72c2dd49d (bug 1346616) for eslint failure in DirectoryLinksProvider.jsm. r=backout on a CLOSED TREE 2017-04-18 00:48:16 +02:00
Zibi Braniecki
cce53c69bc Bug 1346616 - Migrate callsites that are retrieving requested locale from pref, to use LocaleService::GetRequestedLocales. r=jfkthame,Pike
I'm adding a helper function mozILocaleService::GetRequestedLocale to simplify
most of the callsites that are looking for the first of the requested locales.

In most cases, I'm just matching the behavior of the code with reusing
LocaleService API instead of direct manipulation on the prefs.
That includes how I handle error case scenarios.

In case of sdk/l10n/locale.js I am reusing LocaleService heuristics over
the custom one from the file since the ones in LocaleService are just
more correct and unified accross the whole platform.

In case of FallbackEncoding I have to turn it into a nsIObserver to listen
to intl:requested-locales-changed.

MozReview-Commit-ID: 7rOr2CovLK

--HG--
extra : rebase_source : 2f166cf1746f389a035f7cf557edcadeacb10fa0
2017-03-11 18:43:11 -08:00
Sebastian Hengst
8bd051237a merge mozilla-inbound to mozilla-central. r=merge a=merge
MozReview-Commit-ID: JpAhOPjgvkF
2017-04-15 19:59:24 +02:00
Florian Queze
4c6a68d1c9 Bug 1355161 - script-generated patch to replace .{currentThread,mainThread}.dispatch(..., Ci.nsIThread.DISPATCH_NORMAL) with .dispatchToMainThread(...), r=froydnj. 2017-04-14 18:29:12 +02:00
Drew Willcoxon
c62a09b53e Bug 1353831 - OneOff block in search bar doesn't update text if Customize was opened at least once. r=florian
MozReview-Commit-ID: Iu7xhCbCh6B

--HG--
extra : rebase_source : c3c68c7935393c7e8ad264010ce4bd6b53d6a6f5
2017-04-14 16:34:41 -07:00
Drew Willcoxon
4f0389f555 Bug 1334615 - Add a probe to determine whether the keyboard or the mouse was used to select an action. r=bsmedberg,mak
MozReview-Commit-ID: G3K2l6jnCR8

--HG--
extra : rebase_source : e3f9696defa7cdd76695f657b7f5a6e01edb604f
2017-04-14 17:27:51 -07:00
Sebastian Hengst
1e3c7e2a9c Backed out changeset 3742522c4533 (bug 1353831) for failing at least test_focus_autocomplete.xul in a11y suite on OSX 10.10 debug. r=backout 2017-04-15 00:00:29 +02:00
Drew Willcoxon
edf816f89a Bug 1353831 - OneOff block in search bar doesn't update text if Customize was opened at least once. r=florian
MozReview-Commit-ID: Iu7xhCbCh6B

--HG--
extra : rebase_source : 9a953c8fd6bfe80e38da7dac2079f27a5d1058de
2017-04-11 07:17:27 -07:00
RyanBRiley
f7f53449d6 Bug 1353711 - Changing reference to this.AppConstants to parent AppConstants, removing local AppConstants field r=dao
MozReview-Commit-ID: Hgo4FjreOos

--HG--
extra : rebase_source : 490b603e3f3f00d7290e1aadf276079845887fc1
2017-04-13 18:45:00 -06:00
Sebastian Hengst
f54f97f562 Bug 1352161 - Fix search engine installation from searchbar. r=florian
MozReview-Commit-ID: B9JbHknJLC5

--HG--
extra : rebase_source : 4da7a64c4bdfef8631989dad866bcbdec83529a7
2017-03-31 00:27:05 +02:00
Drew Willcoxon
cc637153bc Bug 1295458 - Rework key and mouse handling for the one-off search buttons. r=florian
MozReview-Commit-ID: DKbU8r2BrA8

--HG--
extra : rebase_source : 9f0ff5241907455516ddec24f22e6c7f5e52105d
2017-04-11 08:40:11 -07:00
Jared Wein
e0f097b470 Bug 1353808 - Only show the 'Search' preferences when the Manage Search Engines button is clicked. r=mconley
MozReview-Commit-ID: 2sVbayD6tPf

--HG--
extra : rebase_source : 222a1d8553c4580dc21992867735c4b91d5ed691
2017-04-05 23:38:30 -04:00
Zack Herrick
84361e7e85 Bug 1335907 - Reorganize the preferences based on feedback from user research. r=mconley
The FX_PREFERENCES_CATEGORY_OPENED probe must be extended to version 59 to support the fallback "forked" preference implementation (in-content-old).

The switchToAdvancedSubPane within utilityOverlay's openPreferences must also remain until the fallback has been removed (bug 1349689).

Patch co-authored by Zack Herrick <herrickz@msu.edu> and Ziyan Long <lzylong@gmail.com>.

MozReview-Commit-ID: 1sx0Wj15yM7

--HG--
extra : rebase_source : 0266027fb3023d4cb155533193d6809d799de1e4
2017-03-29 11:52:08 -04:00
Florian Queze
37ff4fc7cc Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Jared Wein
a54eda04ca Bug 1348068 - Enable the key-spacing rule for eslint and fix the related issues. r=standard8
Running eslint with --fix didn't fix many of the issues. The majority here had to be fixed by hand but a significant majority of the issues were related to a few files that I was able to use find-and-replace with. I regret not making this in to separate commits of the hand-fixes and the fixes from --fix but I don't recall --fix fixing any of the issues.

MozReview-Commit-ID: ANyg2qfo3Qx

--HG--
extra : rebase_source : 61d2aa91bf9474af3d72a5dea41b25dca442c1b7
2017-03-21 14:29:43 -04:00
Mark Banner
bd625e4e9f Bug 1347712 - Change the testing configurations into ESLint configurations within eslint-plugin-mozilla - automatically update .eslintrc.js test config files for new config locations. r=jaws
MozReview-Commit-ID: LH0CQOPfoe6

--HG--
extra : rebase_source : 83eaf40c5cbb5e25cfb3f3b5afadf4fbf0422c92
2017-03-20 12:36:37 +01:00
CactusTribe
313e8af5e9 Bug 1214284 - Adding engine title and line separator in tooltip of button add search engine, r=florian. 2017-03-11 12:51:18 +01:00
Michael Kaply
8069a07ee2 Bug 1337560 - Use chrome icons for Yahoo and Amazon. r=flod
--HG--
extra : amend_source : 8c3b6a37bd7c67358a8c4d7a889efc5b210a2a4c
2017-03-09 09:10:38 -06:00
Mark Banner
561b6cfb0c Bug 1344027 - Fix most of the remaining ESLint no-undef issues in browser/components. r=jaws
MozReview-Commit-ID: DUnxVITvZgh

--HG--
extra : rebase_source : abe5adf3b024a45c2804d048f078c6a59a936242
2017-03-03 09:29:14 +00:00
Drew Willcoxon
09678765af Bug 1335992 - Search with default search engine stops working. r=florian
MozReview-Commit-ID: 9GnA9Y3YvTS

--HG--
extra : rebase_source : f44b3fff39b18ac2d806346b64a5c454d1cd7d96
2017-03-01 09:53:24 -08:00
Drew Willcoxon
f3e44164ad Bug 1343507 - Search settings button moves to its own line with 150% zoom follow-up. r=florian
MozReview-Commit-ID: LGSiMzW6AT9

--HG--
extra : rebase_source : 9fc3a74545127ddc3bc2b3ed777a7be41e56c091
2017-03-01 06:31:40 -08:00
Masatoshi Kimura
7be7b11a1c Bug 1342144 - Remove version parameter from the type attribute of script elements. r=jmaher
This patch is generated by the following sed script:
find . ! -wholename '*/.hg*' -type f \( -iname '*.html' -o -iname '*.xhtml' -o -iname '*.xul' -o -iname '*.js' \) -exec sed -i -e 's/\(\(text\|application\)\/javascript\);version=1.[0-9]/\1/g' {} \;

MozReview-Commit-ID: AzhtdwJwVNg

--HG--
extra : rebase_source : e8f90249454c0779d926f87777f457352961748d
2017-02-23 06:10:07 +09:00
Chris Manchester
e8d8814b95 Bug 1315953 - Skip browser_google_nocodes.js on artifact builds. r=mkaply
A previous patch missed this failing test.

MozReview-Commit-ID: FlirLJzkFHF

--HG--
extra : rebase_source : a98f0a87b455e62443a8b3a3e470b56825966ba9
2017-02-24 10:31:53 -08:00
Chris Manchester
6206009d10 Bug 1315953 - Skip search related browser chrome tests on artifact builds. r=mkaply
MozReview-Commit-ID: Bxzqm9Mn6zR

--HG--
extra : rebase_source : 91ffff96c8f5217f0da4d54f935f529c5cfb653d
2017-02-07 16:55:38 -08:00
Drew Willcoxon
aa291c2796 Last Comment Bug 1316566 - Search settings button moves to its own line with 150% zoom. r=florian
MozReview-Commit-ID: Lb0GjHLZSEX

--HG--
extra : rebase_source : acdb2c583051565f5ada2b30fa3461afeee95af1
2017-02-03 18:26:39 -08:00
Michael Kaply
4c1e311638 Bug 1335104 - Use search locale logic to test Google codes. r=florian
MozReview-Commit-ID: 9pNmJv46b0r

--HG--
extra : rebase_source : 74071f096bb2ef78af73312e97d8aad1b7d8623d
2017-01-30 12:00:08 -06:00