Commit graph

48 commits

Author SHA1 Message Date
Jared Wein
a54eda04ca Bug 1348068 - Enable the key-spacing rule for eslint and fix the related issues. r=standard8
Running eslint with --fix didn't fix many of the issues. The majority here had to be fixed by hand but a significant majority of the issues were related to a few files that I was able to use find-and-replace with. I regret not making this in to separate commits of the hand-fixes and the fixes from --fix but I don't recall --fix fixing any of the issues.

MozReview-Commit-ID: ANyg2qfo3Qx

--HG--
extra : rebase_source : 61d2aa91bf9474af3d72a5dea41b25dca442c1b7
2017-03-21 14:29:43 -04:00
Florian Quèze
be00c3b9e8 Bug 1345294 - add an eslint rule to reject usage of {get,set}ComplexValue for nsISupportsString and suggest {get,set}StringPref instead, and make it pass, r=Mossop. 2017-03-16 19:26:02 +01:00
Florian Quèze
9c4d40bb54 Bug 1345294 - script generated patch (+ some hand cleanup) to replace {get,set}ComplexValue for nsISupportsString by {get,set}StringPref, r=Mossop. 2017-03-16 19:26:01 +01:00
Mark Banner
a656cedb11 Bug 1341029 - Turn on the ESLint no-undef rule for all of toolkit/. r=jaws
MozReview-Commit-ID: Ed9FfkskDos

--HG--
extra : rebase_source : 6ae47dc76b3ebe77b66725a899d32e728af5d35e
2017-02-20 11:45:58 +00:00
Jared Wein
43bac26d30 Bug 1331661 - Enable the 'quotes' rule for eslint and fix most of the errors with --fix. r=Gijs
MozReview-Commit-ID: 6tv0Z06CO4a

--HG--
extra : rebase_source : 014c0b04d8538dc5f15bc6dd4ed6bd220c55c5d4
2017-01-17 09:48:17 -06:00
Jared Wein
9141469edf Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN
MozReview-Commit-ID: FuVu8skcqOe

--HG--
extra : rebase_source : 8ab34c4e46a7c3075b459bf44786ec184d10d203
2016-12-30 21:47:25 -05:00
Jared Wein
ecab54a7c9 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje

--HG--
extra : rebase_source : 0572a35415a766a3f31d266760ecd07f0dcc3f72
2016-12-29 18:34:54 -05:00
Wes Kocher
0dfb7c2b5c Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
7255df4e9a Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR

--HG--
extra : rebase_source : da7172285d43b820421557ed3b05887e091ff939
2016-12-29 15:20:47 -05:00
Dave Townsend
c5bb304fd9 Bug 1316882: Turn on space-before-function-paren eslint rule (toolkit). r=jaws
MozReview-Commit-ID: FGFwg6TYkvm

--HG--
extra : rebase_source : 4073cebbef1694393efe312aaafbdb803adbd304
2016-11-11 15:22:34 -08:00
Jared Wein
5040f17e00 Bug 1312486 - Enable no-extra-boolean-cast, no-new-object, no-shadow-restricted-names, and spaced-comment rules for eslint. r=standard8
MozReview-Commit-ID: 7Gx90a5y8t6

--HG--
extra : rebase_source : 9c8a6b15c19982d720b0163fbbf19d465da786fe
2016-10-24 13:14:19 -04:00
Jared Wein
8ba24fd3a9 Bug 1294618 - Enable the computed-property-spacing rule for eslint. r=felipe
MozReview-Commit-ID: IaN54BFBksA
2016-08-16 15:44:14 -04:00
Jared Wein
fd84c776c7 Bug 1292042 - Enable the keyword-spacing rule for eslint. Most of this patch was autogenerated by 'eslint --fix'. Files with .xml extension needed to be changed by hand due to limitations of custom plugin. r=markh
MozReview-Commit-ID: EMjJ3yWt9Wt

--HG--
extra : rebase_source : 2b8327e5a7cf0bfd190d696ad5fe475f13faa3cc
2016-08-04 03:28:58 -04:00
Jared Wein
169d66a3ed Bug 1292035 - Enable the space-before-blocks rule for eslint. This patch was generated using 'eslint --fix'. r=markh
MozReview-Commit-ID: 2XVoU05YvES

--HG--
extra : rebase_source : e7ed2d094c21b59dd59476b8930b75da2e6d6980
2016-08-04 03:20:25 -04:00
Tooru Fujisawa
65e2703499 Bug 1217082 - Remove for-each from toolkit/. r=Gijs
--HG--
extra : commitid : Ewr7Bixammr
extra : rebase_source : 91e560a7b8b8d4b78debb1db2512867262b18375
2015-10-19 04:57:14 +09:00
Tooru Fujisawa
accd89d4fd Bug 1207498 - Part 1: Remove use of expression closure from toolkit/components/, except tests. r=Gijs
--HG--
extra : commitid : 5yrVqfOUmEG
extra : rebase_source : e2ec30261bd76c1966b0e61fd7e08c2924f270b0
2015-09-24 20:32:23 +09:00
Tooru Fujisawa
e5f587574b Backed out changeset 036615ba3257 (bug 1207498) for Linux pgo M(oth) failure
--HG--
extra : commitid : 4RedbQZ6Rzu
2015-09-27 23:42:50 +09:00
Tooru Fujisawa
b92d75e47c Bug 1207498 - Part 1: Remove use of expression closure from toolkit/components/, except tests. r=Gijs
--HG--
extra : commitid : 2Gx1wpjvr9w
extra : rebase_source : 0a378fd51f45d3fe71430ad8a37a79a8862bfa76
2015-09-24 20:32:23 +09:00
aceman
7abf58cbcc Bug 1063469 - fix some trivial "assignment to undeclared variable" in extApplication.js. r=Neil 2014-09-10 07:49:00 +01:00
Justin Lebar
f5377cfc4f Bug 750454 - Fix FUEL leaks. Part 8: Reformat FUEL code. r=mak
--HG--
extra : rebase_source : f60cacaef0d993a4fde695140fcd3b6fab9e8c7e
2012-06-05 20:05:50 -04:00
Justin Lebar
3edc398a35 Bug 750454 - Fix FUEL leaks. Part 6: Remove gShutdown. r=mak
--HG--
extra : rebase_source : 0e5af38e6de7e477823a2da59ecdcb05af99d8e6
2012-06-05 20:05:50 -04:00
Justin Lebar
5744d4f1b6 Bug 750454 - Fix FUEL leaks. Part 5: Fix extensions. r=mak
--HG--
extra : rebase_source : 82f31f3fb2308f34249d96dd0a6b0a42a5c868a1
2012-06-05 20:05:50 -04:00
Justin Lebar
759bce65ba Bug 750454 - Fix FUEL leaks. Part 3: Fix preferences leaks. r=mak
--HG--
extra : rebase_source : 8b311aa9058e41fa594598a933b2b820e7b6f2bd
2012-06-05 20:05:50 -04:00
Justin Lebar
943b7e31fb Bug 750454 - Fix FUEL leaks. Part 1: Use weak refs in Application. r=mak
--HG--
extra : rebase_source : 04b4ce7ee1488481281a3073b4ba6900f14afbdf
2012-06-05 20:05:50 -04:00
Gervase Markham
82ff7027aa Bug 716478 - update licence to MPL 2. 2012-05-21 12:12:37 +01:00
Patrick Walton
46d104bb9d Bug 750583 - Empty out FUEL's gShutdown array in a less clownshoes manner. r=jlebar 2012-05-04 12:11:13 -07:00
Geoff Lankow
a825a1156c Bug 718255 - Merge nsIPrefBranch2 with nsIPrefBranch - Part C, remove uses of nsIPrefBranch2 in toolkit/ ; r=bsmedberg 2012-01-17 14:18:29 +13:00
Peter Van der Beken
5cc319391d Fix for bug 658632 (Provide easy way to add non-leaky classinfo to JS components). r=gavin.
--HG--
extra : rebase_source : 8463c6f8ba1f969278d4e33bfa08495fa3e36071
2011-05-25 10:46:51 +02:00
Benjamin Smedberg
4f8e7bcf17 Fix review comments from bug 568691 comment 45. 2010-06-24 11:56:28 -04:00
Benjamin Smedberg
09db74cdec Bug 573557 - Rename the category names for script globals to avoid spaces, r=jst 2010-06-21 16:57:44 -04:00
John P Baker
8006bc86f8 Bug 566866 - "Restart now" gives Quit dialog instead of Restart dialog. r=dtownsend 2010-05-26 14:50:29 +02:00
Dave Townsend
f7cfa7038f Bug 552731: Update FUEL to use the new EM APIs. r=mfinkle 2010-04-20 15:14:15 -07:00
Dave Townsend
bfd56a86b8 Backout new add-ons manager due to Ts regression on OSX 10.5
--HG--
rename : toolkit/mozapps/extensions/test/xpcshell/data/test_bug404024.xml => toolkit/mozapps/extensions/test/unit/data/test_bug404024.xml
rename : toolkit/mozapps/extensions/test/xpcshell/data/test_bug417606.xml => toolkit/mozapps/extensions/test/unit/data/test_bug417606.xml
rename : toolkit/mozapps/extensions/test/xpcshell/data/test_bug424262.xml => toolkit/mozapps/extensions/test/unit/data/test_bug424262.xml
rename : toolkit/mozapps/extensions/test/xpcshell/test_bug404024.js => toolkit/mozapps/extensions/test/unit/test_bug404024.js
rename : toolkit/mozapps/extensions/test/xpcshell/test_bug417606.js => toolkit/mozapps/extensions/test/unit/test_bug417606.js
rename : toolkit/mozapps/extensions/test/xpcshell/test_bug424262.js => toolkit/mozapps/extensions/test/unit/test_bug424262.js
rename : toolkit/mozapps/extensions/test/xpcshell/test_bug449027.js => toolkit/mozapps/extensions/test/unit/test_bug449027.js
rename : toolkit/mozapps/extensions/test/xpcshell/test_bug455906.js => toolkit/mozapps/extensions/test/unit/test_bug455906.js
rename : toolkit/mozapps/extensions/test/xpcshell/test_bug514327_3.js => toolkit/mozapps/extensions/test/unit/test_bug514327_3.js
rename : toolkit/mozapps/extensions/test/xpcshell/test_bug541420.js => toolkit/mozapps/extensions/test/unit/test_bug541420.js
2010-05-01 11:04:44 -07:00
Dave Townsend
e853b6f3b4 Bug 552731: Update FUEL to use the new EM APIs. r=mfinkle 2010-04-20 15:14:15 -07:00
Dão Gottwald
0c0415832c Bug 543675 - Assignment to undeclared variable eventItem. r=mfinkle 2010-02-03 13:40:55 +01:00
Dietrich Ayala
a9cd8a88e0 Bug 506471 - FUEL should avoid putting itself in the app-startup category (r=mfinkle) 2010-01-31 19:12:57 -08:00
Metal Sonic
80ae9b3620 Bug 507387 - fix copyright holder; Mozilla Corporation -> Mozilla Foundation. r=gerv. 2009-12-21 21:50:30 +00:00
Dão Gottwald
ded14bca93 Bug 526987 - getItemList, getIncompatibleItemList, getDependentItemListForID and updateAndGetNewBlocklistedItems itemCount out params should be optional. r=dtownsend 2009-11-07 09:21:07 +01:00
Dão Gottwald
b6e71f34a2 Bug 524270 - Make the second getChildList parameter optional. r=bsmedberg 2009-10-26 21:02:06 +01:00
Dietrich Ayala
b1746c5217 backing out bug 506471 due to leaks 2009-10-14 17:01:55 -07:00
Paul O’Shannessy
1c87bfe342 Followup to Bug 506471 - Fix whitespace & remove unused code. r=dietrich 2009-10-14 15:17:51 -07:00
vladimir@pobox.com
540894409d Bug 506471 - FUEL should avoid putting itself in the app-startup category (r=mfinkle) 2009-10-14 13:31:48 -07:00
Mark Finkle
51cf52294d Bug 473156: fuelIEvents.removeListener removes all listeners for an event, r=dtownsend 2009-01-15 13:47:55 -05:00
Shawn Wilsher
8e48a3e072 Bug 462077 - Lazily create Extensions object (FUEL)
This lazily creates the Extensions object off of Application so we do not take
the hit of initializing the object during startup if we do not need it.
r=gavin
2008-10-29 16:56:46 -04:00
Simon Bunzli
37606681b4 b=338039, p=zeniko, r=enndeakin. Provide easy, right way to restart an application. 2008-09-06 23:30:13 -05:00
dmose@mozilla.org
8520347457 Factor out generic toolkit aspects of FUEL into a reusable form (bug 407693), patch by Joey Minta <jminta@gmail.com> and Emre Birol <ebirol@gmail.com>; r=mfinkle, moa for adding toolkit directory=bsmedberg, a1.9b5=beltzner 2008-03-24 17:38:03 -07:00
reed@reedloden.com
b623bfe3b9 Back out jminta's FUEL/exthandler patch from bug 407963 due to assertion failure and leaks. 2008-01-13 00:26:09 -08:00
reed@reedloden.com
7f18a1e329 Bug 407963 - "[FUEL] Factor out generic toolkit aspects of FUEL into a reusable form" [p=jminta@gmail.com (Joey Minta) r=mfinkle r=gavin sr=bsmedberg a1.9=beltzner] 2008-01-12 23:48:31 -08:00