Commit graph

72 commits

Author SHA1 Message Date
Mike Conley
1d9b7575d2 Bug 1823438 - Make it possible for panel-list to get a minimum width from its anchor. r=hjones
With this patch, users of panel-list can have the list gain a minimum width from
the anchor element by setting min-width-from-anchor="" on the panel-list element.

Differential Revision: https://phabricator.services.mozilla.com/D173058
2023-03-21 19:41:38 +00:00
Mike Conley
d960e3303e Bug 1814278 - Align the spacing and layout of the new Migration Wizard more closely to the spec. r=kpatenio,fluent-reviewers,flod,settings-reviewers
Along with bringing us closer to the layout and spacing from Figma, this does the following:

1. Changes the header element to an <h1> and uses CSS to get the expected font size. This should
   make the organization of the wizard make more sense to screenreaders.
2. Handles the "single resource" case for Variant 2, where we hide "Select All" and align the
   resource list to the left if there's only a single resource to import.
3. Fixes a string to match the spec.

Differential Revision: https://phabricator.services.mozilla.com/D173054
2023-03-21 12:35:19 +00:00
elephanteatsapple
8ca988dcf3 Bug 1811933 -Replace placeholder <select> and <options> in MigrationWizard with a <button> and a <panel-list>. r=mconley,settings-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D170420
2023-03-20 14:56:41 +00:00
Mark Banner
80295c5a70 Bug 1812098 - Fix ESLint raised issues with no-shadow of builtinGlobals in browser .mjs files. r=Gijs,credential-management-reviewers,sgalich,fxview-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D169463
2023-03-14 09:13:48 +00:00
Abhishek Tiwari
2a31a8b68d Bug 1818767 - Add link to our deployed Storybook instance in our docs updated patch r=tgiles
Differential Revision: https://phabricator.services.mozilla.com/D172239
2023-03-10 14:54:42 +00:00
Mike Conley
bdabd15be2 Bug 1819343 - Add a skeleton loading page for the new MigrationWizard component. r=kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D171741
2023-03-06 21:39:01 +00:00
brian
62b680db2c Bug 1809347 Implement the page that appears if no other browsers to import cannot be found. r=mconley,fluent-reviewers,flod.
Differential Revision: https://phabricator.services.mozilla.com/D168981
2023-03-03 20:35:52 +00:00
Norisz Fay
d8f467432b Backed out changeset cfa8d4331629 (bug 1809347) for causing mochitest failures on test_migration_wizard.html CLOSED TREE 2023-03-03 22:10:10 +02:00
brian
20e0d71c81 Bug 1809347 Implement the page that appears if no other browsers to import cannot be found. r=mconley,fluent-reviewers,flod.
Differential Revision: https://phabricator.services.mozilla.com/D168981
2023-03-03 19:24:29 +00:00
Mike Conley
c542a81924 Bug 1819750 - Map branding strings to the nightly folder when running Storybook. r=hjones
Differential Revision: https://phabricator.services.mozilla.com/D171399
2023-03-01 22:17:18 +00:00
Mark Striemer
a40c763925 Bug 1810885 - Use ChromeMap for rewriting chrome:// URIs in Storybook r=hjones
Differential Revision: https://phabricator.services.mozilla.com/D170936
2023-02-28 05:43:54 +00:00
Mike Conley
fc12997ae0 Bug 1818284 - Use Lit to construct the Storybook instance of the new MigrationWizard. r=hjones
This will make it easier to use Storybook to simulate how the MigrationWizard is likely to
be used in practice - which is to say, declaratively.

Differential Revision: https://phabricator.services.mozilla.com/D170666
2023-02-22 19:44:13 +00:00
Tim Giles
cdbe2eb104 Bug 1766701 - Split existing README.stories.md into two docs. r=hjones,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D169646
2023-02-16 14:50:01 +00:00
Tim Giles
9a35c1f5d7 Bug 1766701 - Document Storybook usage in Firefox Source Docs. r=mstriemer,hjones
Differential Revision: https://phabricator.services.mozilla.com/D169386
2023-02-16 14:50:01 +00:00
Hanna Jones
97c12cb0ec Bug 1805490 - storybook addon for psuedo localization r=mstriemer
This patch does a few things:

* creates a storybook addon for pseudo localization, which adds a button to the storybook toolbar and kicks off generating/connecting a new Fluent bundle when the pseudo localization strategy changes
* pulls in l10n-pseudo.js from the devtools profiler
* moves the fluent logic out of preview.js into a separate file (possibly a precursor to some moves we'll make when we create a proper fluent addon)

Differential Revision: https://phabricator.services.mozilla.com/D169382
2023-02-15 15:29:41 +00:00
Hanna Jones
703dc940f1 Bug 1816202 - remove toggle-button.css and cleanup remaining references r=tgiles,settings-reviewers,mconley
It occurred to me that we're not actually using `toggle-button.css` anywhere since the about:preferences work landed. I definitely should have removed the reference in `preferences.xhtml` as part of that patch, whoops.

Differential Revision: https://phabricator.services.mozilla.com/D169530
2023-02-13 20:41:02 +00:00
Nolan Ishii
077ebaf8d9 Bug 1803446 Implement 'variant 2' version of the main selector page for the migration wizard. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D166949
2023-02-08 15:58:24 +00:00
Hanna Jones
3a587db896 Bug 1805573 - make it possible to write .stories.md or .stories.mdx documentation r=mstriemer,tgiles
This patch both fixes the dependency issues that we were running into when writing `.stories.mdx` stories and gives us the ability to write `.stories.md` docs only vanilla markdown stories.

To get the MDX stories working I had to clear out my `package-lock.json` and install `@mdx-js/react` with the `--legacy-peer-deps` flag as described here: https://github.com/storybookjs/storybook/issues/18094#issuecomment-1112883092

Let me know if you run into issues with installing dependencies and running Storybook given all the changes. There was a different solution I explored in January to enable MDX2 support, but I couldn't seem to resolve all the dependency version mismatch issues there anymore. There will probably be follow up work to update all of this after Storybook v7 is officially released in March.

To enable us to write `.stories.md` docs only stories I added a custom Webpack loader that takes markdown and transforms it into docs only MDX, then runs that through all the other necessary loaders. There's definitely some follow up work here too - for example right now all our docs only pages get put in a "Docs" folder because I ran out of steam for exploring a way for us to specify/parse out a path and name for the docs stories.

Differential Revision: https://phabricator.services.mozilla.com/D168268
2023-02-02 21:54:35 +00:00
Mike Conley
5a995322ec Bug 1813141 - Use a relative path for the progress mask image in the MigrationWizard Storybook story. r=hjones
Differential Revision: https://phabricator.services.mozilla.com/D168136
2023-01-27 20:35:34 +00:00
Mike Conley
828431224a Bug 1811935 - Adjust visibility of the resource types available for each migrator / profile pair in the new migration wizard. r=Gijs
This causes the MigrationWizardChild to request the full collection of available
migrators and user profiles, and then based on which resourceTypes those migrators
and user profiles have available, changes the visibility of the checkboxes in the
selection page of the new MigrationWizard component.

Differential Revision: https://phabricator.services.mozilla.com/D167617
2023-01-25 12:53:31 +00:00
Marian-Vasile Laza
188fed440d Backed out changeset 97ee58e6c65d (bug 1811935) for causing bc failures on browser_dialog_cancel_close.js. CLOSED TREE 2023-01-25 04:06:11 +02:00
Mike Conley
ed79566bd6 Bug 1811935 - Adjust visibility of the resource types available for each migrator / profile pair in the new migration wizard. r=Gijs
This causes the MigrationWizardChild to request the full collection of available
migrators and user profiles, and then based on which resourceTypes those migrators
and user profiles have available, changes the visibility of the checkboxes in the
selection page of the new MigrationWizard component.

Differential Revision: https://phabricator.services.mozilla.com/D167617
2023-01-24 21:15:03 +00:00
Mark Striemer
ca1db8aad0 Bug 1803155 - Part 2: Reorganize storybook/mach_commands.py r=tgiles
Depends on D167320

Differential Revision: https://phabricator.services.mozilla.com/D167321
2023-01-24 17:28:38 +00:00
Mark Striemer
2e212908c3 Bug 1803155 - Part 1: Install Storybook npm dependencies when needed r=tgiles
Differential Revision: https://phabricator.services.mozilla.com/D167320
2023-01-24 17:28:37 +00:00
Hanna Jones
eb9fd58f2b Bug 1799699 - expand storybook args table docs r=mstriemer,tgiles
This is still far from perfect given the limitations of the Storybook web components package, but I figured this was worth putting up since it's still an improvement over the current state of our args tables (I think).

I'm mostly leaving the default generated `custom-elements-manifest.json` alone save for filtering some internal properties we don't want documented since they shouldn't really be accessed directly. If it seems too strange to just have the `aria-label` attr documented we could possibly remove `attributes` from the docs for now (this happens because it's the only attr where the name is different from the property name).

Open to feedback/thoughts on if this is useful or too wonky for now given the weirdness around how Storybook creates naming collisions.

Differential Revision: https://phabricator.services.mozilla.com/D162599
2023-01-23 23:52:36 +00:00
Mike Conley
71d5700fd0 Bug 1811943 - Fix Lit import for Credential Management Stories. r=mtigley
According to mstriemer, when we want to use Lit in mozilla-central,
including in Storybook stories, this is how we want to import it now
that the Lit package has been removed from Storybook as of bug 1803151.

Differential Revision: https://phabricator.services.mozilla.com/D167611
2023-01-23 22:20:50 +00:00
Hanna Jones
411e26c16f Bug 1809457 - disable wonky Storybook addons r=mstriemer
These addons either no longer work with our custom element wrapper, or never really worked:

* backgrounds - isn't super useful because it doesn't follow theme and now doesn't have any visible effect
* mesaure - this one breaks when you click on it, it seems to be looking for a specific root element
* outline - this stil works on the docs page but isn't really useful on the main story page anymore

Differential Revision: https://phabricator.services.mozilla.com/D167295
2023-01-23 15:22:08 +00:00
Micah Tigley
4dfea91742 Bug 1805233 - Replace created/updated/used times with timeline. r=sgalich,eemeli
Differential Revision: https://phabricator.services.mozilla.com/D164469
2023-01-20 16:48:10 +00:00
Otto Länd
2a48a3fd2f Bug 1809457, 1809457, 1809457: apply code formatting via Lando
# ignore-this-changeset
2023-01-19 21:13:20 +00:00
Hanna Jones
25d40a1646 Bug 1809457 - Add decorator/wrapper component to fix Storybook style conflicts r=mstriemer
This fixes the style leakage/conflict issue @tgiles identified by using @mstriemer's `WithCommonStyles` component as a Storybook decorator.

Differential Revision: https://phabricator.services.mozilla.com/D166380
2023-01-19 20:07:41 +00:00
Hanna Jones
4f40774f76 Bug 1809457 - make panel-list work in shadow DOM r=mstriemer
Similar to `named-deck` listeners and `activeElement` checks needed to be updated to use `getRootNode` for cases where `panel-list` is used in the shadow DOM. `parentElement` also doesn't account for shadow roots, but swapping out `shadowRoot.host` seems to work the same. I also pulled in the changes from https://phabricator.services.mozilla.com/D166376.

Differential Revision: https://phabricator.services.mozilla.com/D166701
2023-01-19 20:07:40 +00:00
Hanna Jones
cc00f93f0f Bug 1803676 - fix small typo in npm command r=mstriemer,tgiles
Differential Revision: https://phabricator.services.mozilla.com/D167161
2023-01-18 16:17:12 +00:00
Mark Striemer
9bd107cbe0 Bug 1803151 - Part 2: Use bundled lit for lit-html in Storybook r=hjones
Differential Revision: https://phabricator.services.mozilla.com/D167104
2023-01-18 16:15:00 +00:00
Hanna Jones
9529a09b44 Bug 1803676 - expanding storybook/reusable components documentation r=tgiles,mstriemer
Took a stab at revamping and adding to the Storybook README. The stuff on reusable components should probably be in a separate document, but I wasn't sure where to put it just yet. Eventually some part of this doc will become our Storybook landing page.

Differential Revision: https://phabricator.services.mozilla.com/D166209
2023-01-17 22:07:24 +00:00
Mark Striemer
2c4c02137b Bug 1804162 - Enable context-properties in local Storybook r=hjones
Differential Revision: https://phabricator.services.mozilla.com/D166959
2023-01-17 19:21:32 +00:00
Mike Conley
ccd1a56cdd Bug 1809330 - Allow the MigrationWizard to close dialogs that it is embedded in. r=niklas
Differential Revision: https://phabricator.services.mozilla.com/D166392
2023-01-16 22:25:40 +00:00
Mike Conley
941da3b0b8 Bug 1803447 - Implement progress page for the new migration wizard. r=hjones,kpatenio,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D165090
2023-01-16 22:25:40 +00:00
Mark Striemer
4a07af42bb Bug 1803151 - Use our vendored lit.all.mjs in storybook r=hjones
Differential Revision: https://phabricator.services.mozilla.com/D166393
2023-01-16 21:39:56 +00:00
Cosmin Sabou
bf19cefca8 Backed out changeset fc5baaf503c7 (bug 1805233) for causing frequent leaks in bug 1798028. 2023-01-14 05:42:19 +02:00
Csoregi Natalia
4f92543a87 Backed out 2 changesets (bug 1803447, bug 1809330) for failures on browser_dialog_cancel_close.js. CLOSED TREE
Backed out changeset 57167994f026 (bug 1809330)
Backed out changeset 4c1fd71421ab (bug 1803447)
2023-01-14 04:10:45 +02:00
Mike Conley
abec24600c Bug 1809330 - Allow the MigrationWizard to close dialogs that it is embedded in. r=niklas
Differential Revision: https://phabricator.services.mozilla.com/D166392
2023-01-13 18:28:04 +00:00
Mike Conley
39e90d6676 Bug 1803447 - Implement progress page for the new migration wizard. r=hjones,kpatenio,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D165090
2023-01-13 18:28:03 +00:00
Micah Tigley
7de32ecbc5 Bug 1805233 - Replace created/updated/used times with timeline. r=sgalich,eemeli
Differential Revision: https://phabricator.services.mozilla.com/D164469
2023-01-12 20:23:50 +00:00
Sandor Molnar
d8dc7446e1 Backed out changeset 1d92870692f2 (bug 1805233) for causing mochitest failures in browser/components/aboutlogins/tests/chrome/test_login_item.html CLOSED TREE 2023-01-12 01:47:22 +02:00
Micah Tigley
73b08c494d Bug 1805233 - Replace created/updated/used times with timeline. r=sgalich
Differential Revision: https://phabricator.services.mozilla.com/D164469
2023-01-11 23:23:31 +00:00
Mark Striemer
260e4270fc Bug 1765635 - Extract panel-list from aboutaddons to widgets r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D144224
2023-01-09 22:22:20 +00:00
Tim Giles
58e247939f Bug 1804927 - Add @storybook/addon-a11y to our storybook. r=hjones
Differential Revision: https://phabricator.services.mozilla.com/D165996
2023-01-05 19:39:55 +00:00
Cristian Tuns
3f2b28b9da Backed out changeset da24ae3723ce (bug 1765635) for causing bc failures on browser_html_detail_view.js CLOSED TREE 2023-01-05 14:50:17 -05:00
Mark Striemer
8ffe801580 Bug 1765635 - Extract panel-list from aboutaddons to widgets r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D144224
2023-01-05 16:32:19 +00:00
Mike Conley
55e6cfad28 Bug 1808608 - Move migration wizard constants into their own module for ease of use. r=kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D165994
2023-01-05 00:20:54 +00:00