Commit graph

616 commits

Author SHA1 Message Date
Gregory Pappas
8a35d5cf5f Bug 1845311 - [Part 2] Use ChromeUtils.defineLazyGetter in more places r=arai,webcompat-reviewers,necko-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sync-reviewers,anti-tracking-reviewers,tabbrowser-reviewers,bytesized,twisniewski,sgalich,mak,kershaw,sclements,pbz,robwu,geckoview-reviewers,amejiamarmol
Differential Revision: https://phabricator.services.mozilla.com/D184623
2023-08-01 23:01:02 +00:00
Malte Juergens
05a00d1692 Bug 1720458: Do not isolate https-only-load-insecure by origin attributes r=fluent-reviewers,settings-reviewers,flod,ckerschb,Gijs
Do not isolate `https-only-load-insecure` by origin attributes. This way the HTTPS-Only exceptions will behave similar to the `cookie` permission. This means that exceptions set in the system settings will also apply to private windows, but exceptions set in private windows via the identity pane will be reset after closing the browser.

Depends on D182761

Differential Revision: https://phabricator.services.mozilla.com/D183745
2023-07-24 13:31:19 +00:00
Malte Juergens
31665cb4bb Bug 1757297: Only work with http scheme for HTTPS-Only exceptions r=freddyb,settings-reviewers,Gijs
- Update the HTTPS-Only dropdown in the site identity pane to always set exceptions for the http version of the current origin.
- Add new parameter `forcedHTTP` to `gPermissionManager`, in order to only allow origins with a http scheme to be added in the HTTPS-Only section of the settings. This means when a https URL is added as an exeption, it will automatically be converted into a http one.
- Add a migration to convert all existing HTTPS-Only exceptions with a https scheme to a http scheme.
- Update `browser_https_only_exceptions.js` and `browser_identityPopup_HttpsOnlyMode.js` to account for this new behaviour.

Differential Revision: https://phabricator.services.mozilla.com/D182761
2023-07-24 13:31:19 +00:00
Morgan Rae Reschenberg
1bb8233b60 Bug 1628476: Add keyboard navigation pref to allow focus mode changes on macOS r=Jamie,fluent-reviewers,settings-reviewers,flod,mconley
Differential Revision: https://phabricator.services.mozilla.com/D182266
2023-07-17 23:11:41 +00:00
Cristian Tuns
38c979ee94 Backed out changeset 88c664a821cb (bug 1628476) for causing multiple bc failures browser/* CLOSED TREE 2023-07-14 20:34:02 -04:00
Morgan Rae Reschenberg
53af615a49 Bug 1628476: Add keyboard navigation pref to allow focus mode changes on macOS r=Jamie,fluent-reviewers,settings-reviewers,flod,mconley
Differential Revision: https://phabricator.services.mozilla.com/D182266
2023-07-14 23:28:46 +00:00
Mark Banner
0b2d2afdea Bug 1837176 - Convert imports of httpd.js to consume the ES module directly. r=necko-reviewers,webcompat-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,robwu,issammani,bytesized,pbz,valentin
Differential Revision: https://phabricator.services.mozilla.com/D181159
2023-07-12 13:38:34 +00:00
Malte Juergens
87c5e45f0f Bug 1835792: Enable HTTPS-Only exception button if HTTPS-First is enabled r=freddyb,settings-reviewers
This should be seen as a temporary change since the UI probably needs a slightly bigger update if it should manage both HTTPS-Only and HTTPS-First.

Depends on D179424

Differential Revision: https://phabricator.services.mozilla.com/D179425
2023-07-11 14:27:38 +00:00
Sergey Galich
fa8b0690ca Bug 1838872 - removing extensions.formautofill.creditCards.available pref r=settings-reviewers,credential-management-reviewers,mconley,issammani
Differential Revision: https://phabricator.services.mozilla.com/D182693
2023-07-05 22:46:44 +00:00
Katherine Patenio
130ce23c4c Bug 1834831 - update imports of browser/modules JSMs r=webdriver-reviewers,perftest-reviewers,zeid,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,whimboo,mhowell,sgalich,robwu,sparky,Standard8,mconley,dao,sclements
Differential Revision: https://phabricator.services.mozilla.com/D179169
2023-06-19 18:44:48 +00:00
Cristian Tuns
110cfccc1f Backed out 2 changesets (bug 1834831) for causing node failures with checkBundles CLOSED TREE
Backed out changeset 58b351a155c8 (bug 1834831)
Backed out changeset 1acbb5231d14 (bug 1834831)
2023-06-19 13:22:35 -04:00
Katherine Patenio
a73f6ec769 Bug 1834831 - update imports of browser/modules JSMs r=webdriver-reviewers,perftest-reviewers,zeid,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,whimboo,mhowell,sgalich,robwu,sparky,Standard8,mconley,dao,sclements
Differential Revision: https://phabricator.services.mozilla.com/D179169
2023-06-19 16:46:18 +00:00
Gijs Kruitbosch
75d012d803 Bug 1831259 - prevent initialization re-entrancy for preference panes, r=mconley
This should fix the issue experienced by the reporter. It also pushes the
re-entrancy guard into the the 'init' method we define on gCategoryInits
objects, and removes the asynchronicity which was only there for fluent's sake.

Instead of blocking the insertion on fluent, which meant that for the in-page
find functionality we do N initializations and fluent passes, we make each of
the 2 consumers responsible for checking translation has completed. This means
find in page now just has 1 fluent pass, instead of N passes for N categories.
This should speed up the find in page initialization, and means initialization
of a category is now sync instead of async.

Differential Revision: https://phabricator.services.mozilla.com/D178232
2023-06-06 12:16:38 +00:00
Mark Banner
5d59c7aecd Bug 1824613 - Convert consumers of toolkit/mozapps/extensions/ to import ES modules directly. r=extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,sync-reviewers,sgalich,bytesized,robwu,skhamis
Depends on D179819

Differential Revision: https://phabricator.services.mozilla.com/D179820
2023-06-02 20:00:35 +00:00
Butkovits Atila
87ba454e5c Backed out changeset c34f2e337a31 (bug 1831259) for causing Bug 1836325 and Bug 1836332. a=backout 2023-06-01 21:44:15 +03:00
Gijs Kruitbosch
59070c7a5d Bug 1831259 - prevent initialization re-entrancy for preference panes, r=mconley
This should fix the issue experienced by the reporter. It also pushes the
re-entrancy guard into the the 'init' method we define on gCategoryInits
objects, and removes the asynchronicity which was only there for fluent's sake.

Instead of blocking the insertion on fluent, which meant that for the in-page
find functionality we do N initializations and fluent passes, we make each of
the 2 consumers responsible for checking translation has completed. This means
find in page now just has 1 fluent pass, instead of N passes for N categories.
This should speed up the find in page initialization, and means initialization
of a category is now sync instead of async.

Differential Revision: https://phabricator.services.mozilla.com/D178232
2023-05-31 22:24:26 +00:00
Saira Abdulla
9691ab4a5f Bug 1824612 - Convert consumers of toolkit/components/extensions to ES modules. r=robwu,webcompat-reviewers,geckoview-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,sgalich,valentin,nalexander,mconley,m_kato
Depends on D175553

Differential Revision: https://phabricator.services.mozilla.com/D176005
2023-05-31 15:27:03 +00:00
Iulian Moraru
90b739a400 Backed out 2 changesets (bug 1824612) for causing dt failures on browser_dbg-features-source-tree.js. CLOSED TREE
Backed out changeset c3f38adc818e (bug 1824612)
Backed out changeset 58ba8bb3398a (bug 1824612)
2023-05-31 17:28:16 +03:00
Gregory Pappas
941d7766f8 Bug 1822864 - Remove browser.download.improvements_to_download_panel pref r=Gijs,settings-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D179300
2023-05-31 10:29:37 +00:00
Saira Abdulla
2e8db5969a Bug 1824612 - Convert consumers of toolkit/components/extensions to ES modules. r=robwu,webcompat-reviewers,geckoview-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,sgalich,valentin,nalexander,mconley,m_kato
Depends on D175553

Differential Revision: https://phabricator.services.mozilla.com/D176005
2023-05-31 10:21:37 +00:00
Cristian Tuns
2a18c8252e Backed out changeset af6ffefb5572 (bug 1831259) for causing bc failures in browser_aboutPrefs_fc_check_cantApply.js CLOSED TREE 2023-05-30 23:53:55 -04:00
Gijs Kruitbosch
aa7c4e888e Bug 1831259 - prevent initialization re-entrancy for preference panes, r=mconley
This should fix the issue experienced by the reporter. It also pushes the
re-entrancy guard into the the 'init' method we define on gCategoryInits
objects, and removes the asynchronicity which was only there for fluent's sake.

Instead of blocking the insertion on fluent, which meant that for the in-page
find functionality we do N initializations and fluent passes, we make each of
the 2 consumers responsible for checking translation has completed. This means
find in page now just has 1 fluent pass, instead of N passes for N categories.
This should speed up the find in page initialization, and means initialization
of a category is now sync instead of async.

Differential Revision: https://phabricator.services.mozilla.com/D178232
2023-05-30 22:15:27 +00:00
Mark Banner
8b4f426ecf Bug 1834204 - Update more consumers to import ES modules directly. r=kpatenio,geckoview-reviewers,whimboo,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D178590
2023-05-26 11:36:33 +00:00
Sergey Galich
d79aecafe1 Bug 1829427 - Update Relay integration checkbox in Settings r=credential-management-reviewers,fluent-reviewers,settings-reviewers,flod,jneuberger,mconley
Differential Revision: https://phabricator.services.mozilla.com/D176192
2023-05-25 13:22:26 +00:00
Noemi Erli
65bf71c0c0 Backed out changeset db1ae5bf8516 (bug 1831259) for causing failures in browser_UsageTelemetry_interaction.js CLOSED TREE
browser/components/preferences/preferences.js HG: changed browser/components/preferences/tests/browser_experimental_features_filter.js
2023-05-23 19:10:18 +03:00
Gijs Kruitbosch
3c8d3721dd Bug 1831259 - prevent initialization re-entrancy for preference panes, r=mconley
This should fix the issue experienced by the reporter. It also pushes the
re-entrancy guard into the the 'init' method we define on gCategoryInits
objects, and removes the asynchronicity which was only there for fluent's sake.

Instead of blocking the insertion on fluent, which meant that for the in-page
find functionality we do N initializations and fluent passes, we make each of
the 2 consumers responsible for checking translation has completed. This means
find in page now just has 1 fluent pass, instead of N passes for N categories.
This should speed up the find in page initialization, and means initialization
of a category is now sync instead of async.

Differential Revision: https://phabricator.services.mozilla.com/D178232
2023-05-23 13:16:18 +00:00
Mark Banner
130a655906 Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu
Differential Revision: https://phabricator.services.mozilla.com/D177027
2023-05-20 12:26:53 +00:00
Mark Banner
8219a5c503 Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish
Differential Revision: https://phabricator.services.mozilla.com/D177025
2023-05-20 12:26:49 +00:00
Tim Huang
b97e2b7429 Bug 1830054 - Disable Email tracking protection if tracking protection is disabled on the ETP Custom UI. r=anti-tracking-reviewers,pbz
We surface the email tracking protection using the existing tracking
protection UI on the protection panel, but we don't disable email
tracking protection if tracking protection is disabled. So, users will
still see blocked trackers if tracking protection is disabled for
private windows. To provide a way to disable email tracking protection
in private windows, we also use the existing tracking protection checkbox
UI to disable the email tracking protection.

This patch implements that disabling the tracking protection via the
tracking protection checkbox also disables email tracking protection.

Differential Revision: https://phabricator.services.mozilla.com/D177520
2023-05-16 07:06:01 +00:00
Harshit Sohaney
558059175a Bug 1826340 - Removed level2 PBM from ETP strict as it is now set as true by default pref from ETP strict. r=anti-tracking-reviewers,pbz
Differential Revision: https://phabricator.services.mozilla.com/D177308
2023-05-15 13:43:02 +00:00
Valentin Gosu
ed35510019 Bug 1829905 - Add tests for DoH UI settings telemetry r=settings-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D177256
2023-05-07 20:54:33 +00:00
Greg Tatum
cf91f08437 Bug 1820259 - Implement the translation language download preferences; r=nordzilla,flod,mconley
Differential Revision: https://phabricator.services.mozilla.com/D176189
2023-04-26 19:12:17 +00:00
Valentin Gosu
2e188c9fa3 Bug 1826749 - DoH Settings UI tests r=Gijs,settings-reviewers
This adapts previous test cases from the connection UI to the privacy UI.

Additional improvements:
- Set the ROLLOUT_URI_Pref to empty string to avoid DoHConfig reset setting it to undefined.
- Always set network.trr.uri even if it matches the default_provider_uri if it's a user choice.
- If the value of network.trr.uri doesn't match any of the providers, then set custom_uri so
  it shows up in the input text field. This can happen when it's set by a policy.

Differential Revision: https://phabricator.services.mozilla.com/D174876
2023-04-16 19:52:18 +00:00
Ebilite Uchenna
8c931cb313 Bug 1824611 - Convert consumers of toolkit/components/passwordmgr to import ES modules directly. r=Standard8,credential-management-reviewers,settings-reviewers,fxview-reviewers,sclements,sgalich,geckoview-reviewers,owlish
Differential Revision: https://phabricator.services.mozilla.com/D174446
2023-04-11 19:06:24 +00:00
Valentin Gosu
13498a03fe Bug 1610741 - Remove old DoH UI r=Gijs,settings-reviewers,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D173940
2023-04-11 09:57:28 +00:00
Cosmin Sabou
904ab94a50 Backed out 7 changesets (bug 1816948, bug 1596847, bug 1610741) for causing build bustages on TRRService.cpp. CLOSED TREE
Backed out changeset a7341379f263 (bug 1610741)
Backed out changeset 5689f1b0d016 (bug 1816948)
Backed out changeset 7746c3a39e92 (bug 1596847)
Backed out changeset 8e85f984f46c (bug 1610741)
Backed out changeset b9b738076d55 (bug 1610741)
Backed out changeset 403f22e3a0a0 (bug 1610741)
Backed out changeset 8ec3cfe29b61 (bug 1610741)
2023-04-07 00:45:15 +03:00
Mark Banner
474708c181 Bug 1826702 - Convert PermissionTestUtils to an ES module. r=permissions-reviewers,settings-reviewers,media-playback-reviewers,pbz,padenot
Differential Revision: https://phabricator.services.mozilla.com/D174846
2023-04-06 15:07:56 +00:00
Valentin Gosu
7ee022849f Bug 1610741 - Remove old DoH UI r=Gijs,settings-reviewers,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D173940
2023-04-06 12:57:50 +00:00
Cristian Tuns
456072646e Backed out 7 changesets (bug 1610741, bug 1816948, bug 1596847) for causing xpcshell failures in test_dooh.js CLOSED TREE
Backed out changeset 8596bc4554df (bug 1610741)
Backed out changeset 1a9baaa49d3d (bug 1816948)
Backed out changeset d72b9cdfbb1e (bug 1596847)
Backed out changeset e2e564f584b3 (bug 1610741)
Backed out changeset e9e331ccc7ab (bug 1610741)
Backed out changeset 44218f91e7cf (bug 1610741)
Backed out changeset 6f296319409a (bug 1610741)
2023-04-05 15:14:36 -04:00
Valentin Gosu
524bec08c5 Bug 1610741 - Remove old DoH UI r=Gijs,settings-reviewers,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D173940
2023-04-05 17:13:52 +00:00
CanadaHonk
91709586ba Bug 1801379 - Migrate Sinon.jsm to an ES module r=extension-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,fxview-reviewers,devtools-reviewers,Standard8,nchevobbe,sclements,dimi,mconley,bytesized,robwu
Migrated `testing/modules/Sinon.sys.mjs` to an ES module.

`testing` should now be 100% ESM 🎉

Differential Revision: https://phabricator.services.mozilla.com/D173643
2023-03-29 07:34:10 +00:00
Karl Tomlinson
dce6901df0 Bug 1804352 display current permission value in menulist even when not in available states r=pbz
For speaker permissions, this has the effect of presenting a menulist instead
of a label when a device-specific ALLOW permission is set, providing the
option to the user of changing this to a BLOCK.

A global permission for speaker selection is not currently supported but if it
were implemented and set to BLOCK, then a menulist would be shown for all
sites with permissions set.  It would include at least PROMPT and BLOCK
menuitems.  This change would mean that the menulist selected item can display
"Allowed" when a device-specific ALLOW permission has already been granted
through a selectAudioOutput() prompt.

_permissionsToChange is modified in _removePermissionFromList() so that
permissions changed then deleted are not added by onApplyChanges().

Differential Revision: https://phabricator.services.mozilla.com/D172085
2023-03-21 21:57:11 +00:00
Karl Tomlinson
1ea516e3f4 Bug 1804352 add support for removing double-keyed permissions r=pbz
as are used to allow speaker devices from speaker selection.

Differential Revision: https://phabricator.services.mozilla.com/D170305
2023-03-16 00:32:36 +00:00
Karl Tomlinson
1c4704d106 Bug 1804352 add blocking speaker selection permissions to about:preferences#privacy r=fluent-reviewers,desktop-theme-reviewers,flod,dao,pbz
This patch adds support only for BLOCK permissions because ALLOW permissions
are double-keyed and will be included via a subsequent patch.

Support for a global BLOCK permission is not added here because of
inconsistencies in the way this interacts with device-specific ALLOW
permissions.

Differential Revision: https://phabricator.services.mozilla.com/D170303
2023-03-15 22:07:23 +00:00
Mike Conley
610167bc5a Bug 1820655 - Add a new section to about:preferences to launch the migration wizard. r=jhirsch,fluent-reviewers,flod DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D172324
2023-03-15 00:35:16 +00:00
Butkovits Atila
91f502bbd2 Backed out changeset 5c4677b1ea47 (bug 1820655) for causing failures at browser_open_migration_wizard.js. CLOSED TREE 2023-03-14 05:20:08 +02:00
Mike Conley
f1d3ef9dd0 Bug 1820655 - Add a new section to about:preferences to launch the migration wizard. r=jhirsch,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D172324
2023-03-14 01:59:01 +00:00
Butkovits Atila
640d009e7b Backed out changeset 21ac89d8a165 (bug 1820655) for causing Gecko Decision failure. CLOSED TREE 2023-03-14 03:20:05 +02:00
Mike Conley
3eb16d3b85 Bug 1820655 - Add a new section to about:preferences to launch the migration wizard. r=jhirsch,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D172324
2023-03-14 01:06:42 +00:00
Masatoshi Kimura
409be9d4ba Bug 1821796 - Add the handle internally option for internal types even if the type is not pre-listed. r=Gijs,settings-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D172322
2023-03-13 19:08:50 +00:00