nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity
851592 commits 1 branch 98 tags 6.4 GiB
Commit graph

2772 commits

Author SHA1 Message Date
Drew Willcoxon
7121a1965b Bug 1846765 - Avoid using -moz-bool-pref CSS for experiments. r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D185204
 2023-08-03 01:06:02 +00:00
Sean Feng
173c3a000a Bug 1811129 - Update quicksuggestOnboarding.html to reflect the latest <dialog> focusing algorithm changes r=adw 
Given the <dialog> itself becomes focusable, the expected focusing
order has been changed.

Differential Revision: https://phabricator.services.mozilla.com/D185096
 2023-08-02 13:35:47 +00:00
Gregory Pappas
8a35d5cf5f Bug 1845311 - [Part 2] Use ChromeUtils.defineLazyGetter in more places r=arai,webcompat-reviewers,necko-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sync-reviewers,anti-tracking-reviewers,tabbrowser-reviewers,bytesized,twisniewski,sgalich,mak,kershaw,sclements,pbz,robwu,geckoview-reviewers,amejiamarmol 
Differential Revision: https://phabricator.services.mozilla.com/D184623
 2023-08-01 23:01:02 +00:00
Karandeep
985fcbfa2b Bug 1846028 - Add .featureGate pref to clipboard suggestion. r=mak 
Depends on D184502

Differential Revision: https://phabricator.services.mozilla.com/D184934
 2023-08-01 11:51:59 +00:00
Karandeep
5ddb360057 Bug 1842236 - Limit for displaying clipboard result in URL bar suggestions. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D184502
 2023-08-01 11:51:59 +00:00
Karandeep
cac61c91ab Bug 1842234 - Dismiss clipboard result through result menu button. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D183748
 2023-08-01 11:51:59 +00:00
Karandeep
1643d58b56 Bug 1842230 - URL bar suggested action for paste when clipboard contains valid URL. r=mak,flod 
Differential Revision: https://phabricator.services.mozilla.com/D183747
 2023-08-01 11:51:59 +00:00
Drew Willcoxon
86f9df5b57 Bug 1846085 - Treat "how to" as one word when matching prefixes for Pocket suggestions. r=daisuke 
Differential Revision: https://phabricator.services.mozilla.com/D184867
 2023-07-31 23:31:09 +00:00
Daisuke Akatsuka
93ecf8da8d Bug 1844706: Add and use new MDN icon for MDN Suggestions r=desktop-theme-reviewers,adw,dao 
Depends on D184075

Differential Revision: https://phabricator.services.mozilla.com/D184786
 2023-07-30 21:07:01 +00:00
Narcis Beleuzu
a7bc20e76f Backed out changeset 783d744d047b (bug 1844706) for xpcshell failure on test_quicksuggest_mdn.js 2023-07-28 23:53:57 +03:00
Daisuke Akatsuka
4ff93d1005 Bug 1844706: Add and use new MDN icon for MDN Suggestions r=desktop-theme-reviewers,adw,dao 
Depends on D184075

Differential Revision: https://phabricator.services.mozilla.com/D184786
 2023-07-28 19:56:25 +00:00
Daisuke Akatsuka
eb41625b1c Bug 1844495: Implement base of MDN Suggestions r=adw,dao 
Differential Revision: https://phabricator.services.mozilla.com/D184075
 2023-07-28 00:15:27 +00:00
Iulian Moraru
d42f44b7fa Backed out changeset 058d7fc0c711 (bug 1844495) for causing bc failures on browser_quicksuggest_mdn.js. CLOSED TREE 2023-07-28 02:05:53 +03:00
Daisuke Akatsuka
931bbe3df1 Bug 1844495: Implement base of MDN Suggestions r=adw,dao 
Differential Revision: https://phabricator.services.mozilla.com/D184075
 2023-07-27 20:33:57 +00:00
Niklas Baumgardner
c0a6a9f5c3 Bug 1844171 - Update screenshots tests. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D183912
 2023-07-27 16:15:03 +00:00
Marc Seibert
663d931818 Bug 1836962 - Only trim URL if directionality doesn't change to RTL.r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D184629
 2023-07-27 11:46:46 +00:00
Gregory Pappas
3eac12bbd7 Bug 1845311 - Use ChromeUtils.defineLazyGetter in more places r=arai,webdriver-reviewers,geckoview-reviewers,extension-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,anti-tracking-reviewers,sessionstore-reviewers,pbz,joschmidt,robwu,issammani,bytesized,owlish,dao 
Differential Revision: https://phabricator.services.mozilla.com/D184481
 2023-07-26 16:28:11 +00:00
Chris H-C
c57cc06926 Bug 1845400 - reporting_url should be sent on 'quick-suggest' ping r=nanj 
Differential Revision: https://phabricator.services.mozilla.com/D184510
 2023-07-25 20:52:31 +00:00
Marc Seibert
8af4489012 Bug 1704420 - Test.r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D184456
 2023-07-25 15:14:23 +00:00
James Teow
b6b8ff043e Bug 1842766 - r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D183753
 2023-07-25 14:39:26 +00:00
Dale Harvey
89f4a029b6 Bug 1843386 - Dont deduplicate rich suggestions. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D183881
 2023-07-21 08:37:25 +00:00
Daisuke Akatsuka
eb2f7932de Bug 1844266: Check enabling the feature after async processing in onRemoteSettingsSync r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D183951
 2023-07-19 22:27:13 +00:00
Marco Bonardo
1fa445c504 Bug 1843100 - Address Bar view should not try to reuse rows from different providers. r=daleharvey 
Different providers have different time characteristics, reusing results across
providers may thus cause flicker of results coming from the fastest ones.

Differential Revision: https://phabricator.services.mozilla.com/D183507
 2023-07-19 07:43:40 +00:00
Marc Seibert
c1d53aee3f Bug 1416881 - Entering characters with character/accent marks on macOS doesn't remove the autofilled selected part.r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D182664
 2023-07-18 08:00:38 +00:00
Daisuke Akatsuka
5de700b9b3 Bug 1843186: Append UTM parameter to Pocket suggestions r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D183455
 2023-07-13 21:20:01 +00:00
Marco Bonardo
52c561897c Bug 1843074 - SkippableTimer.done should be set immediately. r=scunnane 
Invoking fire() in a loop may invoke the callback multiple times because done
is not set immediately.

Differential Revision: https://phabricator.services.mozilla.com/D183412
 2023-07-13 09:25:37 +00:00
Mark Banner
0b2d2afdea Bug 1837176 - Convert imports of httpd.js to consume the ES module directly. r=necko-reviewers,webcompat-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,robwu,issammani,bytesized,pbz,valentin 
Differential Revision: https://phabricator.services.mozilla.com/D181159
 2023-07-12 13:38:34 +00:00
Mark Banner
182b6db303 Bug 1792824 - Convert ObjectUtils.jsm to an ES module. r=barret,necko-reviewers,devtools-reviewers,kershaw 
Depends on D183308

Differential Revision: https://phabricator.services.mozilla.com/D183309
 2023-07-12 08:07:23 +00:00
Hannah Peuckmann
b91be58abf Bug 1836248 - Update the strip-on-share strings from the prototype for the v1. r=pbz,bolsson 
I got the strings from Martin Balfanz, he worked on them with the content-team. They also requested to have a localization note added.

The strings for the prototype have been added in [D174253](https://phabricator.services.mozilla.com/D174253) and [D174251](https://phabricator.services.mozilla.com/D174251)

Differential Revision: https://phabricator.services.mozilla.com/D183245
 2023-07-12 07:34:16 +00:00
Daisuke Akatsuka
0b06742055 Bug 1838743: Avoid firing paste event when middle-clicking on not editor in Chrome document r=masayuki,dao 
Differential Revision: https://phabricator.services.mozilla.com/D182880
 2023-07-12 01:31:29 +00:00
Marco Bonardo
1dbce16a75 Bug 1842381 - The address bar chunk timer is not firing early when all heuristic providers are done. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D183164
 2023-07-11 08:27:37 +00:00
Marco Bonardo
8259e0e3d5 Bug 1816572 - Allow more time for Address Bar heuristic results to be returned. r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D181128
 2023-07-07 15:48:34 +00:00
Marco Bonardo
73e7350295 Bug 1827770 - Remove isPrivate argument from onEngagement() since it can be inferred. r=daleharvey 
We can't use context.isPrivate because sometimes context is undefined.
I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1841762 about that.

Differential Revision: https://phabricator.services.mozilla.com/D182772
 2023-07-07 10:01:50 +00:00
Marco Bonardo
9804a5187b Bug 1827770 - Remove QueryContext.view and pass the controller to onEngagement() instead. r=daleharvey 
Differential Revision: https://phabricator.services.mozilla.com/D182771
 2023-07-07 10:01:50 +00:00
Norisz Fay
8c7626e3a4 Backed out changeset 909fc50c54a1 (bug 1838743) for causing failures on browser_947914_button_paste.js CLOSED TREE 2023-07-07 05:57:07 +03:00
Daisuke Akatsuka
3b22c5aec2 Bug 1838743: Ignore paste event if the event was fired from not urlbar r=masayuki,dao 
Differential Revision: https://phabricator.services.mozilla.com/D182880
 2023-07-07 00:43:34 +00:00
Daisuke Akatsuka
396a58236f Bug 1841877: Hide 'Show less frequently' for high confidence matches r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D182822
 2023-07-07 00:31:45 +00:00
Drew Willcoxon
85edb0cf2a Bug 1841409 - Create new row content as necessary to make sure the Feedback button is shown. r=dao 
Depends on D182537

Differential Revision: https://phabricator.services.mozilla.com/D182625
 2023-07-05 18:24:57 +00:00
Stanca Serban
60bb6b1b9f Backed out changeset 5cf32b0ba18a (bug 1841409) for causing mochitests failures. CLOSED TREE 2023-07-06 01:30:56 +03:00
Drew Willcoxon
e3d7e9a498 Bug 1841409 - Create new row content as necessary to make sure the Feedback button is shown. r=dao 
Depends on D182537

Differential Revision: https://phabricator.services.mozilla.com/D182625
 2023-07-05 18:24:57 +00:00
Drew Willcoxon
41dcc16398 Bug 1841447 - Change the "Top pick" label to "Recommended reads" for Pocket suggestions. r=daisuke,fluent-reviewers,flod 
Depends on D182634

Differential Revision: https://phabricator.services.mozilla.com/D182635
 2023-07-05 15:47:25 +00:00
Drew Willcoxon
036b13835f Bug 1841446 - Update the "Not interested" command to disable Pocket suggestions. r=daisuke,fluent-reviewers,flod 
Depends on D182606

Differential Revision: https://phabricator.services.mozilla.com/D182634
 2023-07-05 15:47:24 +00:00
Drew Willcoxon
6ab4467c1a Bug 1837097 - Implement "Show less frequently" behavior for Pocket suggestions. r=daisuke 
Same as addon suggestions.

Depends on D182632

Differential Revision: https://phabricator.services.mozilla.com/D182606
 2023-07-05 15:47:24 +00:00
Drew Willcoxon
5a79fd667d Bug 1841442 - Finish integrating Pocket suggestions with rich suggestions. r=daisuke,fluent-reviewers,flod 
* Add the "Pocket - Related to {keyword}" bottom text
* Don't show the description for non-top-picks
* Make sure the URL is always shown

[Reference Figma](https://www.figma.com/file/3m1GVo9lejjorUZrPSn7VW/Pocket-collections-suggestions?type=design&node-id=2616%3A9002&mode=design&t=0BKzoltXIvYTpPi6-1) (see "CD Work area" in the left sidebar, then the "V4 - Final" group)

Depends on D182537

Differential Revision: https://phabricator.services.mozilla.com/D182632
 2023-07-05 15:47:24 +00:00
Drew Willcoxon
ce2ff6f009 Bug 1841408 - Unify rich suggestions, best match, Firefox Suggest sponsored results, and Pocket Suggestions. r=dao,daleharvey 
This does a few things:

* Unify the view implementations of rich suggestions, Firefox Suggest sponsored
  results, and best match. I did this by using the best match implementation
  and extending it to rich suggestions and Suggest sponsored.
* Use the unified implementation for Pocket suggestions too.
* Add a bottom-text concept since Pocket suggestions shown as top picks need to
  show both a description and some text below it. (The actual bottom text per
  result is added in D182632 since I didn't want to make this patch bigger than
  necessary)

I have a couple motivations for these changes:

* I'm implementing Pocket suggestions, which need to show some text below the
  suggestion title as well as the URL. I was going to just use the Firefox
  Suggest sponsored approach, where the action text is wrapped below the title,
  but that doesn't work because it can't show both the wrapped action text and
  the URL.
* IMO we should use rich suggestions as the basis for all rows going forward,
  i.e., unify the different row implementations around rich suggestions.

The reason I chose the best match implementation instead of the rich suggestions
implementation is because the grid-based approach of rich suggestions doesn't
work well when the URL also needs to be shown. The URL should be
baseline-aligned with the row title, which isn't easy to do when the URL is
outside the grid. The rich suggestions implementation also doesn't wrap the URL.

Other details:

* The `rich-suggestion=no-icon` attribute value is only used for styling, so we
  can replace it with `@supports -moz-bool-pref()`. That lets us make the
  `rich-suggestion` attribute a simple boolean.
* I kept the `isBestMatch` property for results since
  `searchEngagementTelemetryGroup()` uses it to return "top_pick", and the view
  also uses it to create the "Top pick" row/group label. It still has semantic
  meaning so I think that's OK. It's no longer used by the view to create
  different DOM or styling.
* Move `isRichSuggestion` from the payload to the result itself, since it's no
  longer used for only one type of result. It's like `isBestMatch`, which is
  also on the result.
* Add `richSuggestionIconSize` to the result too. The best match icon size
  is 52. The Pocket best match icon size is 24 (but will have added padding and
  a background color to make it appear 52px). IMO this is better than adding
  rules for each type of suggestion to the CSS. It's cleaner and also indicates
  what the "standard" icon sizes are.

Depends on D182580

Differential Revision: https://phabricator.services.mozilla.com/D182537
 2023-07-05 15:47:24 +00:00
Drew Willcoxon
e574c0c557 Bug 1841553 - JsonSchemaValidator: Support "additionalProperties" in schema objects and rename "allowExtraProperties" to "allowAdditionalProperties". r=mossop 
Differential Revision: https://phabricator.services.mozilla.com/D182683
 2023-07-05 15:47:23 +00:00
Dale Harvey
a32f3a2750 Bug 1796805 - Only update quickactions searchmode layout on search. r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D182330
 2023-07-05 09:23:11 +00:00
Butkovits Atila
1f7b14ac8e Backed out changeset 986f4f6398a4 (bug 1816572) for causing failures at browser_search_bookmarks.js. CLOSED TREE 2023-07-04 16:29:04 +03:00
Marco Bonardo
834caa9a69 Bug 1816572 - Allow more time for Address Bar heuristic results to be returned. r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D181128
 2023-07-04 09:28:46 +00:00
Drew Willcoxon
5714ea5aad Bug 1841295 - Update PocketSuggestions for the final suggestions schema and implement the desired matching behavior. r=daisuke 
Each suggestion has "low" and "high confidence" keywords. When a high confidence
keyword is matched, the suggestion should be shown as a top pick, and otherwise
it should be shown as a normal Suggest result. High confidence keywords must be
matched in full, but low confidence keywords can be matched with prefixes
starting at the first word.

The low confidence matching behavior is the same as addon suggestions, so I
factored out that function into a new helper defined on `SuggestionsMap`.

I added a `full_keyword` property to the suggestions. It's not used yet but
we'll use it when we implement the final UI, which needs to show the full
keyword.

Differential Revision: https://phabricator.services.mozilla.com/D182580
 2023-07-04 02:28:21 +00:00