Commit graph

243 commits

Author SHA1 Message Date
Dave Townsend
7e86f176b1 Bug 1864896: Autofix unused function arguments (browser/components/preferences). r=settings-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D202952
2024-03-01 18:28:32 +00:00
Natalia Csoregi
96b1b25a39 Backed out 2 changesets (bug 1864896) for causing node failures. CLOSED TREE
Backed out changeset adba0b352699 (bug 1864896)
Backed out changeset 153146ce081c (bug 1864896)
2024-03-01 18:25:05 +02:00
Dave Townsend
d8c28c253d Bug 1864896: Autofix unused function arguments (browser/components/preferences). r=settings-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D202952
2024-03-01 15:20:18 +00:00
Iulian Moraru
97fd2dad96 Backed out 5 changesets (bug 1864896) for causing newtab failures related to bundles. CLOSED TREE
Backed out changeset 2cd1cc279f99 (bug 1864896)
Backed out changeset e48d6928bdcb (bug 1864896)
Backed out changeset 1abbcaf91693 (bug 1864896)
Backed out changeset 06a05e5257d5 (bug 1864896)
Backed out changeset b1955ae3e9e2 (bug 1864896)
2024-03-01 12:58:03 +02:00
Dave Townsend
716a972585 Bug 1864896: Autofix unused function arguments (browser/components/preferences). r=settings-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D202952
2024-03-01 10:10:09 +00:00
Bojidar Marinov
c7286a75c7 Bug 1839845 - Add about:settings as alias of about:preferences. r=Gijs,settings-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D202594
2024-02-29 10:09:58 +00:00
Gregory Pappas
27838882b1 Bug 1878401 - part 2 - Update nsIFilePicker users in browser/ to pass BrowsingContext to init r=extension-reviewers,settings-reviewers,credential-management-reviewers,Gijs,sgalich,migration-reviewers,mconley,robwu
Depends on D200546

Differential Revision: https://phabricator.services.mozilla.com/D200547
2024-02-28 21:29:37 +00:00
Sandor Molnar
3951121cc6 Backed out 8 changesets (bug 1878401, bug 1879041) for causing build bustages on widget/nsBaseFilePicker.cpp CLOSED TREE
Backed out changeset 2e2b8df3bdd6 (bug 1879041)
Backed out changeset 6d6952f9df2c (bug 1878401)
Backed out changeset 30b5bb590d3e (bug 1878401)
Backed out changeset 9a4b830334b9 (bug 1878401)
Backed out changeset 3c3d67f1fcb7 (bug 1878401)
Backed out changeset c83ba4026822 (bug 1878401)
Backed out changeset 6bcb670ce475 (bug 1878401)
Backed out changeset f263b196df96 (bug 1878401)
2024-02-28 17:56:48 +02:00
Gregory Pappas
67cc3e9258 Bug 1878401 - part 2 - Update nsIFilePicker users in browser/ to pass BrowsingContext to init r=extension-reviewers,settings-reviewers,credential-management-reviewers,Gijs,sgalich,migration-reviewers,mconley,robwu
Depends on D200546

Differential Revision: https://phabricator.services.mozilla.com/D200547
2024-02-28 15:07:44 +00:00
Morgan Rae Reschenberg
dd81432c7e Bug 1864445: Add text zoom only warning r=dholbert,fluent-reviewers,desktop-theme-reviewers,dao,mconley,flod
Differential Revision: https://phabricator.services.mozilla.com/D196116
2024-02-08 01:44:42 +00:00
Meera Murthy
c381da7159 Bug 1869830 - [translations] Add a page for Translation Setting Preferences. r=nordzilla,fluent-reviewers,settings-reviewers,desktop-theme-reviewers,translations-reviewers,Gijs,bolsson,dao
Differential Revision: https://phabricator.services.mozilla.com/D197048
2024-01-22 14:19:25 +00:00
DJ
2c25cf5feb Bug 1783521 - add card preview when inactive tab hovered. r=settings-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,fluent-reviewers,flod,dao,mconley
Differential Revision: https://phabricator.services.mozilla.com/D184260
2024-01-12 19:29:18 +00:00
Anna Yeddi
6086fd330f Bug 1872739 - Provide an accessible name to Applications richlistbox's actionsMenu comboboxes in Settings UI. r=settings-reviewers,mossop
The [<menulist> with class `actionsMenu`](https://searchfox.org/mozilla-central/rev/0f39860036f9b6339e65d485aeb6b6be73d9dbda/browser/components/preferences/main.js#3737) that opens when a control under the `Action` header of the `Applications` richlistbox on `Settings` > `General` > `Files and Applications` is activated is not labelled. The combobox pattern is expected to provide an accessible name for the control even when the listbox opened has an accessible name.

We could refer to [the `#actionColumn` container](https://searchfox.org/mozilla-central/rev/0f39860036f9b6339e65d485aeb6b6be73d9dbda/browser/components/preferences/main.inc.xhtml#452-454) with `aria-labelledby` to ensure the combobox is labeled and the purpose of opened list of options is communicated to an assistive technology user.

Since some a11y_checks will be passing with this change, we are also removing the `fail-if` notations from the appropriate test files in the Settings UI manifest.

Differential Revision: https://phabricator.services.mozilla.com/D197535
2024-01-03 14:36:40 +00:00
Javier Rueda
2f53830863 Bug 1461755 - Remove app.update.service.enabled from settings UI. r=settings-reviewers,mossop
Differential Revision: https://phabricator.services.mozilla.com/D197340
2024-01-02 13:31:30 +00:00
Hanna Jones
b502751459 Bug 1869827 - Fix click listeners for Language and Appearance links in about:preferences r=settings-reviewers,Gijs
This patch moves the event click event listeners off of the nested DOM elements to a common ancestor.

I was looking around but didn't see related tests - happy to add coverage here or as part of a follow up bug.

Differential Revision: https://phabricator.services.mozilla.com/D196343
2023-12-21 17:43:44 +00:00
Narcis Beleuzu
11a7de2215 Backed out changeset fe2ffeac3ec2 (bug 1783521) for marionette failure on test_restore_manually.py . CLOSED TREE 2023-12-20 21:20:39 +02:00
DJ
d9aae7c836 Bug 1783521 - add card preview when inactive tab hovered. r=settings-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,fluent-reviewers,flod,dao,mconley
Differential Revision: https://phabricator.services.mozilla.com/D184260
2023-12-20 15:56:51 +00:00
Nipun Shukla
b6b703dee7 Bug 1860271 - Resolved launch on login checkbox and infobar bugs when user created Startup shortcut exists r=nalexander,settings-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D191763
2023-12-12 00:22:08 +00:00
Sandor Molnar
580c448874 Backed out changeset 677c3005fd69 (bug 1860271) for causing node newtab failures at browser/components/newtab CLOSED TREE 2023-12-11 23:31:08 +02:00
Nipun Shukla
954e579287 Bug 1860271 - Resolved launch on login checkbox and infobar bugs when user created Startup shortcut exists r=nalexander,settings-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D191763
2023-12-11 20:59:45 +00:00
Eemeli Aro
94b1ab321c Bug 1814969: Migrate ContextualIdentityService strings to Fluent r=geckoview-reviewers,fluent-reviewers,mconley,owlish,flod
This includes a containers.json version increment and the necessary migration,
as the StringBundle identifiers are replaced with a Fluent reference.

As it's not possible to filter the attributes that are applied with DOM localization,
the code in utilityOverlay.js is a little clumsy. The non-acceskey versions are needed
due to bug 1297738, i.e. the long-press menu available from the tab bar down arrow.

Previously, the "Manage containers" menu item and its accesskey were defined in two places.
These are here combined into one.

Differential Revision: https://phabricator.services.mozilla.com/D194510
2023-12-04 13:09:15 +00:00
Michael Hughes
be184998f5 Bug 1863980 - [msix] Make ShellService.setDefaultBrowser async. r=nalexander,mconley,dmose,omc-reviewers
This commit includes the changes to call into the new asynchronous code to set the browser as default, using powershell.

While here, we add more logging to this interaction to allow easier
debugging with QA.

Differential Revision: https://phabricator.services.mozilla.com/D194949
2023-12-01 20:07:08 +00:00
Cosmin Sabou
12fba69a84 Backed out 2 changesets (bug 1801954, bug 1863980) for bc failures on browser_setDefaultBrowser.js. CLOSED TREE
Backed out changeset b96506a6d950 (bug 1801954)
Backed out changeset 306a649fcc00 (bug 1863980)
2023-12-01 02:34:26 +02:00
Michael Hughes
0ff75af53b Bug 1863980 - [msix] Make ShellService.setDefaultBrowser async. r=nalexander,mconley,dmose,omc-reviewers
This commit includes the changes to call into the new asynchronous code to set the browser as default, using powershell.

While here, we add more logging to this interaction to allow easier
debugging with QA.

Differential Revision: https://phabricator.services.mozilla.com/D194949
2023-11-30 22:22:16 +00:00
Emilio Cobos Álvarez
8acfbe4ba0 Bug 1664278 - Expose an "always underline links" checkbox in settings. r=morgan,settings-reviewers,fluent-reviewers,Gijs
Might want to run it through UX or so...

Differential Revision: https://phabricator.services.mozilla.com/D190672
2023-11-02 09:43:41 +00:00
ChaseKnowlden
b9bb8aa130 Bug 1859348 - Rename mac to macosx in preferences. r=settings-reviewers,mossop
Differential Revision: https://phabricator.services.mozilla.com/D192165
2023-10-30 07:28:21 +00:00
Olivia Hall
dff4357484 Bug 1857002 - Move getLanguageList from browser to toolkit r=gregtatum,settings-reviewers,mconley
This function is helpful for GeckoView and Translations on Android.
Moving it to toolkit for shared use.

Differential Revision: https://phabricator.services.mozilla.com/D190118
2023-10-16 18:32:51 +00:00
Mike Conley
abe65ca4e2 Bug 1855280 - Remove the ability to switch to the old migration wizard. r=kpatenio,omc-reviewers,settings-reviewers,credential-management-reviewers,negin,aminomancer,mtigley
This removes the pref to re-enable the legacy wizard, and all of the things that used
to read from it.

It also disables the ability to use the legacy wizard from about:welcome with the
aboutWelcomeBehavior feature.

It also removes the closeMigrationWizard utility from BrowserTestUtils, since that
effectively became a thin-wrapper around BrowserTestUtils.removeTab.

Finally, this patch also removes some documentation about the legacy migration wizard,
and tests that specifically check the legacy dialog behaviour.

Differential Revision: https://phabricator.services.mozilla.com/D190716
2023-10-16 18:24:42 +00:00
Nipun Shukla
8a377b9b77 Bug 1849252 - Added UI components and notification for Firefox launch on Windows login r=settings-reviewers,nalexander,omc-reviewers,flod,aminomancer
Depends on D184437

Differential Revision: https://phabricator.services.mozilla.com/D186510
2023-10-06 15:30:24 +00:00
Nipun Shukla
0bb5d4e327 Bug 1843202 - Added Nimbus experiment to Windows autostart on login r=nalexander,mconley
Depends on D183504

Differential Revision: https://phabricator.services.mozilla.com/D184437
2023-10-06 15:30:23 +00:00
Nipun Shukla
b15137b324 Bug 1843202 - Added automatic launch on Windows login based on registry key r=nalexander,settings-reviewers,flod,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D183504
2023-10-06 15:30:23 +00:00
Masatoshi Kimura
bcd7d268c4 Bug 1856104 - Remove useless version checks from JavaScript code. r=Gijs,webcompat-reviewers,settings-reviewers,search-reviewers,Standard8,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D189696
2023-10-02 19:00:07 +00:00
Noemi Erli
26e0b0be0a Backed out 3 changesets (bug 1856187, bug 1856100, bug 1856104) for causing newtab failures
Backed out changeset db28784a1734 (bug 1856187)
Backed out changeset bd11e14dca63 (bug 1856104)
Backed out changeset 2741311b6055 (bug 1856100)
2023-10-02 21:16:25 +03:00
Masatoshi Kimura
7ad48d61dd Bug 1856104 - Remove useless version checks from JavaScript code. r=Gijs,webcompat-reviewers,settings-reviewers,search-reviewers,Standard8,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D189696
2023-10-02 17:36:27 +00:00
Masatoshi Kimura
3e8c44dd66 Bug 1845057 - Remove aClaimAllTypes from setDefaultBrowser. r=nrishel,settings-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D189678
2023-10-02 16:56:42 +00:00
Iulian Moraru
e7ba138c88 Backed out changeset 5f5354d30a45 (bug 1783521) for causing bc failures on browser_ext_windows_create_url.js. CLOSED TREE 2023-09-08 10:21:20 +03:00
DJ
bfd5a700c3 Bug 1783521 - add card preview when inactive tab hovered. r=settings-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,fluent-reviewers,flod,dao,mconley
Differential Revision: https://phabricator.services.mozilla.com/D184260
2023-09-08 02:47:16 +00:00
Gregory Pappas
47a1fa0853 Bug 1846476 - Remove ui.osk.require_win10 pref r=rkraesig,Gijs,settings-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D185199
2023-08-03 19:07:25 +00:00
Gregory Pappas
8a35d5cf5f Bug 1845311 - [Part 2] Use ChromeUtils.defineLazyGetter in more places r=arai,webcompat-reviewers,necko-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sync-reviewers,anti-tracking-reviewers,tabbrowser-reviewers,bytesized,twisniewski,sgalich,mak,kershaw,sclements,pbz,robwu,geckoview-reviewers,amejiamarmol
Differential Revision: https://phabricator.services.mozilla.com/D184623
2023-08-01 23:01:02 +00:00
Greg Tatum
679b17cf8c Bug 1845339 - Use install/remove rather than download/delete for translations settings; r=nordzilla,fluent-reviewers,settings-reviewers,flod,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D184491
2023-07-26 14:59:30 +00:00
Morgan Rae Reschenberg
1bb8233b60 Bug 1628476: Add keyboard navigation pref to allow focus mode changes on macOS r=Jamie,fluent-reviewers,settings-reviewers,flod,mconley
Differential Revision: https://phabricator.services.mozilla.com/D182266
2023-07-17 23:11:41 +00:00
Cristian Tuns
38c979ee94 Backed out changeset 88c664a821cb (bug 1628476) for causing multiple bc failures browser/* CLOSED TREE 2023-07-14 20:34:02 -04:00
Morgan Rae Reschenberg
53af615a49 Bug 1628476: Add keyboard navigation pref to allow focus mode changes on macOS r=Jamie,fluent-reviewers,settings-reviewers,flod,mconley
Differential Revision: https://phabricator.services.mozilla.com/D182266
2023-07-14 23:28:46 +00:00
Mike Conley
6321a063dc Bug 1823489 - Have the migration-wizard element create the panel-list in its shadow root. r=kpatenio,negin,desktop-theme-reviewers,dao
This involves opening the shadow root of the migration wizard, as the panel-list
really isn't designed to handle being embedded within a closed shadow root.

Differential Revision: https://phabricator.services.mozilla.com/D182484
2023-07-10 18:31:19 +00:00
Cristina Horotan
9f7140497c Backed out 2 changesets (bug 1823489) for causing bc failures at browser_multistage_spotlight.js
Backed out changeset 684648252672 (bug 1823489)
Backed out changeset 15437d29bacc (bug 1823489)
2023-07-10 17:47:20 +03:00
Mike Conley
c6172c47a1 Bug 1823489 - Have the migration-wizard element create the panel-list in its shadow root. r=kpatenio,negin,desktop-theme-reviewers,dao
This involves opening the shadow root of the migration wizard, as the panel-list
really isn't designed to handle being embedded within a closed shadow root.

Differential Revision: https://phabricator.services.mozilla.com/D182484
2023-07-10 13:34:04 +00:00
Stanca Serban
31702d1881 Backed out 2 changesets (bug 1823489) for causing multiple bc failures.
Backed out changeset da128472125a (bug 1823489)
Backed out changeset dd5996a4e7d2 (bug 1823489)
2023-07-08 21:11:49 +03:00
Mike Conley
026715310b Bug 1823489 - Have the migration-wizard element create the panel-list in its shadow root. r=kpatenio,negin,desktop-theme-reviewers,dao
This involves opening the shadow root of the migration wizard, as the panel-list
really isn't designed to handle being embedded within a closed shadow root.

Differential Revision: https://phabricator.services.mozilla.com/D182484
2023-07-08 16:18:01 +00:00
Noemi Erli
d9678cc655 Backed out 2 changesets (bug 1823489) for causing failures in test_panel_list_min_width_from_anchor.html
Backed out changeset abe4ae7a4c01 (bug 1823489)
Backed out changeset ccb73c7c777a (bug 1823489)
2023-07-07 19:05:56 +03:00
Mike Conley
068a531975 Bug 1823489 - Have the migration-wizard element create the panel-list in its shadow root. r=kpatenio,negin,desktop-theme-reviewers,dao
This involves opening the shadow root of the migration wizard, as the panel-list
really isn't designed to handle being embedded within a closed shadow root.

Differential Revision: https://phabricator.services.mozilla.com/D182484
2023-07-07 15:19:49 +00:00