Commit graph

88 commits

Author SHA1 Message Date
Michelle Goossens
1a08eedf0c Bug 1693815 - Remove illustrations on error pages r=emalysz
Differential Revision: https://phabricator.services.mozilla.com/D108883
2021-03-24 21:48:48 +00:00
Brindusan Cristian
442d9401c1 Backed out changeset 7c3c130fc7df (bug 1688703) for bc leaks. CLOSED TREE 2021-03-20 03:59:04 +02:00
Dana Keeler
047c44bdd9 Bug 1688703 - reuse certviewer utility files in devtools r=johannh,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D106340
2021-03-19 21:44:16 +00:00
james
16060f0cc4 Bug 1691274 - Use DOM hidden property methods instead of attribute methods in browser/ directory. r=ntim,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D104552
2021-02-13 23:33:51 +00:00
Narcis Beleuzu
ed6880e281 Backed out changeset b3fcb4fcea64 (bug 1691274) for bc failures on browser_pointerlock_warning.js . CLOSED TREE 2021-02-13 21:46:51 +02:00
james
8069ab6165 Bug 1691274 - Use DOM hidden property methods instead of attribute methods in browser/ directory. r=ntim,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D104552
2021-02-13 18:11:18 +00:00
Dana Keeler
103f64a076 Bug 1685552 - move certificate subject alternative name processing for error pages from backend to frontend r=bbeurdouche,johannh,baku
This removes nsIX509Cert.subjectAltNames and reduces potential attack surface
by avoiding parsing subject alternative names in C/C++. It also reduces PSM
reliance on NSS types.

Differential Revision: https://phabricator.services.mozilla.com/D101418
2021-01-14 09:58:03 +00:00
Dana Keeler
f984ac2500 Bug 1681839 - remove nsISecurityReporter and implementation r=johannh,necko-reviewers,dragana
TLS error report sending was disabled by default in bug 1579906. The server
that ingested these reports has been decommissioned as well, so this patch
removes this dead code.

Differential Revision: https://phabricator.services.mozilla.com/D99405
2021-01-07 17:47:47 +00:00
Johann Hofmann
3d58a1fbfb Bug 941354 - Use innerMostURI on about:{neterror,certerror}. r=prathiksha,baku
This is to prevent issues with parsing the correct hostname for displaying and adding
exceptions for urls like view-source:.

Differential Revision: https://phabricator.services.mozilla.com/D94421
2020-10-27 10:55:51 +00:00
Butkovits Atila
9817823a41 Backed out changeset 2edd2bd119ff (bug 941354) for browser-chrome related failures. CLOSED TREE 2020-10-26 23:31:58 +02:00
Johann Hofmann
a735fc4151 Bug 941354 - Use innerMostURI on about:{neterror,certerror}. r=prathiksha,baku
This is to prevent issues with parsing the correct hostname for displaying and adding
exceptions for urls like view-source:.

Differential Revision: https://phabricator.services.mozilla.com/D94421
2020-10-26 20:12:14 +00:00
Noemi Erli
f25dabf9d9 Backed out changeset a96912059b4c (bug 1644719) for causing failures in browser_all_files_referenced.js CLOSED TREE 2020-09-30 19:18:42 +03:00
prathiksha
d76d514ef5 Bug 1644719 - Add basic functionality to display offline support pages when SUMO is unreachable from certerror pages. r=nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D91451
2020-09-30 12:45:10 +00:00
Gijs Kruitbosch
563e70deeb Bug 1524323 - fix advanced error messages for certificate error pages regarding certs broken in several ways, r=prathiksha,April
Differential Revision: https://phabricator.services.mozilla.com/D88135
2020-09-02 01:50:06 +00:00
Tim Huang
26fd85af70 Bug 1647825 - Part 2: Report the XFO and CSP: frame-ancestors error through the telemetry event. r=ckerschb,chutten,nhnt11
After user ticks the checkbox of allowing error reporting, we will
report the error through the telemetry event. The event includes the
error type, XFO policy, CSP policy, the frame uri and the top-level uri.

Differential Revision: https://phabricator.services.mozilla.com/D82332
2020-07-22 15:12:38 +00:00
Tim Huang
748ddb821d Bug 1647825 - Part 1: Add the UI for enable reporting XFO and CSP:frame-ancestors error. r=ckerschb,nhnt11
This patch adds the UI for allowing users to enable reporting XFO error.
The reporting UI will be displayed in the error page if the error is a
XFO error.

Differential Revision: https://phabricator.services.mozilla.com/D82331
2020-07-22 15:12:38 +00:00
Dave Townsend
c551d1b151 Bug 1642398: Add a lint rule to warn about multiple calls to document.l10n.formatValue. r=Standard8,preferences-reviewers,ntim
Differential Revision: https://phabricator.services.mozilla.com/D77900
2020-07-02 18:51:44 +00:00
Gijs Kruitbosch
8909e119d0 Bug 1642725 - use sets of known message identifiers to limit possible error titles and messages instead of consulting fluent, r=zbraniecki,prathiksha,fluent-reviewers,Pike
Differential Revision: https://phabricator.services.mozilla.com/D82135
2020-07-06 11:12:08 +00:00
Ingrid Buh twigle_ingrid
ba2b2420ff Bug 1643595 - Add a learn more link on XFO/CSP error pages r=prathiksha
Differential Revision: https://phabricator.services.mozilla.com/D79280
2020-06-12 12:41:02 +00:00
Ingrid Buh twigle_ingrid
c0dab1fc06 Bug 1461195 - CSP/XFO error pages should offer an option to visit the page directly r=johannh,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D69703
2020-05-26 10:17:50 +00:00
Johann Hofmann
4540e975f8 Bug 1629826 - Re-enable event telemetry probes for certificate error pages. r=nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D72514
2020-04-25 18:12:32 +00:00
Arthur Iakab
d2c2253278 Backed out changeset 5616dd0ad683 (bug 1592877) for causing browser-chrome failures on browser_aboutCertError_manySANsError.js
CLOSED TREE
2020-04-08 15:26:13 +03:00
Lupita Arroyo
929140139b Bug 1592877 - Truncate SANs to 50 in aboutNetError.js and add a test for it. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D68730

--HG--
extra : moz-landing-system : lando
2020-04-08 11:22:10 +00:00
aarushivij
ac01256b16 Bug 1624820 - aboutNetError's setNetErrorMessageFromCode likes to pass empty strings to document.l10n.formatValues which produces errors r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D69230

--HG--
extra : moz-landing-system : lando
2020-04-08 09:46:34 +00:00
sourab
6a08fb7e82 Bug 1622269 - Use fluent to display cert error titles. r=flod,prathiksha,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D66968

--HG--
extra : moz-landing-system : lando
2020-03-26 14:35:50 +00:00
jayati
2f85edd153 Bug 1500464 - Do not display local system clock message if update ping date matches the current date. r=nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D67524

--HG--
extra : moz-landing-system : lando
2020-03-26 13:36:19 +00:00
Michael Kaply
6d38738dd2 Bug 1617275 - Don't allow TLS downgrade if TLS min pref is locked. r=mt
Differential Revision: https://phabricator.services.mozilla.com/D63731

--HG--
extra : moz-landing-system : lando
2020-02-24 19:47:58 +00:00
prathiksha
1624e3f67f Bug 1613477 - Add relevant info to the advanced section of the captive portal page and make the buttons work. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D62204

--HG--
extra : moz-landing-system : lando
2020-02-20 12:59:05 +00:00
Thomas Wisniewski
1e12d53224 Bug 1553265 - add a document.addCertException function to about:certerror pages and use it there; also treat GeckoView error pages as CallerIsTrusted(Net|Cert)Error; r=snorp,johannh,baku
Add a document.addCertException function to about:certerror pages, and use it on the desktop certerror page.

Also, as the CallerIsTrusted* functions expect URLs like about:certerror, but GeckoView error pages are data URLs, and so need to be handled differently for these special error-page methods to be exposed on their documents.

Example usage of document.addCertException:
  document.addCertException(
    true|false /* true == temporary, false == permanent */
  ).then(
    () => {
      location.reload();
    },
    err => {
      console.error(err);
    }
  );

Differential Revision: https://phabricator.services.mozilla.com/D56974

--HG--
extra : moz-landing-system : lando
2019-12-18 21:55:32 +00:00
Cosmin Sabou
fbd904633a Backed out changeset b1e1671fd704 (bug 1553265) for gv-unit failures. 2019-12-18 03:18:14 +02:00
Thomas Wisniewski
63935c0afe Bug 1553265 - add a document.addCertException function to about:certerror pages and use it there; also treat GeckoView error pages as CallerIsTrusted(Net|Cert)Error; r=snorp,johannh,baku
Add a document.addCertException function to about:certerror pages, and use it on the desktop certerror page.

Also, as the CallerIsTrusted* functions expect URLs like about:certerror, but GeckoView error pages are data URLs, and so need to be handled differently for these special error-page methods to be exposed on their documents.

Example usage of document.addCertException:
  document.addCertException(
    true|false /* true == temporary, false == permanent */
  ).then(
    () => {
      location.reload();
    },
    err => {
      console.error(err);
    }
  );

Differential Revision: https://phabricator.services.mozilla.com/D56974

--HG--
extra : moz-landing-system : lando
2019-12-17 21:54:32 +00:00
Johann Hofmann
407c6ddefc Bug 1586846 - Put the TLS 1.0 and TLS 1.1 enabling UI behind a pref. r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D56528

--HG--
extra : moz-landing-system : lando
2019-12-12 10:22:25 +00:00
kyle
3ee8ea8b52 Bug 1570502 - Fixed typo erroCodeString to errorCodeString r=keeler
Fix for Bug: 1570502
fixed typo `erroCodeString` to `errorCodeStrng`

Differential Revision: https://phabricator.services.mozilla.com/D52492

--HG--
extra : moz-landing-system : lando
2019-11-27 13:46:10 +00:00
Martin Thomson
7a96f9362c Bug 1590935 - Offer to re-enable TLS 1.0 on SSL_ERROR_PROTOCOL_VERSION_ALERT, r=nhnt11
As it turns out, there are some sites that generate this error.  It's a small
number, but enough to justify the change.

No new tests because we can't generate this condition in our test setup.

Differential Revision: https://phabricator.services.mozilla.com/D50396

--HG--
extra : moz-landing-system : lando
2019-11-13 09:34:48 +00:00
Kashav Madan
6c785d7c00 Bug 1588193 - Don't dispatch AboutNetErrorLoad until we're completely setup, r=johannh
BrowserTestUtils.waitForErrorPage may resolve slightly earlier than it did
before, so we may arrive at an about:neterror page that hasn't been completely
initialized. We should only dispatch the AboutNetErrorLoad event when we're done
making changes to the page.

Differential Revision: https://phabricator.services.mozilla.com/D51439

--HG--
extra : moz-landing-system : lando
2019-11-06 19:34:18 +00:00
Dorel Luca
97387d0d91 Backed out 4 changesets (bug 1588193) for Broswer-chrome failures on browser/base/content/test/favicons/browser_favicon_change_not_in_document.js. CLOSED TREE
Backed out changeset df4c4004abc5 (bug 1588193)
Backed out changeset 1beab20978b2 (bug 1588193)
Backed out changeset 1ada54e7ba7c (bug 1588193)
Backed out changeset a0d9537d24c6 (bug 1588193)
2019-11-06 21:30:29 +02:00
Kashav Madan
1e0fa9099f Bug 1588193 - Don't dispatch AboutNetErrorLoad until we're completely setup, r=johannh
BrowserTestUtils.waitForErrorPage may resolve slightly earlier than it did
before, so we may arrive at an about:neterror page that hasn't been completely
initialized. We should only dispatch the AboutNetErrorLoad event when we're done
making changes to the page.

Differential Revision: https://phabricator.services.mozilla.com/D51439

--HG--
extra : moz-landing-system : lando
2019-11-06 15:35:18 +00:00
Brindusan Cristian
3eaf139d31 Backed out 4 changesets (bug 1588193) for bc failures at browser_mixedcontent_aboutblocked.js. CLOSED TREE
Backed out changeset 0bbb1f92bb47 (bug 1588193)
Backed out changeset 074bb8a6fd68 (bug 1588193)
Backed out changeset b10ec4058ec3 (bug 1588193)
Backed out changeset c90bab12f4cb (bug 1588193)
2019-11-06 02:39:32 +02:00
Kashav Madan
ea829b2fb5 Bug 1588193 - Don't dispatch AboutNetErrorLoad until we're completely setup, r=johannh
BrowserTestUtils.waitForErrorPage may resolve slightly earlier than it did
before, so we may arrive at an about:neterror page that hasn't been completely
initialized. We should only dispatch the AboutNetErrorLoad event when we're done
making changes to the page.

Differential Revision: https://phabricator.services.mozilla.com/D51439

--HG--
extra : moz-landing-system : lando
2019-11-05 21:52:14 +00:00
Christoph Kerschbaumer
e8e2dc31b7 Bug 1584998: Make x-frame-options work with fission enabled. r=jkt,farre,johannh,flod
Differential Revision: https://phabricator.services.mozilla.com/D50588

--HG--
extra : moz-landing-system : lando
2019-10-31 08:28:35 +00:00
Razvan Maries
dc147d06b0 Backed out changeset 5f185a11889b (bug 1584998) for perma fails on browser_bug593387.js. CLOSED TREE 2019-10-30 23:26:01 +02:00
Christoph Kerschbaumer
36376205fb Bug 1584998: Make x-frame-options work with fission enabled. r=jkt,farre,johannh
Differential Revision: https://phabricator.services.mozilla.com/D50588

--HG--
extra : moz-landing-system : lando
2019-10-30 17:54:36 +00:00
Daniel Varga
617d42c7ed Backed out changeset ac8f6632f7e0 (bug 1584998) on request by dev. On a CLOSED TREE 2019-10-30 19:33:29 +02:00
Christoph Kerschbaumer
9c55479432 Bug 1584998: Make x-frame-options work with fission enabled. r=jkt,farre,johannh
Differential Revision: https://phabricator.services.mozilla.com/D50588

--HG--
extra : moz-landing-system : lando
2019-10-30 14:47:19 +00:00
prathiksha
770ea8cdd6 Bug 1563355 - Handle exceptionDialogButton click on certerror pages in AboutNetErrorhandler.jsm. r=johannh
Depends on D46438

Differential Revision: https://phabricator.services.mozilla.com/D46583

--HG--
extra : moz-landing-system : lando
2019-10-28 20:39:16 +00:00
prathiksha
f23a25ca16 Bug 1563355 - Remove AboutNetErrorResetPreferences and use RPM in aboutNetError.js to communicate with AboutNetErrorHandler. r=johannh
Depends on D46154

Differential Revision: https://phabricator.services.mozilla.com/D46438

--HG--
extra : moz-landing-system : lando
2019-10-28 20:39:01 +00:00
prathiksha
f70c312dac Bug 1563355 - Remove AboutNetErrorSetAutomatic and use RPM in aboutNetError.js to communicate with AboutNetErrorHandler.jsm. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D46154

--HG--
extra : moz-landing-system : lando
2019-10-28 20:38:45 +00:00
Csoregi Natalia
0fe2839016 Backed out changeset 54ca07441fde (bug 1590935) for browser-chrome failures on browser_aboutNetError.js. CLOSED TREE 2019-10-25 05:27:32 +03:00
Martin Thomson
44f6080af9 Bug 1590935 - Offer to re-enable TLS 1.0 on SSL_ERROR_PROTOCOL_VERSION_ALERT, r=johannh
As it turns out, there are some sites that generate this error.  It's a small
number, but enough to justify the change.

No new tests because we can't generate this condition in our test setup.

Differential Revision: https://phabricator.services.mozilla.com/D50396

--HG--
extra : moz-landing-system : lando
2019-10-25 00:25:34 +00:00
Johann Hofmann
edb7353176 Bug 1584685 - Don't use try..catch to check for non-existent error strings in aboutNetError.js. r=nhnt11
document.l10n.formatValues seems to have changed and now not throw an error but instead
return `undefined` when no string was found. This broke the implementation which relied
on try..catch to detect non-existent error strings.

Differential Revision: https://phabricator.services.mozilla.com/D49873

--HG--
extra : moz-landing-system : lando
2019-10-22 11:48:36 +00:00