nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity
610691 commits 1 branch 98 tags 6.4 GiB
Commit graph

1743 commits

Author SHA1 Message Date
Cosmin Sabou
3211507dfb Merge mozilla-inbound to mozilla-central. a=merge 2018-08-24 00:40:14 +03:00
Emilio Cobos Álvarez
2340488c8b Bug 1485430 - Simplify PlaceBelowCurrentFloats. r=dbaron,mats 
No reason to pass our own member as an argument.

Differential Revision: https://phabricator.services.mozilla.com/D4000

--HG--
extra : moz-landing-system : lando
 2018-08-22 23:29:22 +00:00
Emilio Cobos Álvarez
b6a59eedfc Bug 488725: Don't position floats in a nowrap context until hitting a break opportunity. r=dbaron 
Differential Revision: https://phabricator.services.mozilla.com/D3900
 2018-08-23 16:45:01 +02:00
Cameron McCormack
99d9013b12 Bug 1482782 - Part 5: Move CSS anonymous box atoms to nsGkAtoms. r=njn,emilio 
Summary: Depends On D3283

Reviewers: njn!, emilio!

Tags: #secure-revision

Bug #: 1482782

Differential Revision: https://phabricator.services.mozilla.com/D3284
 2018-08-15 15:46:39 +10:00
Cameron McCormack
4a23b5ff06 Bug 1482782 - Part 4: Move CSS pseudo-element atoms to nsGkAtoms. r=njn,emilio 
Summary: Depends On D3282

Reviewers: njn!, emilio!

Tags: #secure-revision

Bug #: 1482782

Differential Revision: https://phabricator.services.mozilla.com/D3283
 2018-08-15 15:46:00 +10:00
Narcis Beleuzu
d20e8e7674 Backed out 8 changesets (bug 1483121, bug 1482782) for build bustages on nsDirectoryService.cpp. CLOSED TREE 
Backed out changeset 0a8334bbcf45 (bug 1483121)
Backed out changeset cb2dcb859071 (bug 1482782)
Backed out changeset c834d4ca2eef (bug 1482782)
Backed out changeset 887de0efbb67 (bug 1482782)
Backed out changeset 018fdb50a6be (bug 1482782)
Backed out changeset 33a8aa8096c9 (bug 1482782)
Backed out changeset e3632354f16e (bug 1482782)
Backed out changeset 46f8319bee82 (bug 1482782)
 2018-08-15 09:14:41 +03:00
Cameron McCormack
d9edae8bde Bug 1482782 - Part 5: Move CSS anonymous box atoms to nsGkAtoms. r=njn,emilio 
Summary: Depends On D3283

Reviewers: njn!, emilio!

Tags: #secure-revision

Bug #: 1482782

Differential Revision: https://phabricator.services.mozilla.com/D3284
 2018-08-15 15:46:39 +10:00
Cameron McCormack
cc6c806369 Bug 1482782 - Part 4: Move CSS pseudo-element atoms to nsGkAtoms. r=njn,emilio 
Summary: Depends On D3282

Reviewers: njn!, emilio!

Tags: #secure-revision

Bug #: 1482782

Differential Revision: https://phabricator.services.mozilla.com/D3283
 2018-08-15 15:46:00 +10:00
Morgan Rae Reschenberg
f72ce47c36 Bug 1472919 - Establish stacking context, containing block, independent formatting context for contain:layout. r=dbaron 
MozReview-Commit-ID: H36HpePX29C

--HG--
rename : layout/reftests/w3c-css/submitted/contain/contain-paint-containing-block-absolute-001.html => layout/reftests/w3c-css/submitted/contain/contain-layout-containing-block-absolute-001.html
rename : layout/reftests/w3c-css/submitted/contain/contain-paint-containing-block-fixed-001.html => layout/reftests/w3c-css/submitted/contain/contain-layout-containing-block-fixed-001.html
rename : layout/reftests/w3c-css/submitted/contain/contain-paint-formatting-context-float-001.html => layout/reftests/w3c-css/submitted/contain/contain-layout-formatting-context-float-001.html
rename : layout/reftests/w3c-css/submitted/contain/contain-paint-formatting-context-margin-001-ref.html => layout/reftests/w3c-css/submitted/contain/contain-layout-formatting-context-margin-001-ref.html
rename : layout/reftests/w3c-css/submitted/contain/contain-paint-formatting-context-margin-001.html => layout/reftests/w3c-css/submitted/contain/contain-layout-formatting-context-margin-001.html
rename : layout/reftests/w3c-css/submitted/contain/contain-paint-ignored-cases-no-principal-box-001.html => layout/reftests/w3c-css/submitted/contain/contain-layout-ignored-cases-no-principal-box-001.html
rename : layout/reftests/w3c-css/submitted/contain/contain-paint-containing-block-absolute-001-ref.html => layout/reftests/w3c-css/submitted/contain/contain-layout-ignored-cases-no-principal-box-002-ref.html
rename : layout/reftests/w3c-css/submitted/contain/contain-paint-containing-block-absolute-001.html => layout/reftests/w3c-css/submitted/contain/contain-layout-ignored-cases-no-principal-box-002.html
rename : layout/reftests/w3c-css/submitted/contain/contain-paint-containing-block-fixed-001-ref.html => layout/reftests/w3c-css/submitted/contain/contain-layout-ignored-cases-no-principal-box-003-ref.html
rename : layout/reftests/w3c-css/submitted/contain/contain-paint-containing-block-fixed-001.html => layout/reftests/w3c-css/submitted/contain/contain-layout-ignored-cases-no-principal-box-003.html
extra : rebase_source : d6e53cd496c98949b0b4ecfb96d6a8a5eb4d6635
 2018-07-20 10:57:22 -07:00
Morgan Rae Reschenberg
1eafba7c64 Bug 1476495 - Treat overflow in contain:layout elements as ink overflow. r=dholbert 
MozReview-Commit-ID: 2gRm0LOUTI6

--HG--
extra : rebase_source : 83c0519bd76d68ff6fd8a20968fbb1a0ef9e81d4
 2018-07-23 11:04:50 -07:00
Cosmin Sabou
2000d70040 Backed out changeset b580e5b9f9e4 (bug 1476495) for wpt reftest failures on contain-layout-ink-overflow. CLOSED TREE 
--HG--
extra : amend_source : 52811bc4cb88b219adc749a02c8f51c7ddb69bd3
 2018-08-10 07:17:58 +03:00
Morgan Rae Reschenberg
717134bfa2 Bug 1476495 - Treat overflow in contain:layout elements as ink overflow. r=dholbert 
MozReview-Commit-ID: 2gRm0LOUTI6

--HG--
extra : rebase_source : 3efe39a597fce724e59ebc8d001c19234b3646ed
 2018-07-23 11:04:50 -07:00
Emilio Cobos Álvarez
26b508d03c Bug 1478069: Trivial frame constructor cleanup. r=TYLin 
Using references helps to see when stuff can and cannot be null.

I removed useless aTag / aNamespaceId arguments which are useless now that XBL
can't override them (bug 1450617), so FindXULData is the only one that keeps
them alive.

Also, I took the liberty of renaming a few fooComputedStyle variables to just
fooStyle, and clarify naming in some pseudo-element-related functions to say
originating element (the spec term) and avoid confusing it with the generated
_moz_generated_content_before / _moz_generated_content_after element.

Note that this is a partial state, more stuff will come in the future.

Differential Revision: https://phabricator.services.mozilla.com/D2326

MozReview-Commit-ID: 39B30doREUH
 2018-07-25 11:31:18 +02:00
Gerald Squelart
a9f6702044 Bug 1459937 - In DEBUG mode, verify that reparenting direction is correct - r=dbaron 
MozReview-Commit-ID: JPfg9YtBm6M

--HG--
extra : rebase_source : f56a9a4a666fc61e69ba537a69e3161b58083d02
 2018-07-10 15:35:48 +10:00
Gerald Squelart
4b4619bb45 Bug 1459937 - Mark pulled floats (from pulled lines) dirty - r=dbaron 
Similar to lines (see previous patch), floats from next-in-flow or overflow
frames have probably not been marked dirty (as ReflowInput hasn't dealt with
them when it was constructed), so we need to mark them dirty for proper reflow.

If we don't do that, and they don't fit in the current column, the next column
will only mark its current children dirty, so when pulling back its first
floats from the previous column they will not be reflowed as needed.

MozReview-Commit-ID: KKrwtzeQMrI

--HG--
extra : rebase_source : ec99f380c978c6d28135490401beb0bb54c8e2b3
 2018-07-10 11:36:33 +10:00
Gerald Squelart
52440e9648 Bug 1459937 - Mark pulled lines (from n-i-f or overflow) dirty - r=dbaron 
Lines pulled from next-in-flow or overflow frames have probably not been marked
dirty (as ReflowInput hasn't dealt with them when it was constructed), so we
need to mark them dirty for proper reflow.

If we don't do that, and they don't fit in the current column, the next column
will only mark its current children dirty, so when pulling back its first lines
from the previous column they will not be reflowed as needed, which causes this
bug.

MozReview-Commit-ID: 8GFO1ZWuZ1b

--HG--
extra : rebase_source : ee55a9ae7408e1f2603c1b2bc80ddcd8dbc837f0
 2018-07-09 11:42:47 +10:00
Emilio Cobos Álvarez
adf95c2d09 Bug 1476054: Fixes and cleanups for Servo PR #21156. r=me 
Similar to the previous patch, logical clear doesn't appear in computed style
objects.

MozReview-Commit-ID: FbN0hiUGzYa
 2018-07-17 10:23:26 +02:00
Emilio Cobos Álvarez
bbc6f5b7f2 Bug 1476054: Fixes and cleanups for Servo PR #21139. r=me 
Logical floats don't appear in the computed style objects, so there's no need to
check for them.

MozReview-Commit-ID: 3ocJrRB3jeO
 2018-07-17 10:15:46 +02:00
Gurzau Raul
c05f725b1e Backed out 6 changesets (bug 1476054) for failing on servo/ports/geckolib/glue.rs on a CLOSED TREE 
Backed out changeset f4941fe345ad (bug 1476054)
Backed out changeset cc571c618e4c (bug 1476054)
Backed out changeset 0a712d7bcb66 (bug 1476054)
Backed out changeset 62293a989ed2 (bug 1476054)
Backed out changeset ef2a43e3fc6c (bug 1476054)
Backed out changeset a2bb0089cf1d (bug 1476054)
 2018-07-16 23:56:23 +03:00
Emilio Cobos Álvarez
9325870208 Bug 1476054: Fixes and cleanups for Servo PR #21156. r=me 
Similar to the previous patch, logical clear doesn't appear in computed style
objects.

MozReview-Commit-ID: FbN0hiUGzYa
 2018-07-16 21:38:46 +02:00
Emilio Cobos Álvarez
cd116a52c4 Bug 1476054: Fixes and cleanups for Servo PR #21139. r=me 
Logical floats don't appear in the computed style objects, so there's no need to
check for them.

MozReview-Commit-ID: 3ocJrRB3jeO
 2018-07-16 21:38:44 +02:00
Andreea Pavel
10d4df5aa9 Backed out 3 changesets (bug 1459937) for failing crashtest with Assertion failure: (IndexInFlow(aOldParent) < IndexInFlow(aNewParent)) on a CLOSED TREE 
Backed out changeset 2cff5c67d000 (bug 1459937)
Backed out changeset fb3fba19e615 (bug 1459937)
Backed out changeset bd4bd8ac335c (bug 1459937)
 2018-07-15 10:06:23 +03:00
Gerald Squelart
846c1a6377 Bug 1459937 - In DEBUG mode, verify that reparenting direction is correct - r=dbaron 
MozReview-Commit-ID: JPfg9YtBm6M

--HG--
extra : rebase_source : d648adaad1d8cc03d7d246fedc3095ba8553f3c8
 2018-07-10 15:35:48 +10:00
Gerald Squelart
1c1d2d71b5 Bug 1459937 - Mark pulled floats (from pulled lines) dirty - r=dbaron 
Similar to lines (see previous patch), floats from next-in-flow or overflow
frames have probably not been marked dirty (as ReflowInput hasn't dealt with
them when it was constructed), so we need to mark them dirty for proper reflow.

If we don't do that, and they don't fit in the current column, the next column
will only mark its current children dirty, so when pulling back its first
floats from the previous column they will not be reflowed as needed.

MozReview-Commit-ID: KKrwtzeQMrI

--HG--
extra : rebase_source : 2b1abb27e9a6ef248a90254b8b56c05207ae25e6
 2018-07-10 11:36:33 +10:00
Gerald Squelart
51058bcdb8 Bug 1459937 - Mark pulled lines (from n-i-f or overflow) dirty - r=dbaron 
Lines pulled from next-in-flow or overflow frames have probably not been marked
dirty (as ReflowInput hasn't dealt with them when it was constructed), so we
need to mark them dirty for proper reflow.

If we don't do that, and they don't fit in the current column, the next column
will only mark its current children dirty, so when pulling back its first lines
from the previous column they will not be reflowed as needed, which causes this
bug.

MozReview-Commit-ID: 8GFO1ZWuZ1b

--HG--
extra : rebase_source : 0198b291a1b50441188e050dd5bcb2c06694df81
 2018-07-09 11:42:47 +10:00
Morgan Rae Reschenberg
2b431dd034 Bug 1467209 - Implement contain:size for blockFrame. r=dholbert 
MozReview-Commit-ID: 852mDXLEpOj

--HG--
extra : rebase_source : f55cb848e798ef38fd501c6ffd6fff238fc126bc
 2018-06-29 10:30:07 -07:00
Chris Peterson
2afd829d0f Bug 1469769 - Part 6: Replace non-failing NS_NOTREACHED with MOZ_ASSERT_UNREACHABLE. r=froydnj 
This patch is an automatic replacement of s/NS_NOTREACHED/MOZ_ASSERT_UNREACHABLE/. Reindenting long lines and whitespace fixups follow in patch 6b.

MozReview-Commit-ID: 5UQVHElSpCr

--HG--
extra : rebase_source : 4c1b2fc32b269342f07639266b64941e2270e9c4
extra : source : 907543f6eae716f23a6de52b1ffb1c82908d158a
 2018-06-17 22:43:11 -07:00
Cameron McCormack
284d195059 Bug 1469738 - Part 2: Replace mentions of "space manager" with "float manager" in comments. r=xidorn 
MozReview-Commit-ID: 1BxlziyTEOM

--HG--
extra : rebase_source : 43ce3aa59773063454926b756dc9c2db1c9837e8
 2018-06-05 15:33:42 +10:00
Brad Werth
6e44ec2131 Bug 1466231 Part 1: Change nsBlockFrame::PlaceLine to accept an nsFlowAreaRect and update flags if it shrinks the area due to a float. r=dbaron 
MozReview-Commit-ID: 4stQQfboUl7

--HG--
extra : rebase_source : c27e886d61d53435a40831f5e527a893f91e57bf
 2018-06-06 12:02:36 -07:00
Cosmin Sabou
5a87ab1364 Backed out 5 changesets (bug 1466231) for reftest failures on float-retry-push-image.html. 
Backed out changeset 8141b2848c2c (bug 1466231)
Backed out changeset 2250da9a0dd0 (bug 1466231)
Backed out changeset 012e16dcc677 (bug 1466231)
Backed out changeset 332453c76ec7 (bug 1466231)
Backed out changeset f926e605d5a9 (bug 1466231)
 2018-06-16 01:45:26 +03:00
Brad Werth
31b77c9374 Bug 1466231 Part 1: Change nsBlockFrame::PlaceLine to accept an nsFlowAreaRect and update flags if it shrinks the area due to a float. r=dbaron 
MozReview-Commit-ID: 4stQQfboUl7

--HG--
extra : rebase_source : c27e886d61d53435a40831f5e527a893f91e57bf
 2018-06-06 12:02:36 -07:00
Brad Werth
b7bb03c1bd Bug 1463745 Part 3: Change nsBlockFrame::DoReflowInlineFrames to detect when the float area may widen in the block direction, and push the inline frame down by a pixel at a time to retry until it fits. r=dbaron 
MozReview-Commit-ID: I4jisE3EYi5

--HG--
extra : rebase_source : 5cb1d98786811a61db2940e8577bfb7d36057d7e
 2018-05-30 12:39:58 -07:00
Brad Werth
5cb7ed31be Bug 1463745 Part 2: Change nsFlowAreaRect to also track whether it may widen in the block direction. r=dbaron 
MozReview-Commit-ID: FWKQEFDBFgr

--HG--
extra : rebase_source : d08e5b466dd6a7f0a61b5a3142eb756e17446473
 2018-05-30 11:07:18 -07:00
Cameron McCormack
43d697cf92 Bug 1464967 - Part 2: Fix nsReflowStatus dumping when REALLY_NOISY_REFLOW is defined. r=gerald 
MozReview-Commit-ID: JPN7i5z5IeX

--HG--
extra : rebase_source : a9642d4cf38f0b94678ab8661bd204c53a397c39
 2018-05-29 14:08:01 +10:00
Boris Zbarsky
30e5cc5d8b Bug 1387143 part 24. Remove nsISelection::ContainsNode. r=mats 2018-05-08 13:52:42 -04:00
Chris Peterson
71422dcaa9 Bug 1457813 - Part 2: Replace non-asserting NS_PRECONDITIONs with MOZ_ASSERTs. r=froydnj 
s/NS_PRECONDITION/MOZ_ASSERT/ and reindent

MozReview-Commit-ID: KuUsnVe2h8L

--HG--
extra : source : c14655ab3df2c9b1465dd8102b9d25683359a37b
 2018-04-28 12:50:58 -07:00
Emilio Cobos Álvarez
f39eaa5d48 Bug 1452080: Remove ComputedStyle::PresContext usage from layout and canvas code. r=xidorn 
Couldn't find an easy way of splitting these up :(

MozReview-Commit-ID: 2kTZ5McREUT
 2018-04-09 11:19:49 +02:00
Noemi Erli
5d9588e156 Backed out 3 changesets (bug 1452080) for bustage in /builds/worker/workspace/build/src/layout/base/nsCSSFrameConstructor.cpp on a CLOSED TREE 
Backed out changeset 7f5104c7a242 (bug 1452080)
Backed out changeset 806a9c95a243 (bug 1452080)
Backed out changeset bffebe8aa254 (bug 1452080)
 2018-04-09 11:18:12 +03:00
Emilio Cobos Álvarez
2a427429ff Bug 1452080: Remove ComputedStyle::PresContext usage from layout and canvas code. r=xidorn 
Couldn't find an easy way of splitting these up :(

MozReview-Commit-ID: 2kTZ5McREUT
 2018-04-09 09:57:55 +02:00
Emilio Cobos Álvarez
e1aec7cd95 Bug 1447827: Rename the reparenting stuff. r=xidorn 
MozReview-Commit-ID: H7tl6O8Ju32
 2018-04-07 15:51:19 +02:00
Emilio Cobos Álvarez
e128bf7b1a Bug 1447827: Remove ServoRestyleManager. r=xidorn 
MozReview-Commit-ID: CFafQsb4rQn
 2018-04-07 15:50:06 +02:00
Emilio Cobos Álvarez
b508e66696 Bug 1447827: Move members from ServoRestyleManager to RestyleManager. r=xidorn 
This leaves ServoRestyleManager as just a typedef.

MozReview-Commit-ID: 5wfTkiDc2Nr
 2018-04-07 15:40:00 +02:00
Matt Woodrow
8eb6516c62 Bug 1443380 - Don't mark all descendant frames modified for display list building when invalidating a frame subtree since marking just the root is sufficient. r=miko 2018-04-04 16:15:49 +12:00
Xidorn Quan
4cf9aed667 Bug 1449400 part 5 - Remove StyleSetHandle. r=emilio 
This patch basically does:
* remove StyleSetHandle and its corresponding files
* revisit #includes of related header files and change correspondingly
* change nsIPresShell::mStyleSet to be UniquePtr<ServoStyleSet>
* change the creating path of ServoStyleSet to pass UniquePtr
* change other mentions of StyleSetHandle to ServoStyleSet*
* remove AsServo() calls on ServoStyleSet

Some unfortunate bits:
* some methods of (Servo)StyleSet only accepts ServoStyleSheet while
  many places call into the methods with StyleSheet, so there are many
  ->AsServo() added to sheets

MozReview-Commit-ID: K4zYnuhOurA

--HG--
extra : rebase_source : 459e8efeb171adad089d94272e143e8c244bd279
extra : source : 65ba2f174fcf7dba4e59c00ee8908b1bd0820a48
 2018-03-29 22:15:46 +11:00
Emilio Cobos Álvarez
2265ef0801 Bug 1448688: Remove RestyleTracker, ComputedStyle::AsServo, old style system element bits. r=xidorn 
MozReview-Commit-ID: ALiOngGqozN
 2018-03-26 09:38:07 +02:00
Emilio Cobos Álvarez
e341b20ec4 Bug 1447483: Merge nsStyleContext and ServoStyleContext, rename to ComputedStyle. r=jwatt on a CLOSED TREE 
MozReview-Commit-ID: JPopq0LudD
 2018-03-22 20:06:24 +01:00
Emilio Cobos Álvarez
5dd797f154 Back out changeset b683bb3f22a1 (Bug 1447483) for not landing with all the files. r=me on a CLOSED TREE 
This reverts commit 1808914126bb9f9e4a82d2c3d7ac961885fe7d62.

MozReview-Commit-ID: 5skESBseEvo
 2018-03-22 20:05:22 +01:00
Emilio Cobos Álvarez
ca5ac79cca Bug 1447483: Merge nsStyleContext and ServoStyleContext, rename to ComputedStyle. r=jwatt 
MozReview-Commit-ID: JPopq0LudD
 2018-03-22 19:48:42 +01:00
Daniel Holbert
7f66b8109f Bug 1438020: Add some includes for "Inlines" headers to address clang build warnings in non-unified build. r=mats 
MozReview-Commit-ID: HRHnjznPjx1

--HG--
extra : rebase_source : f0500a1c68a823a4583093a25f1a9fcf97aa1515
 2018-02-13 14:38:20 -08:00
Boris Zbarsky
8c61d57bca Bug 1276438 part 6. Stop using nsIDOMHTMLDocument::GetBody. r=mystor 
MozReview-Commit-ID: EcDTnByuZsm
 2018-01-26 00:53:35 -05:00