Commit graph

116 commits

Author SHA1 Message Date
Dave Townsend
29625e4aba Bug 1602186: Allow installing SSBs and launching them from the command line. r=Gijs
Allows for persisting SSBs to storage for realoading in a later app instance.
Also adds a command line argument to load and open an SSB based on its ID.

Differential Revision: https://phabricator.services.mozilla.com/D56289

--HG--
extra : moz-landing-system : lando
2019-12-16 19:49:12 +00:00
Dave Townsend
5d6cb8398a Bug 1603787: Remove the long-expired telemetry logging for page action items. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D57138

--HG--
extra : moz-landing-system : lando
2019-12-13 17:26:58 +00:00
Dave Townsend
35f21af04d Bug 1602176: When available use a site's app manifest to determine what is inside and outside of an SSB. r=Gijs
When launched from a browser we can retrieve a site manifest to provide more
information about the site.

Differential Revision: https://phabricator.services.mozilla.com/D56287

--HG--
extra : moz-landing-system : lando
2019-12-13 15:49:26 +00:00
Arthur Iakab
923816f740 Backed out 3 changesets (bug 1602176, bug 1602173) for causing browser-chrome failures on browser_ssb_direct.js CLOSED TREE
Backed out changeset c7c2e74ae25c (bug 1602176)
Backed out changeset 8243a0bcfcb1 (bug 1602173)
Backed out changeset 01189bae5706 (bug 1602173)
2019-12-13 02:46:37 +02:00
Dave Townsend
356455443d Bug 1602176: When available use a site's app manifest to determine what is inside and outside of an SSB. r=Gijs
When launched from a browser we can retrieve a site manifest to provide more
information about the site.

Differential Revision: https://phabricator.services.mozilla.com/D56287

--HG--
extra : moz-landing-system : lando
2019-12-12 20:23:10 +00:00
Dave Townsend
b6cef263d5 Bug 1602168: Add a command line argument to launch an ssb. r=Gijs
Allows launching a site browser from the command line (see https://bugzilla.mozilla.org/show_bug.cgi?id=1283670).
Moves the code for launching an SSB into a shared module.

Differential Revision: https://phabricator.services.mozilla.com/D56284

--HG--
extra : moz-landing-system : lando
2019-12-12 20:23:00 +00:00
Dave Townsend
c696551b78 Bug 1602123: Add a page action to open the current tab into a standalone window. r=Gijs
The action should open the SSB UI to show the page. No other custom behaviour
is expecgterd at this point.

Differential Revision: https://phabricator.services.mozilla.com/D56283

--HG--
extra : moz-landing-system : lando
2019-12-12 20:22:50 +00:00
Brindusan Cristian
d784ce8921 Backed out 2 changesets (bug 1602168, bug 1602123) for turning bug 1336075 into perma. CLOSED TREE
Backed out changeset b892c240d938 (bug 1602168)
Backed out changeset f47c59a4e3d3 (bug 1602123)

--HG--
extra : histedit_source : c3cddd5170a0d0e98753cd01f901964a92ad48bc
2019-12-11 04:44:43 +02:00
Dave Townsend
e891cab2a3 Bug 1602168: Add a command line argument to launch an ssb. r=Gijs
Allows launching a site browser from the command line (see https://bugzilla.mozilla.org/show_bug.cgi?id=1283670).
Moves the code for launching an SSB into a shared module.

Differential Revision: https://phabricator.services.mozilla.com/D56284

--HG--
extra : moz-landing-system : lando
2019-12-10 22:33:06 +00:00
Dave Townsend
597e62a81e Bug 1602123: Add a page action to open the current tab into a standalone window. r=Gijs
The action should open the SSB UI to show the page. No other custom behaviour
is expecgterd at this point.

Differential Revision: https://phabricator.services.mozilla.com/D56283

--HG--
extra : moz-landing-system : lando
2019-12-10 22:33:10 +00:00
Harry Twyford
4f99373ef5 Bug 1599123 - Rename instances of "search icon" to "search button". r=mak
Differential Revision: https://phabricator.services.mozilla.com/D54539

--HG--
extra : moz-landing-system : lando
2019-11-26 09:38:02 +00:00
Harry Twyford
baac927898 Bug 1592268 - Make the permanent search icon a bookmarks doorhanger anchor. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D51814

--HG--
extra : moz-landing-system : lando
2019-11-05 16:28:13 +00:00
monikamaheshwari
9d60e0d578 Bug 1578683 Turn on ESLint rule prefer-boolean-length-check for toolkit and browser r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D45629

--HG--
extra : moz-landing-system : lando
2019-09-14 09:39:26 +00:00
Edouard Oger
f4b32d8096 Bug 1579445 - Refresh the FxA device list on Send Tab menu open. r=markh
Differential Revision: https://phabricator.services.mozilla.com/D45189

--HG--
extra : moz-landing-system : lando
2019-09-12 22:42:31 +00:00
James Teh
ee21b9ffb2 Bug 1571389: For page actions which show an iframe, focus the iframe when the action is activated. r=jaws
This includes the Save to Pocket action.
Previously, keyboard users had to press f6 twice to focus the iframe.
Worse, screen reader users weren't aware anything popped up at all.

Differential Revision: https://phabricator.services.mozilla.com/D40913

--HG--
extra : moz-landing-system : lando
2019-08-07 21:03:42 +00:00
Tim Nguyen
b6d8cc41ad Bug 1569375 - Refactor browser panel CSS to reduce shadow DOM traversal after CE conversion. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D39594

--HG--
extra : moz-landing-system : lando
2019-07-31 15:22:08 +00:00
Victor Porof
f9f5914039 Bug 1561435 - Format browser/base/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36041

--HG--
extra : source : 96b3895a3b2aa2fcb064c85ec5857b7216884556
2019-07-05 09:48:57 +02:00
Andrew Swan
293531d7dd Bug 1557871 Fix badged-button leftovers r=dao
In bug 1519577, the badged-button class for toolbarbuttons was replaced
with a "badged" attribute but a few old uses of the class were overlooked.
This patch fixes them.

Differential Revision: https://phabricator.services.mozilla.com/D34438

--HG--
extra : moz-landing-system : lando
2019-06-11 14:36:18 +00:00
Boris Zbarsky
9de72a3ac6 Bug 1557793 part 2. Stop using [array] in nsIStringBundle. r=Pike
Differential Revision: https://phabricator.services.mozilla.com/D34196

--HG--
extra : moz-landing-system : lando
2019-06-11 15:51:51 +00:00
Andrew Swan
a745ec6099 Bug 1519577 Convert toolbarbutton to a custom element r=surkov
Differential Revision: https://phabricator.services.mozilla.com/D31941

--HG--
extra : rebase_source : 3709ef713f1a7dc9fbc2d0ac97f16bea757fcd2b
2019-05-20 10:01:02 -07:00
Andrew Swan
b14c25d6ab Bug 1519577 Mark badged page action toolbarbuttons before inserting r=Gijs
The "add search engine" page action wants to use badged toolbarbuttons,
but it does this by adding the "badged-button" class (which changes the
XBL binding) after the button has already been created and added to
the DOM.  To avoid having to switch between non-badged and badged buttons
when toolbarbutton is converted to custom elements, add a property to
page actions so that the badged status can be determined when the element
is created.

Differential Revision: https://phabricator.services.mozilla.com/D31940

--HG--
extra : rebase_source : 335ba3c9ff73f3fa2f17ac113623e5572f7389c5
2019-05-14 20:39:38 -07:00
Vijay Budhram
b326d15f68 Bug 1524665 - Add send tab to device button, r=gijs
Differential Revision: https://phabricator.services.mozilla.com//D23387

--HG--
extra : rebase_source : 2f41fc8a0f78149105b32b87017e1d9035cc5d3e
2019-03-13 20:31:59 +00:00
Ricky Rosario
4c98b7c5c0 Bug 1528952 - Add Pin tab action to the Page Actions Menu r=andreio,dao
MozReview-Commit-ID: 4MMiF2u61uV

Differential Revision: https://phabricator.services.mozilla.com/D20422

--HG--
extra : moz-landing-system : lando
2019-02-22 08:04:12 +00:00
Mark Striemer
911fb7280f Bug 1500147 - Part 3: Record add-on manager telemetry for page/browser actions r=rpl
Differential Revision: https://phabricator.services.mozilla.com/D18003

--HG--
extra : moz-landing-system : lando
2019-02-07 16:43:02 +00:00
Mike de Boer
4e948732c1 Bug 1525833 - nsISearchService::addEngine does not support using a callback anymore, instead it returns a Promise. Update the searchbar's usage to reflect this. r=florian
This also officially gets rid of the nsIBrowserSearchInitObserver and nsISearchInstallCallback
from nsISearchService.idl, even though they're not used for anything anymore.

Differential Revision: https://phabricator.services.mozilla.com/D18993

--HG--
extra : moz-landing-system : lando
2019-02-07 16:17:54 +00:00
Mike de Boer
481ae95c00 Bug 1524593 - nsISearchService (aka nsIBrowserSearchService, previously) refactor to be mostly an asynchronous, in preparation of WebExtension engines. r=daleharvey
This is a rollup of all the patches that have landed on the cedar project branch:

891252fdd0
Bug 1492475 - Part 1: Migrate most, if not all nsSearchService consumers to use async APIs. r=florian

79b2eb2367
Bug 1492475 - Part 2: Move nsIBrowserSearchService.idl to toolkit/components/search/nsISearchService.idl and update references. r=florian

a947d3cdf0
Bug 1492475 - Part 3: The search service init() method should simply return a Promise. r=florian

c1e172dfac
Bug 1492475 - Part 4: Remove the synchronous initialization flow. r=florian

cd41189eac
Bug 1492475 - Part 5: Since async initialization of the search service now is implicit behavior, remove the distinctive verbiage used internally. r=florian

2ae7189dfa
Bug 1492475 - Part 6: Update the cache build task to work with an actual Promise and re-initialize only once at the same time - all to fix race conditions here. r=florian

c8ee92973f
Bug 1492475 - Part 7: Make the region fetch not block the init flow, to ensure it's as fast as possible. r=florian

c44e674e16
Bug 1492475 - Part 8: Introduce an init flag, which can only be used privately, that allows to explicitly skip waiting for the region check process to complete. r=florian

6c79eaf1d3
Bug 1492475 - Part 9: Update unit tests to stop using 'currentEngine', in favor of 'defaultEngine'. r=Standard8

21b3aa17ee
Bug 1492475 - Part 10: Update unit tests to be fully aware of the new, async signatures of the search service API and remove sync init flow tests. r=mkaply,florian

ce5ba69019
Bug 1492475 - Part 11: Repair incorrect usage of the `identifier` property of nsISearchEngine instances. r=florian

fd177a7994
Bug 1518543 - Fix up the Android (Fennec) nsISearchService shim to work with the new asynchronous API. r=florian

3653d8ee22
Bug 1523708 - Change the search service interaction in the show-heartbeat action to use the new async API. r=florian

Differential Revision: https://phabricator.services.mozilla.com/D18355

--HG--
rename : netwerk/base/nsIBrowserSearchService.idl => toolkit/components/search/nsISearchService.idl
extra : moz-landing-system : lando
2019-02-02 11:27:21 +00:00
Edouard Oger
40fc208fc3 Bug 1516997 p2 - Use hasSyncedThisSession to determine if Send Tab is configured and loading. r=markh
Depends on D15657

Differential Revision: https://phabricator.services.mozilla.com/D15658

--HG--
extra : moz-landing-system : lando
2019-01-03 22:29:03 +00:00
James Teh
3efa5efdbd Bug 1506504: Add/fix keyboard behaviour for browser toolbar buttons which open popups. r=Gijs
1. Fix the Firefox menu button so that it only handles space and enter, rather than incorrectly activating for *all* key presses.
2. Add keyboard support (space and enter) for the Library and page Actions buttons.
3. Add keyboard support (space and enter) for customizable widgets of type "view"; e.g. the Developer button.
4. Add keyboard support (space and enter) for page action buttons pinned to the URL bar; e.g. the Send Tab to Device button.

Differential Revision: https://phabricator.services.mozilla.com/D11608

--HG--
extra : moz-landing-system : lando
2018-12-20 11:33:32 +00:00
Dale Harvey
ce7a7296b3 Bug 1363169 - Add support for native windows share. r=gijs, r=aklotz
MozReview-Commit-ID: 7quON7Somvr
2018-10-16 13:54:13 +01:00
Coroiu Cristina
9c477e78d3 Backed out changeset c3c3a9571f63 (bug 1363169) for Bmsvc build bustage at build/src/widget/windows/WindowsUIUtils.cpp 2018-10-15 19:00:20 +03:00
Dale Harvey
eba28f888d Bug 1363169 - Add support for native windows share. r=gijs, r=aklotz 2018-10-15 15:42:34 +01:00
Diego Pino Garcia
45377e5099 Bug 1481199 - Drop the obsolete dataType parameter for nsIBrowserSearchService.addEngine. r=mkaply 2018-10-09 13:39:35 +01:00
Drew Willcoxon
a9f52240ca Bug 1489834 - Fix the Send Tab to Device page action title and tooltip r=jaws
Bug 1470555 moved the title from a dtd to a properties file, so we can and should now set the action's title directly when the action is created in PageActions.jsm.  But it's a PluralForm string, so we need to jump through that hoop.

Differential Revision: https://phabricator.services.mozilla.com/D5721

--HG--
extra : moz-landing-system : lando
2018-10-02 14:25:37 +00:00
Jared Wein
b08075b904 Bug 1492702 - Send the contextual link to the device, not the selected tab when a link is right-clicked. r=markh
Differential Revision: https://phabricator.services.mozilla.com/D6980

--HG--
extra : moz-landing-system : lando
2018-09-27 07:49:05 +00:00
Mark Striemer
2b0aaa8c2d Bug 1483591 - Treat built-in webextension page actions as built-in r=adw
Differential Revision: https://phabricator.services.mozilla.com/D6329

--HG--
extra : moz-landing-system : lando
2018-09-21 21:50:26 +00:00
Abdoulaye O. Ly
f39692c1fe Bug 1470555 - Implement ability to send a selection of tabs. r=flod,jaws
Differential Revision: https://phabricator.services.mozilla.com/D3126

--HG--
extra : moz-landing-system : lando
2018-09-04 14:36:05 +00:00
Mark Banner
691543ee89 Bug 1486739 - Add missing dangling commas in browser/, services/, taskcluster/ and toolkit/. r=mossop
Automatic changes by ESLint, except for manual corrections for .xml files.

Differential Revision: https://phabricator.services.mozilla.com/D4439

--HG--
extra : moz-landing-system : lando
2018-08-31 05:59:17 +00:00
Brendan Dahl
f6923ccc24 Bug 1485426 - Use createXULElement instead of createElement in XUL docs. r=bgrins
Preparing for transitioning to XHTML.

MozReview-Commit-ID: JLlmUxsvhIB

Differential Revision: https://phabricator.services.mozilla.com/D4265

--HG--
extra : moz-landing-system : lando
2018-08-25 00:16:27 +00:00
James Teh
598f267168 Bug 1482025: Don't set aria-label on hbox page action nodes. r=Gijs
This change means that the #pocket-button-box hbox is pruned from the accessibility tree as it should be.

Normally, hbox elements aren't exposed to accessibility, as they are semantically meaningless.
However, this code was previously setting aria-label on hbox elements, which forces the hbox to be exposed to accessibility.

Differential Revision: https://phabricator.services.mozilla.com/D2987

--HG--
extra : moz-landing-system : lando
2018-08-24 03:21:30 +00:00
Drew Willcoxon
8a7b209c5b Bug 1483167 - Copy Link and Send Tab to Device page action button tooltips say "coypURL-title" and "sendToDevice-title" r=Gijs
Replacing onPlacedInPanel with onBeforePlacedInWindow is the right fix.

Differential Revision: https://phabricator.services.mozilla.com/D4028

--HG--
extra : moz-landing-system : lando
2018-08-23 10:20:54 +00:00
Paolo Amadini
b4630c69a3 Bug 1481813 - Part 4 - Remove support for adding generic DOM attributes to page actions. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D3011

--HG--
extra : rebase_source : 34d987669c8c83ccf5fd50adfc31594b8c07dd46
extra : source : 0fa77a8d96fd46ef19cbfdf439ae0ca12f8fe191
2018-08-09 13:22:20 +01:00
Brian Grinstead
abf1620630 Bug 1479125 - Migrate calls that expect an element to be returned to use element variation firstChild etc to firstElementChild etc;r=Paolo
This allows the JS to work in HTML documents, where whitespace is preserved. In XUL
documents, whitespace is ignored when parsing so text nodes are generally not returned.

The following changes were made, with manual cleanups as necessary (i.e. when firstChild actually
refers to a text node, or when firstChild is used in a loop to empty out an element):

  firstChild->firstElementChild
  lastChild->lastElementChild
  nextSibling->nextElementSibling
  previousSibling->previousElementSibling
  childNodes->children

MozReview-Commit-ID: 95NQ8syBhYw

--HG--
extra : rebase_source : 186d805f7a2a56694dda9032aceac2dfe5424753
2018-08-08 15:22:53 -07:00
Dave Townsend
389a969138 Bug 1479050: Migrate a number of call-sites to use document.createXULElement. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D2489

--HG--
extra : moz-landing-system : lando
2018-07-31 19:13:38 +00:00
Boris Zbarsky
270fa12c79 Bug 1476145 part 3. Stop using getInterface(nsIDOMWindowUtils) in browser/. r=gijs 2018-07-24 19:47:41 -04:00
Dale Harvey
dc2a4a2d84 Bug 1471877 - Add link to share menu to configuration. r=Gijs,mstange
MozReview-Commit-ID: CCTO9SJJMY6

--HG--
extra : rebase_source : 23daee7ff3550b7613c03f817c2db87aecaf7ec5
2018-06-30 18:35:46 +01:00
Noemi Erli
7c4c1c603f Backed out changeset 68859b04588d (bug 1471877) for failures in browser/content/browser-pageActions.js on a CLOSED TREE 2018-07-18 13:32:50 +03:00
Dale Harvey
dbcfb245b1 Bug 1471877 - Add link to share menu to configuration. r=Gijs,mstange
MozReview-Commit-ID: CCTO9SJJMY6

--HG--
extra : rebase_source : c9ae961b87a5b40a501f72501738f70c129f6d8b
2018-06-30 18:35:46 +01:00
Dão Gottwald
cd159c76f7 Bug 1459907 - Implement new bookmark confirmation. r=mak
MozReview-Commit-ID: DsTXTKgX72y

--HG--
extra : rebase_source : 836ba1340189d22e4ee9f0fdb1c4ff339fbd266f
2018-06-23 15:28:47 +02:00
Dale Harvey
2beab3540e Bug 1455310 - Add title data and activity to sharing. r=mstange
MozReview-Commit-ID: IL4sqvRwSwu

--HG--
extra : rebase_source : ff973f92552931c725a81c177c02fcbd5c6aab63
2018-04-25 08:23:32 +01:00
Cosmin Sabou
2474ce8cde Backed out changeset 48b66743b97b (bug 1455310) for xpcshell failures on widget/tests/unit/test_macsharingservice.js. CLOSED TREE 2018-04-27 19:12:07 +03:00