Bug 1512634 introduced a case-insensitive check for CSS properties. This caused a regression whereby inherited CSS variables with mixed case were incorrectly unmatched when shown in the Rules view.
To fix this, we do a strict check for CSS variables in CSSProperties front because they are case sensitive (--color and --COLOR are different CSS variables).
See: https://www.w3.org/TR/css-variables-1/
> Unlike other CSS properties, custom property names are case-sensitive.
Differential Revision: https://phabricator.services.mozilla.com/D23113
--HG--
extra : moz-landing-system : lando
Ideally, formAttributeName would be a field on the prototype of each front,
but unfortunately, Firefox doesn't support ES Class's fields yet. So it is
put as an instance attribute instead.
This patch streamline the manually set actorID and the retrieval of actor ID
from root or target front's form into `getFront` helper method.
So that all the specific related to the lazy actor is now inside of this helper.
It also moves the special "this.manage(this)" to this helper.
We might be able to followup on this one and finally have only the root front
being self managed. But the initialize method makes it hard.
Note the special tweak made to devtools/client/responsive.html/manager.js
Hopefully this can be removed once the target classes are merged.
Depends on D15832
Differential Revision: https://phabricator.services.mozilla.com/D17615
--HG--
extra : moz-landing-system : lando
[Bug 1512634](https://bugzilla.mozilla.org/show_bug.cgi?id=1512634) occurred because the Rule view marks CSS properties as overriden when they are not lowercase. This happens because `ElementStyle.markOverridden()` relies on computed properties. They get built using `CSSProperties.getSubproperties()`. If the input to that method is not lowercase, it doesn't match properties from the CSS database and returns an empty array. This has a side-effect of marking the property as overriden.
In this patch we allow users to type property names in any case, but we validate the lowercase version of them.
Differential Revision: https://phabricator.services.mozilla.com/D14568
--HG--
extra : moz-landing-system : lando
Displays which CSS variable is used in the rule view.
Displays the actual variable value on the variable name's title property.
Displays all the inherited CSS variables on the selected element in the rule view.
MozReview-Commit-ID: 52uLJA123AP
This caching feature is no longer valid as the client-side database
will not necessarily be the same as the server since the DB is
only built on nightly.
MozReview-Commit-ID: 550EQmgO9O7
--HG--
extra : rebase_source : 8863a9b42a976c5b6a6b8d4a8e2481b50f2ffa86
This caching feature is no longer valid as the client-side database
will not necessarily be the same as the server since the DB is
only built on nightly.
MozReview-Commit-ID: 550EQmgO9O7
--HG--
extra : rebase_source : 9d924ea3a4c33995ab5db1e854404f4f181ecd41
In preparation for the additional files in the `mach generate-css-db`
command, collect the CSS files into a folder.
MozReview-Commit-ID: 9JRVsC2NMK8
--HG--
rename : devtools/shared/css-color-db.js => devtools/shared/css/color-db.js
rename : devtools/shared/css-lexer.js => devtools/shared/css/lexer.js
rename : devtools/shared/css-properties-db.js => devtools/shared/css/properties-db.js
extra : rebase_source : b73bbe7fcf8177a25b41ecdd6d6c760ed1472fb7
This creates an easy interface for getting the static css database, and
splits up the initCssProperties function into smaller re-usable parts.
MozReview-Commit-ID: G86bNy3KQDp
--HG--
extra : rebase_source : 608df38114de31320594516ca776cc35ddb6ee8e
Added the list of supported types to each css property returned by the
CssProperties actor.
As a fallback, the css-properties-db static file also contains this list.
Also, if connected to a server that has the CssProperties actor but not
the data about supported types, then the type data is retrieved from the
static db too.
MozReview-Commit-ID: J1o8JGODMiC
--HG--
extra : rebase_source : 9c997516c0b1c374a016a6a5f54dacfb5ce076bf
extra : amend_source : 15ae16c64120b984b212fd2e2723da5018aaaa5c
