Commit graph

109 commits

Author SHA1 Message Date
Gijs Kruitbosch
6f1da44727 Bug 1643321 - fix missing/differently-identified fluent localization of browser profile migration data types, r=MattN,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D78412
2020-06-08 12:00:38 +00:00
Riley Byrd
ad82a96dad Bug 1518234 - Migrate migration wizard to Fluent r=flod,Gijs,fluent-reviewers
Based on a patch originally written by Ian Kirkpatrick <kirkpa47@msu.edu>

Differential Revision: https://phabricator.services.mozilla.com/D17393
2020-06-02 06:46:09 +00:00
Adam Gashlin
f66d880b9e Bug 1634115 - Send telemetry when refresh is requested from uninstaller. r=MattN,mhowell,chutten
Differential Revision: https://phabricator.services.mozilla.com/D76234
2020-05-26 21:47:58 +00:00
Ed Lee
a6fbc5aae4 Bug 1618311 - Contextually suggest importing passwords as an autocomplete entry r=MattN,fluent-reviewers,flod
Add importableLogins autocomplete items that show for a site when there's chromium-based logins, no saved logins, and appropriate experiment state. Default behavior is unchanged with default "" pref value, and new behavior can be turned on with "import" pref value.

Differential Revision: https://phabricator.services.mozilla.com/D72096
2020-04-28 21:59:34 +00:00
Matthew Noorenberghe
162a23e550 Bug 1605871 - Delete unused importBookmarks/importFromBookmarks code/string for the migration window. r=zombie
Differential Revision: https://phabricator.services.mozilla.com/D58198

--HG--
extra : moz-landing-system : lando
2019-12-24 17:03:47 +00:00
Kirk Steuber
047d40ee73 Bug 1584283 - Stop using xul:wizard as a root element and migrate consumers to xul:window[role=dialog] with the wizard as the only child r=surkov. On a CLOSED TREE
Differential Revision: https://phabricator.services.mozilla.com/D48922

--HG--
extra : source : 01007f3333ea182c83bced4ff750c96b22925e80
extra : amend_source : 3b06af7be6009d6bd94798e14f30a2550f1c4c4f
extra : histedit_source : be50ba403a84dda5af1c902438c918c17a971578
2019-10-17 21:25:53 +00:00
Dorel Luca
659e2d2335 Backed out changeset 01007f3333ea (bug 1584283) for Browser-chrome failures in widget/tests/browser/browser_test_procinfo.js 2019-10-23 03:23:24 +03:00
Kirk Steuber
e937081418 Bug 1584283 - Stop using xul:wizard as a root element and migrate consumers to xul:window[role=dialog] with the wizard as the only child r=surkov
Differential Revision: https://phabricator.services.mozilla.com/D48922

--HG--
extra : moz-landing-system : lando
2019-10-17 21:25:53 +00:00
Victor Porof
1f830c96da Bug 1561435 - Format browser/components/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36042

--HG--
extra : source : d3afcafdce650a6f36cebbc126ee93b17f13cf52
2019-07-05 09:53:32 +02:00
Brendan Dahl
543c10a1d2 Bug 1551320 - Replace all CreateElement calls in XUL documents with CreateXULElement. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D31295

--HG--
extra : moz-landing-system : lando
2019-05-20 16:50:28 +00:00
Jonas Allmann
df684f89db Bug 1498569, Replace wizard.xml attributes with event listeners, r=Gijs
* Removed all occurences of custom onwizard* attributes.
* Removed custom handler code from wizard.xml.
* Updated eval()-usage whitelist.

Differential Revision: https://phabricator.services.mozilla.com/D24033

--HG--
extra : moz-landing-system : lando
2019-04-02 08:56:25 +00:00
Kris Maglione
e930b89c34 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750

--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
2019-01-17 10:18:31 -08:00
Doug Thayer
511d92a9fe Bug 1432529 - Exit spinEventLoopUntil when canceling migrator r=Gijs
Fairly trivial - discussed in bug 862127. Opt to cancel the spin wait
rather than disable canceling in the UI.

MozReview-Commit-ID: B55Fsw34uX7

--HG--
extra : rebase_source : 3b7e83799af01cef096894b40537c1a4021ffc16
2018-02-15 11:55:10 -08:00
Gijs Kruitbosch
9239725b9a Bug 1434167 - remove home page code from the migration wizard, r=MattN
This removes all the homepage-related code. All the cases where we advance the wizard straight to
the homepage wizardpage now go straight to the 'start migrating' page (the 'point' was skipping
earlier pages that allowed users to select items).
The brand bundle was only used by the homepage code so is also being removed.

MozReview-Commit-ID: I9nSU2IMkQz

--HG--
extra : rebase_source : da803ed67b443cb164f2bc55550bfd7c107fa916
2018-02-07 10:37:20 +00:00
Gijs Kruitbosch
ac1ce88bcf Bug 1434167 - remove getSourceHomePageURL implementations and callsites, r=dthayer
MozReview-Commit-ID: 98p2Iy70EPv

--HG--
extra : rebase_source : 7980fffb74a3deff1493353c610d03a506c392d9
2018-02-07 10:18:46 +00:00
Andrew McCreight
5dec0e0beb Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG

--HG--
extra : rebase_source : d9c41878036c1ef7766ef5e91a7005025bc1d72b
2018-02-06 09:36:57 -08:00
Kris Maglione
918ed6c474 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
extra : intermediate-source : 34c999fa006bffe8705cf50c54708aa21a962e62
extra : histedit_source : b2be2c5e5d226e6c347312456a6ae339c1e634b0
2018-01-29 15:20:18 -08:00
Cosmin Sabou
9a65a40178 Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
6476f95b13 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
2018-01-29 15:20:18 -08:00
Brindusan Cristian
af8879d1eb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
c276bb9375 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : rebase_source : c004a023389f1f6bf3d2f3efe93c13d423b23ccd
2018-01-29 15:20:18 -08:00
Doug Thayer
cec5b96dc3 Bug 862127 - Convert migration.js to use async migration interfaces r=Gijs
migration.js is a special case where we generally need blocking
calls in order for the wizard to work correctly. Accordingly we
block waiting for the new async interfaces. With automigration
and potential new UIs that are in the works for migration, the
asynchronicity of these interfaces will be more relevant, but
here it's not really important enough to make big changes to the
way the UI is implemented.

MozReview-Commit-ID: LkfwBVfpCJO

--HG--
extra : rebase_source : 1f9f2c7e2fa20b883840e091dbee366a161eaaf7
2018-01-12 09:11:38 -08:00
Mark Banner
42cb2dc6a3 Bug 1230373 - Enable mozilla/use-services for browser/components/ r=mossop
MozReview-Commit-ID: 9m9iss3jUJJ

--HG--
extra : rebase_source : e6a6f9dec168ab1d0e0343236db65f3dd1b44aeb
2017-10-11 15:43:51 +01:00
Florian Queze
37ff4fc7cc Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst
a07223d699 Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
Florian Queze
95d4d20c17 Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Florian Quèze
9c4d40bb54 Bug 1345294 - script generated patch (+ some hand cleanup) to replace {get,set}ComplexValue for nsISupportsString by {get,set}StringPref, r=Mossop. 2017-03-16 19:26:01 +01:00
Florian Quèze
9d62681259 Bug 1345253 - Use element.firstChild.remove() instead of element.removeChild(element.firstChild), r=jaws. 2017-03-08 10:17:52 +01:00
Jared Wein
9141469edf Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN
MozReview-Commit-ID: FuVu8skcqOe

--HG--
extra : rebase_source : 8ab34c4e46a7c3075b459bf44786ec184d10d203
2016-12-30 21:47:25 -05:00
Jared Wein
ecab54a7c9 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje

--HG--
extra : rebase_source : 0572a35415a766a3f31d266760ecd07f0dcc3f72
2016-12-29 18:34:54 -05:00
Wes Kocher
0dfb7c2b5c Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
7255df4e9a Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR

--HG--
extra : rebase_source : da7172285d43b820421557ed3b05887e091ff939
2016-12-29 15:20:47 -05:00
Dave Townsend
8de07a19a0 Bug 1316882: Turn on space-before-function-paren eslint rule (browser). r=jaws
MozReview-Commit-ID: 2ZvTiZDHchz

--HG--
extra : rebase_source : db6482481b7338df491afd6f6fd376eccec84d7e
2016-11-11 08:10:51 -08:00
Gijs Kruitbosch
8d23ab9355 Bug 1311043 - make eslint much more strict in browser/components/migration/, and fix issues, r=mikedeboer
MozReview-Commit-ID: RXO68w3Kv3

--HG--
extra : rebase_source : b25a1976f2be89f12c2ad14e649270bacd17d174
2016-10-18 16:03:06 +01:00
Gijs Kruitbosch
b8f887fd76 Bug 1310596 - do not allow errors in reporting migrator data recency to break the rest of the migration, r=mikedeboer
MozReview-Commit-ID: eWr0abwU7p

--HG--
extra : rebase_source : c7582c27866f86666780beb5c7a5b4b3918e1b9a
2016-10-18 11:54:22 +01:00
Justin Dolske
5547aa8006 Bug 1298208 - followup fix for correct JS type. CLOSED TREE 2016-08-26 15:20:48 -07:00
Justin Dolske
19f629190b Bug 1298208 - FX_MIGRATION_HOMEPAGE_IMPORTED probe is (incorrectly) always true. r=mattn
MozReview-Commit-ID: 6wZUeRTKExw
2016-08-26 13:06:14 -07:00
Wes Kocher
12e25dac0f Backed out changeset 8f30fd1bbbe1 (bug 1298208) for build bustage a=backout 2016-08-25 16:37:44 -07:00
Justin Dolske
adb45e70b6 Bug 1298208 - FX_MIGRATION_HOMEPAGE_IMPORTED probe is (incorrectly) always true. r=MattN
MozReview-Commit-ID: 6wZUeRTKExw

--HG--
extra : rebase_source : 2ddbb5906e29dae6e47af8409031f31ddf2bca80
2016-08-25 15:50:41 -07:00
Jared Wein
fd84c776c7 Bug 1292042 - Enable the keyword-spacing rule for eslint. Most of this patch was autogenerated by 'eslint --fix'. Files with .xml extension needed to be changed by hand due to limitations of custom plugin. r=markh
MozReview-Commit-ID: EMjJ3yWt9Wt

--HG--
extra : rebase_source : 2b8327e5a7cf0bfd190d696ad5fe475f13faa3cc
2016-08-04 03:28:58 -04:00
Gijs Kruitbosch
c99c0d5e93 Bug 1289229 - disable automigration undo if people create/change bookmarks/logins, r=mak
MozReview-Commit-ID: DAoNV9H71Yv

--HG--
extra : rebase_source : b75fce027c28a98566523f54427b7f965e79ad52
2016-07-26 12:48:37 +01:00
Gijs Kruitbosch
579b36016a Bug 1276694 - store recency of browser data in telemetry when importing to see how good a predictor default browser is, r=dolske,bsmedberg
MozReview-Commit-ID: 16uPNGGDE68

--HG--
extra : rebase_source : fdb3ad8a3429079cb23cddd4a003b03043a95728
2016-05-30 17:10:54 +01:00
Gijs Kruitbosch
b46aa62ca8 Bug 1275114 - add telemetry to determine how to make browser choices when automatically migrating on first profile startup, r=bsmedberg,Dolske
MozReview-Commit-ID: zVmKTBzAS9

--HG--
extra : rebase_source : 3a311a15534ffe769df550ca4fac320c6f6131f2
2016-05-24 11:44:49 +01:00
Gijs Kruitbosch
939515d3cc Bug 1265368 - enable resetting non-default profiles, r=MattN
MozReview-Commit-ID: KpW9JgghFkn

--HG--
extra : rebase_source : e1a6ce0a05ccd6ef94026c6fdeaf6421d5cffe03
extra : histedit_source : ca0ed957aa68ed495cc2d8897aae3e553dd2ebff%2C8ce1e45de095401a6cc85f912cfebacd384eb989
2016-05-05 21:38:49 +01:00
Dave Townsend
4bf4f02ce7 Bug 1257246: Update browser for eslint 2. r=felipe
Most of this is fixing functions that in some cases return a value but then
can also run to completion without returning anything. ESLint 2 catches this
where previous versions didn't. Unless there was an obvious other choice I just
made these functions return undefined at the end which is effectively what
already happens.

MozReview-Commit-ID: DEskVIjiKDM

--HG--
extra : rebase_source : 07ba1d14655f5d761624b105ef025ec88323d4d5
extra : histedit_source : 9e5ab54ce1b1a5ee1f0fb143f8d1450522455e3b
2016-04-05 11:33:33 -07:00
Gijs Kruitbosch
dc4b4997fd Bug 1246591 - remove preprocessing and fix any other issues, r=MattN
--HG--
extra : commitid : ERDudjbCnHC
extra : rebase_source : df5f44f84c5c56f76a65c887cd5b374284562a61
2016-02-08 12:54:38 +00:00
Gijs Kruitbosch
14415f1212 Bug 1246591 - fix whitespace issues, r=MattN
--HG--
extra : commitid : JI5mQGtLa2f
extra : rebase_source : a8aff743dac30977112b5ce6420631c432601b41
2016-02-08 12:03:10 +00:00
Gijs Kruitbosch
04b6f41448 Bug 1219707 - fix argument passing to migration.js, r=jaws
--HG--
extra : commitid : 8GHFDaUhXA2
2015-10-29 12:16:15 +00:00
Gijs Kruitbosch
b4048dc695 Bug 731025 - Add telemetry for migrator usage and errors, r=MattN,p=bsmedberg
--HG--
extra : commitid : 1TzjbWkzOq7
extra : rebase_source : fad923bd73689a49315e0e737553f0fd146a8d57
2015-10-07 13:34:46 +01:00
Carsten "Tomcat" Book
08997000eb Backed out 2 changesets (bug 1202902) to recking bug 1202902 to be able to reopen inbound on a CLOSED TREE
Backed out changeset 647025383676 (bug 1202902)
Backed out changeset d70c7fe532c6 (bug 1202902)
2015-10-07 14:03:21 +02:00