Commit graph

5572 commits

Author SHA1 Message Date
Mark Banner
bbee5e7f3a Bug 1793414 - Move paste and search handling for the search bar into the search bar code itself. r=jteow
Differential Revision: https://phabricator.services.mozilla.com/D158499
2022-10-07 07:12:18 +00:00
Sandor Molnar
d416a7b827 Backed out 2 changesets (bug 1793414) for causing browser-chrome failures in browser/components/search/test/browser/browser_searchbar_context.js CLOSED TREE
Backed out changeset f27b2a93224e (bug 1793414)
Backed out changeset 1f011637d116 (bug 1793414)
2022-10-06 12:03:15 +03:00
Mark Banner
496c1718fa Bug 1793414 - Move paste and search handling for the search bar into the search bar code itself. r=jteow
Differential Revision: https://phabricator.services.mozilla.com/D158499
2022-10-06 07:44:51 +00:00
Alexandre Poirot
99b6c8357e Bug 1793573 - [devtools] Convert DevToolsSocketStatus.jsm to DevToolsSocketStatus.sys.mjs. r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D158572
2022-10-05 16:07:25 +00:00
Angel_V129
c74a074e42 Bug 1788756 - [Themes] Convert browser/theme JSM modules to ESMs. r=kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D157037
2022-10-04 19:02:24 +00:00
Niklas Baumgardner
14b904f207 Bug 1790855 - Enable screenshots button on about pages when screenshots component is enabled. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D157355
2022-10-04 13:23:19 +00:00
William Durand
7d12af981e Bug 1788994 - Fix test cases when the unifiedExtensions pref is enabled by default. r=rpl,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D157185
2022-10-04 08:45:57 +00:00
Sandor Molnar
fcb74829f6 Backed out changeset 45ea391514c0 (bug 1790855) for causing bc failures in browser_contextmenu CLOSED TREE 2022-10-04 06:41:48 +03:00
Niklas Baumgardner
ffa2f8034a Bug 1790855 - Enable screenshots button on about pages when screenshots component is enabled. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D157355
2022-10-04 02:09:08 +00:00
Sandor Molnar
6d6d17465d Backed out changeset d8835c4ab04f (bug 1790855) for causing bc failures in browser/components/screenshots/tests/browser/browser_screenshots_test_toggle_pref.js CLOSED TREE 2022-10-04 04:12:42 +03:00
Niklas Baumgardner
5ffcda4977 Bug 1790855 - Enable screenshots button on about pages when screenshots component is enabled. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D157355
2022-10-04 00:03:56 +00:00
Csoregi Natalia
13179f500d Backed out changeset d91a621a39be (bug 1785853) for multiple failures e.g.browser_setup_state.js CLOSED TREE 2022-10-03 19:48:44 +03:00
Sarah Clements
2fad8f1409 Bug 1785853 - Close device connected tab after user returns to Firefox View r=sfoster
* Add _closeDeviceConnectedTab to FirefoxViewHandler that's called by the TabSelect event handler
* Add test coverage

Differential Revision: https://phabricator.services.mozilla.com/D158031
2022-10-03 16:07:54 +00:00
Dão Gottwald
68b7f1fcb0 Bug 1792814 - Don't load the home page in hidden tabs such as Firefox View. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D158396
2022-09-30 20:04:37 +00:00
Mark Banner
8d1ebcb9d6 Bug 1792365 - Convert toolkit/modules consumers to use ES module imports directly. r=webdriver-reviewers,perftest-reviewers,geckoview-reviewers,extension-reviewers,preferences-reviewers,desktop-theme-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,robwu,Gijs,sgalich,bytesized,AlexandruIonescu,dao,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D158094
2022-09-29 06:52:34 +00:00
Emilio Cobos Álvarez
4e978b56b5 Bug 1689816 - Implement <tabpanels> and <deck> without XUL layout. r=Gijs,Jamie,morgan,preferences-reviewers,mconley,TYLin
Gijs for front-end bits, layout for the new CSS properties and the
removal of nsDeckFrame / nsStackLayout, Jamie and Morgan for the a11y
changes.

As discussed in the bug, the main tricky part here is handling a11y
correctly. For <deck>, that's trivial (just use `visibility: hidden` to
hide the panels visually, while removing the unselected panels from the
a11y tree).

For <tabpanels> however we need to do something special. We do want to
hide stuff visually, but we want to preserve the contents in the a11y
tree.

For that, the easiest fix is introducing a new privileged CSS property
(-moz-subtree-hidden-only-visually), which takes care of not painting
the frame, but marks stuff offscreen in the accessibility tree. This is
not intended to be a property used widely.

Other than that, the changes are relatively straight-forward, though
some of the accessible/mac changes I could get a sanity-check on.

Differential Revision: https://phabricator.services.mozilla.com/D157875
2022-09-27 04:18:16 +00:00
Marian-Vasile Laza
f54a464c90 Backed out changeset 2f74f8f2ed19 (bug 1689816) for causing reftest failures on skip-ink-multiline-position.html. 2022-09-26 23:24:03 +03:00
Emilio Cobos Álvarez
f875681246 Bug 1689816 - Implement <tabpanels> and <deck> without XUL layout. r=Gijs,Jamie,morgan,preferences-reviewers,mconley,TYLin
Gijs for front-end bits, layout for the new CSS properties and the
removal of nsDeckFrame / nsStackLayout, Jamie and Morgan for the a11y
changes.

As discussed in the bug, the main tricky part here is handling a11y
correctly. For <deck>, that's trivial (just use `visibility: hidden` to
hide the panels visually, while removing the unselected panels from the
a11y tree).

For <tabpanels> however we need to do something special. We do want to
hide stuff visually, but we want to preserve the contents in the a11y
tree.

For that, the easiest fix is introducing a new privileged CSS property
(-moz-subtree-hidden-only-visually), which takes care of not painting
the frame, but marks stuff offscreen in the accessibility tree. This is
not intended to be a property used widely.

Other than that, the changes are relatively straight-forward, though
some of the accessible/mac changes I could get a sanity-check on.

Differential Revision: https://phabricator.services.mozilla.com/D157875
2022-09-26 17:40:30 +00:00
Emilio Cobos Álvarez
cb0b3ab372 Bug 1791972 - Simplify dialog stack and rdm styles. r=Gijs,devtools-reviewers,jdescottes
.browserContainer is relatively positioned, so we can position the
tab-modal dialogs absolutely inside it instead of making them part of
the browser stack.

While at it, make the rdm toolbar part of the regular browserContainer,
just like the regular devtools toolbox is. That way there's no need to
do ResizeObserver shenanigans to be able to let it grow. Keep it also
absolutely positioned tho, because we need to overlay the whole
container when the device modal is opened. That's somewhat gross.

This should in general be simpler to understand than the current set-up,
and more performant to since it avoids the dialog stack from forming
part of the browser element's flow.

Differential Revision: https://phabricator.services.mozilla.com/D157912
2022-09-23 22:23:37 +00:00
Brian
34064a8838 Bug 1788925 - Convert AboutReader from JSM to ESM. r=Gijs.
Differential Revision: https://phabricator.services.mozilla.com/D157034
2022-09-23 21:19:12 +00:00
Evan
f71e1c1af2 Bug 1788783 -Converted Picture in Picture JSM modules to ESMs. r=kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D157039
2022-09-23 18:11:48 +00:00
Daisuke Akatsuka
042de19c2e Bug 1790814: Depends on existing tabs to change the tab to open about:addons page. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D157400
2022-09-21 22:58:47 +00:00
Ryan VanderMeulen
0109742091 Bug 1784692 - Revert focus behavior for new windows introduced by bug 1770818. a=backout 2022-09-21 14:08:31 -04:00
Niklas Baumgardner
33d42fbb13 Bug 1790823 - Firefox View button should not be open when added to toolbar. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D157662
2022-09-19 21:54:45 +00:00
Julian Descottes
87ef6aa2ff Bug 1790753 - [devtools] Track all devtools sockets in DevToolsSocketStatus r=ochameau,Gijs
The DevToolsSocketStatus could be misleading for any usage other than the current one from browser.js since it misses browser toolbox sockets

This patch allows the singleton to track all sockets but changes the API to allow consumers to exclude browser toolbox sockets.

Differential Revision: https://phabricator.services.mozilla.com/D157300
2022-09-14 19:11:22 +00:00
Sarah Clements
204e4fc381 Bug 1787979 - keyboard shortcut navigates to the wrong tab from Firefox View tab r=dao
* Remove index: 0 in FirefoxViewHandler.openTab
* Add condition in tabbrowser _selectNextTab for FirefoxView tab
* Fix tests

Differential Revision: https://phabricator.services.mozilla.com/D156688
2022-09-14 15:20:01 +00:00
Marian-Vasile Laza
02b993c483 Backed out changeset 9bf0a16672ec (bug 1787979) for causing bc failures on browser_sma_click_element.js. CLOSED TREE 2022-09-14 16:45:04 +03:00
Sarah Clements
20971e4d83 Bug 1787979 - keyboard shortcut navigates to the wrong tab from Firefox View tab r=dao
* Remove index: 0 in FirefoxViewHandler.openTab
* Add condition in tabbrowser _selectNextTab for FirefoxView tab
* Fix tests

Differential Revision: https://phabricator.services.mozilla.com/D156688
2022-09-14 11:24:58 +00:00
Brian
b34f9afb6d Bug 1788776 - Convert screenshots component from JSM to ESM. r=niklas.
Differential Revision: https://phabricator.services.mozilla.com/D157038
2022-09-11 19:08:38 +00:00
Bernard Igiri
ae6f7157e4 Bug 1784054 - Enable full height scrolling in Colorway Closet modal in small windows r=dao
Updated SubDialog.jsm's sizeTo=available to have better support for responsive layouts with the ability to specify max height and widths on the dialog.

Differential Revision: https://phabricator.services.mozilla.com/D155014
2022-09-08 17:43:58 +00:00
Mark Banner
c9b0aa74c1 Bug 1789254 - Migrate enterprisepolicies consumers to use ESM imports directly. r=mkaply,necko-reviewers,application-update-reviewers,nalexander
Differential Revision: https://phabricator.services.mozilla.com/D156464
2022-09-08 14:40:07 +00:00
Norisz Fay
1bb0960ae2 Backed out 3 changesets (bug 1789254) for causing bc failures on browser_xpcom_graph_wait.js CLOSED TREE
Backed out changeset bea1e1ba4a14 (bug 1789254)
Backed out changeset 4086aaa5f3d0 (bug 1789254)
Backed out changeset 131cac1d1146 (bug 1789254)
2022-09-08 17:14:00 +03:00
Mark Banner
5dca28c108 Bug 1789254 - Migrate enterprisepolicies consumers to use ESM imports directly. r=mkaply,necko-reviewers,application-update-reviewers,nalexander
Differential Revision: https://phabricator.services.mozilla.com/D156464
2022-09-08 12:43:32 +00:00
Dão Gottwald
684a24a549 Bug 1787797 - Let the Firefox View menu item re-add the button to the tabs toolbar if it got previously removed. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D156412
2022-09-07 12:21:25 +00:00
Katherine Patenio
b1e0f5998c Bug 1767827: Use Nimbus feature (with pref fallback) as the condition for enabling Firefox View r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D156004
2022-09-02 15:45:21 +00:00
Gijs Kruitbosch
ba0b238fde Bug 1787437 - close the Firefox View tab when removing the FxView toolbar item completely, r=dao
Differential Revision: https://phabricator.services.mozilla.com/D155921
2022-09-02 12:49:54 +00:00
James Teow
3f63de5a98 Bug 1779465 - Part 1: Show search term on default SERP - r=adw
Differential Revision: https://phabricator.services.mozilla.com/D153280
2022-09-01 19:26:29 +00:00
Niklas Baumgardner
cda1615035 Bug 1784294 - Sync tabs when Firefox View tab is selected. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D154825
2022-09-01 13:06:50 +00:00
Daisuke Akatsuka
836333a034 Bug 1786249: Fixup sponsored link. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D155807
2022-08-30 22:02:18 +00:00
Butkovits Atila
59d03e0b1d Backed out 2 changesets (bug 1676492) for causing failures at test_navigation.py. CLOSED TREE
Backed out changeset 09fd88048f35 (bug 1676492)
Backed out changeset bc76e6966ec9 (bug 1676492)
2022-08-30 20:56:51 +03:00
Sean Feng
712dda078c Bug 1750034 - Remove lazyload telemetry related code r=emilio
We have decided to use 600px in all directions, there's no need
to keep the telemetry stuff around.

Differential Revision: https://phabricator.services.mozilla.com/D155879
2022-08-30 16:00:11 +00:00
Neil Deakin
507f721d6c Bug 1676492, show the bookmarks toolbar when a new window is opened when the preference is set to show a blank page, r=Mardak,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D155003
2022-08-30 14:02:02 +00:00
Neil Deakin
444a492608 Bug 1676492, create a special blank tab page that will show the bookmarks toolbar when 'Only Show on New Tab' is used' even when the new tab page is disabled, r=Gijs,Mardak
Differential Revision: https://phabricator.services.mozilla.com/D154319
2022-08-30 14:02:01 +00:00
Meg Viar
4120ecafe3 Bug 1786356 - Create Firefox View open Tracker r=niklas,jprickett
Differential Revision: https://phabricator.services.mozilla.com/D155432
2022-08-26 16:16:17 +00:00
Gijs Kruitbosch
31960f9a88 Bug 1787443 - ensure fxview button is always present by default, also for upgrading profiles, r=dao
Differential Revision: https://phabricator.services.mozilla.com/D155695
2022-08-26 15:50:18 +00:00
Mark Banner
fb7f9b8a58 Bug 1786899 - Remove unused uri argument to BrowserSearch.addEngine. r=jteow
Differential Revision: https://phabricator.services.mozilla.com/D155498
2022-08-26 07:55:44 +00:00
Mark Banner
ef27351558 Bug 1786899 - Remove unused BrowserSearch.loadAddEngines and remove formatURL. r=jteow,preferences-reviewers
formatURL is only used in one other place - nsContextMenu.js, so we don't really need that when we can call the necessary function direct.

Also moves `searchEnginesURL` into SearchUIUtils, as that seems a reasonable place to start storing things like that.

Differential Revision: https://phabricator.services.mozilla.com/D155496
2022-08-26 07:55:44 +00:00
Paul Zuehlcke
3e16fc7823 Bug 1751481 - Enable felt privacy features by default and integrate with Nimbus. r=dao,preferences-reviewers,Gijs
Depends on D155013

Differential Revision: https://phabricator.services.mozilla.com/D155065
2022-08-25 11:17:39 +00:00
Dão Gottwald
fc26620216 Bug 1786293 - Move Firefox View button from CustomizableWidgets to markup. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D155356
2022-08-24 15:51:44 +00:00
Norisz Fay
ccea767237 Backed out changeset ebba7740ac81 (bug 1784294) for causing bc failures on browser_setup_state.js CLOSED TREE 2022-08-24 09:33:55 +03:00