Commit graph

37 commits

Author SHA1 Message Date
Brian Grinstead
62ec8eba92 Bug 1407737 - Don't persist sidebar state unless if the last window is being closed. r=mikedeboer
MozReview-Commit-ID: 7wBtCZDG1V3

--HG--
extra : rebase_source : 414412a0f01566b84f28d12df4985369d2a8110b
2017-10-18 08:32:41 -07:00
Gijs Kruitbosch
069f2c2997 Bug 1391280 - store last sidebar command irrespective of whether sidebar was open, r=bgrins,mixedpuppy
MozReview-Commit-ID: HBfdW5vEZaD

--HG--
extra : rebase_source : 5058884698a2a2144b921a36abbe7c8c3a1fda52
2017-08-23 14:06:26 +01:00
Shane Caraveo
73b473d1aa Bug 1385630 fix extension sidebar restore after app update, r=Gijs
MozReview-Commit-ID: IR0UDJgrp58

--HG--
extra : rebase_source : 6bb066650a94c3991e05c72ff3fb28cdb0e5a021
2017-09-10 13:36:54 -07:00
Brian Grinstead
2ed7602d7a Bug 1394207 - Export a function to show the sidebar without firing focus for session restore;r=Gijs
MozReview-Commit-ID: uHrShpl2xJ

--HG--
extra : rebase_source : b9a79d541171982c6860edec366722821844f3e1
2017-09-06 08:58:10 -07:00
Brian Grinstead
935f53a280 Bug 1394207 - Only fire the SidebarFocused event for non-startup entry points;r=Gijs
If the sidebar is being opened during startup (either at delayedLoad or when being
adopted from another window), we don't want sidebar panels to steal focus from the page

MozReview-Commit-ID: 4mBP2dQdyKY

--HG--
extra : rebase_source : 1349ddcac55fc7bf7e02ff410e6d49d1c03facb3
2017-09-06 08:49:07 -07:00
Adrian Wielgosik
8d734f5355 Bug 1387356 - Remove deprecated sidebar functions. r=dao
MozReview-Commit-ID: R7iw6RpDmc

--HG--
extra : rebase_source : 792d014a8beb62463c3b13556bf0b4878238401a
2017-09-04 19:53:35 +02:00
Gijs Kruitbosch
5098cc9707 Back out b5f5d47ac123 (bug 1391280) for breaking when session store tries to restore sidebars (latent errors in webextension test browser/components/extensions/test/browser/test-oop-extensions/browser_ext_tabs_lazy.js ) on a CLOSED TREE
MozReview-Commit-ID: LO2dv6ALkfZ

--HG--
extra : rebase_source : 4eab585a14d52bb84a39d67b65b4b52098dee4a9
extra : amend_source : 2dd6e64a005fd949ab1429190b46dbb6861c9898
2017-08-25 12:17:21 +01:00
Gijs Kruitbosch
45e59c97f6 Bug 1391549 - persist positionend value to ensure sidebar side is correct on startup when sidebar is closed, r=bgrins
MozReview-Commit-ID: LOn3Q7Hg3BC

--HG--
extra : rebase_source : 712fc121385e12045aa9e96ff0d051ce858a6530
2017-08-23 14:07:46 +01:00
Gijs Kruitbosch
a39a60a912 Bug 1391280 - store last sidebar command irrespective of whether sidebar was open, r=bgrins
MozReview-Commit-ID: HBfdW5vEZaD

--HG--
extra : rebase_source : 167ed942355129e062746fe012f26fbb47016732
2017-08-23 14:06:26 +01:00
Gijs Kruitbosch
7cf533b94e Bug 1372601 - fix title being gone when closing and reopening the sidebar with a webpage loaded, r=bgrins
MozReview-Commit-ID: JvZ5BbVqdz2

--HG--
extra : rebase_source : 861662ebce7559774666315be2a20ed962295953
2017-08-17 12:24:05 +01:00
Mike de Boer
25583e0eda Bug 1377968 - Add a tools section and subview to the Bookmarks subview inside the Library widget. r=Gijs
MozReview-Commit-ID: GqbUMbuvYoO

--HG--
extra : rebase_source : 09f489b9b558a9b8dfc0aecbf1ab863d816ee43b
2017-08-15 13:34:41 +02:00
Blake Winton
7da5825a6f Bug 1374048 - Show the sidebar extension icon in the header. r=Gijs, ui-r=shorlander.
MozReview-Commit-ID: 3FLYauvCs8E

--HG--
extra : rebase_source : 34e979c2670c162778ad8c31db7791c0c705bcdd
2017-08-08 14:31:40 -04:00
Nihanth Subramanya
d6a2e3e8a6 Bug 1387022 - Don't attempt to show the sidebar switcher panel if it's closing. r=Gijs
MozReview-Commit-ID: Cw0VrpC4V8U

--HG--
extra : rebase_source : 60d2bd8b124cc022696f34786b78bd9abcb918a8
2017-08-03 17:41:41 +05:30
Brian Grinstead
54aa0a0210 Bug 1366851 - Flip the sidebar icon depending on if the sidebar is positioned at the start or end of the browser;r=Gijs
MozReview-Commit-ID: Kaobl1Ox2QZ

--HG--
extra : rebase_source : c9979bb5da2cdbf61553394c87f57adac64a3257
2017-06-28 10:15:48 -07:00
Brian Grinstead
2d93723913 Bug 1372954 - Do not persist sidebar checked state to document;r=Gijs
The the state will be properly set in the show() call anyway, and the xulstore
doesn't track attribute removals which led to improper checked state

MozReview-Commit-ID: rGb6Td55eW

--HG--
extra : rebase_source : 2d145a02d1cfe3bf31f1bf0c6ad8739f01a37f4e
2017-06-19 13:45:03 -07:00
Gijs Kruitbosch
a9dd1d894a Bug 1368317 - fix sidebar overlap styling for when the sidebar is on the end-side of the window (rhs in ltr), r=bgrins
MozReview-Commit-ID: 3BZily6xSD2

--HG--
extra : rebase_source : 0332398458dab27542c49b75614153c6c44aed25
2017-06-15 14:31:54 +01:00
Brian Grinstead
7133c66b38 Bug 1360282 - Remove the popup that opens from the sidebar toolbar button;r=Gijs
MozReview-Commit-ID: 4N841nISf3F

--HG--
rename : browser/components/customizableui/test/browser_988072_sidebar_events.js => browser/components/customizableui/test/browser_sidebar_toggle.js
extra : rebase_source : ac822ab6f4f64a32c51b5cd55ba7f87bee4f90f8
2017-06-13 08:14:58 -07:00
Brian Grinstead
536568a93b Bug 1360282 - Use the existing title setter for SidebarUI instead of changing the value directly;r=Gijs
MozReview-Commit-ID: FCke6FxUrJj

--HG--
extra : rebase_source : bc2b45ea29848aee3767757a8a0497eaf065cd0d
2017-06-13 08:14:58 -07:00
Brian Grinstead
b6848cb6ba Bug 1360282 - Remove _setVisibility helper now that the sidebar is always shown through show();r=Gijs
MozReview-Commit-ID: FWJshLtYZ3h

--HG--
extra : rebase_source : ed67bebb88ca18ba009d3b943d52086e648161f4
2017-06-13 08:14:57 -07:00
Brian Grinstead
5725b640bc Bug 1360282 - Use querySelectorAll instead of getElementsByAttribute and a condition;r=Gijs
MozReview-Commit-ID: Fq6pXxiSZ7b

--HG--
extra : rebase_source : 6a76148a3adaef616df2107f62d2a1138dd86aa0
2017-06-13 08:14:57 -07:00
Brian Grinstead
3806dc7f1c Bug 1360282 - Always call show to open the sidebar, even when it's called from startDelayedLoad;r=Gijs
By running through the same path anytime the sidebar is shown it will be easier to
implement the sidebar-button as a toggle, since we can rely on consistent state
to determine which sidebar was opened last.

MozReview-Commit-ID: 14HXtr8uNmb

--HG--
extra : rebase_source : dc1f7224f62af95c50672e278613da7951db8571
2017-06-13 08:14:10 -07:00
Florian Quèze
fc7a0af0d3 Bug 1369751 - avoid constructing the sidebar browser before first paint, r=mikedeboer. 2017-06-09 15:11:07 +02:00
Brian Grinstead
ddf43a91db Bug 1355331 - Create an option to move sidebar between the left and right sides of the window;r=mikedeboer
MozReview-Commit-ID: 79ts9djMC3e

--HG--
extra : rebase_source : 13a3281744ca1d16b478bc6269ce4f189e8b22b4
2017-05-24 09:54:34 -07:00
Brian Grinstead
5bf51d8dd7 Bug 1355324 - Create a popup to switch between sidebars from the sidebar header;r=Gijs
MozReview-Commit-ID: HBwIfmtKybi

--HG--
rename : browser/base/content/test/general/browser_bug409481.js => browser/base/content/test/sidebar/browser_bug409481.js
extra : rebase_source : ae9d07e61e997c60b9633126296f20b9c3bed7f4
2017-05-16 10:31:00 -07:00
Shane Caraveo
fd8887b9cd Bug 1350597 fix reload/upgrade of sidebar addon, r=kmag
MozReview-Commit-ID: FcC7zJn1ka5

--HG--
extra : rebase_source : 860e43a19619acaaf4762c5810d489dab1d6ef73
2017-04-14 17:01:23 -07:00
Shane Caraveo
6359cf10d6 Bug 1208596 implement sidebar api for webextensions, f?kmag, gijs r=Gijs,kmag
MozReview-Commit-ID: 6GMdU5kcrFR

--HG--
extra : rebase_source : 03acc88de0a87051f222408cc6e80b8f62a770cb
2017-02-09 15:32:50 -08:00
Jared Wein
ecab54a7c9 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje

--HG--
extra : rebase_source : 0572a35415a766a3f31d266760ecd07f0dcc3f72
2016-12-29 18:34:54 -05:00
Wes Kocher
0dfb7c2b5c Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
7255df4e9a Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR

--HG--
extra : rebase_source : da7172285d43b820421557ed3b05887e091ff939
2016-12-29 15:20:47 -05:00
Jared Wein
871ed4e3ba Bug 1291855 - Enable the no-else-return rule for eslint. r=Felipe,kmag,mossop
MozReview-Commit-ID: DYOmE6xwMJh

--HG--
extra : rebase_source : bc81b68ea5599fd1815dc34dac7106eef7044483
2016-08-03 18:54:59 -04:00
Mark Hammond
6b215d4b0f Bug 1241571 - Collect synced tabs and sidebar ui telemetry. r=Gijs
Adds UI telemetry for sidebar opening and closing and actions taken in the
SyncedTabs menu and side. Also adds a "sync-state" object so that analysis
of the Synced Tabs data can determine if the user has Sync configured at the
time.

MozReview-Commit-ID: JDxFmlNMi7n
2016-05-18 10:39:14 +10:00
Zachary Carter
4937ef326e Bug 1210586 - Create a Synced tabs sidebar r=markh 2016-01-27 14:40:30 -08:00
Felipe Gomes
909d49249d Bug 1228627 - Remove #includes from browser.js. r=Gijs 2015-11-30 12:13:57 -02:00
Shu-yu Guo
64db2267cf Bug 1202902 - Mass replace toplevel 'let' with 'var' in preparation for global lexical scope. (rs=jorendorff) 2015-09-15 11:19:45 -07:00
Mark Capella
4acb3731d8 Bug 1133489 - Hook up "Open ReadingList" button in desktop ReaderMode, r=unfocused 2015-02-27 14:31:31 -05:00
Mark Hammond
385b0dc1aa Bug 1136291 - better handle an unexpected (eg, the hidden DOM window) being the window opener when initializing the sidebar. r=Unfocused 2015-02-25 20:51:21 +11:00
Blair McBride
40d4ef0e6c Bug 1123517 - Refactor sidebar code. r=florian
--HG--
extra : transplant_source : %04%FAZ%B3%DD%EB%8C%28%9Bj%CB%B3%D1%89%D9AJ%22%08%C6
2015-02-20 21:21:33 +13:00