Commit graph

544 commits

Author SHA1 Message Date
Mark Banner
f99b0cbb91 Bug 1484482 - Fix the bookmarks menu when it is displayed via the hidden window. r=paolo
MozReview-Commit-ID: 7VYNxFmedZl

Differential Revision: https://phabricator.services.mozilla.com/D3923

--HG--
extra : moz-landing-system : lando
2018-08-22 10:17:28 +00:00
ExE Boss
73411195a3 Bug 1482498 - Remove mozMatchesSelector(…) usage from browser‑places.js r=miketaylr
Differential Revision: https://phabricator.services.mozilla.com/D3766

--HG--
extra : moz-landing-system : lando
2018-08-20 18:36:58 +00:00
Paolo Amadini
73dd1c2b03 Bug 1481813 - Part 3 - Remove bookmarkThisPageBroadcaster. r=Standard8,bgrins
The PageActions API is now used to assign a title to the bookmark action.

This also prevents some tooltips from being set unnecessarily on menu items.

Differential Revision: https://phabricator.services.mozilla.com/D3010

--HG--
extra : source : 9222f57d2c20b59b878660b0b998646101d70022
extra : amend_source : a160298483258a7bbd9920dd4eba9dcc43cfb4f3
2018-08-13 17:25:28 +01:00
Paolo Amadini
025cd83e9c Bug 1481813 - Part 2 - Move reference strings out of the bookmark broadcaster. r=Standard8
This prevents the reference string attributes from being replicated unneededly.

Differential Revision: https://phabricator.services.mozilla.com/D3008

--HG--
extra : source : 99addb2df281405ebd65805884ffde95c553f6ea
2018-08-13 17:02:44 +01:00
Paolo Amadini
88c6b35cb5 Bug 1481813 - Part 1 - Remove unneeded broadcaster observers for bookmarks. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D3007

--HG--
extra : source : a2067cf24c1befd37d200fe7055dbdb06ad9c152
2018-08-09 13:13:27 +01:00
Mark Banner
f1731211b5 Bug 1479722 - Rework PlacesUtils.setCharsetForURI to PlacesUIUtils.setCharsetForPage and avoid main thread sync io. r=mak
MozReview-Commit-ID: HeO3Mm5Dibo

Differential Revision: https://phabricator.services.mozilla.com/D2582

--HG--
extra : moz-landing-system : lando
2018-08-01 10:13:59 +00:00
Mark Striemer
f106ce9b88 Bug 1478042 - Check if gBrowser exists in History menu for hidden tabs r=mak
MozReview-Commit-ID: F8zhbb4l7J8

--HG--
extra : rebase_source : 1a35e66c2bb8558ec76d84c2342eee695b910107
2018-07-27 17:13:55 -05:00
Boris Zbarsky
270fa12c79 Bug 1476145 part 3. Stop using getInterface(nsIDOMWindowUtils) in browser/. r=gijs 2018-07-24 19:47:41 -04:00
Brian Grinstead
96dc530924 Bug 1476333 - Refer to AppConstants.BROWSER_CHROME_URL to get the browser URL from the frontend;r=Gijs
Before this change, we accessed the browser URL in the following ways:

- "chrome://browser/content/browser.xul"
- "chrome://browser/content/" (which redirects to chrome://browser/content/browser.xul)
- Services.prefs.getCharPref("browser.chromeURL") which returns "chrome://browser/content/"
- getBrowserURL() from utilityOverlay.js

MozReview-Commit-ID: I5vtRke1x9t

--HG--
extra : rebase_source : c525350a1954740873e85b045cbb14a8b43aa89d
2018-07-24 08:12:50 -07:00
Dão Gottwald
0a52ebeb01 Bug 1476901 - Stop ever hiding editBookmarkPanelContent and editBookmarkPanelBottomButtons in the bookmark panel. r=mak
MozReview-Commit-ID: CwfHapJicIG

--HG--
extra : rebase_source : 2a90878ef2af61f240c6e3d986f119c013b6b3d4
2018-07-19 13:43:30 +02:00
Abdoulaye O. Ly
ce5ee236b1 Bug 1458067 - Implement ability to bookmark a selection of tabs. r=Gijs
MozReview-Commit-ID: 4KE3qSf3j0y

--HG--
extra : rebase_source : e4a30f6706c455f08d9519e86b61ea389eb89ed5
2018-07-12 00:25:35 +00:00
Marco Bonardo
d932936d53 Bug 1475276 - Remove some no more necessary usage of promiseItemGuid. r=lina
Some code is unnecessarily using promiseItemGuid

Differential Revision: https://phabricator.services.mozilla.com/D2100

--HG--
extra : moz-landing-system : lando
2018-07-12 21:38:21 +00:00
Dão Gottwald
343857e754 Bug 1473862 - Remove URL and title arguments from PlacesCommandHook.bookmarkPage. r=standard8
MozReview-Commit-ID: MYERqUTpD6

--HG--
extra : rebase_source : 7501a2a5c1cb163e5ffc2cb52490f8dd11405235
2018-07-06 14:08:03 +02:00
Dão Gottwald
96a00916f7 Bug 1473073 - Remove PlacesCommandHook.bookmarkPage's browser argument. r=mak
MozReview-Commit-ID: BH5r7Tn8KV1

--HG--
extra : rebase_source : 845e8ec126d91f682ed09939aa89c07bd2c1078e
2018-07-03 22:46:46 +02:00
Dão Gottwald
03203945f5 Bug 1472275 - Remove PlacesCommandHook.bookmarkPage's aShowEditUI argument. r=standard8
MozReview-Commit-ID: CGYSF1OvoVg

--HG--
extra : rebase_source : 3470cd6522ae3c3e2802dfa2e032643c7fbdcb55
2018-06-29 19:45:35 +02:00
Dão Gottwald
f794a876e1 Bug 1468077 - Stop disabling cmd_close and cmd_closeWindow in the bookmark panel since it seems to be half-broken and is inconsistent with other panels. r=mak
MozReview-Commit-ID: AkKaq5Kon77

--HG--
extra : rebase_source : 23abeac68a167cb45e128474e322ac9283fa91ce
2018-06-29 13:33:05 +02:00
Dão Gottwald
bea31df2b2 Bug 1459878 - Add "Show editor when saving" checkbox to the Bookmark panel. r=mak
MozReview-Commit-ID: IUji9cQmVz9

--HG--
extra : rebase_source : 67e0f9a5bd5ca0c5292fa738119b01cfec9dda7a
2018-06-29 12:39:30 +02:00
Dão Gottwald
50b93853b4 Bug 1471585 - Stop assuming that BookmarkingUI.anchor can be null. r=standard8
MozReview-Commit-ID: JpObSnChEU0

--HG--
extra : rebase_source : 0b96b14c94a5823073cafe65e327b7294f5574bf
2018-06-27 15:14:27 +02:00
Dão Gottwald
bd9b790de8 Bug 1471580 - Remove unused _bookmarkPopupInitialized flag. r=standard8
MozReview-Commit-ID: LI7oXGLDyso

--HG--
extra : rebase_source : f8a4a2282b215ef4d02c91995916002af87d23b4
2018-06-27 14:57:16 +02:00
Mark Banner
5b8ba7f27e Bug 1452645 - Remove load in sidebar functionality. r=lina,mak
Based on patch by mixedpuppy.

MozReview-Commit-ID: BZwOtr4VbCH

--HG--
extra : rebase_source : 2e3ad3fedaf82d0e5d3db9bcebf1c2faa46447e7
2018-06-06 21:00:45 +01:00
Dão Gottwald
cd159c76f7 Bug 1459907 - Implement new bookmark confirmation. r=mak
MozReview-Commit-ID: DsTXTKgX72y

--HG--
extra : rebase_source : 836ba1340189d22e4ee9f0fdb1c4ff339fbd266f
2018-06-23 15:28:47 +02:00
Mark Striemer
337dd181f0 Bug 1446101 - Part 3: Make History > Hidden Tabs deep link to Hidden Tabs menu r=mak
MozReview-Commit-ID: KgfpYbfVjUm

--HG--
extra : rebase_source : a74189c177c39a9e1c450e64aa6da57ff7635885
2018-06-04 17:11:23 -05:00
Dão Gottwald
bd123422ea Bug 1460248 - Display screenshot and favicon in the New Bookmark dialog. r=mak
MozReview-Commit-ID: C5zMr2HlBC9

--HG--
extra : rebase_source : 15be04a537c66dbf1ca53c4a0fb6e3b6fbf61d2c
2018-06-19 20:36:20 +02:00
Sam Foster
3a33c9cd4e Bug 1385262 - Restore the star icon when the bookmark animation ends. r=jaws
* Also remove unused frame at the end of the bookmark-animation

MozReview-Commit-ID: 5zOO1gXEfcz

--HG--
extra : rebase_source : 678595644a8a8ad5d08f7e7f211dc3013e2ea7b6
2018-06-04 12:21:26 -07:00
Mark Banner
ea3dbe0fdd Bug 1460579 - Replace the 'bookmarkPropertiesDialog/folderLastUsed' annotation with a key/value pair in moz_meta. r=mak
MozReview-Commit-ID: GpEPxOMDret

--HG--
extra : rebase_source : ca691591356d12d17c6e51f5fc3b0cd4cfe687da
2018-05-11 07:35:59 +01:00
Dão Gottwald
9cf7a7f896 Bug 1464489 - When creating a new bookmark, the bookmark panel should be titled "New Bookmark" instead of "Page Bookmarked". r=standard8
MozReview-Commit-ID: 1OeIdsf3bx

--HG--
extra : rebase_source : 73fa791b0ce1d4f7cb2f62035633f0e2b66f609e
2018-05-25 20:22:35 +02:00
Mark Banner
9f30e28934 Bug 1463738 - Remove the Bookmark description UI. r=dao
This removes the bookmark description UI, but leaves the backend in-place for a release or two, so that users have time to save anything they want (e.g. via backup).
The backend will be removed in bug 1402890.

MozReview-Commit-ID: La4AYFar7eK

--HG--
extra : rebase_source : 02bfe3cacdac331d09d5e62a1a70f48b68741670
2018-05-23 17:15:09 +01:00
Tawny Hoover
76e5f6e185 Bug 1400323 - Refactor code for openInTabClosesMenu pref to avoid needing setTimeout on Mac. (cleanup on popuphidden) r=mak
MozReview-Commit-ID: FR6vZksnFEz

--HG--
extra : rebase_source : 2600a29f733f179426a65c096fc264de70d3dff3
2018-05-17 22:32:47 -04:00
Mark Striemer
46f9153fac Bug 1455300 - Part 2: Include hidden tabs in the History menu r=mak
MozReview-Commit-ID: 8sKrAJVIAD5

--HG--
extra : rebase_source : 3f60e2c766051b6e8c8f92cb6680e7f528d8895a
2018-05-10 16:01:36 -05:00
Dão Gottwald
dace246775 Bug 1464384 - Stop returning true/false from focusAndSelectUrlBar. r=mak
MozReview-Commit-ID: BKmsjCRZiLs

--HG--
extra : rebase_source : b40289a591de543a8efd9c4470b576d4cb37859d
2018-05-25 15:38:09 +02:00
Dão Gottwald
9515340567 Bug 1459887 - Relabel the "Remove Bookmark" button to "Cancel" in the New Bookmark dialog. r=standard8
MozReview-Commit-ID: EcCW2eBzfBT

--HG--
extra : rebase_source : f9160b3a36085f375bb47fe0d18740fd7e020ebb
2018-05-25 10:53:53 +02:00
Mark Banner
11e49d2982 Bug 824502 - Change folder=<id> to parent=<guid> in Places' bookmark queries. r=mak
This allows queries to be stable across devices, and requires less work to obtain the ids.

MozReview-Commit-ID: 5KAKKags7o9

--HG--
extra : rebase_source : 22c01cf5b24468dd76dabe63fa9d1033d4138e54
2018-04-26 09:05:00 +01:00
Dão Gottwald
2ae6b628dc Bug 1459885 - Implement new header style and lay out labels above input fields in the new bookmarks dialog. r=mak
MozReview-Commit-ID: 9FmGhfP9aDo

--HG--
extra : rebase_source : eaf2854b569ecb2e7c8012b65b3f0f9b94a47139
2018-05-22 12:21:52 +02:00
Kris Maglione
a259026c9d Bug 1456035: Part 4 - Convert callers of XPCOMUtils.generateQI to ChromeUtils.generateQI. r=mccr8
This also removes any redundant Ci.nsISupports elements in the interface
lists.

This was done using the following script:

acecb401b7/processors/chromeutils-generateQI.jsm

MozReview-Commit-ID: AIx10P8GpZY

--HG--
extra : rebase_source : a29c07530586dc18ba040f19215475ac20fcfb3b
2018-04-22 20:55:06 -07:00
Neil Deakin
cf9835ac8b Bug 1446961, remove obsolete calls to showPopup and replace usages of the popup box object with the same methods defined on popups, r=paolo 2018-04-27 11:04:36 -04:00
Paolo Amadini
3193903d17 Bug 1391948 - Don't use checkboxes for the "View Bookmarks Toolbar" and "View Bookmarks Sidebar" items in the Bookmarks button menu. r=mak
MozReview-Commit-ID: 2P3yV6xHLxi

--HG--
extra : rebase_source : 9352eac0344844218622149a3dc34959e620d431
2018-04-11 12:42:18 +01:00
Jonathan Kingston
ff73ac0338 Bug 1374741 - Within browser/ make openUILinkIn() provide the correct triggeringPrincipal. r=gijs
MozReview-Commit-ID: 1NQrlWzIBja

--HG--
extra : rebase_source : 29d337e111d82e9c5729b5a59e1a16d06e67774c
2018-02-21 14:28:48 +00:00
Manish Kumar
8084e0be59 Bug 1450588 - Remove old bookmark animation code and images. r=ntim,dao 2018-04-04 10:47:50 +02:00
Paolo Amadini
bd53878f66 Bug 1434860 - Part 2 - Remove support for menu-button toolbar buttons. r=enn
MozReview-Commit-ID: MTLaIPzg7a

--HG--
extra : rebase_source : edcefa844e36f8e1ff4199580502d516d26b0f8f
extra : amend_source : ca4896a89bb7b45aef8d782d31e47d4ed3be5351
extra : source : 54f36172186d7345c6aeb92fd3c1254717156767
2018-04-03 16:26:03 +01:00
Masayuki Nakano
989795493b Bug 1449018 - The bookmark panel should listen to keypress event at the system event group r=mak
The bookmark panel should handle keypress events at the system event group
because it needs to handle keypress events after autocomplete module which
handles keypress events at the system event group.

MozReview-Commit-ID: 9KjBlQ59gHw

--HG--
extra : rebase_source : 7a626d2b1bd7ae4f8fd917d5e569be34e34227dc
2018-03-27 16:50:18 +09:00
Marco Bonardo
59e8fa7fa3 Bug 1448362 - Remove some unused code from Places. r=standard8
MozReview-Commit-ID: DQCoYyZIvGD

--HG--
extra : rebase_source : 4e54453619111fcae1d57627049b0bf73ab01c23
2018-03-23 16:26:56 +01:00
Brendan Dahl
c52106c442 Bug 1444228 - Remove editBookmarkOverlay.xul. r=standard8
Move the main contents of editBookmarkOverlay.xul into an include file and
inline the DTD and CSS files where used. Convert several chrome tests to
browser tests since the preprocessor is hard to use within the testing
framework.


MozReview-Commit-ID: DpPBOpZSuBN

--HG--
rename : browser/components/places/content/editBookmarkOverlay.js => browser/components/places/content/editBookmark.js
rename : browser/components/places/content/editBookmarkOverlay.xul => browser/components/places/content/editBookmarkPanel.inc.xul
rename : browser/components/places/tests/chrome/test_bug427633_no_newfolder_if_noip.xul => browser/components/places/tests/browser/browser_bug427633_no_newfolder_if_noip.js
rename : browser/components/places/tests/chrome/test_bug485100-change-case-loses-tag.xul => browser/components/places/tests/browser/browser_bug485100-change-case-loses-tag.js
rename : browser/components/places/tests/chrome/test_bug631374_tags_selector_scroll.xul => browser/components/places/tests/browser/browser_bug631374_tags_selector_scroll.js
rename : browser/components/places/tests/chrome/test_editBookmarkOverlay_keywords.xul => browser/components/places/tests/browser/browser_editBookmark_keywords.js
rename : browser/components/places/tests/chrome/test_editBookmarkOverlay_tags_liveUpdate.xul => browser/components/places/tests/browser/browser_editBookmark_tags_liveUpdate.js
rename : browser/themes/linux/places/editBookmarkOverlay.css => browser/themes/linux/places/editBookmark.css
rename : browser/themes/osx/places/editBookmarkOverlay.css => browser/themes/osx/places/editBookmark.css
rename : browser/themes/windows/places/editBookmarkOverlay.css => browser/themes/windows/places/editBookmark.css
extra : rebase_source : aca072691251c1a44e82ab8091796abd2b140e22
2018-03-16 09:26:49 -07:00
Mark Banner
2155e56144 Bug 1310295 - Make left pane queries virtual in the Places Library window. r=kitcambridge,mak
MozReview-Commit-ID: DcEMAlrXu8R

--HG--
extra : rebase_source : c98e6a50702ef0c238d036fa2a26f4a6ac9f15af
2018-02-16 20:30:04 +00:00
Dorel Luca
7065341d2f Backed out 2 changesets (bug 1310295) for Mochitest and TV failures on browser/components/places/tests/browser/browser_bookmark_folder_moveability.js
Backed out changeset a277657bfffa (bug 1310295)
Backed out changeset b1af75c617ea (bug 1310295)

--HG--
extra : rebase_source : cb7317f5afa7c828ec3b6d9b7679b474fa9cf5da
2018-03-14 18:23:46 +02:00
Mark Banner
80abee119b Bug 1310295 - Make left pane queries virtual in the Places Library window. r=kitcambridge,mak
MozReview-Commit-ID: DcEMAlrXu8R

--HG--
extra : rebase_source : a956958f5c9adde0ee775e9bc918a8970564bbb7
2018-02-16 20:30:04 +00:00
Marco Bonardo
388f9e4090 Bug 1439315 - 1 - rename InsertionPoint to PlacesInsertionPoint. r=standard8
MozReview-Commit-ID: 1NfkueEUPXC

--HG--
extra : rebase_source : 9e3e6f58742a0900fdd73e6c5ed5089f7d01da63
2018-02-28 12:10:12 +01:00
Florian Quèze
c714053d73 Bug 1433175 - scripted patch to replace Components.classes[, Components.interfaces.nsI, Components.utils. and Components.results. with Cc, Ci, Cu and Cr, r=Mossop. 2018-02-28 18:51:33 +01:00
Tawny Hoover
85044e0002 Bug 1420749 - Allow browser.bookmarks.openInTabClosesMenu to work with containers as well as single menuitems r=mak
MozReview-Commit-ID: Bba3pLyHZUV

--HG--
extra : rebase_source : 9b82b3452277b2230783329c1f68edde2d967848
2018-02-08 20:59:08 -05:00
Mark Banner
362505f227 Bug 1423896 - Make the All Bookmarks folder for the left pane of the Library a virtual query. r=mak
MozReview-Commit-ID: HzJ9y1fiEz1

--HG--
extra : rebase_source : 27b0280e9dfef2626d187f9b8a81f23e4583302f
2017-12-07 14:15:39 +00:00
Coroiu Cristina
1c85c04c62 Backed out 5 changesets (bug 1423896) for bustage at /src/toolkit/components/places/nsNavHistoryResult.cpp on a CLOSED TREE
Backed out changeset 4012bc74e900 (bug 1423896)
Backed out changeset 12239646395f (bug 1423896)
Backed out changeset abf61cd5fb77 (bug 1423896)
Backed out changeset 569173c95238 (bug 1423896)
Backed out changeset 6401e950298d (bug 1423896)
2018-02-07 14:07:31 +02:00